From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 18:51:00 2016 Received: (at submit) by debbugs.gnu.org; 30 Oct 2016 22:51:00 +0000 Received: from localhost ([127.0.0.1]:37482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywO-000514-Dj for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:51:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywM-00050s-ID for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:50:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0ywG-0001jX-Bo for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:50:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0ywG-0001jT-8c for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:50:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0ywF-000176-6c for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0ywB-0001hw-6f for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:50:51 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35839) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0ywB-0001ho-0e for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:50:47 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9UMojLb030271 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Oct 2016 22:50:45 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u9UMoj2c003992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Oct 2016 22:50:45 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id u9UMoiu1023493 for ; Sun, 30 Oct 2016 22:50:45 GMT MIME-Version: 1.0 Message-ID: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> Date: Sun, 30 Oct 2016 15:50:43 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Macro `easy-mmode-define-navigation' apparently defines Emacs commands (functions). Per the Emacs Lisp coding conventions, its seems that the macro should be renamed. >From (elisp `Coding Conventions': Constructs that define a function or variable should be macros, not functions, and their names should start with `define-'. The macro ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ should receive the name to be defined as the first argument. That will help various tools find the definition automatically. Avoid constructing the names in the macro itself, since that would confuse these tools. In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D3D/c/usr --host=3D3Di686-pc-mingw32' From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 08:50:58 2019 Received: (at 24829) by debbugs.gnu.org; 27 Jul 2019 12:50:58 +0000 Received: from localhost ([127.0.0.1]:43849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMA5-0001kS-L4 for submit@debbugs.gnu.org; Sat, 27 Jul 2019 08:50:57 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMA3-0001kI-KI for 24829@debbugs.gnu.org; Sat, 27 Jul 2019 08:50:56 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrM9z-0000Ju-0K; Sat, 27 Jul 2019 14:50:53 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention References: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> Date: Sat, 27 Jul 2019 14:50:50 +0200 In-Reply-To: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> (Drew Adams's message of "Sun, 30 Oct 2016 15:50:43 -0700 (PDT)") Message-ID: <871rybiqtx.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > Macro `easy-mmode-define-navigation' apparently defines Emacs commands > (functions). Per the Emacs Lisp coding conventions, its seems that the > macro should be renamed. > >>From (elisp `Coding Con [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24829 Cc: 24829@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > Macro `easy-mmode-define-navigation' apparently defines Emacs commands > (functions). Per the Emacs Lisp coding conventions, its seems that the > macro should be renamed. > >>>From (elisp `Coding Conventions': > > Constructs that define a function or variable should be macros, not > functions, and their names should start with `define-'. The macro > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > should receive the name to be defined as the first argument. That > will help various tools find the definition automatically. Avoid > constructing the names in the macro itself, since that would > confuse these tools. I'm not sure how much of an edict that's supposed to be. easy-mmode has other functions/macros using the same naming convention (like easy-mmode-define-syntax), but those don't define functions, of course. We could change easy-mmode-define-navigation to, say, `define-easy-mmode-navigation', but I'm not sure that would be a net win, confusion wise. Anybody have an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 11 20:46:18 2020 Received: (at 24829) by debbugs.gnu.org; 12 Aug 2020 00:46:19 +0000 Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5euI-0006rd-Nt for submit@debbugs.gnu.org; Tue, 11 Aug 2020 20:46:18 -0400 Received: from mail-yb1-f181.google.com ([209.85.219.181]:34739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5euG-0006rR-Sj for 24829@debbugs.gnu.org; Tue, 11 Aug 2020 20:46:17 -0400 Received: by mail-yb1-f181.google.com with SMTP id c9so457389ybq.1 for <24829@debbugs.gnu.org>; Tue, 11 Aug 2020 17:46:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=LjZiFy1fJK+eJm/mq2KIVoqG71/jA/bLSYC3yoPUXj8=; b=F4F/8lSMUFC+Tz4A0+tWeC7HpBMQTP/hlWLcT28f4h9yaaBL09n9Qy8ncpt3Chn5kN XTBqW3UXN2GSCDzzG+dKA4vMrg5xs9z6iENhb0L4gEu14nuSqOWul8i1pKylI9ZWpz3S pbFHiQWN/zcfvhbTmN8enc07Ga/O+fv3SSY+CPEZQGc83hy6M+PmSe8gw+/AZV63svFU T79j3YpPk/CZSkHMeSOJCqP0OyBmrLhR1Jf7UvDQ4HxE832871wOUPqQ7lwY/2+UzMq8 x5c6N+U7MuTIZZmF82Gkj93nwTFHzJpoy+d6JyOKWIA07sFwlFsZfX02NIz/s5/owIpg PlYg== X-Gm-Message-State: AOAM532sqQQcrYX8O1O66G1+nkmmgUF53oMqcOb5qlVZUCBywnJlQFXS fJl568KyrOAZimli2nOJcSeL0YBPOfuLRuJDzvo= X-Google-Smtp-Source: ABdhPJxnseuWCDHQz+iGds4pWpACCqLm3kWXWp9ZMLhu35dejf+kW/ftM3G5auPLerI1TrhvpWwcwWB5HTPTC2AP+xo= X-Received: by 2002:a5b:410:: with SMTP id m16mr51122262ybp.309.1597193171280; Tue, 11 Aug 2020 17:46:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Aug 2020 17:46:10 -0700 From: Stefan Kangas In-Reply-To: <871rybiqtx.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 14:50:50 +0200") References: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> <871rybiqtx.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 11 Aug 2020 17:46:10 -0700 Message-ID: Subject: Re: bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24829 Cc: 24829@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Drew Adams writes: > >> Macro `easy-mmode-define-navigation' apparently defines Emacs commands >> (functions). Per the Emacs Lisp coding conventions, its seems that the >> macro should be renamed. >> >>>>>From (elisp `Coding Conventions': >> >> Constructs that define a function or variable should be macros, not >> functions, and their names should start with `define-'. The macro >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> should receive the name to be defined as the first argument. That >> will help various tools find the definition automatically. Avoid >> constructing the names in the macro itself, since that would >> confuse these tools. > > I'm not sure how much of an edict that's supposed to be. > > easy-mmode has other functions/macros using the same naming convention > (like easy-mmode-define-syntax), but those don't define functions, of > course. > > We could change easy-mmode-define-navigation to, say, > `define-easy-mmode-navigation', but I'm not sure that would be a net > win, confusion wise. Anybody have an opinion here? FWIW, I also think the original name is less confusing. It also includes the package name prefix, which is probably nice given its surrounding context. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 06:51:56 2020 Received: (at 24829) by debbugs.gnu.org; 12 Aug 2020 10:51:56 +0000 Received: from localhost ([127.0.0.1]:42999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oMO-0002Ss-0N for submit@debbugs.gnu.org; Wed, 12 Aug 2020 06:51:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oML-0002SY-LF for 24829@debbugs.gnu.org; Wed, 12 Aug 2020 06:51:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Jmw68wCYUhnTwLFOfde5YO78u2mOCPWz3wgYYPXMZB4=; b=bEhUfIIVQDkYZdc7Xmh5xaGs3S NHuKbJ3ks24ZOZSoVLdlqotTIqaQtRLjn3VBzTCGm2d4hl7nXdgpFOhckj1oF4px8VgsTW2yP+A6O wPqB2boJSorZ72tJ+ljoVt5Wc0c//m47uZ+O9CP4KXGnfFw3LZQVtomJLL2QxUkPwYkY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oMA-00086K-Cq; Wed, 12 Aug 2020 12:51:46 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention References: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> <871rybiqtx.fsf@mouse.gnus.org> Date: Wed, 12 Aug 2020 12:51:40 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 11 Aug 2020 17:46:10 -0700") Message-ID: <87y2mkp26b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > FWIW, I also think the original name is less confusing. It also > includes the package name prefix, which is probably nice given its > surrounding context. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24829 Cc: Drew Adams , 24829@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > FWIW, I also think the original name is less confusing. It also > includes the package name prefix, which is probably nice given its > surrounding context. OK, closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 06:52:01 2020 Received: (at control) by debbugs.gnu.org; 12 Aug 2020 10:52:01 +0000 Received: from localhost ([127.0.0.1]:43002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oMT-0002TF-8n for submit@debbugs.gnu.org; Wed, 12 Aug 2020 06:52:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oMR-0002Sm-TC for control@debbugs.gnu.org; Wed, 12 Aug 2020 06:52:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fIC4FzzH/LjutqQlsDFIcpqaOKdHDPEcBRHosCTRl/k=; b=L+6VPkEGTr4Nnx/6rpcgW8odoN laPPUc6iJM89QR3lTYW9biRaiGElUhSzPLB/wwaltc9/DBx8lPu2jFqqXwKiVqcjhUJW9z66sp2Z2 nAqSM29zLlfwJQ9bFWMwGM+pAMeNA1uuiOvkdKib2hbToaBRp74s/qOJ99fmAcUXvSCk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oMK-00086S-0h for control@debbugs.gnu.org; Wed, 12 Aug 2020 12:51:54 +0200 Date: Wed, 12 Aug 2020 12:51:50 +0200 Message-Id: <87wo24p261.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24829 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 24829 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 24829 quit From unknown Sun Jun 22 17:12:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 Sep 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator