GNU bug report logs - #24828
26.0.50; Renaming of display-buffer-in-major-side-window broke which-key.el

Previous Next

Full log

Message #8 received at 24828 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Óscar Fuentes <ofv <at> wanadoo.es>, 
 24828 <at> debbugs.gnu.org, justin <at> burkett.cc
Subject: Re: bug#24828: 26.0.50;
 Renaming of display-buffer-in-major-side-window broke which-key.el
Date: Sun, 30 Oct 2016 20:34:46 +0100

> Renaming of display-buffer-in-major-side-window broke which-key.el
>
> As the subject says. Maybe an alias is in order?
>
> I don't know if there are more cases like this.

Hmm...  all this is obviously my fault.  As a matter of fact, I wasn't
aware that side windows were anywhere used at all.

The problem is that ‘display-buffer-in-major-side-window’, which I
renamed to ‘window--make-major-side-window’, actually is an internal
function which should not be used outside of window.el.  With other
words: If there is anything ‘window--make-major-side-window’ does which
‘display-buffer-in-side-window’ doesn't, then I should fix that in the
latter rather than exposing the side window internals.

I added the author to the list of recipients.  Maybe he can tell us
more.  If there's no other way, I'll obviously make the alias.

Thanks for the report, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.