GNU bug report logs - #24826
[PATCH 1/2] gzip --no-name: avoid spurious warning

Previous Next

Package: gzip;

Reported by: Jim Meyering <jim <at> meyering.net>

Date: Sun, 30 Oct 2016 14:56:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 24826-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, 24826-done <at> debbugs.gnu.org
Subject: Re: bug#24826: [PATCH 1/2] gzip --no-name: avoid spurious warning
Date: Fri, 4 Nov 2016 20:36:45 -0700
[Message part 1 (text/plain, inline)]
Jim Meyering wrote:
> The first one is a clear bug fix.

Oops, my bad. Thanks for catching that. I installed a simpler fix (first 
attached patch).

> For the second, since --no-time (-T) never worked (-m does),
> I could also just remove its entry from longopts. We've
> done without it for so long, there's little point to adding
> an undocumented --no-time, now.

Thanks, I like that idea and installed the 2nd attached patch.

In rereading the code I noticed other problems likely to bite after the year 
2038 (3rd attached patch, also installed). This stuff is a pain, as it won't see 
realistic testing for another 20 years or so and I don't see easy test cases for 
it, partly because GNU/Linux seems to mishandles these time stamps now on my 
platform (Fedora 24 x86-64; I'll try to file a bug report about this to Fedora).

Boldly marking the bug as done.
[0001-gzip-no-name-avoid-spurious-warning.patch (text/x-diff, attachment)]
[0002-gzip-no-time-cleanup.patch (text/x-diff, attachment)]
[0003-gzip-minor-time-stamp-cleanups.patch (text/x-diff, attachment)]

This bug report was last modified 8 years and 220 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.