GNU bug report logs - #24822
25.1; [PATCH] Support remapping control X keysym

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24822 in the body.
You can then email your comments to 24822 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 01:53:52 +0200

[Message part 1 (text/plain, inline)]

There is a number of X keysyms that can be remapped inside Emacs, namely
alt, hyper, meta and super.  I found it odd that control is not on the
list (and to a lesser degree, shift), so I wrote a patch to offer it as
additional remappable X keysym.  This way one can swap the control and
meta key in Emacs with `(setq x-meta-keysym 'ctrl x-ctrl-keysym 'meta)`.

[0001-Support-remapping-control-X-keysym.patch (text/x-patch, attachment)]

Message #8 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>, 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sat, 29 Oct 2016 17:10:15 -0700

On 10/29/2016 04:53 PM, Vasilij Schneidermann wrote:
> There is a number of X keysyms that can be remapped inside Emacs, namely
> alt, hyper, meta and super.  I found it odd that control is not on the
> list (and to a lesser degree, shift), so I wrote a patch to offer it as
> additional remappable X keysym.  This way one can swap the control and
> meta key in Emacs with `(setq x-meta-keysym 'ctrl x-ctrl-keysym 'meta)`.
>

Don't forget the NEWS entry.

Message #11 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: Daniel Colascione <dancol <at> dancol.org>
Cc: 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 02:27:00 +0200

> Don't forget the NEWS entry.

Thanks, I've considered doing this, but wasn't sure whether this would
go into etc/NEWS or etc/NEWS.25.  Another thing I'm wondering about is
whether there is any reason to not do this.

Message #14 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
Cc: dancol <at> dancol.org, 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 05:37:57 +0200

> Date: Sun, 30 Oct 2016 02:27:00 +0200
> From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
> Cc: 24822 <at> debbugs.gnu.org
> 
> > Don't forget the NEWS entry.
> 
> Thanks, I've considered doing this, but wasn't sure whether this would
> go into etc/NEWS or etc/NEWS.25.

Changes should always be documented in NEWS.  NEWS.25 describes
changes in Emacs 25.x for Emacs 26 and higher, so it's never relevant.

> Another thing I'm wondering about is whether there is any reason to
> not do this.

In general, any user-visible changes should be in NEWS, unless they
are too insignificant to mention.

Did you look into the Emacs manual, to see if it also needs an update?

Thanks.

Message #17 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
Cc: 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sat, 29 Oct 2016 23:14:04 -0600

Vasilij Schneidermann <v.schneidermann <at> gmail.com> writes:

> There is a number of X keysyms that can be remapped inside Emacs, namely
> alt, hyper, meta and super.  I found it odd that control is not on the
> list (and to a lesser degree, shift), so I wrote a patch to offer it as
> additional remappable X keysym.  This way one can swap the control and
> meta key in Emacs with `(setq x-meta-keysym 'ctrl x-ctrl-keysym 'meta)`.

In the patch, all of the x-*-keysyms have the same docstring (including
the same examples and default). Is that intentional?

Message #20 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: Alex <agrambot <at> gmail.com>
Cc: 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 11:02:01 +0100

> In the patch, all of the x-*-keysyms have the same docstring (including
> the same examples and default). Is that intentional?

Previously, their docstrings were the same except for the first line
(naming the remapped modifier) and the last line (naming the default).
Thank you for pointing that out, I've fixed the latter case.

Message #23 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: dancol <at> dancol.org, 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 11:33:05 +0100

[Message part 1 (text/plain, inline)]

> Changes should always be documented in NEWS.  NEWS.25 describes
> changes in Emacs 25.x for Emacs 26 and higher, so it's never relevant.

Thanks, I've added it to the "Changes in Emacs 26.1" section.
 
> Did you look into the Emacs manual, to see if it also needs an update?

I've updated the existing manual entry now as well.

[0001-Support-remapping-control-X-keysym.patch (text/x-diff, attachment)]

Message #26 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
Cc: 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 12:22:23 -0600

Vasilij Schneidermann <v.schneidermann <at> gmail.com> writes:

>> In the patch, all of the x-*-keysyms have the same docstring (including
>> the same examples and default). Is that intentional?
>
> Previously, their docstrings were the same except for the first line
> (naming the remapped modifier) and the last line (naming the default).
> Thank you for pointing that out, I've fixed the latter case.

What about this line?

  +`super'.  For example, `alt' means use the Alt_L and Alt_R keysyms.

For example, in x-hyper-keysym it mentioned Hyper_L and Hyper_R instead.

Message #29 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: Alex <agrambot <at> gmail.com>
Cc: 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 20:29:29 +0100

> What about this line?
> 
>   +`super'.  For example, `alt' means use the Alt_L and Alt_R keysyms.
> 
> For example, in x-hyper-keysym it mentioned Hyper_L and Hyper_R instead.

That line explains the keysyms for the value `alt`, so that should be
fine.  If someone wants the docstring to explain different values
depending on what keysym remapping it supports, fine by me.

Message #32 received at 24822 <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: Alex <agrambot <at> gmail.com>
Cc: 24822 <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Sun, 30 Oct 2016 20:38:10 +0100

[Message part 1 (text/plain, inline)]

Sorry, I've looked at my version instead of the original one.

I've attached a fixed one.

[0001-Support-remapping-control-X-keysym.patch (text/x-diff, attachment)]

Message #37 received at 24822-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
Cc: agrambot <at> gmail.com, 24822-done <at> debbugs.gnu.org
Subject: Re: bug#24822: 25.1; [PATCH] Support remapping control X keysym
Date: Fri, 04 Nov 2016 11:11:15 +0200

> Date: Sun, 30 Oct 2016 20:38:10 +0100
> From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
> Cc: 24822 <at> debbugs.gnu.org
> 
> Sorry, I've looked at my version instead of the original one.
> 
> I've attached a fixed one.

Thanks, pushed to master.

Please in the future include ChangeLog-style commit log message for
your changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.