GNU bug report logs - #24811
Waiting to answer s at untrusted cert dialog causes crash

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: 24811 <at> debbugs.gnu.org
Subject: bug#24811: 26.0.50; backtrace
Date: Tue, 01 Nov 2016 19:39:13 +0100

Mark Oteiza <mvoteiza <at> udel.edu> writes:

> 1. M-x eww RET https://marmalade-repo.org RET
>
> The certificate is signed by Comodo, which is an untrusted CA on my
> system.  At this point, NSM pops up asking how I want to proceed.
>
> 2. Wait for a while. A minute here is sufficient.
> 3. Hit s to allow the cert for the session only.
>
> Emacs has now crashed:

I'm unable to reproduce this problem.  Can you test the following patch
and see whether it fixes the bug?

diff --git a/src/process.c b/src/process.c
index 8cf045c..3078c01 100644
--- a/src/process.c
+++ b/src/process.c
@@ -3082,6 +3082,11 @@ finish_after_tls_connection (Lisp_Object proc)
   Lisp_Object contact = p->childp;
   Lisp_Object result = Qt;
 
+  if (p->outfd < 0) {
+    pset_status (p, Qfailed);
+    deactivate_process (proc);
+  }
+
   if (!NILP (Ffboundp (Qnsm_verify_connection)))
     result = call3 (Qnsm_verify_connection,
 		    proc,


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.