GNU bug report logs - #24784
26.0.50; JSON strings with utf-16 escape codes

Previous Next

Full log

Message #17 received at 24784 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Helmut Eller <eller.helmut <at> gmail.com>, Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 24784 <at> debbugs.gnu.org
Subject: RE: bug#24784: 26.0.50; JSON strings with utf-16 escape codes
Date: Wed, 26 Oct 2016 10:37:41 -0700 (PDT)

> >> +(defsubst json--decode-utf-16-surrogates (high low)
> >
> > IIRC, there might be no actual benefit from making it a defsubst.
> > If someone could benchmark it, I'd like to see the result.
> 
> I guess it doesn't hurt but I also doubt that it makes a measurable
> difference as utf-16 surrogates are rarely needed.

IMO, we should never, ever use defsubst nowadays.  Unless you can
come up with a REALLY good rationale.

Every time defsubst is used it throws a monkey wrench in the ability
of users to extend and modify Emacs behavior.  And nothing is really
gained.

Just one opinion.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.