GNU bug report logs - #2478
23.0.91; font antialiasing switch in nextstep broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2478 in the body.
You can then email your comments to 2478 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Nikolaj Schumacher <me <at> nschum.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.91; font antialiasing switch in nextstep broken
Date: Thu, 26 Feb 2009 09:29:06 +0100

Hello,

switching font antialiasing in nextstep doesn't work.  A fix is included.


regards,
Nikolaj Schumacher

In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-02-26 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns' '--without-x' 'CC=gcc-4.2' 'CFLAGS=-arch i386 -O2''


diff --git a/src/nsfont.m b/src/nsfont.m
index 386637d..e2e537f 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
 
     CGContextSetFont (gcontext, font->cgfont);
     CGContextSetFontSize (gcontext, font->size);
-    if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
+    if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
       CGContextSetShouldAntialias (gcontext, 0);
     else
       CGContextSetShouldAntialias (gcontext, 1);

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Nikolaj Schumacher <me <at> nschum.de>
Cc: 2478 <at> debbugs.gnu.org, emacs-pretest-bug <at> gnu.org
Subject: Re: bug#2478: 23.0.91; font antialiasing switch in nextstep broken
Date: Thu, 26 Feb 2009 10:26:17 -0500

> --- a/src/nsfont.m
> +++ b/src/nsfont.m
> @@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
 
>      CGContextSetFont (gcontext, font->cgfont);
>      CGContextSetFontSize (gcontext, font->size);
> -    if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
> +    if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
>        CGContextSetShouldAntialias (gcontext, 0);
>      else
>        CGContextSetShouldAntialias (gcontext, 1);

If someone could try and compile the Emacs.app port
with -DUSE_LISP_UNION_TYPE, this bug (and probably several others) would
get caught during compilation.


        Stefan

Message #22 received at 2478 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: 2478 <at> debbugs.gnu.org
Cc: Nikolaj Schumacher <me <at> nschum.de>,
        Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: 23.0.91; font antialiasing switch in nextstep broken
Date: Wed, 4 Mar 2009 23:23:20 +0200

Thanks, I've applied the patch, leaving bug report open as a reminder  
to try this UNION_TYPE as suggested.

-Adrian

Message #25 received at 2478 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nikolaj Schumacher <me <at> nschum.de>
Cc: 2478 <at> debbugs.gnu.org
Subject: Re: bug#2478: 23.0.91; font antialiasing switch in nextstep broken
Date: Wed, 04 Mar 2009 22:48:26 -0500

Nikolaj Schumacher wrote:

> A fix is included.

With this, you have seven "tiny changes". You should complete a
copyright assignment before contributing more.

Message #30 received at 2478 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: 2478 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: 23.0.91; font antialiasing switch in nextstep broken
Date: Fri, 6 Mar 2009 17:17:17 +0200

> If someone could try and compile the Emacs.app port
> with -DUSE_LISP_UNION_TYPE, this bug (and probably several others)  
> would
> get caught during compilation.

I just tried this and found errors in core files relating to  
specification of Lisp_Object arguments as "register" variables.  I'm  
not sure the compiler complaint is specific to the version of gcc on  
OS X (4.0.1)?

gcc -c  -Demacs -DHAVE_CONFIG_H  -I. -I/Users/arobert/src/EmacsApp/ 
emacs/src -I/usr/X11R6/include -Dtemacs    -g -O2 -Wno-pointer-sign - 
DUSE_LISP_UNION_TYPE frame.c
frame.c: In function 'delete_frame':
frame.c:1505: error: address of register variable 'force' requested
make: *** [frame.o] Error 1
make: *** Waiting for unfinished jobs....

Then I got an error in nsterm that I can't make sense of:

nsterm.m: In function 'ns_term_init':
nsterm.m:3897: error: incompatible types in assignment

This line is a simple call to a DEFUN taking one arg:

Lisp_Object color_file, color_map, color;
...
color_map = Fx_load_color_file (color_file);

Message #35 received at 2478-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: 2478-done <at> debbugs.gnu.org
Date: Sun, 31 May 2009 12:49:28 +0700

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.