From unknown Mon Jun 23 22:05:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24779: 26.0.50; Incorrect Edebug spec for define-skeleton Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2016 20:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24779@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14772551065835 (code B ref -1); Sun, 23 Oct 2016 20:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Oct 2016 20:38:26 +0000 Received: from localhost ([127.0.0.1]:50248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byPXG-0001W3-Gc for submit@debbugs.gnu.org; Sun, 23 Oct 2016 16:38:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byPXF-0001Vp-7l for submit@debbugs.gnu.org; Sun, 23 Oct 2016 16:38:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byPX8-0005yy-PJ for submit@debbugs.gnu.org; Sun, 23 Oct 2016 16:38:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byPX8-0005yu-MJ for submit@debbugs.gnu.org; Sun, 23 Oct 2016 16:38:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byPX7-0005o0-4u for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 16:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byPX2-0005xr-7o for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 16:38:17 -0400 Received: from aibo.runbox.com ([91.220.196.211]:53091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byPX2-0005xa-0k for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 16:38:12 -0400 Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1byPX0-0005R8-Mm for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 22:38:10 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=rainbow.local) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1byPWZ-0005Ws-Cx for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 22:37:44 +0200 From: Gemini Lasswell Date: Sun, 23 Oct 2016 13:37:32 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Edebug fails to instrument a large number of the skeletons included in Emacs, and some of those which it succeeds in instrumenting do not work under the debugger. I have not tried every skeleton in Emacs, but among those I tried which had problems are sgml-tag, rul-if, rul-function, m2-begin, sh-case, and texinfo-insert-quotation. To reproduce this behavior using the skeletons in ada-stmt.el, start Emacs, with -Q or otherwise, and open lisp/progmodes/ada-stmt.el from the Emacs source tree. Then: C-s ada-array RET C-u C-M-x=20 Result: Invalid read syntax: "Head of list form must be a symbol or lambda expression" To reproduce an example of a skeleton that can be instrumented but then produces an error while debugging, continue with: C-s ada-declare-block RET C-u C-M-x C-x b ada RET M-x ada-mode RET M-x ada-declare-block RET g g Foo RET g g g Result: Symbol's value as variable is void: | In GNU Emacs 26.0.50.10 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Versi= on 10.11.6 (Build 15G1004)) of 2016-10-22 built on rainbow.local Repository revision: f577b8efec324afc80aa4308efbfa40dcce30bbf Windowing system distributor 'Apple', version 10.3.1404 Recent messages: Result: (backward-delete-char-untabify (min ada-indent (current-column))) Go... Result: (setq str (skeleton-read (quote "[block name]: ") nil nil)) Go... Result: (backward-delete-char-untabify (min ada-indent (current-column))) Go... Result: (backward-delete-char-untabify (min ada-indent (current-column))) Go... Result: "Foo" Go... Symbol's value as variable is void: | Go... Adjusting case ... Done edebug-signal: Symbol=E2=80=99s value as variable is void: | Configured using: 'configure --with-ns --disable-ns-self-contained' Configured features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: diff-auto-refine-mode: t ivy-mode: t buffer-face-mode: t yas-global-mode: t yas-minor-mode: t pyvenv-mode: t shell-dirtrack-mode: t nameless-mode: t beacon-mode: t rainbow-mode: t column-enforce-mode: t volatile-highlights-mode: t region-state-mode: t ws-butler-global-mode: t ws-butler-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-global-strict-mode: t smartparens-strict-mode: t smartparens-mode: t which-key-mode: t modalka-mode: t recentf-mode: t global-auto-revert-mode: t winner-mode: t display-time-mode: t savehist-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs mailabbrev gmm-utils mailheader skeleton edebug vc-git diff-mode colir flx dired dired-loaddefs counsel esh-util swiper ivy delsel ffap face-remap guess-style smtpmail sendmail mail-utils yasnippet highlight-indentation flymake company help-fns radix-tree elpy pyvenv elpy-refactor smartparens-python python tramp-sh tramp tramp-compat tramp-loaddefs trampver shell pcomplete format-spec json map grep compile files-x cus-edit virtualenvwrapper gud comint nameless lisp-mnt ace-window avy beacon smex ido deft debbugs soap-client mm-decode mm-bodies mm-encode warnings rng-xsd rng-dt rng-util xsd-regexp xml rainbow-mode ansi-color color s hydra lv column-enforce-mode etags xref project volatile-highlights region-state ws-butler smartparens-config smartparens thingatpt dash which-key modalka quail smart-mode-line-dark-theme smart-mode-line advice rich-minority whiteboard-theme classic-theme recentf tree-widget wid-edit autorevert filenotify winner ring time cus-start cus-load savehist cap-words superword subword use-package diminish bind-key easy-mmode finder-inf edmacro kmacro info network-stream starttls url-http tls gnutls mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm subr-x puny url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap cl package epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 527832 168555) (symbols 48 40887 0) (miscs 40 872 673) (strings 32 94990 175020) (string-bytes 1 2776740) (vectors 16 62134) (vector-slots 8 1093296 27939) (floats 8 924 1055) (intervals 56 11124 3330) (buffers 976 15)) From unknown Mon Jun 23 22:05:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24779: 26.0.50; Incorrect Edebug spec for define-skeleton Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 13:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gemini Lasswell Cc: 24779@debbugs.gnu.org Received: via spool by 24779-submit@debbugs.gnu.org id=B24779.15642333299232 (code B ref 24779); Sat, 27 Jul 2019 13:16:01 +0000 Received: (at 24779) by debbugs.gnu.org; 27 Jul 2019 13:15:29 +0000 Received: from localhost ([127.0.0.1]:43876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMXp-0002Op-5Q for submit@debbugs.gnu.org; Sat, 27 Jul 2019 09:15:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:38130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMXm-0002Of-HD for 24779@debbugs.gnu.org; Sat, 27 Jul 2019 09:15:27 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrMXi-0000v6-UX; Sat, 27 Jul 2019 15:15:25 +0200 From: Lars Ingebrigtsen References: Date: Sat, 27 Jul 2019 15:15:22 +0200 In-Reply-To: (Gemini Lasswell's message of "Sun, 23 Oct 2016 13:37:32 -0700") Message-ID: <87v9vnhb4l.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gemini Lasswell writes: > Edebug fails to instrument a large number of the skeletons included in > Emacs, and some of those which it succeeds in instrumenting do not work > under the debugger. I have not tried every skeleton [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gemini Lasswell writes: > Edebug fails to instrument a large number of the skeletons included in > Emacs, and some of those which it succeeds in instrumenting do not work > under the debugger. I have not tried every skeleton in Emacs, but among > those I tried which had problems are sgml-tag, rul-if, rul-function, > m2-begin, sh-case, and texinfo-insert-quotation. > > To reproduce this behavior using the skeletons in ada-stmt.el, start > Emacs, with -Q or otherwise, and open lisp/progmodes/ada-stmt.el from > the Emacs source tree. Then: > > C-s ada-array RET > C-u C-M-x > > Result: Invalid read syntax: "Head of list form must be a symbol or > lambda expression" (define-skeleton ada-array "Insert array type definition. Prompt for component type and index subtypes." () "array (" ("index definition: " str ", " ) -2 ") of " _ ?\;) It's complaining about "index definition", which is indeed not a string. The following patch fixes this, but I have no idea what's intended here: diff --git a/lisp/skeleton.el b/lisp/skeleton.el index bce73d6bfe..6a8ec7993a 100644 --- a/lisp/skeleton.el +++ b/lisp/skeleton.el @@ -105,7 +105,7 @@ skeleton-point (defvar skeleton-regions) (def-edebug-spec skeleton-edebug-spec - ([&or null stringp (stringp &rest stringp) [[¬ atom] def-form]] + ([&or null stringp (stringp &rest stringp) [[¬ atom] sexp]] &rest &or "n" "_" "-" ">" "@" "&" "!" "resume:" ("quote" def-form) skeleton-edebug-spec def-form)) ;;;###autoload > To reproduce an example of a skeleton that can be instrumented but then > produces an error while debugging, continue with: > > C-s ada-declare-block RET > C-u C-M-x > C-x b ada RET > M-x ada-mode RET > M-x ada-declare-block RET > g g Foo RET g g g > > Result: Symbol's value as variable is void: | I'm able to reproduce that, too, and adding "|" to the list of strings in the spec seems to fix this. I know nothing about any of this, though, so... Is this the right thing to do? diff --git a/lisp/skeleton.el b/lisp/skeleton.el index bce73d6bfe..67fc4aae15 100644 --- a/lisp/skeleton.el +++ b/lisp/skeleton.el @@ -105,8 +105,8 @@ skeleton-point (defvar skeleton-regions) (def-edebug-spec skeleton-edebug-spec - ([&or null stringp (stringp &rest stringp) [[¬ atom] def-form]] - &rest &or "n" "_" "-" ">" "@" "&" "!" "resume:" + ([&or null stringp (stringp &rest stringp) [[¬ atom] sexp]] + &rest &or "n" "_" "-" ">" "@" "&" "!" "|" "resume:" ("quote" def-form) skeleton-edebug-spec def-form)) ;;;###autoload (defmacro define-skeleton (command documentation &rest skeleton) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 09:15:31 2019 Received: (at control) by debbugs.gnu.org; 27 Jul 2019 13:15:31 +0000 Received: from localhost ([127.0.0.1]:43879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMXr-0002P5-Hn for submit@debbugs.gnu.org; Sat, 27 Jul 2019 09:15:31 -0400 Received: from quimby.gnus.org ([80.91.231.51]:38144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMXq-0002Ox-GX for control@debbugs.gnu.org; Sat, 27 Jul 2019 09:15:30 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrMXn-0000vD-Uv for control@debbugs.gnu.org; Sat, 27 Jul 2019 15:15:29 +0200 Date: Sat, 27 Jul 2019 15:15:27 +0200 Message-Id: <87tvb7hb4g.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24779 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 24779 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24779 + patch quit From unknown Mon Jun 23 22:05:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24779: 26.0.50; Incorrect Edebug spec for define-skeleton Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gemini Lasswell Cc: 24779@debbugs.gnu.org Received: via spool by 24779-submit@debbugs.gnu.org id=B24779.15642334369486 (code B ref 24779); Sat, 27 Jul 2019 13:18:01 +0000 Received: (at 24779) by debbugs.gnu.org; 27 Jul 2019 13:17:16 +0000 Received: from localhost ([127.0.0.1]:43885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMZX-0002Sw-SP for submit@debbugs.gnu.org; Sat, 27 Jul 2019 09:17:16 -0400 Received: from quimby.gnus.org ([80.91.231.51]:38236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMZW-0002Sp-F9 for 24779@debbugs.gnu.org; Sat, 27 Jul 2019 09:17:14 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrMZR-0000w6-Ui; Sat, 27 Jul 2019 15:17:13 +0200 From: Lars Ingebrigtsen References: <87v9vnhb4l.fsf@mouse.gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEX3AAL3BQ/60dP9AAD3 AAD3JT71aH32DRv5AAP4AAL////4AQdR6C3RAAACZ0lEQVQ4ja3UMWvcMBQAYAcO2iNL1cVJvXm4 IVurUM7cci0iYDqF4nPp1gMra91yCHrT4UJ8eLlgEfy4LWOmqHcQG/25PslJ7UC79YGF0OcnPUnG zu0/wrn1bYy47/M/8dnAyHajaMaTCNskTon4YSExA1EcWcAOIeQVwg1PYiEWQkQiXiwMuES9tIC5 WgmRktQVKHHqtRDFy5qOlVfnpAV85QE8SukEG+XihAhCfLPlXtQG0oxOUHCRB7jhPEaZ1DlyQXA0 dYkF3z/xR59oG+NC4RL6l80w2+ZRnFl5TbEM+sbAjM84n6Mm3+ljWMDlEgQ+51+eAr9YzOZzc15d SgtzPhrZE+T84xPgURLjrparBee7/hoJnqBHFmKdu2nWB+G5xB6uR1fnfTCHGuMtYP2X8XkH5jYi k4YJunA7SEWqlOt6pKbFjo53HRDPTY8nhToAna2J2D2CIuTe07AS2q2rS7LLugycjNTogtRV2a2B NyBw8Ku4F9uyv3MsUx+5ohlvgo22wxl924IgjSJNCXnxIptYsnCla91sSFOtYXUUlBVWFZy1VaV1 DQWoqlC7cQ4avwALdx7RGmq4X2YN6KqBHS0tNM7myltvlxprAlCH8ieABSkrfbcloFVTBpDfORAw CxA6zvCKiGMJUAb0lIWMXRvYyxCGWwVrgBzCyVYO9m3GYPA8BIxAHj47BthMmWzBGWLuEGQJ+mB/ +oGxw0dwmAyHwxCkDKWUjEmnBWZjOjBtaHr4dDC1z3S6N8Scp2Bij1MNBux9N1WLzru214Mp64cB bjpn+En7vThBsG+c/eVf8v/gNzhpzf9vOMU7AAAAAElFTkSuQmCC Date: Sat, 27 Jul 2019 15:17:09 +0200 In-Reply-To: <87v9vnhb4l.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 15:15:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> Result: Invalid read syntax: "Head of list form must be a symbol or >> lambda expression" > > (define-skeleton ada-array > "Insert array type definition. > Prompt for component type and index subty [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> Result: Invalid read syntax: "Head of list form must be a symbol or >> lambda expression" > > (define-skeleton ada-array > "Insert array type definition. > Prompt for component type and index subtypes." > () > "array (" ("index definition: " str ", " ) -2 ") of " _ ?\;) > > It's complaining about "index definition", which is indeed not a > string. I mean, not a symbol... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 22:05:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24779: 26.0.50; Incorrect Edebug spec for define-skeleton Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gemini Lasswell Cc: 24779@debbugs.gnu.org Received: via spool by 24779-submit@debbugs.gnu.org id=B24779.15665197356639 (code B ref 24779); Fri, 23 Aug 2019 00:23:01 +0000 Received: (at 24779) by debbugs.gnu.org; 23 Aug 2019 00:22:15 +0000 Received: from localhost ([127.0.0.1]:38575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xLK-0001iz-IF for submit@debbugs.gnu.org; Thu, 22 Aug 2019 20:22:14 -0400 Received: from quimby.gnus.org ([80.91.231.51]:36084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xLI-0001ir-Uh for 24779@debbugs.gnu.org; Thu, 22 Aug 2019 20:22:13 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xLD-0001sm-U6; Fri, 23 Aug 2019 02:22:11 +0200 From: Lars Ingebrigtsen References: <87v9vnhb4l.fsf@mouse.gnus.org> Date: Fri, 23 Aug 2019 02:22:07 +0200 In-Reply-To: <87v9vnhb4l.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 15:15:22 +0200") Message-ID: <878srkbuj4.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I'm able to reproduce that, too, and adding "|" to the list of strings > in the spec seems to fix this. I know nothing about any of this, > though, so... Is this the right thing to do? > > diff --gi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I'm able to reproduce that, too, and adding "|" to the list of strings > in the spec seems to fix this. I know nothing about any of this, > though, so... Is this the right thing to do? > > diff --git a/lisp/skeleton.el b/lisp/skeleton.el > index bce73d6bfe..67fc4aae15 100644 > --- a/lisp/skeleton.el > +++ b/lisp/skeleton.el > @@ -105,8 +105,8 @@ skeleton-point > (defvar skeleton-regions) > > (def-edebug-spec skeleton-edebug-spec > - ([&or null stringp (stringp &rest stringp) [[¬ atom] def-form]] > - &rest &or "n" "_" "-" ">" "@" "&" "!" "resume:" > + ([&or null stringp (stringp &rest stringp) [[¬ atom] sexp]] > + &rest &or "n" "_" "-" ">" "@" "&" "!" "|" "resume:" > ("quote" def-form) skeleton-edebug-spec def-form)) > ;;;###autoload > (defmacro define-skeleton (command documentation &rest skeleton) There weren't any comments, and this does seem to fix the test cases, so I've applied this now. But like I said, I don't really know this area, so if this is the wrong thing to do, feel free to revert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 22 20:22:20 2019 Received: (at control) by debbugs.gnu.org; 23 Aug 2019 00:22:20 +0000 Received: from localhost ([127.0.0.1]:38578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xLP-0001jL-TP for submit@debbugs.gnu.org; Thu, 22 Aug 2019 20:22:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:36098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xLO-0001jC-3Z for control@debbugs.gnu.org; Thu, 22 Aug 2019 20:22:18 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xLL-0001st-GY for control@debbugs.gnu.org; Fri, 23 Aug 2019 02:22:17 +0200 Date: Fri, 23 Aug 2019 02:22:15 +0200 Message-Id: <877e74buiw.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24779 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 24779 fixed close 24779 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24779 fixed close 24779 27.1 quit