GNU bug report logs - #24767
jgraph comments not recognized any more

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Mackenzie <acm <at> muc.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24767: closed (jgraph comments not recognized any more)
Date: Sun, 30 Oct 2016 17:38:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 30 Oct 2016 17:37:30 +0000
with message-id <20161030173730.GA17103 <at> acm.fritz.box>
and subject line Re: bug#24767: jgraph comments not recognized any more
has caused the debbugs.gnu.org bug report #24767,
regarding jgraph comments not recognized any more
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24767: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24767
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: jgraph comments not recognized any more
Date: Sat, 22 Oct 2016 17:24:01 -0400

Package: Emacs


Try the following:

    % emacs -Q -l .../elpa/packages/jgraph-mode/jgraph-mode.el ~/foo.jgr
    (* hello *)

The string "(* hello *)" should be highlighted as a comment, and is
indeed correctly highlighted this way in Emacs-25 (and Emacs-24), but
not in "master".

The particularity of jgraph-mode's handling of (*...*) is that ?(, ?),
and ?* are given "symbol" syntax, so I guess that src/syntax.c was
modified in a way which makes it skip the whole (* as being a symbol.


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Alan Mackenzie <acm <at> muc.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 24767-done <at> debbugs.gnu.org
Subject: Re: bug#24767: jgraph comments not recognized any more
Date: Sun, 30 Oct 2016 17:37:30 +0000

Hello, Stefan.

On Sat, Oct 29, 2016 at 11:12:51AM -0400, Stefan Monnier wrote:
> > Would you try out the following patch, please, and let me know whether
> > there are still problems with it.  Thanks.

> I confirm it fixes my problems, thank you,

I've committed it, and am closing the bug.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.