GNU bug report logs - #24765
26.0.50; Incorrect Edebug spec for cl-letf, cl-letf*

Previous Next

Package: emacs;

Reported by: Gemini Lasswell <gazally <at> runbox.com>

Date: Sat, 22 Oct 2016 16:19:01 UTC

Severity: normal

Found in version 26.0.50

Done: Gemini Lasswell <gazally <at> runbox.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Gemini Lasswell <gazally <at> runbox.com>
To: 24765 <at> debbugs.gnu.org
Subject: bug#24765: Patch for bug#24765: 26.0.50; Incorrect Edebug spec for cl-letf, cl-letf*
Date: Sat, 09 Sep 2017 12:19:04 -0700
[Message part 1 (text/plain, inline)]
Here is the patch for this bug again, against the current master. Does anyone have
any feedback? If not, I will push this in a few days.

[0001-lisp-emacs-lisp-cl-macs.el-cl-letf-Fix-Edebug-spec-b.patch (text/plain, inline)]
From cb71084395df6981901cf33ba2753ee9c7a4caf0 Mon Sep 17 00:00:00 2001
From: Gemini Lasswell <gazally <at> runbox.com>
Date: Tue, 25 Apr 2017 07:42:01 -0700
Subject: [PATCH] * lisp/emacs-lisp/cl-macs.el (cl-letf): Fix Edebug spec
 (bug#24765)

---
 lisp/emacs-lisp/cl-macs.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 20a956b474..e2d35224f0 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -2437,7 +2437,9 @@ cl-letf
 the PLACE is not modified before executing BODY.
 
 \(fn ((PLACE VALUE) ...) BODY...)"
-  (declare (indent 1) (debug ((&rest (gate gv-place &optional form)) body)))
+  (declare (indent 1) (debug ((&rest [&or (symbolp form)
+                                          (gate gv-place &optional form)])
+                              body)))
   (if (and (not (cdr bindings)) (cdar bindings) (symbolp (caar bindings)))
       `(let ,bindings ,@body)
     (cl--letf bindings () () body)))
-- 
2.14.1


This bug report was last modified 7 years and 250 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.