From unknown Fri Sep 05 08:43:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Oct 2016 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24762@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.147708311623247 (code B ref -1); Fri, 21 Oct 2016 20:52:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Oct 2016 20:51:56 +0000 Received: from localhost ([127.0.0.1]:45706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxgnE-00062t-Gy for submit@debbugs.gnu.org; Fri, 21 Oct 2016 16:51:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxgnC-00062f-8n for submit@debbugs.gnu.org; Fri, 21 Oct 2016 16:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxgn5-0001E4-Rl for submit@debbugs.gnu.org; Fri, 21 Oct 2016 16:51:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxgn5-0001Dg-Of for submit@debbugs.gnu.org; Fri, 21 Oct 2016 16:51:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxgn3-0006Kt-Ui for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:51:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxgmy-00019v-TG for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:51:45 -0400 Received: from aibo.runbox.com ([91.220.196.211]:34334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxgmy-00017i-Ip for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 16:51:40 -0400 Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1bxgmw-0007hy-8p for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 22:51:38 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=rainbow.local) by mailfront12.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1bxgml-0004ER-IT for bug-gnu-emacs@gnu.org; Fri, 21 Oct 2016 22:51:28 +0200 From: Gemini Lasswell Date: Fri, 21 Oct 2016 13:51:24 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) There's an &optional followed by &rest instead of a parameter name in python-define-auxiliary-skeleton in lisp/progmodes/python.el. This doesn't work with defmacro's Edebug spec and prevents use of Edebug on the macro and testcover-start on the file. To repro: 1. start Emacs at the top of its source tree, with -Q if you like 2. C-x C-f lisp/progmodes/python.el RET 3. C-s &optional &r RET 4. C-u C-M-x Result: Invalid read syntax: "Bad argument:", &rest In GNU Emacs 26.0.50.4 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Versio= n 10.11.6 (Build 15G1004)) of 2016-10-20 built on rainbow.local Repository revision: 9e1e257ea8605354d15b4bd93e0af6188aae40db Windowing system distributor 'Apple', version 10.3.1404 Recent messages: Guessed variable =E2=80=99indent-tabs-mode=E2=80=99 (nil) Guessed variable =E2=80=99tab-width=E2=80=99 (8) Could not guess variable =E2=80=99c-basic-offset=E2=80=99 (Not a cc-mode) Guessed variable =E2=80=99nxml-child-indent=E2=80=99 (2) Guessed variable =E2=80=99css-indent-offset=E2=80=99 (2) Guessed variable =E2=80=99python-indent=E2=80=99 (2) Mark saved where search started edebug-syntax-error: Invalid read syntax: "Bad argument:", &rest Configured using: 'configure --with-ns --disable-ns-self-contained' Configured features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t global-undo-tree-mode: t undo-tree-mode: t diff-auto-refine-mode: t ivy-mode: t buffer-face-mode: t yas-global-mode: t yas-minor-mode: t pyvenv-mode: t shell-dirtrack-mode: t nameless-mode: t beacon-mode: t rainbow-mode: t column-enforce-mode: t volatile-highlights-mode: t region-state-mode: t ws-butler-global-mode: t ws-butler-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-global-strict-mode: t smartparens-strict-mode: t smartparens-mode: t which-key-mode: t modalka-mode: t recentf-mode: t global-auto-revert-mode: t auto-revert-mode: t winner-mode: t display-time-mode: t savehist-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m the-org-mode-expansions org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs shr-color linum magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert magit-process magit-popup magit-mode magit-git magit-section magit-utils git-commit log-edit pcvs-util with-editor async-bytecomp async server mailalias goto-chg shadow emacsbug cl-generic-tests testcover flow-fill jka-compr shr svg dom browse-url qp nndraft nnmh nnfolder utf-7 epa-file sort smiley gnus-cite mail-extr gnus-async gnus-bcklg gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-ml gnus-msg disp-table nndoc gnus-cache gnus-dup gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader mm-archive message rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs mailabbrev gmm-utils mailheader crm debbugs-gnu add-log zoom-window highlight-symbol undo-tree diff eieio-opt speedbar sb-image ezimage dframe tabify shrink-whitespace dash-at-point visual-regexp expand-region text-mode-expansions python-el-fgallina-expansions er-basic-expansions expand-region-core expand-region-custom ielm comment-dwim-2 ert find-func ewoc debug pp edebug vc-git diff-mode colir flx dired dired-loaddefs counsel esh-util swiper ivy delsel ffap face-remap guess-style smtpmail sendmail mail-utils yasnippet highlight-indentation flymake company help-fns radix-tree elpy pyvenv elpy-refactor smartparens-python python tramp-sh tramp tramp-compat tramp-loaddefs trampver shell pcomplete format-spec json map grep compile files-x cus-edit virtualenvwrapper gud comint nameless lisp-mnt ace-window avy beacon smex ido deft debbugs soap-client mm-decode mm-bodies mm-encode warnings rng-xsd rng-dt rng-util xsd-regexp xml rainbow-mode ansi-color color s hydra lv column-enforce-mode etags xref project volatile-highlights region-state ws-butler smartparens-config smartparens thingatpt dash which-key modalka quail smart-mode-line-dark-theme smart-mode-line advice rich-minority whiteboard-theme classic-theme recentf tree-widget wid-edit autorevert filenotify winner ring time cus-start cus-load savehist cap-words superword subword use-package diminish bind-key easy-mmode finder-inf edmacro kmacro info network-stream starttls url-http tls gnutls mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm subr-x puny url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap cl package epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 1363213 218822) (symbols 48 59558 68) (miscs 40 7625 4642) (strings 32 204044 88844) (string-bytes 1 5746974) (vectors 16 96779) (vector-slots 8 2219014 137143) (floats 8 5415 2600) (intervals 56 83795 2701) (buffers 976 87)) From unknown Fri Sep 05 08:43:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2016 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gemini Lasswell Cc: 24762@debbugs.gnu.org Received: via spool by 24762-submit@debbugs.gnu.org id=B24762.147932528927397 (code B ref 24762); Wed, 16 Nov 2016 19:42:01 +0000 Received: (at 24762) by debbugs.gnu.org; 16 Nov 2016 19:41:29 +0000 Received: from localhost ([127.0.0.1]:59869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c765J-00077p-Dj for submit@debbugs.gnu.org; Wed, 16 Nov 2016 14:41:29 -0500 Received: from mail-qt0-f176.google.com ([209.85.216.176]:36550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c765H-00077c-FO for 24762@debbugs.gnu.org; Wed, 16 Nov 2016 14:41:27 -0500 Received: by mail-qt0-f176.google.com with SMTP id w33so114496174qtc.3 for <24762@debbugs.gnu.org>; Wed, 16 Nov 2016 11:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=n3EykdMLL/Hx9ZFYaqZz24XNDO15pC58L3k4rJcYEWI=; b=DoMJ7FnrYFZa6xsujThtOo1FJmTBtb6fj8yemJ7i79BKlB3AXK+kz4lEdN1cf0bNh1 nJcldg+IuIkJKDV4lDeuoGDwXIqYKih8MLoGgX4HdYn9+DZQ/umZyEHE3zNXBg1zitJX vLgjOdAXOu6Prfiseb7ZXSLsdop+dlLk4XEZQ1MwvDxg+Sp/SPbZ3ilOGlDwHXlkBCec SfscAuN2y1u5pwiQ4Y9WOHhhgIYAVr9qDiSI93cQzFNvWIpoetm4bUWoC827TGzpuS5m qlqWfPBjwmpuQjujIA0Cfa4+ttcODw+n37xU2iq21jCT3tpKQpNWjijQpRIScc+/Mb4X wfww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=n3EykdMLL/Hx9ZFYaqZz24XNDO15pC58L3k4rJcYEWI=; b=HxrX9Hv4jQaUui7XmSQbr5qHaADXphvbkeQMU9sHDzdVtMJLgQjxgHWXOtg7BzNdE+ gJMszJBSKzZDFp14vnKWTlX+gQseufuEZsPfEcnDRKsyNJwUPnrcRVQWXq4+SDl1o4hk RY4ZtZaI5jbh4XnwIO2NDLSPfQn2Me9Jho1APiNkIsevTBk+e2wevApjP8vVi0bXaD7E kbEo3BlYLbhWpq88cEv0+nvSveQK28+WxLMxU+bIurGFzmLI3b4HjMD8uUCdek+QMKJw 0lZiyo4WT5R4MZafOOU4hERf+d5mpNfPn83xYOzKpWByB0AcAs0y5QcaULhJwlqU4YsT n+mg== X-Gm-Message-State: AKaTC03yxClNmdYgYy4JyvQRouz3zprkaYR31IYotwymh635veNEeIztnu7B6hRsg66vOwdk X-Received: by 10.237.53.176 with SMTP id c45mr3043323qte.222.1479325281901; Wed, 16 Nov 2016 11:41:21 -0800 (PST) Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id d143sm18514701qkc.33.2016.11.16.11.41.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Nov 2016 11:41:21 -0800 (PST) Received: by holos.localdomain (Postfix, from userid 1000) id CA47D663B8; Wed, 16 Nov 2016 14:41:19 -0500 (EST) From: Mark Oteiza References: Date: Wed, 16 Nov 2016 14:41:19 -0500 In-Reply-To: (Gemini Lasswell's message of "Fri, 21 Oct 2016 13:51:24 -0700") Message-ID: <871sybw6u8.fsf@udel.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Gemini Lasswell writes: > There's an &optional followed by &rest instead of a parameter name in > python-define-auxiliary-skeleton in lisp/progmodes/python.el. This > doesn't work with defmacro's Edebug spec and prevents use of Edebug on > the macro and testcover-start on the file. > > To repro: > 1. start Emacs at the top of its source tree, with -Q if you like > 2. C-x C-f lisp/progmodes/python.el RET > 3. C-s &optional &r RET > 4. C-u C-M-x > > Result: Invalid read syntax: "Bad argument:", &rest Thanks for reporting--it looks to me like the following fixes: diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index f9b28c3..9cd9cc8 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table "Abbrev table for Python mode." :parents (list python-mode-skeleton-abbrev-table)) -(defmacro python-define-auxiliary-skeleton (name doc &optional &rest skel) +(defmacro python-define-auxiliary-skeleton (name &optional doc &rest skel) "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL. The skeleton will be bound to python-skeleton-NAME." (declare (indent 2)) @@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton (signal 'quit t)) ,@skel))) -(python-define-auxiliary-skeleton else nil) +(python-define-auxiliary-skeleton else) -(python-define-auxiliary-skeleton except nil) +(python-define-auxiliary-skeleton except) -(python-define-auxiliary-skeleton finally nil) +(python-define-auxiliary-skeleton finally) (python-skeleton-define if nil "Condition: " From unknown Fri Sep 05 08:43:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2016 23:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24762@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.147934044018655 (code B ref -1); Wed, 16 Nov 2016 23:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Nov 2016 23:54:00 +0000 Received: from localhost ([127.0.0.1]:59965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7A1g-0004qo-1W for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:54:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7A1e-0004qa-Fq for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:53:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7A1Y-0002DH-Gb for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:53:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7A1Y-0002D7-C3 for submit@debbugs.gnu.org; Wed, 16 Nov 2016 18:53:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7A1M-0008Sp-Bt for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:53:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7A17-00020A-GM for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:53:40 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:52966) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7A17-0001yv-3y for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 18:53:25 -0500 Received: from [18.26.2.123] ([18.26.2.123]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.168]) with ESMTPSA (Nemesis) id 0Lnnzv-1ci8vV3yiV-00hrV7 for ; Thu, 17 Nov 2016 00:53:23 +0100 References: <871sybw6u8.fsf@udel.edu> From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Message-ID: Date: Wed, 16 Nov 2016 18:53:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <871sybw6u8.fsf@udel.edu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn" X-Provags-ID: V03:K0:slUHhYFNGcA+8Vqtj4gv0zDE0GpNw99W0TzZHCgI8r6H+7FNOA9 YKlfH1T4TCUxm1QX4XMV4ZWsg6HycHjCzu/kv5J6XKJsxwJNmlAanVuW7TyAlEnPS1z8fb4 D+UQjtpjOEGsKmCqP9dPMQ4wTANj0K9PszNyYgGQWJ9nDbuug9rtsAnNChYrz+rGB4Ym+1m waDbtal+WZb42IBfmLClg== X-UI-Out-Filterresults: notjunk:1;V01:K0:zWO2PkymXb0=:nvJXZf9ZDM1tGKpBjk6doJ W8qu/tsQK1fX7BOfXt+1Vl5D41yfBYyaJZ6FjKsuDIsGs8Nz4tmvaPZEBIvy3d/XyCAxYO/eM aFHtFlTfTDd9kFxI3PJulPolGUD57rFV5sC95Ssw52bLhLhnGwxZBJX0LFlu5MnKk2mRbJvxg CSPE33JHqr1I2xrAcUmWgqA2BGVewSNHGw+yphA5vsVnrNGUJcblTnqpdnporbysDd+LSbFBJ FfkWokmjbeNaD/IF97/ZLOMYfjigtEG/Yi0g3kWiG53kbzsGsDUmT7dH31Axt/epMN5VlQcBn hmWh7pzbzEeP3nOdtdipFZfw/1yM4x5Sd1oTgQBtJ6HQak8fX+/sfdSfxgzpC3ifuh6iYs0MH 0LM29AyaGUQeDr5T+JgiKfjMZ1i6sgeYLfd7mspA23mSrHASOgKV7AuKf6KSzX4cdNiCCHMZ7 ABvCOQBPMTdsFjilP0Tz9ZGjk0G2YFOZnRKGMDhySe+vBhRYN0ZeQ9VL8Bu/kFfH2OGV91RMO YeTPoL5l/2sGax3ef8tumwovF60syqHTwJ5GVqxWC/tp21V16xX0hgOOIvUpBmiCIaeblzwGo rg6f6JO4VHQHJlhCYybr9wr5jYvBqtMDLMw3vfqObctUSxWnPZNWPie6lgAt6V/tLog/pcNoG IPxXTkDDQXJyRarGmxqN05Tbi5bsY8jPg+FdZYLffwiFcfh2O2IwrxxLwQQCJusijOkA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn Content-Type: multipart/mixed; boundary="fcqblSrWROw3K3wnv9BIVGKfxhQi62Nip"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: Subject: Re: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error References: <871sybw6u8.fsf@udel.edu> In-Reply-To: <871sybw6u8.fsf@udel.edu> --fcqblSrWROw3K3wnv9BIVGKfxhQi62Nip Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable LGTM :) On 2016-11-16 14:41, Mark Oteiza wrote: > Gemini Lasswell writes: >=20 >> There's an &optional followed by &rest instead of a parameter name in >> python-define-auxiliary-skeleton in lisp/progmodes/python.el. This >> doesn't work with defmacro's Edebug spec and prevents use of Edebug on= >> the macro and testcover-start on the file. >> >> To repro: >> 1. start Emacs at the top of its source tree, with -Q if you like >> 2. C-x C-f lisp/progmodes/python.el RET >> 3. C-s &optional &r RET >> 4. C-u C-M-x >> >> Result: Invalid read syntax: "Bad argument:", &rest >=20 > Thanks for reporting--it looks to me like the following fixes: >=20 > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index f9b28c3..9cd9cc8 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table > "Abbrev table for Python mode." > :parents (list python-mode-skeleton-abbrev-table)) > =20 > -(defmacro python-define-auxiliary-skeleton (name doc &optional &rest s= kel) > +(defmacro python-define-auxiliary-skeleton (name &optional doc &rest s= kel) > "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL. > The skeleton will be bound to python-skeleton-NAME." > (declare (indent 2)) > @@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton > (signal 'quit t)) > ,@skel))) > =20 > -(python-define-auxiliary-skeleton else nil) > +(python-define-auxiliary-skeleton else) > =20 > -(python-define-auxiliary-skeleton except nil) > +(python-define-auxiliary-skeleton except) > =20 > -(python-define-auxiliary-skeleton finally nil) > +(python-define-auxiliary-skeleton finally) > =20 > (python-skeleton-define if nil > "Condition: " >=20 >=20 >=20 >=20 --fcqblSrWROw3K3wnv9BIVGKfxhQi62Nip-- --GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLPFsAAoJEPqg+cTm90wjVpoP/0N8cULQQKzVO0c4ykkVE9Ph JSW0RKdL78KIWywHJ1ZbfjfCA4ldgr2Ke4T+wZtJrSLFwUd13ZqsMpVuLfHh95Ql 9lCj5OI4unwBUvRx3f6Ofg/3Kz8e1oPcd22XbGVEmCH+SJdVy0IKtEdTUthizDCP Qjsushddy4AfQ9jy8xuyDSjQJUpnjgLzgZbbSxUgnNIVNtBJuWhH+e3Cvw/Wb4U1 MIpc3R8nDw8csQ2Azzr9WE47Ti5dGeEe8dTCqvIVbYfpDyhybFEGRcnbSfvyJREe Y7nsYGhH7wUUWfhoeJTObpX/7VfrrDrIE/7FgOcQRyWN+g5Axn162eD+Jxgdh/Pk wx7PRpzmo3F439zE7/Rt+VB//2eNC/UIhLwCRDZEdmrLVD7VltNrvJJ6rYAcAcR1 PGBaA95bZGhuLSdukNPgOcgQ3jjX8t6hvwnddxqOY1jVSZF03aclEpRwxR2NEvzT HjYPmjr7eTjYXcw8YKXG3faCWpiwUT2OU7+9CkBxkXt/llV/uLuUOa1dwdwaeMFx wFLNwEovvTVqBUVaLORbn5hPe3u25kePeuETbAnOqSI1yhBgwp5MmralrQ/jHFfD 0njj965JIEUhKkEIpzz2OuLKI4CQPDahBp1dcC9CWTbitovSUXhtT7jTeqNZM1jo aqqJj31GFS/vd4sF3sxH =urW6 -----END PGP SIGNATURE----- --GjOppxuLgtO1kKP5XUpHxNJN6j2IMvWpn-- From unknown Fri Sep 05 08:43:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24762: 26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2016 00:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mark Oteiza Cc: Gemini Lasswell , 24762@debbugs.gnu.org Received: via spool by 24762-submit@debbugs.gnu.org id=B24762.148055288622446 (code B ref 24762); Thu, 01 Dec 2016 00:42:02 +0000 Received: (at 24762) by debbugs.gnu.org; 1 Dec 2016 00:41:26 +0000 Received: from localhost ([127.0.0.1]:47897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCFRG-0005pv-Dv for submit@debbugs.gnu.org; Wed, 30 Nov 2016 19:41:26 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:33183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCFRD-0005pZ-OP; Wed, 30 Nov 2016 19:41:24 -0500 Received: by mail-io0-f171.google.com with SMTP id j65so384295034iof.0; Wed, 30 Nov 2016 16:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FcYEfFPFo9gzZN1wI5asGEZtUCZ/8eTBOI7ka06MXUI=; b=N0YxuMlpBzXxbD1dHLn3tEUjbNysSdhRKt6XqkhQ/jp2fryo/uMqUQTKSQkz9eLMwe jlPzGnPPlvUZAPq4ERqUXH30/DzgBbW6tBQS2CFiSvXV4v2uZs77b31SutATwQaFfJc5 OD/7XCmrXeCCuW3H0J1Bbf2cmw/qRZUnrmMy73ei38KQ4WfAvmpF3OrIXi2BdGieCN7R AObxlqcDunSI5SyTeSUdlLLUH/GQGvVs/Fg+xuvIE1th8UL3P5mlb7i3IYBeu69zb7oG HMkrnQWERxytvBGalLXm8tQAsS4kxVPLLhsdSKMd50NxqvMJ79m2GEbGYcUJ+oRUjblf a7gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FcYEfFPFo9gzZN1wI5asGEZtUCZ/8eTBOI7ka06MXUI=; b=N2JAAlfI1egtN2fEpMy93/+/pWoTaDbqwkx/PiJGCXHT6hnhdTVt/mVaPN/CcpLhH5 a/MoBhejtuLIvYL45lnUXqMOy37MrF88ckSs7EYuTz6SA5wLPn/Z7+3J5PBbVmFmjTdi ZWE7rtMfsIh73WmXeTbqVGLkyCzxsFtKKeVOMhlRmMvkS77xlWCI+K4ELIVnT5lAB6vz 9Ojty9rtJkcDQB0GJAyLcuaVJ6B2Us/LcoK44gHLWSy+d8EGXcsbLL/DGeWhZoFXsXpk hoX2haOJZTOrf7+IrIrBGcjn63rzbXVL760gBUdzm2qg2lWIcGjspprNYbUp0DIdkw5r pSKg== X-Gm-Message-State: AKaTC00s9eR/YRjNULcBHPEyMJsVBWvJnnSVr3UKefBl+pLDuKwlLftYt5F9ZPrP29FZSg== X-Received: by 10.107.8.201 with SMTP id h70mr31693914ioi.139.1480552877927; Wed, 30 Nov 2016 16:41:17 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n206sm4097005itg.1.2016.11.30.16.41.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Nov 2016 16:41:17 -0800 (PST) From: npostavs@users.sourceforge.net References: <871sybw6u8.fsf@udel.edu> Date: Wed, 30 Nov 2016 19:42:14 -0500 In-Reply-To: <871sybw6u8.fsf@udel.edu> (Mark Oteiza's message of "Wed, 16 Nov 2016 14:41:19 -0500") Message-ID: <87r35sh449.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 24762 fixed close 24762 quit Mark Oteiza writes: > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index f9b28c3..9cd9cc8 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table > "Abbrev table for Python mode." > :parents (list python-mode-skeleton-abbrev-table)) > > -(defmacro python-define-auxiliary-skeleton (name doc &optional &rest skel) > +(defmacro python-define-auxiliary-skeleton (name &optional doc &rest skel) > "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL. > The skeleton will be bound to python-skeleton-NAME." > (declare (indent 2)) > @@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton > (signal 'quit t)) > ,@skel))) > > -(python-define-auxiliary-skeleton else nil) > +(python-define-auxiliary-skeleton else) > > -(python-define-auxiliary-skeleton except nil) > +(python-define-auxiliary-skeleton except) > > -(python-define-auxiliary-skeleton finally nil) > +(python-define-auxiliary-skeleton finally) > > (python-skeleton-define if nil > "Condition: " I see was pushed as 5b003caa "Fix arglist in python.el (Bug#24762)".