GNU bug report logs - #24762
26.0.50; Spurious &optional in lisp/progmodes/python.el causes Edebug error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24762 in the body.
You can then email your comments to 24762 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gemini Lasswell <gazally <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50;
 Spurious &optional in lisp/progmodes/python.el causes Edebug error
Date: Fri, 21 Oct 2016 13:51:24 -0700

There's an &optional followed by &rest instead of a parameter name in
python-define-auxiliary-skeleton in lisp/progmodes/python.el. This
doesn't work with defmacro's Edebug spec and prevents use of Edebug on
the macro and testcover-start on the file.

To repro:
1. start Emacs at the top of its source tree, with -Q if you like
2. C-x C-f lisp/progmodes/python.el RET
3. C-s &optional &r RET
4. C-u C-M-x

Result: Invalid read syntax: "Bad argument:", &rest

In GNU Emacs 26.0.50.4 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G1004))
 of 2016-10-20 built on rainbow.local
Repository revision: 9e1e257ea8605354d15b4bd93e0af6188aae40db
Windowing system distributor 'Apple', version 10.3.1404
Recent messages:
Guessed variable ’indent-tabs-mode’ (nil)
Guessed variable ’tab-width’ (8)
Could not guess variable ’c-basic-offset’ (Not a cc-mode)
Guessed variable ’nxml-child-indent’ (2)
Guessed variable ’css-indent-offset’ (2)
Guessed variable ’python-indent’ (2)
Mark saved where search started
edebug-syntax-error: Invalid read syntax: "Bad argument:", &rest
Configured using:
 'configure --with-ns --disable-ns-self-contained'

Configured features:
JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS
NS

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  diff-auto-refine-mode: t
  ivy-mode: t
  buffer-face-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  pyvenv-mode: t
  shell-dirtrack-mode: t
  nameless-mode: t
  beacon-mode: t
  rainbow-mode: t
  column-enforce-mode: t
  volatile-highlights-mode: t
  region-state-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  show-smartparens-global-mode: t
  show-smartparens-mode: t
  smartparens-global-mode: t
  smartparens-global-strict-mode: t
  smartparens-strict-mode: t
  smartparens-mode: t
  which-key-mode: t
  modalka-mode: t
  recentf-mode: t
  global-auto-revert-mode: t
  auto-revert-mode: t
  winner-mode: t
  display-time-mode: t
  savehist-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(org-element org-rmail org-mhe org-irc org-info org-gnus org-docview
doc-view image-mode org-bibtex bibtex org-bbdb org-w3m
the-org-mode-expansions org org-macro org-footnote org-pcomplete
org-list org-faces org-entities noutline outline org-version
ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys
ob-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu
calendar cal-loaddefs shr-color linum magit-blame magit-stash
magit-bisect magit-remote magit-commit magit-sequence magit magit-apply
magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert
magit-process magit-popup magit-mode magit-git magit-section magit-utils
git-commit log-edit pcvs-util with-editor async-bytecomp async server
mailalias goto-chg shadow emacsbug cl-generic-tests testcover flow-fill
jka-compr shr svg dom browse-url qp nndraft nnmh nnfolder utf-7 epa-file
sort smiley gnus-cite mail-extr gnus-async gnus-bcklg gnus-agent
gnus-srvr gnus-score score-mode nnvirtual nntp gnus-ml gnus-msg
disp-table nndoc gnus-cache gnus-dup gnus-art mm-uu mml2015 mm-view
mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range gnus-win gnus nnheader mm-archive message rfc822 mml mml-sec
epa derived epg gnus-util rmail rmail-loaddefs mailabbrev gmm-utils
mailheader crm debbugs-gnu add-log zoom-window highlight-symbol
undo-tree diff eieio-opt speedbar sb-image ezimage dframe tabify
shrink-whitespace dash-at-point visual-regexp expand-region
text-mode-expansions python-el-fgallina-expansions er-basic-expansions
expand-region-core expand-region-custom ielm comment-dwim-2 ert
find-func ewoc debug pp edebug vc-git diff-mode colir flx dired
dired-loaddefs counsel esh-util swiper ivy delsel ffap face-remap
guess-style smtpmail sendmail mail-utils yasnippet highlight-indentation
flymake company help-fns radix-tree elpy pyvenv elpy-refactor
smartparens-python python tramp-sh tramp tramp-compat tramp-loaddefs
trampver shell pcomplete format-spec json map grep compile files-x
cus-edit virtualenvwrapper gud comint nameless lisp-mnt ace-window avy
beacon smex ido deft debbugs soap-client mm-decode mm-bodies mm-encode
warnings rng-xsd rng-dt rng-util xsd-regexp xml rainbow-mode ansi-color
color s hydra lv column-enforce-mode etags xref project
volatile-highlights region-state ws-butler smartparens-config
smartparens thingatpt dash which-key modalka quail
smart-mode-line-dark-theme smart-mode-line advice rich-minority
whiteboard-theme classic-theme recentf tree-widget wid-edit autorevert
filenotify winner ring time cus-start cus-load savehist cap-words
superword subword use-package diminish bind-key easy-mmode finder-inf
edmacro kmacro info network-stream starttls url-http tls gnutls
mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw
nsm subr-x puny url-cache url-auth url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap cl
package epg-config url-handlers url-parse auth-source cl-seq eieio
eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt
gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs
pcase cl-lib time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote kqueue cocoa ns multi-tty
make-network-process emacs)

Memory information:
((conses 16 1363213 218822)
 (symbols 48 59558 68)
 (miscs 40 7625 4642)
 (strings 32 204044 88844)
 (string-bytes 1 5746974)
 (vectors 16 96779)
 (vector-slots 8 2219014 137143)
 (floats 8 5415 2600)
 (intervals 56 83795 2701)
 (buffers 976 87))

Message #8 received at 24762 <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: 24762 <at> debbugs.gnu.org
Subject: Re: bug#24762: 26.0.50;
 Spurious &optional in lisp/progmodes/python.el causes Edebug error
Date: Wed, 16 Nov 2016 14:41:19 -0500

Gemini Lasswell <gazally <at> runbox.com> writes:

> There's an &optional followed by &rest instead of a parameter name in
> python-define-auxiliary-skeleton in lisp/progmodes/python.el. This
> doesn't work with defmacro's Edebug spec and prevents use of Edebug on
> the macro and testcover-start on the file.
>
> To repro:
> 1. start Emacs at the top of its source tree, with -Q if you like
> 2. C-x C-f lisp/progmodes/python.el RET
> 3. C-s &optional &r RET
> 4. C-u C-M-x
>
> Result: Invalid read syntax: "Bad argument:", &rest

Thanks for reporting--it looks to me like the following fixes:

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index f9b28c3..9cd9cc8 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table
   "Abbrev table for Python mode."
   :parents (list python-mode-skeleton-abbrev-table))
 
-(defmacro python-define-auxiliary-skeleton (name doc &optional &rest skel)
+(defmacro python-define-auxiliary-skeleton (name &optional doc &rest skel)
   "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL.
 The skeleton will be bound to python-skeleton-NAME."
   (declare (indent 2))
@@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton
          (signal 'quit t))
        ,@skel)))
 
-(python-define-auxiliary-skeleton else nil)
+(python-define-auxiliary-skeleton else)
 
-(python-define-auxiliary-skeleton except nil)
+(python-define-auxiliary-skeleton except)
 
-(python-define-auxiliary-skeleton finally nil)
+(python-define-auxiliary-skeleton finally)
 
 (python-skeleton-define if nil
   "Condition: "

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pit <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#24762: 26.0.50; Spurious &optional in
 lisp/progmodes/python.el causes Edebug error
Date: Wed, 16 Nov 2016 18:53:16 -0500

[Message part 1 (text/plain, inline)]

LGTM :)

On 2016-11-16 14:41, Mark Oteiza wrote:
> Gemini Lasswell <gazally <at> runbox.com> writes:
> 
>> There's an &optional followed by &rest instead of a parameter name in
>> python-define-auxiliary-skeleton in lisp/progmodes/python.el. This
>> doesn't work with defmacro's Edebug spec and prevents use of Edebug on
>> the macro and testcover-start on the file.
>>
>> To repro:
>> 1. start Emacs at the top of its source tree, with -Q if you like
>> 2. C-x C-f lisp/progmodes/python.el RET
>> 3. C-s &optional &r RET
>> 4. C-u C-M-x
>>
>> Result: Invalid read syntax: "Bad argument:", &rest
> 
> Thanks for reporting--it looks to me like the following fixes:
> 
> diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> index f9b28c3..9cd9cc8 100644
> --- a/lisp/progmodes/python.el
> +++ b/lisp/progmodes/python.el
> @@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table
>    "Abbrev table for Python mode."
>    :parents (list python-mode-skeleton-abbrev-table))
>  
> -(defmacro python-define-auxiliary-skeleton (name doc &optional &rest skel)
> +(defmacro python-define-auxiliary-skeleton (name &optional doc &rest skel)
>    "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL.
>  The skeleton will be bound to python-skeleton-NAME."
>    (declare (indent 2))
> @@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton
>           (signal 'quit t))
>         ,@skel)))
>  
> -(python-define-auxiliary-skeleton else nil)
> +(python-define-auxiliary-skeleton else)
>  
> -(python-define-auxiliary-skeleton except nil)
> +(python-define-auxiliary-skeleton except)
>  
> -(python-define-auxiliary-skeleton finally nil)
> +(python-define-auxiliary-skeleton finally)
>  
>  (python-skeleton-define if nil
>    "Condition: "
> 
> 
> 
> 

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 24762 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: Gemini Lasswell <gazally <at> runbox.com>, 24762 <at> debbugs.gnu.org
Subject: Re: bug#24762: 26.0.50;
 Spurious &optional in lisp/progmodes/python.el causes Edebug error
Date: Wed, 30 Nov 2016 19:42:14 -0500

tags 24762 fixed
close 24762 
quit

Mark Oteiza <mvoteiza <at> udel.edu> writes:
>
> diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> index f9b28c3..9cd9cc8 100644
> --- a/lisp/progmodes/python.el
> +++ b/lisp/progmodes/python.el
> @@ -4040,7 +4040,7 @@ 'python-mode-abbrev-table
>    "Abbrev table for Python mode."
>    :parents (list python-mode-skeleton-abbrev-table))
>  
> -(defmacro python-define-auxiliary-skeleton (name doc &optional &rest skel)
> +(defmacro python-define-auxiliary-skeleton (name &optional doc &rest skel)
>    "Define a `python-mode' auxiliary skeleton using NAME DOC and SKEL.
>  The skeleton will be bound to python-skeleton-NAME."
>    (declare (indent 2))
> @@ -4060,11 +4060,11 @@ python-define-auxiliary-skeleton
>           (signal 'quit t))
>         ,@skel)))
>  
> -(python-define-auxiliary-skeleton else nil)
> +(python-define-auxiliary-skeleton else)
>  
> -(python-define-auxiliary-skeleton except nil)
> +(python-define-auxiliary-skeleton except)
>  
> -(python-define-auxiliary-skeleton finally nil)
> +(python-define-auxiliary-skeleton finally)
>  
>  (python-skeleton-define if nil
>    "Condition: "

I see was pushed as 5b003caa "Fix arglist in python.el (Bug#24762)".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.