From unknown Wed Jun 18 23:14:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24727: 25.1; Editing custom theme removes undefined variables and faces Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2016 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24727@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.147680477819435 (code B ref -1); Tue, 18 Oct 2016 15:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Oct 2016 15:32:58 +0000 Received: from localhost ([127.0.0.1]:38237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwWNu-00053K-1z for submit@debbugs.gnu.org; Tue, 18 Oct 2016 11:32:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwPWZ-0006QI-LH for submit@debbugs.gnu.org; Tue, 18 Oct 2016 04:13:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwPWT-0002mm-59 for submit@debbugs.gnu.org; Tue, 18 Oct 2016 04:13:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwPWT-0002mf-25 for submit@debbugs.gnu.org; Tue, 18 Oct 2016 04:13:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwPWS-0006ek-2D for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 04:13:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwPWO-0002lj-P7 for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 04:13:19 -0400 Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]:35352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwPWO-0002la-GW for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 04:13:16 -0400 Received: by mail-pf0-x22c.google.com with SMTP id s8so90545648pfj.2 for ; Tue, 18 Oct 2016 01:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:subject:date:message-id:mime-version; bh=CrhUxmGuTMEtfSZj00GfD5jWBmokxj9bpybHwc1k730=; b=bzjWwsGfBvp9vSMqw0SkbBH1mGhsbl1EVJCSOvSnuA14VzcZ31bhMO8v1LxJd8TTCc MSOqMvXfFMQ/IzsKPq81P23LK8q+SQKqTge1KsAwxW0OU0ms/Q9OZ+yBOjNDuGwqPDDB b7RgPvCd+g3XDL/FShBG1mF6b4phUOp//1E9aLRmpdDr+b6jhA5MdWjPyS5oeX5E0oLj 27Y20Beyejv/NHHRj/WB0EHFhP/g/xnOObHrSkVsL/9dqgRyH70g0AuZBSoBf/8J+6HN UHoSe2gpIH+snMcaRzG2fUTNfEdYl9FN/NXUzRtSfEaMs2+6iryuvodR6e1mhd1go9bj dwOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=CrhUxmGuTMEtfSZj00GfD5jWBmokxj9bpybHwc1k730=; b=KslyqZjS9vrfnzopjC+3Y6mSjG2uJCtzDySBMnjWQzyfoX7uHrOsN3ZfGwFT7NzcTR NG8Exm8cK1iTSKOOulY7DV4a91rCYybGoK8xMYRRoTL9mbbo/r3KwZ6xSEBPyKj+JFrj n0HfXjOx1kVlBQnB54GZgMNpMLceBzb72ZiFQNixDhiVyFpfMcj0lHyWJ8AHUYQom43A k2S/3cuzNMVdz8zxanSlRXUW/vbpfmElBubfixrYO0OV5Q8wkMYCFexyfJ+JfDBvakgY 3e+rRKRvOBW4AEpZGeHmPgZzkb1W0W57G3Wyj3xc2G3+BuklgbhHtUhilVtBdggRM6ae gEWg== X-Gm-Message-State: AA6/9Rlu+VHs+z153pzPP712jOfg498fRhnOOD7k+HVWq7IX2mbqluaUeeQ0wS3dc5IFwg== X-Received: by 10.98.198.132 with SMTP id x4mr2691427pfk.23.1476778394825; Tue, 18 Oct 2016 01:13:14 -0700 (PDT) Received: from localhost (c-73-70-42-168.hsd1.ca.comcast.net. [73.70.42.168]) by smtp.gmail.com with ESMTPSA id v86sm53515000pfa.91.2016.10.18.01.13.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Oct 2016 01:13:14 -0700 (PDT) User-agent: mu4e 0.9.16; emacs 25.1.1 From: Allen Li Date: Tue, 18 Oct 2016 01:13:12 -0700 Message-ID: <87oa2if52f.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Tue, 18 Oct 2016 11:32:55 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) When using `customize-create-theme' to visit and edit an existing theme, undefined variables and faces get removed on save (for example, for a package whose autoload hasn't been triggered yet). In GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9) of 2016-09-18 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 From unknown Wed Jun 18 23:14:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24727: 25.1; Editing custom theme removes undefined variables and faces References: <87oa2if52f.fsf@gmail.com> In-Reply-To: <87oa2if52f.fsf@gmail.com> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 13:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24727@debbugs.gnu.org Cc: Allen Li Received: via spool by 24727-submit@debbugs.gnu.org id=B24727.159922458310421 (code B ref 24727); Fri, 04 Sep 2020 13:04:01 +0000 Received: (at 24727) by debbugs.gnu.org; 4 Sep 2020 13:03:03 +0000 Received: from localhost ([127.0.0.1]:37943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBMt-0002i1-By for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:03:03 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:33239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBMr-0002hW-GQ for 24727@debbugs.gnu.org; Fri, 04 Sep 2020 09:03:01 -0400 Received: by mail-wm1-f44.google.com with SMTP id e11so7493460wme.0 for <24727@debbugs.gnu.org>; Fri, 04 Sep 2020 06:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=O9gINvyxcXBheY67dTKAJ53E4tJGDa5rit0YRiuUzo4=; b=A0q2PUo69/Q6T/sHjkqyFMoZiw2qsyxo/1CKP1dsE5bnXwijmZyMP7n4naJnB3pUbr rtVn+ar9Ca+5SS4Ld78neooluwBNyMUkjkXdtvhrmJtVoMYHv2sfgwKeZbVYxV1TuQPw jfU7VVEIyhLBlKm3XZVofgHcyZevtFtzEyyu3GyYdfiOWXUkXIOF0t3QSxdRVqoRnUCi CFtWcPj7UXO0grhU4C0Wwxjv9WJhmbAltliuAIZdSOhmRHqKJbjH8XvaDk344oLGvChr RIyTWlF8KJK3NG/Segk/zwuv5ei8ai9P2RujUOzZMVOI64T3o8yttFs/b68NLG0E2KT0 5iSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=O9gINvyxcXBheY67dTKAJ53E4tJGDa5rit0YRiuUzo4=; b=GpVUjl0sVMSK1GHGHL9cfLVC3PTSqhZ7WO8gUvz4z4/5AselNOhlHftxZ1TEQjfMOU QA8TMCtXjyqguDP2os+KxES4wUs1wvZ+v9QIKaEmz5rDYkwd2Flz8RR0dy0/k6JtC3LF e9ttuPDwyUDOUje/adiDWTXHce0wG7OAc7Clr0vs27ZyXZVvj8+A6fWUr1VK3N/CF6LP BdrqZ5CnlCJ0UFrSJkUZFZwOLz1+eveMpfIpo8NADHyW+KWElKLuhfq0PPv2y2NZcrcA iD0mGUiV8ZBs9MJtLIjm+VG5xUOtmwYdZeRpnp8nFLD3jaSFoyceycqW9Y3kQp5rvm1y ce+Q== X-Gm-Message-State: AOAM531XE92IBNft1zpyXYUyIRji7zizU0FRYGXnTJrtOF6G4rpm6uRb zPtYAS91237SzZwEv3M0ScEWkhS9y4eDd0J8bqijT+bMn8vOoA== X-Google-Smtp-Source: ABdhPJzJdbK4nxM5wVI8zULdOiM/9REaVoMVQmIdNZc6pGZQfxto5h2GaF2BVbi3zcnvS/rLN30kMFiMIN2fjzu42Dc= X-Received: by 2002:a1c:1b43:: with SMTP id b64mr7834950wmb.6.1599224575070; Fri, 04 Sep 2020 06:02:55 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 4 Sep 2020 10:02:43 -0300 Message-ID: Content-Type: multipart/mixed; boundary="000000000000b6ccf205ae7c7c9e" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b6ccf205ae7c7c9e Content-Type: multipart/alternative; boundary="000000000000b6ccef05ae7c7c9c" --000000000000b6ccef05ae7c7c9c Content-Type: text/plain; charset="UTF-8" Allen Li writes: > When using `customize-create-theme' to visit and edit an existing theme, > undefined variables and faces get removed on save (for example, for a > package whose autoload hasn't been triggered yet). > To test this, I used the following theme: (deftheme tbb-test "A test theme.") (custom-theme-set-variables 'tbb-test '(column-number-mode t) '(foo-undefined 'foo)) (provide-theme 'tbb-test) And put it under custom-theme-directory, with name tbb-test-theme.el. Then: M-x custom-theme-visit-theme RET tbb-test And clicked Save Theme. Then I visited tbb-test-theme.el and confirmed that the entry for foo-undefined wasn't there anymore. There is a check in custom-theme-write-variables for a bound symbol, and a check in custom-theme-write-faces for a known face, and I wonder why, because that should not be a concern for these functions. Note that still editing a theme with custom-theme-visit-theme is somewhat buggy, because if you click to show the variable foo-undefined you end up with a lot of errors, and you can't hide it back. But at least removing the checks makes it less rude, and undefined variables or faces stay in the file. Here's my proposed patch. --000000000000b6ccef05ae7c7c9c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Allen Li <v= ianchielfaura@gmail.com> writes:

> When using `customize-c= reate-theme' to visit and edit an existing theme,
> undefined var= iables and faces get removed on save (for example, for a
> package wh= ose autoload hasn't been triggered yet).
>

To test this, I= used the following theme:
(deftheme tbb-test
=C2=A0 "A test the= me.")

(custom-theme-set-variables
=C2=A0'tbb-test
=C2= =A0'(column-number-mode t)
=C2=A0'(foo-undefined 'foo))
<= br>(provide-theme 'tbb-test)

And put it under custom-theme-direc= tory, with name tbb-test-theme.el.
Then:
M-x custom-theme-visit-theme= RET tbb-test

And clicked Save Theme.

Then I visited tbb-test= -theme.el and confirmed that the entry for
foo-undefined wasn't ther= e anymore.

There is a check in custom-theme-write-variables for a bo= und symbol, and
a check in custom-theme-write-faces for a known face, an= d I wonder why,
because that should not be a concern for these functions= .

Note that still editing a theme with custom-theme-visit-theme issomewhat buggy, because if you click to show the variable foo-undefinedyou end up with a lot of errors, and you can't hide it back.

B= ut at least removing the checks makes it less rude, and undefined
variab= les or faces stay in the file.

Here's my proposed patch.
--000000000000b6ccef05ae7c7c9c-- --000000000000b6ccf205ae7c7c9e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Do-not-remove-unbound-variables-or-faces-when-modify.patch" Content-Disposition: attachment; filename="0001-Do-not-remove-unbound-variables-or-faces-when-modify.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_keo8z6wh0 RnJvbSAyZjMzZmMwMTFiNmY1MTRkYmQ2YmNjODBhYWQzMGM1NTdhZjkyODc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgMjYgQXVnIDIwMjAgMTA6MjI6MTEgLTAzMDAKU3ViamVjdDogW1BBVENIXSBE byBub3QgcmVtb3ZlIHVuYm91bmQgdmFyaWFibGVzIG9yIGZhY2VzIHdoZW4gbW9kaWZ5aW5nIGEK IGN1c3RvbS10aGVtZQoKKiBsaXNwL2N1cy10aGVtZS5lbCAoY3VzdG9tLXRoZW1lLXdyaXRlLXZh cmlhYmxlcwpjdXN0b20tdGhlbWUtd3JpdGUtZmFjZXMpOiBSZW1vdmUgY2hlY2sgZm9yIGEgYm91 bmQgc3ltYm9sIG9yIGZvciBhCmZhY2UgbmFtZSwgc28gc2F2aW5nIGEgdGhlbWUgZG9lcyBub3Qg cmVtb3ZlIG5vdCB5ZXQgZGVmaW5lZCB2YXJpYWJsZXMKb3IgZmFjZXMuICAoQnVnIzI0NzI3KS4K LS0tCiBsaXNwL2N1cy10aGVtZS5lbCB8IDE3ICsrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hh bmdlZCwgOCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av Y3VzLXRoZW1lLmVsIGIvbGlzcC9jdXMtdGhlbWUuZWwKaW5kZXggYjBkZWNmZTdiNy4uZGM0NjNl MDVmOSAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtdGhlbWUuZWwKKysrIGIvbGlzcC9jdXMtdGhlbWUu ZWwKQEAgLTQxOSwxNCArNDE5LDEzIEBAIGN1c3RvbS10aGVtZS13cml0ZS12YXJpYWJsZXMKIAkJ CSAgICAod2lkZ2V0LXZhbHVlIGNoaWxkKQogCQkJICA7OyBDaGlsZCBpcyBudWxsIGlmIHRoZSB3 aWRnZXQgaXMgY2xvc2VkIChoaWRkZW4pLgogCQkJICAoY2FyICh3aWRnZXQtZ2V0IHdpZGdldCA6 c2hvd24tdmFsdWUpKSkpKQotCSAgICAod2hlbiAoYm91bmRwIHN5bWJvbCkKLQkgICAgICAodW5s ZXNzIChib2xwKQotCQkocHJpbmMgIlxuIikpCi0JICAgICAgKHByaW5jICIgJygiKQotCSAgICAg IChwcmluMSBzeW1ib2wpCi0JICAgICAgKHByaW5jICIgIikKLQkgICAgICAocHJpbjEgKGN1c3Rv bS1xdW90ZSB2YWx1ZSkpCi0JICAgICAgKHByaW5jICIpIikpKSkpCisJICAgICh1bmxlc3MgKGJv bHApCisJICAgICAgKHByaW5jICJcbiIpKQorCSAgICAocHJpbmMgIiAnKCIpCisJICAgIChwcmlu MSBzeW1ib2wpCisJICAgIChwcmluYyAiICIpCisJICAgIChwcmluMSAoY3VzdG9tLXF1b3RlIHZh bHVlKSkKKwkgICAgKHByaW5jICIpIikpKSkKICAgICAgIChpZiAoYm9scCkKIAkgIChwcmluYyAi ICIpKQogICAgICAgKHByaW5jICIpIikKQEAgLTQ1NCw3ICs0NTMsNyBAQCBjdXN0b20tdGhlbWUt d3JpdGUtZmFjZXMKIAkJICAgOzsgQ2hpbGQgaXMgbnVsbCBpZiB0aGUgd2lkZ2V0IGlzIGNsb3Nl ZCAoaGlkZGVuKS4KIAkJICAgKCh3aWRnZXQtZ2V0IHdpZGdldCA6c2hvd24tdmFsdWUpKQogCQkg ICAodCAoY3VzdG9tLWZhY2UtZ2V0LWN1cnJlbnQtc3BlYyBzeW1ib2wpKSkpKQotCSAgICAod2hl biAoYW5kIChmYWNlcCBzeW1ib2wpIHZhbHVlKQorCSAgICAod2hlbiB2YWx1ZQogCSAgICAgIChw cmluYyAoaWYgKGJvbHApICIgJygiICJcbiAnKCIpKQogCSAgICAgIChwcmluMSBzeW1ib2wpCiAJ ICAgICAgKHByaW5jICIgIikKLS0gCjIuMjguMAoK --000000000000b6ccf205ae7c7c9e-- From unknown Wed Jun 18 23:14:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24727: 25.1; Editing custom theme removes undefined variables and faces Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Allen Li , 24727@debbugs.gnu.org Received: via spool by 24727-submit@debbugs.gnu.org id=B24727.159922673822366 (code B ref 24727); Fri, 04 Sep 2020 13:39:02 +0000 Received: (at 24727) by debbugs.gnu.org; 4 Sep 2020 13:38:58 +0000 Received: from localhost ([127.0.0.1]:38032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBve-0005of-Jo for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:38:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBvd-0005oS-VD for 24727@debbugs.gnu.org; Fri, 04 Sep 2020 09:38:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K8Bq8kJVdY8GL2qqt/W1uNnABs8e8STPDLVghy3KVo4=; b=XODciAI4Is1Lo53pxjcezrsz0U vAxzR97IXSEV4/JVbqmNeBa0styGvjNarqkoW4nUWmAIWEJc3pzTgSITGjRS7fvYK1zFsYcCQtaUu T2rWEQUIEyki1P/1nt6cqPuruGcVpSEhBG5GG0Ex93vsh3LE1A9RFQU+gbAjFsl4EK30=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBvU-0000Ao-P6; Fri, 04 Sep 2020 15:38:51 +0200 From: Lars Ingebrigtsen References: <87oa2if52f.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEX622P96mju2WDn pWOzoEjsbjbWhz70tYvv0qH55878+fH///+IxYaOAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+QJBA0k CUOfzEMAAAGASURBVDjLnZPBaoNAEIa1TxDbF4hroKG3uBU317JvIKm9lzbnIqlJTiki7u6pIDRZ T4Uc4u5T1piGyGgC7bAwsB///DMDYxiGaXWFcQFY/wUIuahvN8DRglYx6AT3ZwDaS7qAVX0iswvA rsxzA55X1NnBLq6e49oAeC/h5DWYeMEIgGGCg3kcx9EJHFaS8AxjXxP9ARQZKUqfkTh7A0BgUaQi IiFUiETwXbFjEnosUvYpPV/ItgLLXRBwfgJGb5/v2LhMJ+Gy0dVBQyKSE5wRDj1u13kUZ5L4DVCb OFk+87NZhOFKkjxM3tNgvIYg2j5FX3k8LVZw7duQ44ThZrt15t9THW/ERsJSYktEwrQan5Z4GJDl RHhMysUIgnXAH9nmedYqpXRZ6HKpV8BcSK201lI1PGqJ4IpoWbICblcoxQpZiVYQCCV1URWDAw4Z m7N92MCjFRfA7/+1i2yEUBtcUYrogLZBdWl2dWttcEPpA3Wa4HjnZq/f6zJvd2X9EfwAN7GyEqS2 dKkAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMDRUMTM6MzY6MDkrMDA6MDAnT2mFAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTA5LTA0VDEzOjM2OjA5KzAwOjAwVhLROQAAAABJRU5ErkJggg== X-Now-Playing: The Pentangle's _Cruel Sister_: "Jack Orion" Date: Fri, 04 Sep 2020 15:38:47 +0200 In-Reply-To: (Mauro Aranda's message of "Fri, 4 Sep 2020 10:02:43 -0300") Message-ID: <87lfhpacgo.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > There is a check in custom-theme-write-variables for a bound symbol, and > a check in custom-theme-write-faces for a known face, and I wonder why, > because that should not be a concern for these fu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > There is a check in custom-theme-write-variables for a bound symbol, and > a check in custom-theme-write-faces for a known face, and I wonder why, > because that should not be a concern for these functions. Yes, that seems odd. I had a short look around at the commit history here, but I was unable to find an explanation (but I didn't do an extensive examination). > But at least removing the checks makes it less rude, and undefined > variables or faces stay in the file. > > Here's my proposed patch. It makes sense to me (and the old behaviour didn't), so I've applied it to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 09:39:11 2020 Received: (at control) by debbugs.gnu.org; 4 Sep 2020 13:39:11 +0000 Received: from localhost ([127.0.0.1]:38036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBvq-0005pW-QO for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:39:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBvp-0005pK-IT for control@debbugs.gnu.org; Fri, 04 Sep 2020 09:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lvJiLl0874XU9cwnfUMDivQq4vR65KPx81c0PTQWRdQ=; b=hJpgjnJ4keYSlzwRAFkgQ/MmDq 1YGxeQpxAomYRo3AujzGC9TjRFqRiuIoJKWyaATBcl3MyfvzUty9Cpqw7iTc/5S1Wv5fAaV7eq2BR OjX4scLAfQOO/RQjUH9tnCjuQKIeUoCS//3EZeqcXe4ACQOKDqVxnDDZVoP3hScOJb+k=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBvh-0000Bj-PL for control@debbugs.gnu.org; Fri, 04 Sep 2020 15:39:04 +0200 Date: Fri, 04 Sep 2020 15:39:00 +0200 Message-Id: <87k0x9acgb.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24727 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 24727 fixed close 24727 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24727 fixed close 24727 28.1 quit