Subject: bug#24722: closed (Re: bug#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 04 Feb 2017 11:22:01 +0000

Your bug report

#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
24722: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24722
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer
From: Eli Zaretskii <[email-masked]>
To: Gemini Lasswell <[email-masked]>
Cc: [email-masked]
Date: Sat, 04 Feb 2017 13:20:53 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Gemini Lasswell <[email-masked]>
> Date: Mon, 17 Oct 2016 16:15:55 -0700
> 
> To reproduce, starting at the root of the Emacs source tree:
> 
> 1. emacs -Q
> 2. M-x edebug-all-defs RET
> 3. C-x C-f test/lisp/jit-lock-tests.el RET
> 4. M-x eval-buffer RET
> 
> Result: invalid-read-syntax "Failed matching" (form)
> 
> Here's a one line patch that fixes it for me:

Thanks, pushed.

Subject: 26.0.50; incorrect Edebug spec for ert-with-test-buffer
From: Gemini Lasswell <[email-masked]>
To: [email-masked]
Date: Mon, 17 Oct 2016 16:15:55 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

To reproduce, starting at the root of the Emacs source tree:

1. emacs -Q
2. M-x edebug-all-defs RET
3. C-x C-f test/lisp/jit-lock-tests.el RET
4. M-x eval-buffer RET

Result: invalid-read-syntax "Failed matching" (form)

Here's a one line patch that fixes it for me:
>From 721683d1f83b342504f25cc6fcb7363509f1c464 Mon Sep 17 00:00:00 2001
From: gazally <[email-masked]>
Date: Mon, 17 Oct 2016 15:57:43 -0700
Subject: [PATCH] Fix the Edebug spec for ert-with-test-buffer

---
 lisp/emacs-lisp/ert-x.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
index 2a2418f..16ba560 100644
--- a/lisp/emacs-lisp/ert-x.el
+++ b/lisp/emacs-lisp/ert-x.el
@@ -97,7 +97,7 @@ ert--call-with-test-buffer
 buffer is killed; if there is an error, the test buffer is kept
 around on error for further inspection.  Its name is derived from
 the name of the test and the result of NAME-FORM."
-  (declare (debug ((form) body))
+  (declare (debug ((":name" form) body))
            (indent 1))
   `(ert--call-with-test-buffer ,name-form (lambda () ,@body)))
 
-- 
2.10.1