GNU bug report logs - #24721
25.1; Reverse the order of `isearch-message-prefix' prefixes from function advice property

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Mon, 17 Oct 2016 22:18:01 UTC

Severity: wishlist

Tags: wontfix

Found in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: 24721 <at> debbugs.gnu.org
Subject: bug#24721: 25.1; Reverse the order of `isearch-message-prefix' prefixes from function advice property
Date: Mon, 17 Oct 2016 15:16:50 -0700 (PDT)
When there is multiple advice (from `add-function') of
`isearch-filter-predicate' that has property `isearch-message-prefix',
these prefixes are currently shown left to right in the Isearch prompt,
with the first added being on the left and the last added being on the
right.

I think this is backwards from what a user expects.  I've reversed the
order in my own copy, and I think it is more helpful: The first one you
see is the latest applied.  Entries are added and removed on the left,
not the right.  The most important such prefix is typically the last
one applied, and having it on the left makes it more noticeable (IMO).

If you agree, all that's required is changing, in the
`isearch-message-prefix' code, (concat np prefix) to (concat prefix np).


In GNU Emacs 25.1.1 (x86_64-w64-mingw32)
 of 2016-09-17
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --without-compress-install CFLAGS=-static'




This bug report was last modified 4 years and 271 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.