GNU bug report logs - #24713
26.0.50; edebug-max-depth should be customizable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24713 in the body.
You can then email your comments to 24713 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gemini Lasswell <gazally <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; edebug-max-depth should be customizable
Date: Sun, 16 Oct 2016 14:58:44 -0700

[Message part 1 (text/plain, inline)]

Edebug's recursion limit is currently 150, but this is not enough for
the following files in the Emacs source tree:

lisp/calc/calc-ext.el
lisp/help-macro.el
lisp/international/fontset.el

The latter two can be successfully instrumented with edebug-max-depth
set to 200, but the minimum value necessary for calc-ext.el is somewhere
between 500 and 1000. All three of these files contain large quoted
lists.

I'm attaching a patch to accomplish this. I chose to mention
max-lisp-eval-depth and max-specpdl-size in the defcustom docstring, but
I also noticed that Edebug temporarily bumps max-lisp-eval-depth up by
800 while it's working. I could modify the patch to replace the 800 by
something along the lines of (+ 200 (* max-edebug-depth 4)), if someone
with more Emacs experience than me says it is a good idea. Edebug also
increases max-specpdl-size (by 2000) so that probably would also need to
be changed in the code.

[0001-Change-edebug-max-depth-from-defconst-to-defcustom.patch (text/plain, attachment)]

Message #10 received at 24713-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: 24713-done <at> debbugs.gnu.org
Subject: Re: bug#24713: 26.0.50; edebug-max-depth should be customizable
Date: Sat, 04 Feb 2017 13:05:13 +0200

> From: Gemini Lasswell <gazally <at> runbox.com>
> Date: Sun, 16 Oct 2016 14:58:44 -0700
> 
> Edebug's recursion limit is currently 150, but this is not enough for
> the following files in the Emacs source tree:
> 
> lisp/calc/calc-ext.el
> lisp/help-macro.el
> lisp/international/fontset.el
> 
> The latter two can be successfully instrumented with edebug-max-depth
> set to 200, but the minimum value necessary for calc-ext.el is somewhere
> between 500 and 1000. All three of these files contain large quoted
> lists.
> 
> I'm attaching a patch to accomplish this.

Thanks, pushed.

A few minor nits for the future:

 . when you add/modify a defcustom, always specify a :version tag
 . please always mention the bug number in the commit log message,
   otherwise it must be added by hand, which is error-prone
 . user-visible changes should be accompanied by suitable changes to
   NEWS and the manuals (I did it this time)
 . please use the US English convention of leaving 2 spaces between
   sentences -- this is what we use in Emacs documentation
 . please configure your Git repo (on Github?) so that your user name
   is identical to what you use to send email, to avoid confusion

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.