GNU bug report logs - #24710
26.0.50; Feature request: Replace double quotes in electric-quote-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24710 in the body.
You can then email your comments to 24710 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Feature request: Replace double quotes in electric-quote-mode
Date: Sun, 16 Oct 2016 19:24:03 +0200

Currently electric-quote-mode only replaces ' and `.  I propose that
it also replace " with a left double quote after spaces, newlines, and
open parentheses, and with a right double quote after alphanumerics and
other punctuation.


In GNU Emacs 26.0.50.4 (x86_64-apple-darwin16.0.0, NS appkit-1504.00 Version 10.12 (Build 16A323))
 of 2016-10-16 built on p
Repository revision: cf566b46a6cf85c6d54d0b0db80e32ed6ae8d1ca
Windowing system distributor 'Apple', version 10.3.1504
Recent messages:
Mark set
Setting ‘send-mail-function’ temporarily since "emacs -q" would overwrite customizations
Sending...
Mark set [2 times]
Sending via mail...
Setting ‘smtpmail-smtp-server’ temporarily since "emacs -q" would overwrite customizations
Setting ‘smtpmail-smtp-service’ temporarily since "emacs -q" would overwrite customizations
Sending email 
Sending email done
Sending...done

Configured using:
 'configure --with-modules --enable-checking
 --enable-check-lisp-object-type --without-xml2'

Configured features:
RSVG IMAGEMAGICK DBUS NOTIFY ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS
MODULES

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(network-stream nsm starttls tls gnutls mailalias smtpmail auth-source
cl-seq eieio eieio-core cl-macs eieio-loaddefs cus-edit cus-start
cus-load wid-edit pp shadow sort mail-extr emacsbug message subr-x puny
seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv
cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml
easymenu mml-sec password-cache epa derived epg epg-config gnus-util
rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind kqueue cocoa ns multi-tty
make-network-process emacs)

Memory information:
((conses 16 235881 14695)
 (symbols 48 22643 6)
 (miscs 40 66 361)
 (strings 32 24312 6843)
 (string-bytes 1 751015)
 (vectors 16 37279)
 (vector-slots 8 708029 5877)
 (floats 8 225 337)
 (intervals 56 511 28)
 (buffers 976 15))

Message #8 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24710 <at> debbugs.gnu.org
Subject: Re: 26.0.50; Feature request: Replace double quotes in
 electric-quote-mode
Date: Fri, 14 Jul 2017 05:48:47 -0700

> Currently electric-quote-mode only replaces ' and `.  I propose that
> it also replace " with a left double quote after spaces, newlines, and
> open parentheses, and with a right double quote after alphanumerics and
> other punctuation.

This sounds reasonable, though I suppose it should be controlled by an option, 
since some people may prefer the current behavior where `` and '' are the only 
convenient ways to get curved double quotes.

Also, shouldn't it always replace " with a curved quote of one flavor of the 
other? I'm puzzled as to why one would want " to stay straight, when the option 
is enabled.

Message #11 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 24710 <at> debbugs.gnu.org
Subject: Re: bug#24710: 26.0.50;
 Feature request: Replace double quotes in electric-quote-mode
Date: Sun, 23 Jul 2017 20:01:05 +0000

[Message part 1 (text/plain, inline)]

Paul Eggert <eggert <at> cs.ucla.edu> schrieb am Fr., 14. Juli 2017 um 14:49 Uhr:

> > Currently electric-quote-mode only replaces ' and `.  I propose that
> > it also replace " with a left double quote after spaces, newlines, and
> > open parentheses, and with a right double quote after alphanumerics and
> > other punctuation.
>
> This sounds reasonable, though I suppose it should be controlled by an
> option,
> since some people may prefer the current behavior where `` and '' are the
> only
> convenient ways to get curved double quotes.
>
> Also, shouldn't it always replace " with a curved quote of one flavor of
> the
> other? I'm puzzled as to why one would want " to stay straight, when the
> option
> is enabled.
>
>
>
OK, here's a patch.

[Message part 2 (text/html, inline)]

[0001-Electric-quote-mode-Conditionally-replace-Bug-24710.txt (text/plain, attachment)]

Message #14 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24710 <at> debbugs.gnu.org
Subject: Re: bug#24710: 26.0.50; Feature request: Replace double quotes in
 electric-quote-mode
Date: Mon, 24 Jul 2017 00:55:13 -0700

Philipp Stephani wrote:

> OK, here's a patch.

Thanks. I don’t see the point of the non-context-sensitive version. That is, if 
‘"’ is supposed to be replaced by a curved double-quote, then I don’t see the 
point of having a mode where ‘"’ is always replaced by closing double quote. 
That does not seem useful for English, anyway.

In the NEWS item, just say ‘"’ instead of ‘double quote’ or ‘double ASCII quote’.

Message #17 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 24710 <at> debbugs.gnu.org
Subject: Re: bug#24710: 26.0.50;
 Feature request: Replace double quotes in electric-quote-mode
Date: Sat, 23 Sep 2017 20:22:02 +0000

[Message part 1 (text/plain, inline)]

Paul Eggert <eggert <at> cs.ucla.edu> schrieb am Mo., 24. Juli 2017 um 09:55 Uhr:

> Philipp Stephani wrote:
>
> > OK, here's a patch.
>
> Thanks. I don’t see the point of the non-context-sensitive version. That
> is, if
> ‘"’ is supposed to be replaced by a curved double-quote, then I don’t see
> the
> point of having a mode where ‘"’ is always replaced by closing double
> quote.
> That does not seem useful for English, anyway.
>
> In the NEWS item, just say ‘"’ instead of ‘double quote’ or ‘double ASCII
> quote’.
>

OK, here's an updated patch.

[Message part 2 (text/html, inline)]

[0001-Electric-quote-mode-Conditionally-replace-Bug-24710.txt (text/plain, attachment)]

Message #20 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24710 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#24710: 26.0.50;
 Feature request: Replace double quotes in electric-quote-mode
Date: Sun, 24 Sep 2017 05:50:31 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sat, 23 Sep 2017 20:22:02 +0000
> Cc: 24710 <at> debbugs.gnu.org
> 
>  In the NEWS item, just say ‘"’ instead of ‘double quote’ or ‘double ASCII quote’.
> 
> OK, here's an updated patch. 

Thanks.  How about updating the Emacs manual as well?

Message #23 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24710 <at> debbugs.gnu.org
Subject: Re: bug#24710: 26.0.50; Feature request: Replace double quotes in
 electric-quote-mode
Date: Sat, 23 Sep 2017 22:03:18 -0700

Eli Zaretskii wrote:
> Thanks.  How about updating the Emacs manual as well?

Yes, other than that it looks good to me.

Message #26 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 24710 <at> debbugs.gnu.org
Subject: Re: bug#24710: 26.0.50;
 Feature request: Replace double quotes in electric-quote-mode
Date: Sun, 24 Sep 2017 07:04:07 +0000

[Message part 1 (text/plain, inline)]

Paul Eggert <eggert <at> cs.ucla.edu> schrieb am So., 24. Sep. 2017 um 07:03 Uhr:

> Eli Zaretskii wrote:
> > Thanks.  How about updating the Emacs manual as well?
>
> Yes, other than that it looks good to me.
>

OK, here's a new patch.

[Message part 2 (text/html, inline)]

[0001-Electric-quote-mode-Conditionally-replace-Bug-24710.txt (text/plain, attachment)]

Message #29 received at 24710 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24710 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#24710: 26.0.50;
 Feature request: Replace double quotes in electric-quote-mode
Date: Fri, 29 Sep 2017 10:08:42 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sun, 24 Sep 2017 07:04:07 +0000
> Cc: 24710 <at> debbugs.gnu.org
> 
>  Eli Zaretskii wrote:
>  > Thanks. How about updating the Emacs manual as well?
> 
>  Yes, other than that it looks good to me.
> 
> OK, here's a new patch. 

Thanks, this LGTM.

> Subject: [PATCH] Electric quote mode: Conditionally replace " (Bug#24710)
> 
> * lisp/electric.el (electric-quote-replace-double): New user option.
> (electric-quote-post-self-insert-function): Use it.
> 
> * electric-tests.el (electric-quote-replace-double-disabled)
> (electric-quote-replace-double-bob)
> (electric-quote-replace-double-bol)
> (electric-quote-replace-double-after-space)
> (electric-quote-replace-double-after-letter)
> (electric-quote-replace-double-after-paren): New unit tests.

Please add the log entries for the documentation here, when you push.

Message #34 received at 24710-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, 24710-done <at> debbugs.gnu.org
Cc: eggert <at> cs.ucla.edu
Subject: Re: bug#24710: 26.0.50;
 Feature request: Replace double quotes in electric-quote-mode
Date: Sat, 30 Sep 2017 22:21:21 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Fr., 29. Sep. 2017 um 09:09 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Sun, 24 Sep 2017 07:04:07 +0000
> > Cc: 24710 <at> debbugs.gnu.org
> >
> >  Eli Zaretskii wrote:
> >  > Thanks. How about updating the Emacs manual as well?
> >
> >  Yes, other than that it looks good to me.
> >
> > OK, here's a new patch.
>
> Thanks, this LGTM.
>
> > Subject: [PATCH] Electric quote mode: Conditionally replace " (Bug#24710)
> >
> > * lisp/electric.el (electric-quote-replace-double): New user option.
> > (electric-quote-post-self-insert-function): Use it.
> >
> > * electric-tests.el (electric-quote-replace-double-disabled)
> > (electric-quote-replace-double-bob)
> > (electric-quote-replace-double-bol)
> > (electric-quote-replace-double-after-space)
> > (electric-quote-replace-double-after-letter)
> > (electric-quote-replace-double-after-paren): New unit tests.
>
> Please add the log entries for the documentation here, when you push.
>

Pushed as d247e1d30a to master.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.