GNU bug report logs - #24676
25.1; `completion-pcm-all-completions' should not reverse order of candidates

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Wed, 12 Oct 2016 16:57:01 UTC

Severity: minor

Tags: fixed

Merged with 26313

Found in version 25.1

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

Message #11 received at 24676 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 24676 <at> debbugs.gnu.org
Subject: Re: bug#24676: 25.1;
 `completion-pcm-all-completions' should not reverse order of
 candidates
Date: Mon, 17 Oct 2016 12:29:50 -0400

> Because of this part, at the end of the function,
> `completion-pcm-all-completions' reverses the order of the candidates.

completion-pcm-all-completions doesn't have any such code.
After searching a bit I decided you meant completion-pcm--all-completions.

> (let ((poss ()))
>   (dolist (c compl)
>     (when (string-match-p regex c) (push c poss)))
>   (nreverse poss))

Looks good, please install,


        Stefan
This bug report was last modified 8 years and 28 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.