From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 12:56:52 2016 Received: (at submit) by debbugs.gnu.org; 12 Oct 2016 16:56:52 +0000 Received: from localhost ([127.0.0.1]:53264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buMpn-0003nl-UJ for submit@debbugs.gnu.org; Wed, 12 Oct 2016 12:56:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buMpm-0003nZ-2Z for submit@debbugs.gnu.org; Wed, 12 Oct 2016 12:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buMpf-0002Rz-Pb for submit@debbugs.gnu.org; Wed, 12 Oct 2016 12:56:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMpf-0002Rk-IY for submit@debbugs.gnu.org; Wed, 12 Oct 2016 12:56:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMpb-0006b4-Vr for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 12:56:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buMpX-0002ME-3z for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 12:56:39 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMpW-0002LG-QW for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 12:56:35 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9CGuXUX013690 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Oct 2016 16:56:33 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u9CGuXJL017448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Oct 2016 16:56:33 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u9CGuXvp018993 for ; Wed, 12 Oct 2016 16:56:33 GMT MIME-Version: 1.0 Message-ID: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> Date: Wed, 12 Oct 2016 09:56:32 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.1; `completion-pcm-all-completions' should not reverse order of candidates X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Because of this part, at the end of the function, `completion-pcm-all-completions' reverses the order of the candidates. (let ((poss ())) (dolist (c compl) (when (string-match-p regex c) (push c poss))) ; <=3D=3D=3D=3D reverses poss) It should not do this. Users should be able to depend on whatever order the candidates are already in (as returned by `all-completions'). For example, for buffer candidates, the default order from `all-completions' is last-display-time order. The fix is trivial: (let ((poss ())) (dolist (c compl) (when (string-match-p regex c) (push c poss))) (nreverse poss)) In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --without-compress-install CFLAGS=3D-static' From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 04:20:35 2016 Received: (at 24676) by debbugs.gnu.org; 17 Oct 2016 08:20:35 +0000 Received: from localhost ([127.0.0.1]:36016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bw39v-0008CN-HW for submit@debbugs.gnu.org; Mon, 17 Oct 2016 04:20:35 -0400 Received: from mout.web.de ([217.72.192.78]:50222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bw39t-0008CA-Kt for 24676@debbugs.gnu.org; Mon, 17 Oct 2016 04:20:34 -0400 Received: from drachen.dragon ([90.186.3.40]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MYeys-1cRWJp381i-00VORK; Mon, 17 Oct 2016 10:20:24 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#24676: 25.1; `completion-pcm-all-completions' should not reverse order of candidates References: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> Date: Mon, 17 Oct 2016 10:19:54 +0200 In-Reply-To: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> (Drew Adams's message of "Wed, 12 Oct 2016 09:56:32 -0700 (PDT)") Message-ID: <8737jvjsk5.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:wUEn5PcXUZfL5yghuld9Nop2ib9rnHlCyxnkjT4z/8z3r4fimq2 gfLqmaYseHpbYK61ijr5Z6jB1AJj4iPnNHmy0TI6RviN2LJBqUdaT7wE4r8zPo9QCjLdxOM 37KRRSZLL4gRe+Fay6pRr4Ly0D0ROakbbB89fq+a+sXfAn0a8L3QmgKYoQ8lpjUVFxqL+zR 2TYD+86X4v1f+x7LCQXEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wZ2LbWLqs38=:WJDOiaibcXb+0GwmTKyLmW Wi4WIyv8JCtMn+Kjr0rZkwtjYeKqFfeEJUjcjGP2jWbYxlLlGCvKHJNalVDYRqH7Qz+qwDf0X KQvNXia/81GkBjxrBlSr2SaUVTGxAgAJdiLk/EMzdZedGDyyqXTzGmCZsOC7b0kNbOkBIZPes +ZTJPmb6ooiqvCBRkRCedwgEyCFWWftLqJ2Hj9HPIbFbH3T1r5L8LliDHUFtuiW+0IOMN1e1k kzxBPLdnR6GW9MhCSXShwHyFPvc5lWKF10cbA0nb7dMubsDMRMksVeNFo2qjTiswtTBG+RnYe lXOCQs10FxSS/cTJd1FKUl0D5Bk/L7I5cJmEjRIbALkC90VXuNjUlbkHRDXrGwRxi4KB1Xqpx g7l2NjLUUKaWu19IQ59AHAVjisVrYRhsTq5j+fo5W317gALo/qpVPSCoPwa4sNLTexmrIqZDQ hRYu1lk1UtJuBeLizZdsHtX0NA6nH2WkhpB05dZNVGh3gkdyT+B6dpi4G8198LBoT5pyPzybF Yage8pS5MqAzLG9KzQIqb4Hup8mCskcKMyCuaxoEYFQ9sPhiBqGdMyetoVB+qtLIkcUB9ErhT gQC6qIci/qgVG/PaWzcjEDxxfyKFrRe3snDAQU6L1YZZw55kEis12NuDIa0KLswVxiAca9bz3 /F09ByZ0pfUYqASvkycDWyPI3GiSvWO3OkR29quxlf+6j+Gl9AMIalbAPQWrFtG7OVUUNQ1r4 w56gVArB/s3Q2QwgVTBi4s7IpW3ZiLGKxzoM3KTE5nz5giRwsj/wuLuZNBK6qR4mkQssVPzWj P1unUfu X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 24676 Cc: 24676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, > Because of this part, at the end of the function, > `completion-pcm-all-completions' reverses the order of the candidates. > > (let ((poss ())) > (dolist (c compl) > (when (string-match-p regex c) (push c poss))) ; <==== reverses > poss) > > It should not do this. Users should be able to depend on whatever order > the candidates are already in (as returned by `all-completions'). > > For example, for buffer candidates, the default order from > `all-completions' is last-display-time order. > > The fix is trivial: > > (let ((poss ())) > (dolist (c compl) > (when (string-match-p regex c) (push c poss))) > (nreverse poss)) Ah, this is the reason for the candidate list reversion I see. Yes, this should IMO not happen. Stefan, if you get the time, can you please have a look at whether the suggested fix looks ok to you, and commit it if applicable? Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 12:31:32 2016 Received: (at 24676) by debbugs.gnu.org; 17 Oct 2016 16:31:32 +0000 Received: from localhost ([127.0.0.1]:36978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwAp1-0007Za-UF for submit@debbugs.gnu.org; Mon, 17 Oct 2016 12:31:32 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwAp0-0007ZO-D5 for 24676@debbugs.gnu.org; Mon, 17 Oct 2016 12:31:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0ADBQALW9BX/3zt92hdGgEBAQECAQEBAYMtAQEBAQEehE23SYYWBAICgWk8EQECAQEBAQEBAV4nhGIBAQMBViMFCws0EhQYDSSIVQi8VQEBAQEGAiWKfYocAQSZWYkkh3EBFYRegwSGC4J2jVU0IIMbgVEghgoBAQE X-IPAS-Result: A0ADBQALW9BX/3zt92hdGgEBAQECAQEBAYMtAQEBAQEehE23SYYWBAICgWk8EQECAQEBAQEBAV4nhGIBAQMBViMFCws0EhQYDSSIVQi8VQEBAQEGAiWKfYocAQSZWYkkh3EBFYRegwSGC4J2jVU0IIMbgVEghgoBAQE X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="276177695" Received: from 104-247-237-124.cpe.teksavvy.com (HELO pastel.home) ([104.247.237.124]) by smtp.teksavvy.com with ESMTP; 17 Oct 2016 12:31:23 -0400 Received: by pastel.home (Postfix, from userid 20848) id 3C241653D2; Mon, 17 Oct 2016 12:29:50 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#24676: 25.1; `completion-pcm-all-completions' should not reverse order of candidates Message-ID: References: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> Date: Mon, 17 Oct 2016 12:29:50 -0400 In-Reply-To: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> (Drew Adams's message of "Wed, 12 Oct 2016 09:56:32 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 24676 Cc: 24676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Because of this part, at the end of the function, > `completion-pcm-all-completions' reverses the order of the candidates. completion-pcm-all-completions doesn't have any such code. After searching a bit I decided you meant completion-pcm--all-completions. > (let ((poss ())) > (dolist (c compl) > (when (string-match-p regex c) (push c poss))) > (nreverse poss)) Looks good, please install, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 04:11:56 2016 Received: (at 24676) by debbugs.gnu.org; 18 Oct 2016 08:11:56 +0000 Received: from localhost ([127.0.0.1]:37500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwPV6-0006Nx-KM for submit@debbugs.gnu.org; Tue, 18 Oct 2016 04:11:56 -0400 Received: from mout.web.de ([212.227.17.12]:62885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwPV5-0006Nk-8p for 24676@debbugs.gnu.org; Tue, 18 Oct 2016 04:11:55 -0400 Received: from drachen.dragon ([90.186.1.90]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0LgYOH-1chJcX34BJ-00o1ZO; Tue, 18 Oct 2016 10:11:41 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#24676: 25.1; `completion-pcm-all-completions' should not reverse order of candidates References: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> Date: Tue, 18 Oct 2016 10:11:38 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 17 Oct 2016 12:29:50 -0400") Message-ID: <871szers91.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:pTlIYb8+G4jD0kGxP9KyGYBE4llOcN2pb8KfAnukaUbsl8QoSM4 judgMQ1BUSdy3UvF+Ghql3T98N1giCPWsF1pSw+NyatOEnQ1sdIGRFqqUzWWvyLvV8ZWqVl KZ6DGttSsG/RkWwNztBc2al822TtGnHshAha7TKHixIFygExKsrRvHylqlHuVEdSkpYcveu KL5kE4wxsQMyTITvbHcvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:P4fUaLa1e+4=:j1GqRLKCux0VNamk9ByVRT OS+WWsvUeg0kGhBYF7bAj/0gG0kaocF54tHZejYgcE1y/TMgdo7BIdSb1xPt3y6St/3wiBXpH s9ewa9P5sqdMf5hJRhutVIUIBIW1mx0rYOTyMMorJSkqVE9cOOZOjIbe+Kr6RqC5ikiz0/Seq jSHbTKcH84RhofHXxfoxfE14WSGrpFKGmbpj5qEw9ioBNVnvtP7HHbPQ90MITrgPntInSrl/4 w0gO4+8t366nPyT8kxeMOSydMtO8OD6yuDPxevXX8UDT4uSR9SSTgEaPwAISsgyQ45yDDUICm Ysqh1i1Pb5EdDjqfkJmKyXM0Y2tGUm+3dN1HfmliVF+HiF5QCvJ1rmkaSzrqZ/dmLFVwIdeXI ysd2Bo2ulnxk9pnkFLOket1+ej3XykIq876S1bu76Pbe+v7CxPZMtl3EvaUIGzEvvWPy38gRy 4qfFhc8K8g9qLMvfvqHSbqephvg06DfORZ6npGVFUKxoiYZ8zIb1XDdKwYEeCjoEq3wL7ZAux 3aArU+2B5AIj3UMLNtmFcrb9iQaV8rbWP+WvwxII5mN/y79o8O0qaBPerneo1h4kvH7sEIaaw wJA0SktkpGC/gJCrdvCqVURSELc4dm+TorR6dHKtZKuy1OZhzHWNSUJlG9rXy6PlhTWIoPeEG JJPyUpnl3+dpecdGLoewFTBaBu0vIxkkIFV4edwQ2GZmQLESj5Dz0uJ9Zf0E9SVqgd2u1QkK3 h+NWBnT3zbkC6ne6PzgRP2+AcfNgrmaD53d7D+5WsJYqcZYb6akbHhj+Oipk7/dE6kVy7K7xK uSdn3u91I3gN0r1WVUNetjj+a062A== X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 24676 Cc: 24676@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > completion-pcm-all-completions doesn't have any such code. After > searching a bit I decided you meant completion-pcm--all-completions. Oh yes, I found that too, but forgot to mention. > > > (let ((poss ())) > > (dolist (c compl) > > (when (string-match-p regex c) (push c poss))) > > (nreverse poss)) > > Looks good, please install, This doesn't seem to meet any of the criteria in http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00007.html so I think I'll have to commit to master. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 09:56:47 2016 Received: (at 24676) by debbugs.gnu.org; 18 Oct 2016 13:56:47 +0000 Received: from localhost ([127.0.0.1]:38194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwUsp-00017y-8l for submit@debbugs.gnu.org; Tue, 18 Oct 2016 09:56:47 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwUsn-00017l-SH for 24676@debbugs.gnu.org; Tue, 18 Oct 2016 09:56:46 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9IDudZV003322 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Oct 2016 13:56:40 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id u9IDucjM023142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Oct 2016 13:56:39 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u9IDuZXP022901; Tue, 18 Oct 2016 13:56:36 GMT MIME-Version: 1.0 Message-ID: <06e9ce6f-685c-475b-a431-c6d902d6b74d@default> Date: Tue, 18 Oct 2016 06:56:34 -0700 (PDT) From: Drew Adams To: Michael Heerdegen , Stefan Monnier Subject: RE: bug#24676: 25.1; `completion-pcm-all-completions' should not reverse order of candidates References: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> <871szers91.fsf@web.de> In-Reply-To: <871szers91.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 24676 Cc: 24676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) > > > (let ((poss ())) > > > (dolist (c compl) > > > (when (string-match-p regex c) (push c poss))) > > > (nreverse poss)) > > > > Looks good, please install, >=20 > This doesn't seem to meet any of the criteria in > http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00007.html > so I think I'll have to commit to master. Thanks for fixing this, Michael. Unfortunately, there is no way for my code that compensates for this bug to= now know whether/when it has been fixed. No simple test such as `fboundp'= or an Emacs version. Of course, if you happened to decide to rename the function, there would be= no problem... And it's already a bit much that there is also a function `completion-pcm-a= ll-completions' that does not even call `completion-pcm--all-completions', = and that has a completely different signature. And the "internal" function= has a nice doc string, but the "external" one has no doc string... Perhaps you would consider taking this opportunity to find a better name fo= r this "internal" function? Especially since it is "internal", probably fe= w 3rd-party libraries would be affected by a name change. In my case, I would not be referencing this "internal" function at all, exc= ept that I needed to work around this bug. If you did choose to rename it,= I would not need to make any code changes, because I already protect this = change with `(when (fboundp 'completion-pcm--all-completions)...)'. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 10:22:54 2016 Received: (at 24676) by debbugs.gnu.org; 18 Oct 2016 14:22:54 +0000 Received: from localhost ([127.0.0.1]:38214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwVI6-0003Nu-DM for submit@debbugs.gnu.org; Tue, 18 Oct 2016 10:22:54 -0400 Received: from mout.web.de ([217.72.192.78]:49477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwVI1-0003Ne-53 for 24676@debbugs.gnu.org; Tue, 18 Oct 2016 10:22:52 -0400 Received: from drachen.dragon ([90.186.1.90]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0LilNJ-1cXEDH1ydp-00cxn5; Tue, 18 Oct 2016 16:22:34 +0200 From: Michael Heerdegen To: Drew Adams Subject: Re: bug#24676: 25.1; `completion-pcm-all-completions' should not reverse order of candidates References: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> <871szers91.fsf@web.de> <06e9ce6f-685c-475b-a431-c6d902d6b74d@default> Date: Tue, 18 Oct 2016 16:22:31 +0200 In-Reply-To: <06e9ce6f-685c-475b-a431-c6d902d6b74d@default> (Drew Adams's message of "Tue, 18 Oct 2016 06:56:34 -0700 (PDT)") Message-ID: <87bmyhvis8.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:gS8ccE9zNAWuhEhuMGx2vR+SC+MP3aMX0yZwF3a/n55xw7HIp2l GKJ9Bv/nqsEV1+JQRTkJMNU5mJhrPJmPZx5Or3jB6wLwbNaLNrzQj5q/wXL8wSIfn4SoFuJ EauzM+yUtNwEJNOoFP4ORW6V4lNNGImpESu2rEpIwKb/RM6+ra5hovvumIQMr3U3Dmt1NIo C38fvvhI/qNXBe3MeFDFw== X-UI-Out-Filterresults: notjunk:1;V01:K0:+f3C+1V0EI8=:YckiIu6ovnOJf8avHra+vX hUKQmr5HCTfYcDDJmgt0CV8Y+86rpTXrBJ4nYQyvKIAhH7xbM/f47CP3iujLJ+FxJvZffaI2j W5LktcsrBf9DrRRtX+4+24DDF3uJHaAPi7rKo2MBrl0le1DPnwibwYjBoLVG8VdOQ4+FmDfkK r8/cku7Jjy5Bh5X6+0pKvD0JNry0TI1srC5qO/R3cW2hssuXzMJe6n569uyhWtyEIZVVoXA2w CFU0zx/hOJVqg62BjhwQvhd7e0HBRJp8UhSnpbUZsQkGP1uRi2te5GxAERWvQtbXhx5DUEj0R a0feIBAOtTs7nXi0AVAVLhEfjevSUTEg6LPer/W/kTyVXD/l+tcjyD9KDm6aaXWj3qAdOi1Xf aDtfTLI6wtgKHL0/NkeQQZL9HXrgr2YYpUfiUEir0LPiUcFVSXKTDNBOj1XjVY7hyS848r95R ghBSoKM8FWBr0u1fWy+8eMjmK0TvxpJ7+e9X7B6asQwS6QkPx6EClHYol+h2j1qJAGQKc9I6I xOHlBUM+KWE3QQTyA/KwZVHxv7VUunfdboDPVQ6ihe64PRgIwZzjd5AFAPDIz7zIYZlS6x9AG fHgwL+x9ugFWW17Q8IVT2JmX9BBvOCBQgbS8T70+cCl7wPGhZ6CnnbIPC4qjA/RVLWQmzDUPn fHgNEczu1jaJ1ZDm898GGQn1ar5bZQ3KAbzPlacotkQYmRMSqzyxT1qsaKlCLfUiQgd6pSjnV 1Q9zkSfeg/HRhjj1T+MaHXEpfbwpOE6rDehj510WwRv4zHcUpek40bMKPeWoPNKBQDLti/B3Y n8B8cJyrk0KezvU+yuhcT1M3swubA== X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 24676 Cc: 24676@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > Unfortunately, there is no way for my code that compensates for this > bug to now know whether/when it has been fixed. No simple test such > as `fboundp' or an Emacs version. > > Of course, if you happened to decide to rename the function, there > would be no problem... Hmm, that sounds reasonable. If nobody objects, I can do that, sure. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 30 15:03:18 2017 Received: (at control) by debbugs.gnu.org; 30 Mar 2017 19:03:18 +0000 Received: from localhost ([127.0.0.1]:53199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctfLq-0002kd-1p for submit@debbugs.gnu.org; Thu, 30 Mar 2017 15:03:18 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:35166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctfLo-0002kI-9v for control@debbugs.gnu.org; Thu, 30 Mar 2017 15:03:16 -0400 Received: by mail-oi0-f44.google.com with SMTP id f193so40474782oib.2 for ; Thu, 30 Mar 2017 12:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xAPk2e0zJYFafNMdWXAFSW7dfdXcLJLmZDtDpexxNcY=; b=Fb8J02LA8A7bpKQVqiQHj/AOUdX+/ndxi4rY/GbYasSLsWF7Vlv2xfWeiNwN2+emNs L1cOKSFNAS5HQAjvsRVFzWXGHj+DL9DjL3pX/w29ZtY5JSR25D43fV/jiQpFllYIpL3L RvSZWb2RDp7OqmZNMbAHNOIIEncFYtUqmuQZR3S1FHSPcGpJzQCsY/GdmBAr3+ccyEv7 Q/5jXGy9VJ+u0LP6i6UWT2dsCN6aIOL28VUnOY9Vaz9ysb5/Lw9eiNvbQLJJyte+7woe JjNLfeGsLucKyjch4lKYYTHbU3FOVl8hykKjLhZevAJDAsuQ4AqsoMRJ40M7xvga4jfJ Q/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=xAPk2e0zJYFafNMdWXAFSW7dfdXcLJLmZDtDpexxNcY=; b=hW3KvDKX3fuSh7IB6Utl2TyNHrs33GWVZz94xwWTqFrcKxvKiFUVuinZCW84mZgiSy ep5Ame2R6Rq1cNRSGBkSPw+HIS74sBKnjHPq7X1sHGYX60Qhv7UtYS1lAHeAL3cw7apm mUQ52Rb733+QsB/90NFw6EthjN6xnhTZ08V/d4RpuM4IQmgrtq/HCtmAlc1/C/a7hBeT uBDG7C019wzdcRVcLXsXXgGxY88T/U+D13bYJYqYDtYGy/vhrsus3PPlAqgn+RZfQOd+ nqlnBxgRy/obCD+krDnuqgIURewg0qV3a3zR3TwZWDzN5L+XV7bQLdqQDEVyiznHX+Xl tyMA== X-Gm-Message-State: AFeK/H0jK2WDfzFAIMYaKEPIU5AzoLz7VhsDMF9Tz7p2qDs3lz3mlViJ8LaWwgg7oY4z6JWl9TsDWqrG5VFN9A== X-Received: by 10.157.1.22 with SMTP id 22mr864722otu.221.1490900590349; Thu, 30 Mar 2017 12:03:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.80.133 with HTTP; Thu, 30 Mar 2017 12:03:09 -0700 (PDT) In-Reply-To: <87lgrm7gvs.fsf@kyleam.com> References: <87lgrm7gvs.fsf@kyleam.com> From: Noam Postavsky Date: Thu, 30 Mar 2017 15:03:09 -0400 X-Google-Sender-Auth: MuAMoAOiuG239FM9y7goUKE4UkQ Message-ID: Subject: Re: bug#26313: 25.1; completion: display-sort-function=identity shows reverse To: Kyle Meyer Content-Type: text/plain; charset=UTF-8 Bcc: control@debbugs.gnu.org X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control Cc: 26313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) forcemerge 24676 26313 quit On Thu, Mar 30, 2017 at 2:34 PM, Kyle Meyer wrote: > > Should completion-pcm--all-completions reverse the list before returning > it? Yeah, it was suggested and approved in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24676#11, but never installed. Also related, completion-pcm--filename-try-filter has the same problem: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25995#8 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 22:49:17 2017 Received: (at control) by debbugs.gnu.org; 21 Jun 2017 02:49:17 +0000 Received: from localhost ([127.0.0.1]:58701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNVhk-00023m-PC for submit@debbugs.gnu.org; Tue, 20 Jun 2017 22:49:16 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:33915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNVhj-00023W-SC; Tue, 20 Jun 2017 22:49:16 -0400 Received: by mail-it0-f68.google.com with SMTP id y134so4998166itc.1; Tue, 20 Jun 2017 19:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T7vsp+GuE9Sag+GMCNtjZksZhddx6CLBwWb2kDQMm+0=; b=JWR3KnjgP9mtoImX4AggJbXa4RN9npklh7pEbtBPoKg7I0o6mikhgRRKmZMPu64bZb njYremh6zXZHLRt4HMq8p8p6xV1YGwPj0kvtZazTOYnxwkk1NQfbQojfYuOukX4DT+vP /aww64j9hOFq97rGPB3PhaYPR8RTuhHYHW+l3u3NnFWeA+gsg2uNKjzl6u6HxB+GZxC/ D3wjzvKI6LyQ+f6zQKPZFaK/gLn9E5uPyu0vS5cNNqW89VxaajGkAbR3+G1qdxnkhGGf BEX2AUwypLC25CppBgsofhzjXsPMO5zEc5aOwPbOFYLZ16l4qrypqLUigUuoF8Sn+pNU K3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=T7vsp+GuE9Sag+GMCNtjZksZhddx6CLBwWb2kDQMm+0=; b=X6wCj9fXCUmNsALErtlkWXV3URBVRiJhLURIJXwSTP4VmXpSk3OqCaHlbLX5BVqGJz l4t1tSThdmlbBo0f9cEtIHw3xdpdNHg/AqX0nXEpPAgmmnkUuZzvqZ5t9DacY8atYBVH xPiivsoJQpkRh9GLsbAJrbszf1GT/Ly2M7fMsSV5NaEqPc9b90bh3zK0DuakKhJNPorD 0fRxpgp3a1yC7zghZrLVBFhLHduFjkDATuv736M0QVHSfeCMR5Rbcon2QzgbryKQYJrK 0Vxo30Tj+1OM3umRk+WZxklWN9xcbEsns9GpswyvKm7DMiykiKvRCtYoK+aPZ524tqRg u//A== X-Gm-Message-State: AKS2vOwBAcyBO3y7Bpu5GKurQshhlwJpyAEJQD/ne26/K3K6Py0tQFuh RIvhkUJgZa8evVdr X-Received: by 10.36.121.216 with SMTP id z207mr6523114itc.86.1498013350049; Tue, 20 Jun 2017 19:49:10 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 86sm318298ioj.8.2017.06.20.19.49.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Jun 2017 19:49:09 -0700 (PDT) From: npostavs@users.sourceforge.net To: Dmitry Gutov Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> <87injsr6yz.fsf@users.sourceforge.net> Date: Tue, 20 Jun 2017 22:50:45 -0400 In-Reply-To: (Dmitry Gutov's message of "Wed, 21 Jun 2017 05:04:51 +0300") Message-ID: <87d19yqcje.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 25995@debbugs.gnu.org, Alexis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 25995 fixed close 25995 26.1 tags 24676 fixed close 24676 26.1 quit Dmitry Gutov writes: > When running it interactively, however (M-x eval-buffer, also starting > with 'emacs -Q'), I'm getting consistently opposite results: Ah, you're measuring interpreted code which will penalize the open-coded loop more than the `cl-delete-if' call which has the loop tucked away (and compiled). > In any case, nreverse barely affects the runtime, so please go ahead > and push the patch. Thanks! Pushed to master [1: 1ed2086a03], also fixes the same issue for `completion-pcm--all-completions' (Bug#24676). [1: 1ed2086a03]: 2017-06-20 22:44:24 -0400 Keep order of completion candidates (Bug#25995, Bug#24676) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ed2086a03a5f33482d2f184e57dad9e6a9d25d8 From unknown Sun Jun 22 11:38:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Jul 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator