From unknown Sat Aug 09 20:50:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24675 <24675@debbugs.gnu.org> To: bug#24675 <24675@debbugs.gnu.org> Subject: Status: 26.0.50; Misleading suggestion in Ediff Info manual Reply-To: bug#24675 <24675@debbugs.gnu.org> Date: Sun, 10 Aug 2025 03:50:22 +0000 retitle 24675 26.0.50; Misleading suggestion in Ediff Info manual reassign 24675 emacs submitter 24675 Philipp Stephani severity 24675 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 11:55:12 2016 Received: (at submit) by debbugs.gnu.org; 12 Oct 2016 15:55:12 +0000 Received: from localhost ([127.0.0.1]:53215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buLs8-0000bK-1Y for submit@debbugs.gnu.org; Wed, 12 Oct 2016 11:55:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buLs6-0000b8-Fl for submit@debbugs.gnu.org; Wed, 12 Oct 2016 11:55:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buLs0-0006HU-2Q for submit@debbugs.gnu.org; Wed, 12 Oct 2016 11:55:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buLrz-0006HH-VP for submit@debbugs.gnu.org; Wed, 12 Oct 2016 11:55:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buLrx-0003sB-E9 for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 11:55:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buLrv-0006GX-7c for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 11:55:00 -0400 Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:35547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buLru-0006GM-RK for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2016 11:54:59 -0400 Received: by mail-lf0-x22f.google.com with SMTP id l131so48126982lfl.2 for ; Wed, 12 Oct 2016 08:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=HWzB+UWxGVlOw5Lb5rc9ZfWysER6sHL2gnMWGNf79ko=; b=adHchZD3gZNuvSP2JPk2cbTSQGKnpFRC+F3YAQJrGXmg5j2ERcMKKY8qP55dEI2ZuN oQlRTWjjWxi6C533o7oOjxNobVorZ2v2OdUyzJwutNjMCuDx/osJG0ACnGtVwi0Pa1C0 rVVd6gBtV3zZ1poCNO/ePCsuprPqYjzdER0vUmYQzmKxs9rYorW0+VZiciwhXaKrpvYH CsDb05R8pcwU1WIqTkvvAZRrBkLpJCwRi2SlHtPUnIwudSb23jnE9gWQfb9Q6e2XnK4v k8rhImjXvB2Pl8Bk6oR9sb7QN2esxPo8lv1ARBKiCUMWG1GI6GTiVqVZnEnUwpLYIuUv EQFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=HWzB+UWxGVlOw5Lb5rc9ZfWysER6sHL2gnMWGNf79ko=; b=NWg1Gvu34RBmSzFWyvsWE/uYt/GkGOjBus4y8qt7rIeJBzwl2XfvYK2iQIBpaf896U MB6LxdSK/OFYHw4FaOT5ukh1dGPMCGK02KB2IGLqmoa9D7lMkdMqNuQQ3Jb+a1dVY0jL hqdHEJ0/1Z2x+ICBhH7EzravtxDMQ5f/bdTqooUYK4h/hRuxbHi4IQE4W7EZDyNFNI76 7sdE8PIMi61jA8dcnQcvykJT74LhpWrTJyqVB9RHyFf5zt38sk2OfY4ktXJao4o9UwXD cFlpYeDToluSfr6HnNQTC4qopodz5IhlasTxS16zPntiy3sM8IhbZkS4knnZQxMZotAq ChfA== X-Gm-Message-State: AA6/9RnJ4wjbiDNVIDa6l2Uxoazw7YepWpcy7708EdmjFRGa6G2YKbcobsLv6/gvxolfmg== X-Received: by 10.194.147.67 with SMTP id ti3mr2493310wjb.17.1476287696810; Wed, 12 Oct 2016 08:54:56 -0700 (PDT) Received: from a.muc.corp.google.com ([2a00:79e0:15:4:1c5e:200a:2c1a:23d]) by smtp.gmail.com with ESMTPSA id q8sm13913543wjj.7.2016.10.12.08.54.55 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 12 Oct 2016 08:54:56 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Misleading suggestion in Ediff Info manual Date: Wed, 12 Oct 2016 17:54:50 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) The Ediff Info manual, in section 7.1 "Hooks", says: =E2=80=98ediff-cleanup-hook=E2=80=99 This hook is run just before =E2=80=98ediff-quit-hook=E2=80=99. This = is a good place to do various cleanups, such as deleting the variant buffers. Ediff provides a function, =E2=80=98ediff-janitor=E2=80=99, as one suc= h possible hook, which you can add to =E2=80=98ediff-cleanup-hook=E2=80=99 with = =E2=80=98add-hook=E2=80=99. However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a function taking two required arguments, so it cannot be added to ediff-cleanup-hook. The manual should e.g. state that a lambda wrapping ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janitor itself. In GNU Emacs 26.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2016-10-12 built on localhost Repository revision: 59c5f36acfcbec4f6119996f7b80383bf86125d4 Windowing system distributor 'The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Composing main Info directory...done Mark saved where search started Quit Loading ediff-util...done Type C-x 1 to delete the help window. Entering debugger... Back to top level Configured using: 'configure --with-modules --enable-checking --enable-check-lisp-object-type' Configured features: XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils debug ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util cl-extra thingatpt help-fns radix-tree help-mode cl-loaddefs pcase cl-lib misearch multi-isearch info easymenu time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 112819 5354) (symbols 48 21981 0) (miscs 40 371 351) (strings 32 23152 4562) (string-bytes 1 795806) (vectors 16 16192) (vector-slots 8 479526 4745) (floats 8 200 219) (intervals 56 748 1479) (buffers 976 15) (heap 1024 23921 1152)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3= =B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do = not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 13:03:45 2016 Received: (at 24675) by debbugs.gnu.org; 13 Dec 2016 18:03:45 +0000 Received: from localhost ([127.0.0.1]:40979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGrQX-0002cZ-8p for submit@debbugs.gnu.org; Tue, 13 Dec 2016 13:03:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGrQV-0002cN-2o for 24675@debbugs.gnu.org; Tue, 13 Dec 2016 13:03:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGrQP-0001bZ-AR for 24675@debbugs.gnu.org; Tue, 13 Dec 2016 13:03:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGrQL-0001ab-VR; Tue, 13 Dec 2016 13:03:33 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cGrQK-0000GC-B1; Tue, 13 Dec 2016 13:03:32 -0500 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#24675: 26.0.50; Misleading suggestion in Ediff Info manual References: X-Spook: jihad Reynosa illuminati Plague Europol Tornado condor X-Ran: c^9T]?x36o@7Io1z.(*+-ZVs|zAk#V747&uU$:E+ov'}IowKz)I}N;xY"\shMQOn.$t))+ X-Hue: yellow X-Attribution: GM Date: Tue, 13 Dec 2016 13:03:32 -0500 In-Reply-To: (Philipp Stephani's message of "Wed, 12 Oct 2016 17:54:50 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-Debbugs-Envelope-To: 24675 Cc: 24675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) Philipp Stephani wrote: > The Ediff Info manual, in section 7.1 "Hooks", says: > > 'ediff-cleanup-hook' > This hook is run just before 'ediff-quit-hook'. This is a good > place to do various cleanups, such as deleting the variant buffers. > Ediff provides a function, 'ediff-janitor', as one such possible > hook, which you can add to 'ediff-cleanup-hook' with 'add-hook'. > > However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > function taking two required arguments, so it cannot be added to > ediff-cleanup-hook. The manual should e.g. state that a lambda wrapping > ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janitor > itself. It seems the doc hasn't been updated in the past 14 years. Before 50a07e1, there was a single optional argument. You might be one of the few users of this functionality, so maybe you would like to fix the doc yourself? (Making the arguments optional is an additional possibility?) Since the use of lambda for hooks is basic (eg documented in the "Hooks" section of the manual), personally I don't see a need to mention it here or in other places that refer to normal hook uses. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 16:26:01 2016 Received: (at 24675) by debbugs.gnu.org; 18 Dec 2016 21:26:01 +0000 Received: from localhost ([127.0.0.1]:46481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIiy1-0000Fb-6j for submit@debbugs.gnu.org; Sun, 18 Dec 2016 16:26:01 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIixx-0000FM-Ii for 24675@debbugs.gnu.org; Sun, 18 Dec 2016 16:25:58 -0500 Received: by mail-wm0-f48.google.com with SMTP id f82so85268410wmf.1 for <24675@debbugs.gnu.org>; Sun, 18 Dec 2016 13:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+SRu1GBZIp+/0b1CYeuBNrPHcjhqjxFcF3TGZV2mxHA=; b=Ik0bQUrqjBATBZAltwPVdzg7U/8B5BO5KB4f6OwerSDGzcG153YHJkvFRZpzvHO5JE fizlQIAIgVu4UHsghp9nrzfxPVHdqNMXOqTghX7AEmT8VD2BgdgAhJJd7MqJeASxoekc CBBE34aTxwYmaCPsZpGiL6a9GJGeOQJY3PEsWuUq0NwZx0RBMrwc9tkuM14GEhkz/Wyk FDLO4AReZnKc8MG0TPQz5qmDoUctI1v5bweVYlJs+rvW2uSEPRfbjcbrRfDuzrlmbq3M PTQQv1FxsMBg/qm7HHzh5kxkAIaaiyHWcqAL8xJis+jVo4CkLahkdYpeX4XsjYawLAl7 M0DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+SRu1GBZIp+/0b1CYeuBNrPHcjhqjxFcF3TGZV2mxHA=; b=UiZk3MnyelxBEXryXZR1saiBTskOoPJ02XZ5p81MOl3OPH4ZgPm8l3X6WFQN5mfkrn gMcMFwCYkgm88yr+JLkMmWkaxq2FnAswV/R+yDiWONblBSRNJSXBjZLgGL/8CCTSAk9l vqvumwosjAoRjQ2C68qOB3WjqBSssMqinh5SvyuTRss3OoRMUjZnnzGbeLDKRjzGO3x/ Tum3D+FyXaUZjPSQwz4wJaNa1AYD6AAAslrVQlsNPkOYePf83SbypGp4I+cDabQfRR03 +4qCaQ/gmh2y6l/xO7HNS1A82Hfjvzg2mAx5CEwfm4CPKwky8LShUyDfP65o/+idDetR gOfA== X-Gm-Message-State: AIkVDXKBFjKYEHrRdmS0aCQ0/N+sr52a3RVANDy6u2eVxvBBtgoIUAWX/gq5a84H0h96QyEeIRRR6eCJKj4H/A== X-Received: by 10.28.195.9 with SMTP id t9mr10242016wmf.92.1482096351902; Sun, 18 Dec 2016 13:25:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Sun, 18 Dec 2016 21:25:41 +0000 Message-ID: Subject: Re: bug#24675: 26.0.50; Misleading suggestion in Ediff Info manual To: Glenn Morris Content-Type: multipart/mixed; boundary=001a1148d9fe941fda0543f57229 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 24675 Cc: 24675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a1148d9fe941fda0543f57229 Content-Type: multipart/alternative; boundary=001a1148d9fe941fd50543f57227 --001a1148d9fe941fd50543f57227 Content-Type: text/plain; charset=UTF-8 Glenn Morris schrieb am Di., 13. Dez. 2016 um 19:03 Uhr: > Philipp Stephani wrote: > > > The Ediff Info manual, in section 7.1 "Hooks", says: > > > > 'ediff-cleanup-hook' > > This hook is run just before 'ediff-quit-hook'. This is a good > > place to do various cleanups, such as deleting the variant buffers. > > Ediff provides a function, 'ediff-janitor', as one such possible > > hook, which you can add to 'ediff-cleanup-hook' with 'add-hook'. > > > > However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > > function taking two required arguments, so it cannot be added to > > ediff-cleanup-hook. The manual should e.g. state that a lambda wrapping > > ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janitor > > itself. > > It seems the doc hasn't been updated in the past 14 years. > Before 50a07e1, there was a single optional argument. > You might be one of the few users of this functionality, so maybe you > would like to fix the doc yourself? I don't use it myself, but I got a report from a colleague who interpreted the manual such that you could add ediff-janitor directly to the hook with add-hook. I've attached a patch to clarify this. I'll push it to emacs-25 in a few days until there are complaints. --001a1148d9fe941fd50543f57227 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Di= ., 13. Dez. 2016 um 19:03=C2=A0Uhr:
Philipp Stephani wrote:

> The Ediff Info manual, in section 7.1 "Hooks", says:
>
> 'ediff-cleanup-hook'
>=C2=A0 =C2=A0 =C2=A0 This hook is run just before 'ediff-quit-hook&= #39;.=C2=A0 This is a good
>=C2=A0 =C2=A0 =C2=A0 place to do various cleanups, such as deleting the= variant buffers.
>=C2=A0 =C2=A0 =C2=A0 Ediff provides a function, 'ediff-janitor'= , as one such possible
>=C2=A0 =C2=A0 =C2=A0 hook, which you can add to 'ediff-cleanup-hook= ' with 'add-hook'.
>
> However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > function taking two required arguments, so it cannot be added to
> ediff-cleanup-hook.=C2=A0 The manual should e.g. state that a lambda w= rapping
> ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janito= r
> itself.

It seems the doc hasn't been updated in the past 14 years.
Before 50a07e1, there was a single optional argument.
You might be one of the few users of this functionality, so maybe you
would like to fix the doc yourself?

I don&= #39;t use it myself, but I got a report from a colleague who interpreted th= e manual such that you could add ediff-janitor directly to the hook with ad= d-hook. I've attached a patch to clarify this. I'll push it to emac= s-25 in a few days until there are complaints.=C2=A0
--001a1148d9fe941fd50543f57227-- --001a1148d9fe941fda0543f57229 Content-Type: text/plain; charset=US-ASCII; name="0001-Clarify-usage-of-ediff-cleanup-hook-Bug-24675.txt" Content-Disposition: attachment; filename="0001-Clarify-usage-of-ediff-cleanup-hook-Bug-24675.txt" Content-Transfer-Encoding: base64 Content-ID: <15913d2f37e8c9f7d301> X-Attachment-Id: 15913d2f37e8c9f7d301 RnJvbSAyODU1NmFiMTg3OWQ1NDUzNDM2M2Y1Y2I0Y2M5Njc4ZjAxNGVmY2M1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFN1biwgMTggRGVjIDIwMTYgMjI6MTg6MDEgKzAxMDAKU3ViamVjdDogW1BBVENIXSBDbGFy aWZ5IHVzYWdlIG9mICdlZGlmZi1jbGVhbnVwLWhvb2snIChCdWcjMjQ2NzUpCgoqIGRvYy9taXNj L2VkaWZmLnRleGkgKEhvb2tzKTogQ2xhcmlmeSB1c2FnZSBvZiAnZWRpZmYtY2xlYW51cC1ob29r JwotLS0KIGRvYy9taXNjL2VkaWZmLnRleGkgfCAxMSArKysrKysrKy0tLQogMSBmaWxlIGNoYW5n ZWQsIDggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbWlz Yy9lZGlmZi50ZXhpIGIvZG9jL21pc2MvZWRpZmYudGV4aQppbmRleCAzNzZhYWVlLi44OTZhNjA0 IDEwMDY0NAotLS0gYS9kb2MvbWlzYy9lZGlmZi50ZXhpCisrKyBiL2RvYy9taXNjL2VkaWZmLnRl eGkKQEAgLTEyNDcsOSArMTI0NywxNCBAQCBIb29rcwogQHZpbmRleCBlZGlmZi1jbGVhbnVwLWhv b2sKIFRoaXMgaG9vayBpcyBydW4ganVzdCBiZWZvcmUgQGNvZGV7ZWRpZmYtcXVpdC1ob29rfS4g IFRoaXMgaXMgYSBnb29kCiBwbGFjZSB0byBkbyB2YXJpb3VzIGNsZWFudXBzLCBzdWNoIGFzIGRl bGV0aW5nIHRoZSB2YXJpYW50IGJ1ZmZlcnMuCi1FZGlmZiBwcm92aWRlcyBhIGZ1bmN0aW9uLCBA Y29kZXtlZGlmZi1qYW5pdG9yfSwgYXMgb25lIHN1Y2ggcG9zc2libGUKLWhvb2ssIHdoaWNoIHlv dSBjYW4gYWRkIHRvIEBjb2Rle2VkaWZmLWNsZWFudXAtaG9va30gd2l0aAotQGNvZGV7YWRkLWhv b2t9LgorRWRpZmYgcHJvdmlkZXMgYSBoZWxwZXIgZnVuY3Rpb24sIEBjb2Rle2VkaWZmLWphbml0 b3J9LCB0aGF0IHlvdSBjYW4KK2ludm9rZSBmcm9tIGEgcHJpdmF0ZSBob29rIGZ1bmN0aW9uLiAg Rm9yIGV4YW1wbGU6CisKK0BleGFtcGxlCisoZGVmdW4gbXktZWRpZmYtamFuaXRvciAoKQorICAo ZWRpZmYtamFuaXRvciBuaWwgbmlsKSkKKyhhZGQtaG9vayAnZWRpZmYtY2xlYW51cC1ob29rICMn bXktZWRpZmYtamFuaXRvcikKK0BlbmQgZXhhbXBsZQogCiBAZmluZGV4IGVkaWZmLWphbml0b3IK IFRoaXMgZnVuY3Rpb24ga2lsbHMgYnVmZmVycyBBLCBCLCBhbmQsIHBvc3NpYmx5LCBDLCBpZiB0 aGVzZSBidWZmZXJzIGFyZW4ndAotLSAKMi4xMC4yCgo= --001a1148d9fe941fda0543f57229-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 23 13:30:24 2016 Received: (at 24675-done) by debbugs.gnu.org; 23 Dec 2016 18:30:24 +0000 Received: from localhost ([127.0.0.1]:52952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKUbo-0007mA-04 for submit@debbugs.gnu.org; Fri, 23 Dec 2016 13:30:24 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKUbn-0007ly-0K for 24675-done@debbugs.gnu.org; Fri, 23 Dec 2016 13:30:23 -0500 Received: by mail-wm0-f47.google.com with SMTP id k184so23069429wme.1 for <24675-done@debbugs.gnu.org>; Fri, 23 Dec 2016 10:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=GotiVBhhp9gD0l5ar3CdFcSRh0RW7b6q4DYgooncxsw=; b=i+aoCMfM2FTMyG+VVo/11H4kvopKiIRw7hAaU3GoqJrYTYbp8u/a75kri9UB5nz87W TARY5aZJ5oupYQ4w5h+Yv7xFymnh1jNCHe2LnOwwKeV00xDNS4++vgwohzJQvytYlU3O BnbKXtM+jioQMGScfFrXMB7yr/YX8JieNa/b41VE/tQbtY5OUsmAD/ZWD8I+V0jCV8qt ufSSDoOH4aCpL6cf27G3/ghxe+YSdzKkjdvcz13XGCtORARXtm8kJh71/7eoB8oe7vzG 1PcQD9ISU6cfvzp07Yhiasurx8E2Z0+yeqAwIXqjYVuDH+y7dcYfl5PXwciaFa9hXopq p3Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GotiVBhhp9gD0l5ar3CdFcSRh0RW7b6q4DYgooncxsw=; b=gfRKPWIoGctfNeDEuQNypDcyHOC8q72ArJqsA04aXoBvzX+X+mo7LVfJigaTrMUUl0 jc/G0sAEom7TiSrMLBPAjBTGGJrijS+9Vu7m2zyRaHAKy9QHJl9a9zbG1QeqDgE9ImB2 /9XnA50trXRgIOQiYR4hKVytXwAqqeqAKQMHhiO2+fAor84yERPfNeLRQ67gjiFt8OAu 3hylFaVksEnOpmgHUDpDXrPj+F8I963JI7Cnr2t+u+UEaHXR8jSGtpi+V6oQZoZu/Oc1 7dmLA0Go4nqEC3q4lo6n1sdx2T85xV+K/VbSHMp+sGh+qU0LZjcwnE+MCrbIoe25NaMV +yLQ== X-Gm-Message-State: AIkVDXKN0zBG9ktBLAdH2NXa6/qD5MXpao7fuHY0ur7pkwENyd54ThTtIlJQXzwcXSPlrvWeBHaYKUFVTIQi6Q== X-Received: by 10.28.195.9 with SMTP id t9mr14069695wmf.92.1482517817290; Fri, 23 Dec 2016 10:30:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Fri, 23 Dec 2016 18:30:06 +0000 Message-ID: Subject: Re: bug#24675: 26.0.50; Misleading suggestion in Ediff Info manual To: Glenn Morris , 24675-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary=001a1148d9fedf75af0544579359 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 24675-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a1148d9fedf75af0544579359 Content-Type: text/plain; charset=UTF-8 Philipp Stephani schrieb am So., 18. Dez. 2016 um 22:25 Uhr: > Glenn Morris schrieb am Di., 13. Dez. 2016 um 19:03 Uhr: > > Philipp Stephani wrote: > > > The Ediff Info manual, in section 7.1 "Hooks", says: > > > > 'ediff-cleanup-hook' > > This hook is run just before 'ediff-quit-hook'. This is a good > > place to do various cleanups, such as deleting the variant buffers. > > Ediff provides a function, 'ediff-janitor', as one such possible > > hook, which you can add to 'ediff-cleanup-hook' with 'add-hook'. > > > > However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > > function taking two required arguments, so it cannot be added to > > ediff-cleanup-hook. The manual should e.g. state that a lambda wrapping > > ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janitor > > itself. > > It seems the doc hasn't been updated in the past 14 years. > Before 50a07e1, there was a single optional argument. > You might be one of the few users of this functionality, so maybe you > would like to fix the doc yourself? > > > I don't use it myself, but I got a report from a colleague who interpreted > the manual such that you could add ediff-janitor directly to the hook with > add-hook. I've attached a patch to clarify this. I'll push it to emacs-25 > in a few days until there are complaints. > Pushed as f69bd7954f113719bb0e46e143231744c80bef34. --001a1148d9fedf75af0544579359 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am So., 18. Dez. 2016 um 22:25=C2=A0Uhr:
Glenn Morris &= lt;rgm= @gnu.org> schrieb am Di., 13. Dez. 2016 um 19:03=C2=A0Uhr:
Philipp Steph= ani wrote:

> The Ediff Info manual, in section 7.1 "Hooks", says:
>
> 'ediff-cleanup-hook'
>=C2=A0 =C2=A0 =C2=A0 This hook is run just before 'ediff-quit-hook&= #39;.=C2=A0 This is a good
>=C2=A0 =C2=A0 =C2=A0 place to do various cleanups, such as deleting the= variant buffers.
>=C2=A0 =C2=A0 =C2=A0 Ediff provides a function, 'ediff-janitor'= , as one such possible
>=C2=A0 =C2=A0 =C2=A0 hook, which you can add to 'ediff-cleanup-hook= ' with 'add-hook'.
>
> However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > function taking two required arguments, so it cannot be added to
> ediff-cleanup-hook.=C2=A0 The manual should e.g. state that a lambda w= rapping
> ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janito= r
> itself.

It seems the doc hasn't been updated in the past 14 years.
Before 50a07e1, there was a single optional argument.
You might be one of the few users of this functionality, so maybe you
would like to fix the doc yourself?
<= br class=3D"gmail_msg">
I don'= t use it myself, but I got a report from a colleague who interpreted the ma= nual such that you could add ediff-janitor directly to the hook with add-ho= ok. I've attached a patch to clarify this. I'll push it to emacs-25= in a few days until there are complaints.=C2=A0

Pushed as f69bd7954f113719bb0e46e143231744c80bef34.= =C2=A0
--001a1148d9fedf75af0544579359-- From unknown Sat Aug 09 20:50:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Jan 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator