GNU bug report logs - #24673
25.1.50; Evaluating '((closure))' aborts Emacs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24673 in the body.
You can then email your comments to 24673 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; Evaluating '((closure))' aborts Emacs
Date: Wed, 12 Oct 2016 12:26:24 +0200

emacs -Q

M-x ((closure)) RET

=> eval.c:2845: Emacs fatal error: assertion failed: CONSP (fun)

The function takes the (XCAR (XCDR '((closure)))), which is not a good
idea, since XCDR returns Qnil, while XCAR expects a cons. 


static Lisp_Object
funcall_lambda (Lisp_Object fun, ptrdiff_t nargs,
		register Lisp_Object *arg_vector)
{
  ....        
  if (CONSP (fun))
    {
      if (EQ (XCAR (fun), Qclosure))
	{
	  fun = XCDR (fun);	/* Drop `closure'.  */
	  lexenv = XCAR (fun);                 <============ 2845
	  CHECK_LIST_CONS (fun, fun);
	}
        ...
    }
  else ...
}

-ap

Message #8 received at 24673 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Andreas Politz <politza <at> hochschule-trier.de>, 24673 <at> debbugs.gnu.org
Subject: Re: bug#24673: 25.1.50; Evaluating '((closure))' aborts Emacs
Date: Wed, 12 Oct 2016 20:52:12 +0000

[Message part 1 (text/plain, inline)]

Andreas Politz <politza <at> hochschule-trier.de> schrieb am Mi., 12. Okt. 2016
um 12:28 Uhr:

>
>
> emacs -Q
>
>
>
> M-x ((closure)) RET
>
>
>
> => eval.c:2845: Emacs fatal error: assertion failed: CONSP (fun)
>
>
>
Thanks for reporting, if nobody complains I'll push the attached patch to
emacs-25.

[Message part 2 (text/html, inline)]

[0001-Fix-crash-in-evaluating-functions.txt (text/plain, attachment)]

Message #11 received at 24673 <at> debbugs.gnu.org (full text, mbox):

From: Robert Cochran <robert-emacs <at> cochranmail.com>
To: Andreas Politz <politza <at> hochschule-trier.de>
Cc: 24673 <at> debbugs.gnu.org
Subject: Re: bug#24673: 25.1.50; Evaluating '((closure))' aborts Emacs
Date: Wed, 12 Oct 2016 14:23:46 -0700

Andreas Politz <politza <at> hochschule-trier.de> writes:

> M-x ((closure)) RET

This is probably a brain-o, but `M-x ((closure))` prompts a "[No match]"
response on my machine. Perhaps you meant `M-:`?

If that's the case, then doing `M-: ((closure))` causes a SIGSEGV on
master's 6d6c93f4 with a non-debug build.

HTH,
-- 
~Robert Cochran

GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26  AD2D E5C3 EB36 4886 8871

Message #14 received at 24673 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24673 <at> debbugs.gnu.org, politza <at> hochschule-trier.de
Subject: Re: bug#24673: 25.1.50; Evaluating '((closure))' aborts Emacs
Date: Thu, 13 Oct 2016 08:51:26 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Wed, 12 Oct 2016 20:52:12 +0000
> 
>  emacs -Q
> 
>  M-x ((closure)) RET
> 
>  => eval.c:2845: Emacs fatal error: assertion failed: CONSP (fun)
> 
> Thanks for reporting, if nobody complains I'll push the attached patch to emacs-25.

I'm okay with the eval.c patch being pushed to emacs-25, but please
don't push the test there, push it to master instead (and to the
appropriate directory), as merging tests from emacs-25 frequently
produces problems due to the changes in directory structure.

Thanks.

Message #17 received at 24673 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24673 <at> debbugs.gnu.org, politza <at> hochschule-trier.de
Subject: Re: bug#24673: 25.1.50; Evaluating '((closure))' aborts Emacs
Date: Thu, 13 Oct 2016 11:13:18 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Do., 13. Okt. 2016 um 07:51 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
>
> > Date: Wed, 12 Oct 2016 20:52:12 +0000
>
> >
>
> >  emacs -Q
>
> >
>
> >  M-x ((closure)) RET
>
> >
>
> >  => eval.c:2845: Emacs fatal error: assertion failed: CONSP (fun)
>
> >
>
> > Thanks for reporting, if nobody complains I'll push the attached patch
> to emacs-25.
>
>
>
> I'm okay with the eval.c patch being pushed to emacs-25, but please
>
> don't push the test there, push it to master instead (and to the
>
> appropriate directory), as merging tests from emacs-25 frequently
>
> produces problems due to the changes in directory structure.
>
>
>
OK, pushed a slight variant that signals invalid-function instead of
wrong-type-argument.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.