GNU bug report logs - #24660
24.5; nxml-mode should support shift selection

Previous Next

Package: emacs;

Reported by: Yuri Khan <yuri.v.khan <at> gmail.com>

Date: Mon, 10 Oct 2016 16:43:02 UTC

Severity: normal

Tags: patch

Found in version 24.5

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 24660-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuri Khan <yuri.v.khan <at> gmail.com>
Cc: 24660-done <at> debbugs.gnu.org
Subject: Re: bug#24660: 24.5; nxml-mode should support shift selection
Date: Tue, 18 Oct 2016 09:46:19 +0300

> From: Yuri Khan <yuri.v.khan <at> gmail.com>
> Date: Mon, 10 Oct 2016 22:41:37 +0600
> 
> Many movement commands, such as forward-word, forward-sexp,
> forward-sentence, next-line, and their backward counterparts, support
> shift selection. That is, holding down Shift along with their bindings
> causes region to be activated and/or extended.
> 
> $ emacs -Q
> 
> C-x C-f /tmp/test.xml
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head>]</head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head></head>]<body></body></html>
> 
> 
> However, nxml-mode’s commands do not behave this way.
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-n ;; C-M-n (translated) runs nxml-forward-element
> 
> Expected:
> 
>     <html>[<head></head>]<body></body></html>
> 
> Observed:
> 
>     <html><head></head>|<body></body></html>
> 
> 
> The attached patch fixes this for me. It is based on current master (fd45b3f).

Thanks, pushed to master.

In the future, please provide ChangeLog-style commit log messages as
described in CONTRIBUTE.

Also, I encourage you to start the legal paperwork for assigning to
the FSF the copyright of your changes, so that we could continue
accepting your contributions without any limitations.
This bug report was last modified 8 years and 279 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.