Subject: Re: bug#24660: 24.5; nxml-mode should support shift selection

From: Clément Pit--Claudel <[email-masked]>
Date: Mon, 10 Oct 2016 12:57:54 -0400

This looks great.  Thanks!

This kind of bugs exists in a bunch of places :/  The other one that I see all the time is modes that break delete-selection-mode by rebinding certain commands.

Cheers,
Clément.

On 2016-10-10 12:41, Yuri Khan wrote:
> Many movement commands, such as forward-word, forward-sexp,
> forward-sentence, next-line, and their backward counterparts, support
> shift selection. That is, holding down Shift along with their bindings
> causes region to be activated and/or extended.
> 
> $ emacs -Q
> 
> C-x C-f /tmp/test.xml
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head>]</head><body></body></html>
> 
> C-M-S-<right> ;; C-M-<right> (translated) runs forward-sexp
> 
>     <html>[<head></head>]<body></body></html>
> 
> 
> However, nxml-mode’s commands do not behave this way.
> 
>     <html>|<head></head><body></body></html>
> 
> C-M-S-n ;; C-M-n (translated) runs nxml-forward-element
> 
> Expected:
> 
>     <html>[<head></head>]<body></body></html>
> 
> Observed:
> 
>     <html><head></head>|<body></body></html>
> 
> 
> The attached patch fixes this for me. It is based on current master (fd45b3f).
>