From unknown Thu Aug 21 14:54:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included Resent-From: Freja Nordsiek Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 10 Oct 2016 15:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24657 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 24657@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14761127719147 (code B ref -1); Mon, 10 Oct 2016 15:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Oct 2016 15:19:31 +0000 Received: from localhost ([127.0.0.1]:51358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btcMU-0002NT-H6 for submit@debbugs.gnu.org; Mon, 10 Oct 2016 11:19:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btX9O-0007n0-C7 for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btX9H-0007qV-AT for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:45:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btX9H-0007pz-1f for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:45:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btX9D-0003of-Qf for bug-guile@gnu.org; Mon, 10 Oct 2016 05:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btX9A-0007nN-P3 for bug-guile@gnu.org; Mon, 10 Oct 2016 05:45:26 -0400 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]:33944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btX9A-0007mp-Ca for bug-guile@gnu.org; Mon, 10 Oct 2016 05:45:24 -0400 Received: by mail-lf0-x233.google.com with SMTP id b81so116672683lfe.1 for ; Mon, 10 Oct 2016 02:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=IRYHuU5LhgqXG7UFElnBN3Gn26jKZ6MiHqGtQdsJC7A=; b=tH8HMum1S2ltpnbntwvuwZGCqZuXjO5EZGsnzNnVvry3gNQ41nhWe+qQX47j6Oq3Wh 7Zl9LA2MjEDa/qKe8gPDgE8fZ5h0X1ZBgemzauNkk4hCBHwa+HrwAZek20/RU53QmB45 CNe/9iI5/Lf0Nw15hXWZFgMEZLEPNuidUJ9yrIHNQnDs4+Bj4Qn0DqSXKeV39wo857Xo OkCSwamRlpSdq+9OlLkXRj2ahuHEX7vNSFEI6ThjPQ1/+YuIlJTUzpggSmUGgNvKoCj2 xyY9OCKta9jcZ3gmADYryoOkKHZoFOYh/paIthGABxDwqS4DM1v8eWKvZ0Pf++w2yBFh ehgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IRYHuU5LhgqXG7UFElnBN3Gn26jKZ6MiHqGtQdsJC7A=; b=dd9hI8y3I1s9p1PJXzY3ISziyiFGN9LL5UYS0Yv7nLMpXclbQH/rAHz0xYqyj0A+3E /A0fGjq7REZyerctsnEj3mTJlGq4n04X4R85iH5s0bF78257o2n0n3uRXUn8GcFy404a Nrh2MceMgGc1YnmJvyyAppY5wT0fHQAFuF5FeHvALcgFFR20uUl5h5inTEm3KOTeRDRH eiG7D1qqAKga9+tsp5Km7aY8IdaxZT2/VqR/OvKk9uFSJbUiX74cnsM5utRCYK8BkRbW 89WDNtyyQ3MXzIkyJRJjPcwByvca+Yiq4lfDGBvcUy3QIcEu4aC0K56y75crioPfDHWS LyTQ== X-Gm-Message-State: AA6/9RmdYY2i+3XJtSDCYfrsOYS0GQINx5+R4GCwM6/bbBjSrUDvMoWmtHHU61Mcx/JVzQphRIHE1FvAJOK/lA== X-Received: by 10.194.129.137 with SMTP id nw9mr35265413wjb.13.1476092722708; Mon, 10 Oct 2016 02:45:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.232.139 with HTTP; Mon, 10 Oct 2016 02:45:21 -0700 (PDT) From: Freja Nordsiek Date: Mon, 10 Oct 2016 16:45:21 +0700 Message-ID: Content-Type: multipart/mixed; boundary=001a11c364d064bc2e053e7f9e62 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Mon, 10 Oct 2016 11:19:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11c364d064bc2e053e7f9e62 Content-Type: text/plain; charset=UTF-8 While trying to build a package that uses guile with autotools, I found a problem in the provided GUILE_PROGS macro. The macro searches for the executables guile, guild, guile-config, and guile-tools. The problem is that even if the macro is given the version, it only looks for guile, guild, etc. with no version suffix. Version suffixes are commonly used by GNU/Linux distros to allow parallel installations of guile 1.8 and 2.0 (and 2.2 if it is there as well). Though typically one of them, whichever the distro considers to be primary, will have no suffix and will be just plain suffixless guile, guild, etc. I installed 2.1.4 (effective version 2.2) from source with the suffix '-2.2' to use the same style and not risk collisions with the guile already on my system (2.0 is the default). I imagine that others may do this sort of thing as well. Anyhow, GUILE_PROGS looks for suffixless guile and then compares its effective version to what was provided as an argument or set in the variable GUILE_EFFECTIVE_VERSION earlier by the GUILE_PKG macro. On a system with parallel guile installations with use of version suffixes, this means that the desired version of guile cannot be targetted unless that one happens to be suffixless (or have a suffixless symlink). If there is no suffixless guile, then the macro fails outright. If there is one and it is pointing to a version different than given as an argument or through the variable GUILE_EFFECTIVE_VERSION, it throws an error. For example, on my system (Fedora 24), guile 2.0 is installed without suffix and with a 'guile2' symlink by a package from the main repository. I have installed the latest version of guile using the sources on the git (2.1.4) in parallel using the suffix '-2.2' meaning its guile executable is 'guile-2.2'. If I use autoconf with the provided guile.m4 in the same directory as the following configure.ac looking for guile 2.2 with GUILE_PROGS AC_INIT([guile_autoconf_test], [0.1], []) m4_include([guile.m4]) GUILE_PROGS([2.2]) AC_OUTPUT I get the following output from the resulting configure script checking for guile... /usr/bin/guile checking for Guile version >= 2.2... configure: error: Guile 2.2 required, but 2.0.11 found If I instead run GUILE_PKG first and use the GUILE_EFFECTIVE_VERSION set by it AC_INIT([guile_autoconf_test], [0.1], []) m4_include([guile.m4]) GUILE_PKG([2.2]) GUILE_PROGS dnl Get the same results if I do GUILE_PROGS([2.2]) AC_OUTPUT I get a similar error from the configure script checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes configure: checking for guile 2.2 configure: found guile 2.2 checking for guile... /usr/bin/guile configure: error: found development files for Guile 2.2, but /usr/bin/guile has effective version 2.0 Looking at the beginning of the GUILE_PROGS macro in guile.m4 from guile 2.1.4 AC_DEFUN([GUILE_PROGS], [AC_PATH_PROG(GUILE,guile) _guile_required_version="m4_default([$1], [$GUILE_EFFECTIVE_VERSION])" if test -z "$_guile_required_version"; then _guile_required_version=2.0 fi if test "$GUILE" = "" ; then AC_MSG_ERROR([guile required but not found]) fi AC_SUBST(GUILE) The problem comes from AC_PATH_PROG(GUILE,guile) in the very first line and then the error 5 and 6 lines below it when it fails. Further on in the macro, if guile is found, it checks its version against the provided version or against 2.0. I've written a patch that makes GUILE_PROGS first look for the specified version (or default version) of guile first with the version suffix '-X.Y', and if that fails looks for it with the version suffix 'X.Y' (no dash, unlike the first one), and if that fails looks for it without any version suffix. If it finds guile in this way, it then compares the versions. The patched version then uses the same suffix (or lack there of) when finding guild, guile-config, and guile-tools. I've attached the patch against the current development version of guile (well, assuming someone hasn't committed in the last half hour). It changes the macro and updated the documentation as well (the documentation builds successfully). The beginning of the GUILE_PROGS macro is changed to AC_DEFUN([GUILE_PROGS], [_guile_required_version="m4_default([$1], [$GUILE_EFFECTIVE_VERSION])" if test -z "$_guile_required_version"; then _guile_required_version=2.0 fi _guile_suffix=-$_guile_required_version AC_PATH_PROG(GUILE,[guile$_guile_suffix]) if test "$GUILE" = "" ; then _guile_suffix=$_guile_required_version AC_PATH_PROG(GUILE,[guile$_guile_suffix]) if test "$GUILE" = "" ; then _guile_suffix= AC_PATH_PROG(GUILE,[guile$_guile_suffix]) if test "$GUILE" = "" ; then AC_MSG_ERROR([guile required but not found]) fi fi fi AC_SUBST(GUILE) Then, the previous configure.ac except with the new autoconf macro file named new_guile.m4 AC_INIT([guile_autoconf_test], [0.1], []) m4_include([new_guile.m4]) GUILE_PKG([2.2]) GUILE_PROGS AC_OUTPUT The configure script succeeds at finding guile 2.2 checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes configure: checking for guile 2.2 configure: found guile 2.2 checking for guile-2.2... /usr/local/bin/guile-2.2 checking for Guile version >= 2.2... 2.1.4 checking for guild-2.2... /usr/local/bin/guild-2.2 checking for guile-config-2.2... /usr/local/bin/guile-config-2.2 configure: creating ./config.status If configure.ac is changed to not use GUILE_PKG and look for guile 1.8, which is not on my system, AC_INIT([guile_autoconf_test], [0.1], []) m4_include([new_guile.m4]) GUILE_PROGS([1.8]) AC_OUTPUT The configure tries to find guile-1.8 and then guile1.8 unsuccessfully. It then finds guile, whose version (2.0) is at least 1.8 so configure considers that a success (whether that would be considered a bug or a feature is up for debate but that is for another time). checking for guile-1.8... no checking for guile1.8... no checking for guile... /usr/bin/guile checking for Guile version >= 1.8... 2.0.11 checking for guild... /usr/bin/guild checking for guile-config... /usr/bin/guile-config configure: creating ./config.status An alternative way to fix the issue would be to instead make GUILE_PROGS take one or more arbitrary suffixes to try as inputs. Another alternative would be to look for all executables that begin with the string 'guile' and check the version of each one till one is successful. The latter one seems like it would take quite a bit of work to implement and test. Freja Nordsiek --001a11c364d064bc2e053e7f9e62 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fixed-specific-version-of-guile-search-in-autoconf-m.patch" Content-Disposition: attachment; filename="0001-Fixed-specific-version-of-guile-search-in-autoconf-m.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iu3vcovn0 RnJvbSA3ZTZkOGQ5ODllNTc3OGUyNTA4ZjFjZTYyMzVhODgzNzY0ZmFkZDMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmVqYSBOb3Jkc2llayA8Zm5vcmRzaWVAZ21haWwuY29tPgpE YXRlOiBNb24sIDEwIE9jdCAyMDE2IDE1OjUwOjE5ICswNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZWQgc3BlY2lmaWMgdmVyc2lvbiBvZiBndWlsZSBzZWFyY2ggaW4gYXV0b2NvbmYgbWFjcm8KIEdV SUxFX1BST0dTLgoKKiBtZXRhL2d1aWxlLm00IChHVUlMRV9QUk9HUyk6ClNlYXJjaCBmb3IgZ3Vp bGUgd2l0aCBzdWZmaXhlcyBmaXJzdCAoJy1YLlknIGFuZCAnWC5ZJyB3aGVyZSBYLlkgZGVub3Rl cwp0aGUgdmVyc2lvbikgYmVmb3JlIHNlYXJjaGluZyBmb3IgZ3VpbGUgd2l0aCBubyBzdWZmaXgu Ci0tLQogbWV0YS9ndWlsZS5tNCB8IDI4ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL21ldGEvZ3VpbGUubTQgYi9tZXRhL2d1aWxlLm00CmluZGV4IDlmZDRmMWEuLjZkNjliYjkg MTAwNjQ0Ci0tLSBhL21ldGEvZ3VpbGUubTQKKysrIGIvbWV0YS9ndWlsZS5tNApAQCAtMTgxLDcg KzE4MSwxMiBAQCBBQ19ERUZVTihbR1VJTEVfU0lURV9ESVJdLAogIwogIyBUaGlzIG1hY3JvIGxv b2tzIGZvciBwcm9ncmFtcyBAY29kZXtndWlsZX0gYW5kIEBjb2Rle2d1aWxkfSwgc2V0dGluZwog IyB2YXJpYWJsZXMgQHZhcntHVUlMRX0gYW5kIEB2YXJ7R1VJTER9IHRvIHRoZWlyIHBhdGhzLCBy ZXNwZWN0aXZlbHkuCi0jIElmIEBjb2Rle2d1aWxlfSBpcyBub3QgZm91bmQsIHNpZ25hbCBhbiBl cnJvci4KKyMgVGhlIG1hY3JvIHdpbGwgYXR0ZW1wdCB0byBmaW5kIEBjb2Rle2d1aWxlfSB3aXRo IHRoZSBzdWZmaXggb2YKKyMgQGNvZGV7LVguWX0sIGZvbGxvd2VkIGJ5IGxvb2tpbmcgZm9yIGl0 IHdpdGggdGhlIHN1ZmZpeCBAY29kZXtYLll9LCBhbmQKKyMgdGhlbiBmYWxsIGJhY2sgdG8gbG9v a2luZyBmb3IgQGNvZGV7Z3VpbGV9IHdpdGggbm8gc3VmZml4LiBJZgorIyBAY29kZXtndWlsZX0g aXMgc3RpbGwgbm90IGZvdW5kLCBzaWduYWwgYW4gZXJyb3IuIFRoZSBzdWZmaXgsIGlmIGFueSwK KyMgdGhhdCB3YXMgcmVxdWlyZWQgdG8gZmluZCBAY29kZXtndWlsZX0gd2lsbCBiZSB1c2VkIGZv ciBAY29kZXtndWlsZH0KKyMgYXMgd2VsbC4KICMKICMgQnkgZGVmYXVsdCwgdGhpcyBtYWNybyB3 aWxsIHNlYXJjaCBmb3IgdGhlIGxhdGVzdCBzdGFibGUgdmVyc2lvbiBvZgogIyBHdWlsZSAoZS5n LiAyLjApLiB4Lnkgb3IgeC55LnogdmVyc2lvbnMgY2FuIGJlIHNwZWNpZmllZC4gSWYgYW4gb2xk ZXIKQEAgLTE5OCwxMyArMjAzLDIyIEBAIEFDX0RFRlVOKFtHVUlMRV9TSVRFX0RJUl0sCiAjIFRo ZSB2YXJpYWJsZXMgYXJlIG1hcmtlZCBmb3Igc3Vic3RpdHV0aW9uLCBhcyBieSBAY29kZXtBQ19T VUJTVH0uCiAjCiBBQ19ERUZVTihbR1VJTEVfUFJPR1NdLAotIFtBQ19QQVRIX1BST0coR1VJTEUs Z3VpbGUpCi0gIF9ndWlsZV9yZXF1aXJlZF92ZXJzaW9uPSJtNF9kZWZhdWx0KFskMV0sIFskR1VJ TEVfRUZGRUNUSVZFX1ZFUlNJT05dKSIKKyBbX2d1aWxlX3JlcXVpcmVkX3ZlcnNpb249Im00X2Rl ZmF1bHQoWyQxXSwgWyRHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTl0pIgogICBpZiB0ZXN0IC16ICIk X2d1aWxlX3JlcXVpcmVkX3ZlcnNpb24iOyB0aGVuCiAgICAgX2d1aWxlX3JlcXVpcmVkX3ZlcnNp b249Mi4wCiAgIGZpCisgIF9ndWlsZV9zdWZmaXg9LSRfZ3VpbGVfcmVxdWlyZWRfdmVyc2lvbgor ICBBQ19QQVRIX1BST0coR1VJTEUsW2d1aWxlJF9ndWlsZV9zdWZmaXhdKQogICBpZiB0ZXN0ICIk R1VJTEUiID0gIiIgOyB0aGVuCi0gICAgICBBQ19NU0dfRVJST1IoW2d1aWxlIHJlcXVpcmVkIGJ1 dCBub3QgZm91bmRdKQorICAgICAgX2d1aWxlX3N1ZmZpeD0kX2d1aWxlX3JlcXVpcmVkX3ZlcnNp b24KKyAgICAgIEFDX1BBVEhfUFJPRyhHVUlMRSxbZ3VpbGUkX2d1aWxlX3N1ZmZpeF0pCisgICAg ICBpZiB0ZXN0ICIkR1VJTEUiID0gIiIgOyB0aGVuCisgICAgICAgICAgX2d1aWxlX3N1ZmZpeD0K KyAgICAgICAgICBBQ19QQVRIX1BST0coR1VJTEUsW2d1aWxlJF9ndWlsZV9zdWZmaXhdKQorICAg ICAgICAgIGlmIHRlc3QgIiRHVUlMRSIgPSAiIiA7IHRoZW4KKyAgICAgICAgICAgICAgQUNfTVNH X0VSUk9SKFtndWlsZSByZXF1aXJlZCBidXQgbm90IGZvdW5kXSkKKyAgICAgICAgICBmaQorICAg ICAgZmkKICAgZmkKICAgQUNfU1VCU1QoR1VJTEUpCiAKQEAgLTI0NiwxNSArMjYwLDE1IEBAIEFD X0RFRlVOKFtHVUlMRV9QUk9HU10sCiAgIGZpCiAgIEFDX01TR19SRVNVTFQoWyRfZ3VpbGVfcHJv Z192ZXJzaW9uXSkKIAotICBBQ19QQVRIX1BST0coR1VJTEQsZ3VpbGQpCisgIEFDX1BBVEhfUFJP RyhHVUlMRCxbZ3VpbGQkX2d1aWxlX3N1ZmZpeF0pCiAgIEFDX1NVQlNUKEdVSUxEKQogCi0gIEFD X1BBVEhfUFJPRyhHVUlMRV9DT05GSUcsZ3VpbGUtY29uZmlnKQorICBBQ19QQVRIX1BST0coR1VJ TEVfQ09ORklHLFtndWlsZS1jb25maWckX2d1aWxlX3N1ZmZpeF0pCiAgIEFDX1NVQlNUKEdVSUxF X0NPTkZJRykKICAgaWYgdGVzdCAtbiAiJEdVSUxEIjsgdGhlbgogICAgIEdVSUxFX1RPT0xTPSRH VUlMRAogICBlbHNlCi0gICAgQUNfUEFUSF9QUk9HKEdVSUxFX1RPT0xTLGd1aWxlLXRvb2xzKQor ICAgIEFDX1BBVEhfUFJPRyhHVUlMRV9UT09MUyxbZ3VpbGUtdG9vbHMkX2d1aWxlX3N1ZmZpeF0p CiAgIGZpCiAgIEFDX1NVQlNUKEdVSUxFX1RPT0xTKQogIF0pCi0tIAoyLjcuNAoK --001a11c364d064bc2e053e7f9e62-- From unknown Thu Aug 21 14:54:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Freja Nordsiek Subject: bug#24657: closed (Re: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included) Message-ID: References: <87bmttw8cv.fsf@pobox.com> X-Gnu-PR-Message: they-closed 24657 X-Gnu-PR-Package: guile Reply-To: 24657@debbugs.gnu.org Date: Thu, 23 Feb 2017 12:21:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1487852462-17173-1" This is a multi-part message in MIME format... ------------=_1487852462-17173-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24657: Autoconf macro GUILE_PROGS only looks for guile without version suf= fix even if given version - patch included which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24657@debbugs.gnu.org. --=20 24657: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24657 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1487852462-17173-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24657-done) by debbugs.gnu.org; 23 Feb 2017 12:20:59 +0000 Received: from localhost ([127.0.0.1]:52021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgsOI-0004SP-LO for submit@debbugs.gnu.org; Thu, 23 Feb 2017 07:20:58 -0500 Received: from pb-sasl2.pobox.com ([64.147.108.67]:61471 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgsOG-0004SH-VM for 24657-done@debbugs.gnu.org; Thu, 23 Feb 2017 07:20:57 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 013C65E25C; Thu, 23 Feb 2017 07:20:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=4K8QMaKabPSKFDpM/3eNs+wG0Yo=; b=fEPEqv fq6dXSafU79HLaF9XfNeaWYB3qeaYxNbGAyTIPnHUVvqsTd0w3asVffbr1Mjm5k3 llGOcdY0QV6hltgHXb/okelv5O06VOYYCEXmO2WZRoQc5bGNQjHVDOlqYhZf1teF Aq6wrsufRHXXuBkZLV+MzgUTe0Id/Qjey/t20= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=sbDpXI5kpyNTzrqrJvOpS0ZFUrakkcg5 sMPsIYwXX3QLxVr32lmjWqTZGo7Q+lk2697fifO2ElW707I7cRWJtkV6qydD9/Yw GoeUrhvMfbQ6e6sjwxsVF6P2wjg8zao8/K4JwuI26Gp6keqeXDZey5N3AvyhONGD PZWjRQAciLo= Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id DB2BC5E25A; Thu, 23 Feb 2017 07:20:54 -0500 (EST) Received: from clucks (unknown [109.190.228.233]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id C98635E259; Thu, 23 Feb 2017 07:20:53 -0500 (EST) From: Andy Wingo To: Freja Nordsiek Subject: Re: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included References: Date: Thu, 23 Feb 2017 10:43:12 +0100 In-Reply-To: (Freja Nordsiek's message of "Mon, 10 Oct 2016 16:45:21 +0700") Message-ID: <87bmttw8cv.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Pobox-Relay-ID: 857F759A-F9C2-11E6-A1E1-6141F2301B6D-02397024!pb-sasl2.pobox.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24657-done Cc: 24657-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Hi Freja, Thanks for this bug report and the patch, and sorry for the delay :) On Mon 10 Oct 2016 11:45, Freja Nordsiek writes: > While trying to build a package that uses guile with autotools, I > found a problem in the provided GUILE_PROGS macro. > > The macro searches for the executables guile, guild, guile-config, and > guile-tools. The problem is that even if the macro is given the > version, it only looks for guile, guild, etc. with no version suffix. Applied your patch with some small modifications; attached. Let me know if it works for you! Andy --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fixed-specific-version-of-guile-search-in-autoconf-m.patch >From b6d3ab6c0f912c48463b597ccfa18879f550cf50 Mon Sep 17 00:00:00 2001 From: Freja Nordsiek Date: Mon, 10 Oct 2016 15:50:19 +0700 Subject: [PATCH] Fixed specific version of guile search in autoconf macro GUILE_PROGS. * meta/guile.m4 (GUILE_PROGS): Search for guile with suffixes first ('-X.Y' and 'X.Y' where X.Y denotes the version) before searching for guile with no suffix. Patch co-authored by Andy Wingo. --- meta/guile.m4 | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/meta/guile.m4 b/meta/guile.m4 index 9fd4f1a..2e4f3dc 100644 --- a/meta/guile.m4 +++ b/meta/guile.m4 @@ -181,7 +181,12 @@ AC_DEFUN([GUILE_SITE_DIR], # # This macro looks for programs @code{guile} and @code{guild}, setting # variables @var{GUILE} and @var{GUILD} to their paths, respectively. -# If @code{guile} is not found, signal an error. +# The macro will attempt to find @code{guile} with the suffix of +# @code{-X.Y}, followed by looking for it with the suffix @code{X.Y}, and +# then fall back to looking for @code{guile} with no suffix. If +# @code{guile} is still not found, signal an error. The suffix, if any, +# that was required to find @code{guile} will be used for @code{guild} +# as well. # # By default, this macro will search for the latest stable version of # Guile (e.g. 2.0). x.y or x.y.z versions can be specified. If an older @@ -198,16 +203,25 @@ AC_DEFUN([GUILE_SITE_DIR], # The variables are marked for substitution, as by @code{AC_SUBST}. # AC_DEFUN([GUILE_PROGS], - [AC_PATH_PROG(GUILE,guile) - _guile_required_version="m4_default([$1], [$GUILE_EFFECTIVE_VERSION])" + [_guile_required_version="m4_default([$1], [$GUILE_EFFECTIVE_VERSION])" if test -z "$_guile_required_version"; then _guile_required_version=2.0 fi - if test "$GUILE" = "" ; then + + _guile_candidates=guile + _tmp= + for v in `echo "$_guile_required_version" | tr . ' '`; do + if test -n "$_tmp"; then _tmp=.$_tmp; fi + _tmp=$v$_tmp + _guile_candidates="guile-$_tmp guile$_tmp $_guile_candidates" + done + + AC_PATH_PROGS(GUILE,[$_guile_candidates]) + if test -z "$GUILE"; then AC_MSG_ERROR([guile required but not found]) fi - AC_SUBST(GUILE) + _guile_suffix=`echo "$GUILE" | sed -e 's,^.*/guile\(.*\)$,\1,'` _guile_effective_version=`$GUILE -c "(display (effective-version))"` if test -z "$GUILE_EFFECTIVE_VERSION"; then GUILE_EFFECTIVE_VERSION=$_guile_effective_version @@ -246,15 +260,15 @@ AC_DEFUN([GUILE_PROGS], fi AC_MSG_RESULT([$_guile_prog_version]) - AC_PATH_PROG(GUILD,guild) + AC_PATH_PROG(GUILD,[guild$_guile_suffix]) AC_SUBST(GUILD) - AC_PATH_PROG(GUILE_CONFIG,guile-config) + AC_PATH_PROG(GUILE_CONFIG,[guile-config$_guile_suffix]) AC_SUBST(GUILE_CONFIG) if test -n "$GUILD"; then GUILE_TOOLS=$GUILD else - AC_PATH_PROG(GUILE_TOOLS,guile-tools) + AC_PATH_PROG(GUILE_TOOLS,[guile-tools$_guile_suffix]) fi AC_SUBST(GUILE_TOOLS) ]) -- 2.10.2 --=-=-=-- ------------=_1487852462-17173-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Oct 2016 15:19:31 +0000 Received: from localhost ([127.0.0.1]:51358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btcMU-0002NT-H6 for submit@debbugs.gnu.org; Mon, 10 Oct 2016 11:19:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btX9O-0007n0-C7 for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btX9H-0007qV-AT for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:45:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btX9H-0007pz-1f for submit@debbugs.gnu.org; Mon, 10 Oct 2016 05:45:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btX9D-0003of-Qf for bug-guile@gnu.org; Mon, 10 Oct 2016 05:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btX9A-0007nN-P3 for bug-guile@gnu.org; Mon, 10 Oct 2016 05:45:26 -0400 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]:33944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btX9A-0007mp-Ca for bug-guile@gnu.org; Mon, 10 Oct 2016 05:45:24 -0400 Received: by mail-lf0-x233.google.com with SMTP id b81so116672683lfe.1 for ; Mon, 10 Oct 2016 02:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=IRYHuU5LhgqXG7UFElnBN3Gn26jKZ6MiHqGtQdsJC7A=; b=tH8HMum1S2ltpnbntwvuwZGCqZuXjO5EZGsnzNnVvry3gNQ41nhWe+qQX47j6Oq3Wh 7Zl9LA2MjEDa/qKe8gPDgE8fZ5h0X1ZBgemzauNkk4hCBHwa+HrwAZek20/RU53QmB45 CNe/9iI5/Lf0Nw15hXWZFgMEZLEPNuidUJ9yrIHNQnDs4+Bj4Qn0DqSXKeV39wo857Xo OkCSwamRlpSdq+9OlLkXRj2ahuHEX7vNSFEI6ThjPQ1/+YuIlJTUzpggSmUGgNvKoCj2 xyY9OCKta9jcZ3gmADYryoOkKHZoFOYh/paIthGABxDwqS4DM1v8eWKvZ0Pf++w2yBFh ehgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IRYHuU5LhgqXG7UFElnBN3Gn26jKZ6MiHqGtQdsJC7A=; b=dd9hI8y3I1s9p1PJXzY3ISziyiFGN9LL5UYS0Yv7nLMpXclbQH/rAHz0xYqyj0A+3E /A0fGjq7REZyerctsnEj3mTJlGq4n04X4R85iH5s0bF78257o2n0n3uRXUn8GcFy404a Nrh2MceMgGc1YnmJvyyAppY5wT0fHQAFuF5FeHvALcgFFR20uUl5h5inTEm3KOTeRDRH eiG7D1qqAKga9+tsp5Km7aY8IdaxZT2/VqR/OvKk9uFSJbUiX74cnsM5utRCYK8BkRbW 89WDNtyyQ3MXzIkyJRJjPcwByvca+Yiq4lfDGBvcUy3QIcEu4aC0K56y75crioPfDHWS LyTQ== X-Gm-Message-State: AA6/9RmdYY2i+3XJtSDCYfrsOYS0GQINx5+R4GCwM6/bbBjSrUDvMoWmtHHU61Mcx/JVzQphRIHE1FvAJOK/lA== X-Received: by 10.194.129.137 with SMTP id nw9mr35265413wjb.13.1476092722708; Mon, 10 Oct 2016 02:45:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.232.139 with HTTP; Mon, 10 Oct 2016 02:45:21 -0700 (PDT) From: Freja Nordsiek Date: Mon, 10 Oct 2016 16:45:21 +0700 Message-ID: Subject: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included To: bug-guile@gnu.org Content-Type: multipart/mixed; boundary=001a11c364d064bc2e053e7f9e62 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 10 Oct 2016 11:19:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11c364d064bc2e053e7f9e62 Content-Type: text/plain; charset=UTF-8 While trying to build a package that uses guile with autotools, I found a problem in the provided GUILE_PROGS macro. The macro searches for the executables guile, guild, guile-config, and guile-tools. The problem is that even if the macro is given the version, it only looks for guile, guild, etc. with no version suffix. Version suffixes are commonly used by GNU/Linux distros to allow parallel installations of guile 1.8 and 2.0 (and 2.2 if it is there as well). Though typically one of them, whichever the distro considers to be primary, will have no suffix and will be just plain suffixless guile, guild, etc. I installed 2.1.4 (effective version 2.2) from source with the suffix '-2.2' to use the same style and not risk collisions with the guile already on my system (2.0 is the default). I imagine that others may do this sort of thing as well. Anyhow, GUILE_PROGS looks for suffixless guile and then compares its effective version to what was provided as an argument or set in the variable GUILE_EFFECTIVE_VERSION earlier by the GUILE_PKG macro. On a system with parallel guile installations with use of version suffixes, this means that the desired version of guile cannot be targetted unless that one happens to be suffixless (or have a suffixless symlink). If there is no suffixless guile, then the macro fails outright. If there is one and it is pointing to a version different than given as an argument or through the variable GUILE_EFFECTIVE_VERSION, it throws an error. For example, on my system (Fedora 24), guile 2.0 is installed without suffix and with a 'guile2' symlink by a package from the main repository. I have installed the latest version of guile using the sources on the git (2.1.4) in parallel using the suffix '-2.2' meaning its guile executable is 'guile-2.2'. If I use autoconf with the provided guile.m4 in the same directory as the following configure.ac looking for guile 2.2 with GUILE_PROGS AC_INIT([guile_autoconf_test], [0.1], []) m4_include([guile.m4]) GUILE_PROGS([2.2]) AC_OUTPUT I get the following output from the resulting configure script checking for guile... /usr/bin/guile checking for Guile version >= 2.2... configure: error: Guile 2.2 required, but 2.0.11 found If I instead run GUILE_PKG first and use the GUILE_EFFECTIVE_VERSION set by it AC_INIT([guile_autoconf_test], [0.1], []) m4_include([guile.m4]) GUILE_PKG([2.2]) GUILE_PROGS dnl Get the same results if I do GUILE_PROGS([2.2]) AC_OUTPUT I get a similar error from the configure script checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes configure: checking for guile 2.2 configure: found guile 2.2 checking for guile... /usr/bin/guile configure: error: found development files for Guile 2.2, but /usr/bin/guile has effective version 2.0 Looking at the beginning of the GUILE_PROGS macro in guile.m4 from guile 2.1.4 AC_DEFUN([GUILE_PROGS], [AC_PATH_PROG(GUILE,guile) _guile_required_version="m4_default([$1], [$GUILE_EFFECTIVE_VERSION])" if test -z "$_guile_required_version"; then _guile_required_version=2.0 fi if test "$GUILE" = "" ; then AC_MSG_ERROR([guile required but not found]) fi AC_SUBST(GUILE) The problem comes from AC_PATH_PROG(GUILE,guile) in the very first line and then the error 5 and 6 lines below it when it fails. Further on in the macro, if guile is found, it checks its version against the provided version or against 2.0. I've written a patch that makes GUILE_PROGS first look for the specified version (or default version) of guile first with the version suffix '-X.Y', and if that fails looks for it with the version suffix 'X.Y' (no dash, unlike the first one), and if that fails looks for it without any version suffix. If it finds guile in this way, it then compares the versions. The patched version then uses the same suffix (or lack there of) when finding guild, guile-config, and guile-tools. I've attached the patch against the current development version of guile (well, assuming someone hasn't committed in the last half hour). It changes the macro and updated the documentation as well (the documentation builds successfully). The beginning of the GUILE_PROGS macro is changed to AC_DEFUN([GUILE_PROGS], [_guile_required_version="m4_default([$1], [$GUILE_EFFECTIVE_VERSION])" if test -z "$_guile_required_version"; then _guile_required_version=2.0 fi _guile_suffix=-$_guile_required_version AC_PATH_PROG(GUILE,[guile$_guile_suffix]) if test "$GUILE" = "" ; then _guile_suffix=$_guile_required_version AC_PATH_PROG(GUILE,[guile$_guile_suffix]) if test "$GUILE" = "" ; then _guile_suffix= AC_PATH_PROG(GUILE,[guile$_guile_suffix]) if test "$GUILE" = "" ; then AC_MSG_ERROR([guile required but not found]) fi fi fi AC_SUBST(GUILE) Then, the previous configure.ac except with the new autoconf macro file named new_guile.m4 AC_INIT([guile_autoconf_test], [0.1], []) m4_include([new_guile.m4]) GUILE_PKG([2.2]) GUILE_PROGS AC_OUTPUT The configure script succeeds at finding guile 2.2 checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes configure: checking for guile 2.2 configure: found guile 2.2 checking for guile-2.2... /usr/local/bin/guile-2.2 checking for Guile version >= 2.2... 2.1.4 checking for guild-2.2... /usr/local/bin/guild-2.2 checking for guile-config-2.2... /usr/local/bin/guile-config-2.2 configure: creating ./config.status If configure.ac is changed to not use GUILE_PKG and look for guile 1.8, which is not on my system, AC_INIT([guile_autoconf_test], [0.1], []) m4_include([new_guile.m4]) GUILE_PROGS([1.8]) AC_OUTPUT The configure tries to find guile-1.8 and then guile1.8 unsuccessfully. It then finds guile, whose version (2.0) is at least 1.8 so configure considers that a success (whether that would be considered a bug or a feature is up for debate but that is for another time). checking for guile-1.8... no checking for guile1.8... no checking for guile... /usr/bin/guile checking for Guile version >= 1.8... 2.0.11 checking for guild... /usr/bin/guild checking for guile-config... /usr/bin/guile-config configure: creating ./config.status An alternative way to fix the issue would be to instead make GUILE_PROGS take one or more arbitrary suffixes to try as inputs. Another alternative would be to look for all executables that begin with the string 'guile' and check the version of each one till one is successful. The latter one seems like it would take quite a bit of work to implement and test. Freja Nordsiek --001a11c364d064bc2e053e7f9e62 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fixed-specific-version-of-guile-search-in-autoconf-m.patch" Content-Disposition: attachment; filename="0001-Fixed-specific-version-of-guile-search-in-autoconf-m.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iu3vcovn0 RnJvbSA3ZTZkOGQ5ODllNTc3OGUyNTA4ZjFjZTYyMzVhODgzNzY0ZmFkZDMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmVqYSBOb3Jkc2llayA8Zm5vcmRzaWVAZ21haWwuY29tPgpE YXRlOiBNb24sIDEwIE9jdCAyMDE2IDE1OjUwOjE5ICswNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZWQgc3BlY2lmaWMgdmVyc2lvbiBvZiBndWlsZSBzZWFyY2ggaW4gYXV0b2NvbmYgbWFjcm8KIEdV SUxFX1BST0dTLgoKKiBtZXRhL2d1aWxlLm00IChHVUlMRV9QUk9HUyk6ClNlYXJjaCBmb3IgZ3Vp bGUgd2l0aCBzdWZmaXhlcyBmaXJzdCAoJy1YLlknIGFuZCAnWC5ZJyB3aGVyZSBYLlkgZGVub3Rl cwp0aGUgdmVyc2lvbikgYmVmb3JlIHNlYXJjaGluZyBmb3IgZ3VpbGUgd2l0aCBubyBzdWZmaXgu Ci0tLQogbWV0YS9ndWlsZS5tNCB8IDI4ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL21ldGEvZ3VpbGUubTQgYi9tZXRhL2d1aWxlLm00CmluZGV4IDlmZDRmMWEuLjZkNjliYjkg MTAwNjQ0Ci0tLSBhL21ldGEvZ3VpbGUubTQKKysrIGIvbWV0YS9ndWlsZS5tNApAQCAtMTgxLDcg KzE4MSwxMiBAQCBBQ19ERUZVTihbR1VJTEVfU0lURV9ESVJdLAogIwogIyBUaGlzIG1hY3JvIGxv b2tzIGZvciBwcm9ncmFtcyBAY29kZXtndWlsZX0gYW5kIEBjb2Rle2d1aWxkfSwgc2V0dGluZwog IyB2YXJpYWJsZXMgQHZhcntHVUlMRX0gYW5kIEB2YXJ7R1VJTER9IHRvIHRoZWlyIHBhdGhzLCBy ZXNwZWN0aXZlbHkuCi0jIElmIEBjb2Rle2d1aWxlfSBpcyBub3QgZm91bmQsIHNpZ25hbCBhbiBl cnJvci4KKyMgVGhlIG1hY3JvIHdpbGwgYXR0ZW1wdCB0byBmaW5kIEBjb2Rle2d1aWxlfSB3aXRo IHRoZSBzdWZmaXggb2YKKyMgQGNvZGV7LVguWX0sIGZvbGxvd2VkIGJ5IGxvb2tpbmcgZm9yIGl0 IHdpdGggdGhlIHN1ZmZpeCBAY29kZXtYLll9LCBhbmQKKyMgdGhlbiBmYWxsIGJhY2sgdG8gbG9v a2luZyBmb3IgQGNvZGV7Z3VpbGV9IHdpdGggbm8gc3VmZml4LiBJZgorIyBAY29kZXtndWlsZX0g aXMgc3RpbGwgbm90IGZvdW5kLCBzaWduYWwgYW4gZXJyb3IuIFRoZSBzdWZmaXgsIGlmIGFueSwK KyMgdGhhdCB3YXMgcmVxdWlyZWQgdG8gZmluZCBAY29kZXtndWlsZX0gd2lsbCBiZSB1c2VkIGZv ciBAY29kZXtndWlsZH0KKyMgYXMgd2VsbC4KICMKICMgQnkgZGVmYXVsdCwgdGhpcyBtYWNybyB3 aWxsIHNlYXJjaCBmb3IgdGhlIGxhdGVzdCBzdGFibGUgdmVyc2lvbiBvZgogIyBHdWlsZSAoZS5n LiAyLjApLiB4Lnkgb3IgeC55LnogdmVyc2lvbnMgY2FuIGJlIHNwZWNpZmllZC4gSWYgYW4gb2xk ZXIKQEAgLTE5OCwxMyArMjAzLDIyIEBAIEFDX0RFRlVOKFtHVUlMRV9TSVRFX0RJUl0sCiAjIFRo ZSB2YXJpYWJsZXMgYXJlIG1hcmtlZCBmb3Igc3Vic3RpdHV0aW9uLCBhcyBieSBAY29kZXtBQ19T VUJTVH0uCiAjCiBBQ19ERUZVTihbR1VJTEVfUFJPR1NdLAotIFtBQ19QQVRIX1BST0coR1VJTEUs Z3VpbGUpCi0gIF9ndWlsZV9yZXF1aXJlZF92ZXJzaW9uPSJtNF9kZWZhdWx0KFskMV0sIFskR1VJ TEVfRUZGRUNUSVZFX1ZFUlNJT05dKSIKKyBbX2d1aWxlX3JlcXVpcmVkX3ZlcnNpb249Im00X2Rl ZmF1bHQoWyQxXSwgWyRHVUlMRV9FRkZFQ1RJVkVfVkVSU0lPTl0pIgogICBpZiB0ZXN0IC16ICIk X2d1aWxlX3JlcXVpcmVkX3ZlcnNpb24iOyB0aGVuCiAgICAgX2d1aWxlX3JlcXVpcmVkX3ZlcnNp b249Mi4wCiAgIGZpCisgIF9ndWlsZV9zdWZmaXg9LSRfZ3VpbGVfcmVxdWlyZWRfdmVyc2lvbgor ICBBQ19QQVRIX1BST0coR1VJTEUsW2d1aWxlJF9ndWlsZV9zdWZmaXhdKQogICBpZiB0ZXN0ICIk R1VJTEUiID0gIiIgOyB0aGVuCi0gICAgICBBQ19NU0dfRVJST1IoW2d1aWxlIHJlcXVpcmVkIGJ1 dCBub3QgZm91bmRdKQorICAgICAgX2d1aWxlX3N1ZmZpeD0kX2d1aWxlX3JlcXVpcmVkX3ZlcnNp b24KKyAgICAgIEFDX1BBVEhfUFJPRyhHVUlMRSxbZ3VpbGUkX2d1aWxlX3N1ZmZpeF0pCisgICAg ICBpZiB0ZXN0ICIkR1VJTEUiID0gIiIgOyB0aGVuCisgICAgICAgICAgX2d1aWxlX3N1ZmZpeD0K KyAgICAgICAgICBBQ19QQVRIX1BST0coR1VJTEUsW2d1aWxlJF9ndWlsZV9zdWZmaXhdKQorICAg ICAgICAgIGlmIHRlc3QgIiRHVUlMRSIgPSAiIiA7IHRoZW4KKyAgICAgICAgICAgICAgQUNfTVNH X0VSUk9SKFtndWlsZSByZXF1aXJlZCBidXQgbm90IGZvdW5kXSkKKyAgICAgICAgICBmaQorICAg ICAgZmkKICAgZmkKICAgQUNfU1VCU1QoR1VJTEUpCiAKQEAgLTI0NiwxNSArMjYwLDE1IEBAIEFD X0RFRlVOKFtHVUlMRV9QUk9HU10sCiAgIGZpCiAgIEFDX01TR19SRVNVTFQoWyRfZ3VpbGVfcHJv Z192ZXJzaW9uXSkKIAotICBBQ19QQVRIX1BST0coR1VJTEQsZ3VpbGQpCisgIEFDX1BBVEhfUFJP RyhHVUlMRCxbZ3VpbGQkX2d1aWxlX3N1ZmZpeF0pCiAgIEFDX1NVQlNUKEdVSUxEKQogCi0gIEFD X1BBVEhfUFJPRyhHVUlMRV9DT05GSUcsZ3VpbGUtY29uZmlnKQorICBBQ19QQVRIX1BST0coR1VJ TEVfQ09ORklHLFtndWlsZS1jb25maWckX2d1aWxlX3N1ZmZpeF0pCiAgIEFDX1NVQlNUKEdVSUxF X0NPTkZJRykKICAgaWYgdGVzdCAtbiAiJEdVSUxEIjsgdGhlbgogICAgIEdVSUxFX1RPT0xTPSRH VUlMRAogICBlbHNlCi0gICAgQUNfUEFUSF9QUk9HKEdVSUxFX1RPT0xTLGd1aWxlLXRvb2xzKQor ICAgIEFDX1BBVEhfUFJPRyhHVUlMRV9UT09MUyxbZ3VpbGUtdG9vbHMkX2d1aWxlX3N1ZmZpeF0p CiAgIGZpCiAgIEFDX1NVQlNUKEdVSUxFX1RPT0xTKQogIF0pCi0tIAoyLjcuNAoK --001a11c364d064bc2e053e7f9e62-- ------------=_1487852462-17173-1-- From unknown Thu Aug 21 14:54:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included Resent-From: Freja Nordsiek Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 23 Feb 2017 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24657 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Andy Wingo Cc: 24657-done@debbugs.gnu.org Received: via spool by 24657-done@debbugs.gnu.org id=D24657.1487889114581 (code D ref 24657); Thu, 23 Feb 2017 22:32:01 +0000 Received: (at 24657-done) by debbugs.gnu.org; 23 Feb 2017 22:31:54 +0000 Received: from localhost ([127.0.0.1]:53334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ch1vW-00009J-0z for submit@debbugs.gnu.org; Thu, 23 Feb 2017 17:31:54 -0500 Received: from mail-wr0-f173.google.com ([209.85.128.173]:36774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ch1vU-000097-PD for 24657-done@debbugs.gnu.org; Thu, 23 Feb 2017 17:31:53 -0500 Received: by mail-wr0-f173.google.com with SMTP id 89so2720993wrr.3 for <24657-done@debbugs.gnu.org>; Thu, 23 Feb 2017 14:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1cKKqQLYRmc5PVvNKykG/tXXsaP8K50Gxoe/N9wlAOI=; b=nWrhzFyhf7S8cR75rt2QOVVhV2XoPiJr6TrX4kelfPkP/1ZmQk0UL4hMAy90YlY123 ZM9UX+2HXwfaPeIRCeg3Ct/rnXWdhv7otQBRZ5j9QOXAU2LHkyQHA2kOTqnoo759PnnF Z6GfWl1Utlo4Mt1x+wUtmQJACJOI8+soeMwdhVxbPiLmTHu7O1OYkAfRfcvWtPRv5blX 9Qk7bDb9Dl5bYsDdSPhSo+BDDok1Bqb8doDTLYeOVmHT+JfHHBSoWU1WSk3ZeP2+UFMd lumhf1k0ej/aPcq9gJwhnyf6jodqS0pYgk4X9a0PTqL151AYHbpOpbCxAPXGDDxuiyOt yO9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1cKKqQLYRmc5PVvNKykG/tXXsaP8K50Gxoe/N9wlAOI=; b=EqMYdsJwXXVOUkMME2VtXSMHDLDOvbBYB39fi26nno8PDpnUdJj5F8J4v6Rs3wzH7C kx51/qCOEaPhe9F6UfCDYMxrwqvY/diTvEm92MSDwL1m8dz5T8O9fVGLIvP1nTZuBm9L qroDlO+6CxlarHnRjdZidKNt8gjBsNNas85CzmwjHHub/oQGva7YxzGjtySkKdBCskiB 7SublZ28Ovy6dw9CQ0ZHgN2FzV2vh/hV7bHRHAgSFZGaWI7kWcEBVZUn0RDhqtkFkbzg 11H9ljzbqFYGm4kWA2+1LgCCP2LNzBYsA3hB6Rxq+tLpo/QgnoX5mJ/ZthRusJpi6q3J OkcQ== X-Gm-Message-State: AMke39nNApD82wdwpnGwF6s6h65EneP8VnCzRWL2kZs45uuv2fDfR+xsDNOsDPuIhW7TnrYArpea0+sfuWtg/g== X-Received: by 10.223.131.97 with SMTP id 88mr4522014wrd.202.1487889106918; Thu, 23 Feb 2017 14:31:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.143.142 with HTTP; Thu, 23 Feb 2017 14:31:46 -0800 (PST) In-Reply-To: <87bmttw8cv.fsf@pobox.com> References: <87bmttw8cv.fsf@pobox.com> From: Freja Nordsiek Date: Thu, 23 Feb 2017 23:31:46 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Andy, Your modifications to the patch make it a bit better since it will handle the case where guile 2.2 gets put under the name guile-2 or guile2. GIven how much more similar guile 2.1.x (and eventually 2.2.x) are to guile 2.0.x than guile 2.0.x is to guile 1.8.x, this is not too unlikely on distribution or another at some point. Only one potential issue. On the off chance that the guile program found by AC_PATH_PROGS is in the current directory and the absolute path is not given nor a prefix of "./", it might be better to replace _guile_suffix=`echo "$GUILE" | sed -e 's,^.*/guile\(.*\)$,\1,'` with _guile_suffix=`basename "$GUILE" | sed -e 's,^.*guile\(.*\)$,\1,'` which replaces echo with basename to remove all the directory information and then '/' is not looked for in the sed script anymore. Freja On Thu, Feb 23, 2017 at 10:43 AM, Andy Wingo wrote: > Hi Freja, > > Thanks for this bug report and the patch, and sorry for the delay :) > > On Mon 10 Oct 2016 11:45, Freja Nordsiek writes: > >> While trying to build a package that uses guile with autotools, I >> found a problem in the provided GUILE_PROGS macro. >> >> The macro searches for the executables guile, guild, guile-config, and >> guile-tools. The problem is that even if the macro is given the >> version, it only looks for guile, guild, etc. with no version suffix. > > Applied your patch with some small modifications; attached. Let me know > if it works for you! > > Andy > From unknown Thu Aug 21 14:54:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included Resent-From: Freja Nordsiek Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 14 Mar 2017 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24657 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Andy Wingo Cc: 24657-done@debbugs.gnu.org Received: via spool by 24657-done@debbugs.gnu.org id=D24657.14895015514645 (code D ref 24657); Tue, 14 Mar 2017 14:26:02 +0000 Received: (at 24657-done) by debbugs.gnu.org; 14 Mar 2017 14:25:51 +0000 Received: from localhost ([127.0.0.1]:55777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnnOY-0001Cq-VS for submit@debbugs.gnu.org; Tue, 14 Mar 2017 10:25:51 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnnOX-0001Cd-1R for 24657-done@debbugs.gnu.org; Tue, 14 Mar 2017 10:25:49 -0400 Received: by mail-wm0-f45.google.com with SMTP id t189so340195wmt.1 for <24657-done@debbugs.gnu.org>; Tue, 14 Mar 2017 07:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=83Yk7iHVqdj38dhTapvbKyzbrJ9HUCdKrtA6yfJ9aM4=; b=n3GJrIJX+LjALkvbkiKeGB3lPW7VOlvdigaSA6O/zgQRkpBjwcfXc73YjiI1iO3haF MBHgBr3rn5bYfybNhSqa7xSOSSKQ3/9l0Sug+BBKqcRsoHCiJ6QkQBwzYN6z0fL5sXU/ nJtPxuukucZeWQyRlAHHjyV1c936ZhWgKmubjHJ0wZfpmzz3n1rOHNSDz7YgMMsX4ToU ELymiqVMsl6kOITfYKlrv29iG9bumLNGchSlMuNnomMWHi+PMZdUMFE8aKMCmsMCDewH SQaekgxmvHnuNLNd1i8XQ4Gz80trdfr5/FUnjVha7DQFYFdbzRBGdgepSOio08nOpRzP Yveg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=83Yk7iHVqdj38dhTapvbKyzbrJ9HUCdKrtA6yfJ9aM4=; b=NDxnjUmbW778hngoqDwUg4sU03kyAcOmPr+BgaAals07bV3Cnstkv78LCgBaRIjPbN nKMqSMzlfT/Pmh+0gXXMmTqzVMAH7sQC1QMexYgqPV+D/JLmG5gZTxIq4ym9QbHAFmHo ZRLH5/yRe/qyQ1h7DYC2Ac8GAArmivJHBjyJJ9xAcexUIjsi/SgOnIYocCHu9SgGns27 7m35HACMG62ssge7TWb0zoP+RgM/StrYN/9n1A0p2yVOujJOfvDlFzUTgy4H4o8VzsyY wVDX8rHEx1asPGyjibXi5VDzQRnwsEzJdhso8n2VJvzx8Cz27DN8VgOKOhRP+LibCJX2 fSPw== X-Gm-Message-State: AFeK/H3DqIr2mFuelV/6x1gUwMaYDJLIx+oPMPGp3itxg+RTI+5YazwWVD1t+z7K7fGPgbAcvz+nivSScN0pSQ== X-Received: by 10.28.208.7 with SMTP id h7mr33533wmg.79.1489501543220; Tue, 14 Mar 2017 07:25:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.234.73 with HTTP; Tue, 14 Mar 2017 07:25:42 -0700 (PDT) In-Reply-To: <87bmttw8cv.fsf@pobox.com> References: <87bmttw8cv.fsf@pobox.com> From: Freja Nordsiek Date: Tue, 14 Mar 2017 15:25:42 +0100 Message-ID: Content-Type: multipart/mixed; boundary=94eb2c0c2fc26067ef054ab19a96 X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --94eb2c0c2fc26067ef054ab19a96 Content-Type: text/plain; charset=UTF-8 Found a bug in the modifications you made. Sorry for not catching this before it got included into the Guile 2.1.8 release. When constructing the candidates for the guile executable (_guile_candidates), the version numbers essentially get reverse. This is not noticeable for 2.2 since 2.2 reversed is still 2.2. But it is a major issue for Guile 2.0.x and 1.8.x where 0.2 and 8.1 get generated meaning the right executables could be missed. For the current version of GUILE_PROGS, looking for 2.0 results in the following candidates guile-0.2 guile0.2 guile-2 guile2 guile and for 1.8 guile-8.1 guile8.1 guile-1 guile1 guile The fix is luckily pretty trivial. A patch is attached. For convenience of anyone trying to reproduce this bug, here are two shell scripts that will take the version as the first input argument and return the generated guile executable candidates. The version with the bug is #!/bin/sh _guile_required_version=$1 _guile_candidates=guile _tmp= for v in `echo "$_guile_required_version" | tr . ' '`; do if test -n "$_tmp"; then _tmp=.$_tmp; fi _tmp=$v$_tmp _guile_candidates="guile-$_tmp guile$_tmp $_guile_candidates" done echo $_guile_candidates And the version with the fix is #!/bin/sh _guile_required_version=$1 _guile_candidates=guile _tmp= for v in `echo "$_guile_required_version" | tr . ' '`; do if test -n "$_tmp"; then _tmp=$_tmp.; fi _tmp=$_tmp$v _guile_candidates="guile-$_tmp guile$_tmp $_guile_candidates" done echo $_guile_candidates On Thu, Feb 23, 2017 at 10:43 AM, Andy Wingo wrote: > Hi Freja, > > Thanks for this bug report and the patch, and sorry for the delay :) > > On Mon 10 Oct 2016 11:45, Freja Nordsiek writes: > >> While trying to build a package that uses guile with autotools, I >> found a problem in the provided GUILE_PROGS macro. >> >> The macro searches for the executables guile, guild, guile-config, and >> guile-tools. The problem is that even if the macro is given the >> version, it only looks for guile, guild, etc. with no version suffix. > > Applied your patch with some small modifications; attached. Let me know > if it works for you! > > Andy > --94eb2c0c2fc26067ef054ab19a96 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fixed-reversed-version-order-bug-in-GUILE_PROGS-Auto.patch" Content-Disposition: attachment; filename="0001-Fixed-reversed-version-order-bug-in-GUILE_PROGS-Auto.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j09mmjme1 RnJvbSAyMDVmNDFkNDFiOTRmMTI2NzAzOTRlYzUyNmRkZGVhZjE0MTZkNzQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmVqYSBOb3Jkc2llayA8Zm5vcmRzaWVAZ21haWwuY29tPgpE YXRlOiBUdWUsIDE0IE1hciAyMDE3IDE1OjE0OjQ3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZWQgcmV2ZXJzZWQgdmVyc2lvbiBvcmRlciBidWcgaW4gR1VJTEVfUFJPR1MgQXV0b2NvbmYKIG1h Y3JvLgoKLS0tCiBtZXRhL2d1aWxlLm00IHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL21ldGEvZ3VpbGUubTQgYi9t ZXRhL2d1aWxlLm00CmluZGV4IDRhMmUyODUuLjUwMWEyMWMgMTAwNjQ0Ci0tLSBhL21ldGEvZ3Vp bGUubTQKKysrIGIvbWV0YS9ndWlsZS5tNApAQCAtMjM0LDggKzIzNCw4IEBAIEFDX0RFRlVOKFtH VUlMRV9QUk9HU10sCiAgIF9ndWlsZV9jYW5kaWRhdGVzPWd1aWxlCiAgIF90bXA9CiAgIGZvciB2 IGluIGBlY2hvICIkX2d1aWxlX3JlcXVpcmVkX3ZlcnNpb24iIHwgdHIgLiAnICdgOyBkbwotICAg IGlmIHRlc3QgLW4gIiRfdG1wIjsgdGhlbiBfdG1wPS4kX3RtcDsgZmkKLSAgICBfdG1wPSR2JF90 bXAKKyAgICBpZiB0ZXN0IC1uICIkX3RtcCI7IHRoZW4gX3RtcD0kX3RtcC47IGZpCisgICAgX3Rt cD0kX3RtcCR2CiAgICAgX2d1aWxlX2NhbmRpZGF0ZXM9Imd1aWxlLSRfdG1wIGd1aWxlJF90bXAg JF9ndWlsZV9jYW5kaWRhdGVzIgogICBkb25lCiAKLS0gCjIuOS4zCgo= --94eb2c0c2fc26067ef054ab19a96-- From unknown Thu Aug 21 14:54:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 14 Mar 2017 14:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24657 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Freja Nordsiek Cc: 24657-done@debbugs.gnu.org Received: via spool by 24657-done@debbugs.gnu.org id=D24657.14895026636850 (code D ref 24657); Tue, 14 Mar 2017 14:45:01 +0000 Received: (at 24657-done) by debbugs.gnu.org; 14 Mar 2017 14:44:23 +0000 Received: from localhost ([127.0.0.1]:55783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnngV-0001mQ-M8 for submit@debbugs.gnu.org; Tue, 14 Mar 2017 10:44:23 -0400 Received: from pb-sasl1.pobox.com ([64.147.108.66]:54351 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnngU-0001mI-BE for 24657-done@debbugs.gnu.org; Tue, 14 Mar 2017 10:44:22 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id BF32769B25; Tue, 14 Mar 2017 10:44:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Jt9qM8VsCR15aaAVkXSQdFxXwg0=; b=U9iRal Ze8airIY/t7gnzN85RnsvSKJ9a9HUt71l2fXZ/V0UeAx8nvPUrZp2/R37d5FpNri E52fzcDsfYZoFWMK+LKWBP/98UHqxbeBKvrM6Dn+dUBaA5JVDzSa+dYr+mt+tl2j wzJBgB9OShNb1Ec8PnGsTgZJuCPLXB3r1MlFk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=QyxsqzBdaxCTtIjyTdb5UyhvHCA2Xkdq z/uLExkqg/30OkRXCeLebcJ6oB/AYPrgSqVG7jkr0ME3uGieNK9xUlikRx/JMRLG LVjy7SCSI0uDh4Gc4o9Rrk7/dB13TyDDCiwhGnfygUyNnQEBI1OYUAgcsPLGiMaa TGOF8InrBJo= Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id B8C6C69B24; Tue, 14 Mar 2017 10:44:21 -0400 (EDT) Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id D70A669B23; Tue, 14 Mar 2017 10:44:20 -0400 (EDT) From: Andy Wingo References: <87bmttw8cv.fsf@pobox.com> Date: Tue, 14 Mar 2017 15:44:13 +0100 In-Reply-To: (Freja Nordsiek's message of "Tue, 14 Mar 2017 15:25:42 +0100") Message-ID: <87lgs77waq.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B59CEE4A-08C4-11E7-9D3C-B667064AB293-02397024!pb-sasl1.pobox.com X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue 14 Mar 2017 15:25, Freja Nordsiek writes: > Found a bug in the modifications you made. Sorry for not catching this > before it got included into the Guile 2.1.8 release. Thank you! Applied. Note that in the gnu coding standards you need an entry in the commit log for every file you modify. Blah, I know, but that's how it is. Andy