GNU bug report logs - #24649
24.5; Why no standard error for "Trailing garbage following expression"?

Previous Next

Full log

Message #13 received at 24649 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 24649 <at> debbugs.gnu.org
Subject: Re: bug#24649: 24.5; Why no standard error for "Trailing garbage
 following expression"?
Date: Fri, 23 Aug 2019 02:25:37 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Drew Adams <drew.adams <at> oracle.com> writes:
>
>> Shouldn't this error be a standard error?  If not a new standard error,
>> shouldn't it at least use one of the existing standard errors, such as
>> `scan-error' or `invalid-read-syntax'?
>>
>> Otherwise, how to easily handle this error (e.g., to tell the user to
>> correct the input being read and then read again)?
>
> Makes sense to me.  I'm not sure what signal to use, though -- anybody
> got an idea?

[...]

> +	    xsignal1 (Qinvalid_read_syntax,
> +		      build_string ("Trailing garbage following expression"));

There weren't any comments, so I've now applied this.  If somebody has a
better idea for the error signal, please amend.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.