GNU bug report logs - #24639
26.0.50; Terminal paste doesn't work right in term char mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24639 in the body.
You can then email your comments to 24639 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Terminal paste doesn't work right in term char mode
Date: Fri, 07 Oct 2016 20:02:45 +0200

In a GNOME Terminal window, run

emacs -nw -Q -f term

RET to start the terminal.  Make sure it's in char mode.  Select
some text in another X window.  Go back to the Emacs term buffer, press
middle click, then press RET.
Expected behavior: Selected text gets inserted and interpreted as shell
command.
Actual behavior in Emacs 24.3: Expected behavior.
Actual behavior in Emacs built from master branch: Selected text gets
inserted, but not interpreted as shell command (i.e. nothing happens
after pressing RET).

This appears to be a regression, possibly caused by
bracketed-paste-mode.


In GNU Emacs 26.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-10-07 built on localhost
Repository revision: d48369db9c97b6f2accf702e5bbe0bda11cb92a1
Windowing system distributor 'The X.Org Foundation', version 11.0.11702000
System Description:	Ubuntu 14.04 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib
dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec
password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 97221 7197)
 (symbols 48 20242 0)
 (miscs 40 330 118)
 (strings 32 17818 3448)
 (string-bytes 1 578527)
 (vectors 16 13700)
 (vector-slots 8 448602 7351)
 (floats 8 181 64)
 (intervals 56 190 0)
 (buffers 976 11)
 (heap 1024 48904 1169))

Message #8 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp <p.stephani2 <at> gmail.com>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50;
 Terminal paste doesn't work right in term char mode
Date: Fri, 07 Oct 2016 22:05:35 +0300

> From: Philipp <p.stephani2 <at> gmail.com>
> Date: Fri, 07 Oct 2016 20:02:45 +0200
> 
> emacs -nw -Q -f term
> 
> RET to start the terminal.  Make sure it's in char mode.  Select
> some text in another X window.  Go back to the Emacs term buffer, press
> middle click, then press RET.
> Expected behavior: Selected text gets inserted and interpreted as shell
> command.
> Actual behavior in Emacs 24.3: Expected behavior.
> Actual behavior in Emacs built from master branch: Selected text gets
> inserted, but not interpreted as shell command (i.e. nothing happens
> after pressing RET).
> 
> This appears to be a regression, possibly caused by
> bracketed-paste-mode.

Does it help to disable the bracketed-paste-mode in term.el?

Message #11 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Fri, 07 Oct 2016 19:19:28 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Fr., 7. Okt. 2016 um 21:05 Uhr:

> > From: Philipp <p.stephani2 <at> gmail.com>
> > Date: Fri, 07 Oct 2016 20:02:45 +0200
> >
> > emacs -nw -Q -f term
> >
> > RET to start the terminal.  Make sure it's in char mode.  Select
> > some text in another X window.  Go back to the Emacs term buffer, press
> > middle click, then press RET.
> > Expected behavior: Selected text gets inserted and interpreted as shell
> > command.
> > Actual behavior in Emacs 24.3: Expected behavior.
> > Actual behavior in Emacs built from master branch: Selected text gets
> > inserted, but not interpreted as shell command (i.e. nothing happens
> > after pressing RET).
> >
> > This appears to be a regression, possibly caused by
> > bracketed-paste-mode.
>
> Does it help to disable the bracketed-paste-mode in term.el?
>

Yes, uncommenting (xterm--init-bracketed-paste-mode) in term/xterm.el fixes
the issue. Maybe M-x term should temporarily bracketed paste mode when in
char mode.

[Message part 2 (text/html, inline)]

Message #14 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Fri, 07 Oct 2016 22:25:00 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Fri, 07 Oct 2016 19:19:28 +0000
> Cc: 24639 <at> debbugs.gnu.org
> 
> Maybe M-x term should temporarily bracketed paste mode when in char
> mode.

That's what I was trying to suggest.  Does this have downsides?

Message #17 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Fri, 07 Oct 2016 20:19:47 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Fr., 7. Okt. 2016 um 21:25 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Fri, 07 Oct 2016 19:19:28 +0000
> > Cc: 24639 <at> debbugs.gnu.org
> >
> > Maybe M-x term should temporarily bracketed paste mode when in char
> > mode.
>
> That's what I was trying to suggest.  Does this have downsides?
>

I wouldn't expect any. Bracketed paste mode is a bit faster, but running a
bit slower is better than not working at all.

[Message part 2 (text/html, inline)]

Message #20 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Sat, 08 Oct 2016 08:27:19 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Fri, 07 Oct 2016 20:19:47 +0000
> Cc: 24639 <at> debbugs.gnu.org
> 
>  > Maybe M-x term should temporarily bracketed paste mode when in char
>  > mode.
> 
>  That's what I was trying to suggest. Does this have downsides?
> 
> I wouldn't expect any. Bracketed paste mode is a bit faster, but running a bit slower is better than not working
> at all. 

Then please push such a change to the emacs-25 branch.

Thanks.

Message #23 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Sun, 09 Oct 2016 20:48:59 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Sa., 8. Okt. 2016 um 07:27 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
>
> > Date: Fri, 07 Oct 2016 20:19:47 +0000
>
> > Cc: 24639 <at> debbugs.gnu.org
>
> >
>
> >  > Maybe M-x term should temporarily bracketed paste mode when in char
>
> >  > mode.
>
> >
>
> >  That's what I was trying to suggest. Does this have downsides?
>
> >
>
> > I wouldn't expect any. Bracketed paste mode is a bit faster, but running
> a bit slower is better than not working
>
> > at all.
>
>
>
> Then please push such a change to the emacs-25 branch.
>
>
>
Unfortunately it's not that simple: Bracketed paste more should only be
disabled when a term buffer is active on an xterm and in char mode. So this
will probably require an addition to window-configuration-change-hook or
similar.

[Message part 2 (text/html, inline)]

Message #26 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Mon, 10 Oct 2016 08:56:16 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sun, 09 Oct 2016 20:48:59 +0000
> Cc: 24639 <at> debbugs.gnu.org
> 
>  > > Maybe M-x term should temporarily bracketed paste mode when in char
>  > > mode.
>  >
>  > That's what I was trying to suggest. Does this have downsides?
>  >
>  > I wouldn't expect any. Bracketed paste mode is a bit faster, but running a bit slower is better than not
>  working
>  > at all.
> 
>  Then please push such a change to the emacs-25 branch.
> 
> Unfortunately it's not that simple: Bracketed paste more should only be disabled when a term buffer is active
> on an xterm and in char mode. So this will probably require an addition to window-configuration-change-hook
> or similar.

Sorry, I don't understand the reasons for the complication.  The "in
char mode" part was already on the table when we discussed this
previously.  Presumably, there's a function in term-mode which
switches to and from char mode, and that function should turn
bracketed paste mode on or off, accordingly.  Is that right?

For the "term buffer is active" part, do you mean re-enable the
bracketed paste mode when the user switches to another buffer?  If so,
won't it be easier, simpler, and more reliable to do that in a
post-command-hook?

Or maybe it's easier to arrange for xterm-paste to realize the current
buffer is in term char mode, and do the "normal" paste part?  Is that
possible?

Message #29 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Sat, 15 Oct 2016 13:25:18 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Mo., 10. Okt. 2016 um 07:56 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
>
> > Date: Sun, 09 Oct 2016 20:48:59 +0000
>
> > Cc: 24639 <at> debbugs.gnu.org
>
> >
>
> >  > > Maybe M-x term should temporarily bracketed paste mode when in char
>
> >  > > mode.
>
> >  >
>
> >  > That's what I was trying to suggest. Does this have downsides?
>
> >  >
>
> >  > I wouldn't expect any. Bracketed paste mode is a bit faster, but
> running a bit slower is better than not
>
> >  working
>
> >  > at all.
>
> >
>
> >  Then please push such a change to the emacs-25 branch.
>
> >
>
> > Unfortunately it's not that simple: Bracketed paste more should only be
> disabled when a term buffer is active
>
> > on an xterm and in char mode. So this will probably require an addition
> to window-configuration-change-hook
>
> > or similar.
>
>
>
> Sorry, I don't understand the reasons for the complication.  The "in
>
> char mode" part was already on the table when we discussed this
>
> previously.  Presumably, there's a function in term-mode which
>
> switches to and from char mode, and that function should turn
>
> bracketed paste mode on or off, accordingly.  Is that right?
>
>
>
>
The complication arises because char-mode is per-buffer, but bracketed
paste mode is per terminal. I've attached a patch now.

[Message part 2 (text/html, inline)]

[0001-Disable-bracketed-paste-in-a-terminal-in-char-mode.txt (text/plain, attachment)]

Message #32 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Sat, 15 Oct 2016 17:31:01 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sat, 15 Oct 2016 13:25:18 +0000
> Cc: 24639 <at> debbugs.gnu.org
> 
> The complication arises because char-mode is per-buffer, but bracketed paste mode is per terminal. I've
> attached a patch now. 

Frankly, I hoped for a simpler solution that doesn't involve so much
non-trivial code.

I plan to release Emacs 25.2 very soon, like in a few weeks.  If you
are okay with installing this on the release branch given that
schedule, please go ahead.

Thanks.

Message #35 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Sat, 15 Oct 2016 14:38:57 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Sa., 15. Okt. 2016 um 16:31 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
>
> > Date: Sat, 15 Oct 2016 13:25:18 +0000
>
> > Cc: 24639 <at> debbugs.gnu.org
>
> >
>
> > The complication arises because char-mode is per-buffer, but bracketed
> paste mode is per terminal. I've
>
> > attached a patch now.
>
>
>
> Frankly, I hoped for a simpler solution that doesn't involve so much
>
> non-trivial code.
>
>
>
> I plan to release Emacs 25.2 very soon, like in a few weeks.  If you
>
> are okay with installing this on the release branch given that
>
> schedule, please go ahead.
>
>
>
I can also install it on master, if you prefer that.

[Message part 2 (text/html, inline)]

Message #38 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50; Terminal paste doesn't work right in term
 char mode
Date: Sat, 15 Oct 2016 18:07:08 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sat, 15 Oct 2016 14:38:57 +0000
> Cc: 24639 <at> debbugs.gnu.org
> 
>  Frankly, I hoped for a simpler solution that doesn't involve so much
>  non-trivial code.
>  I plan to release Emacs 25.2 very soon, like in a few weeks. If you
>  are okay with installing this on the release branch given that
>  schedule, please go ahead.
> 
> I can also install it on master, if you prefer that. 

I'm okay with installing this on master, but I'd like _some_ solution
on the release branch, because I think it's unreasonable to let users
live with this problem until v26.1 is released.

Message #41 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: eliz <at> gnu.org
Cc: 24639 <at> debbugs.gnu.org
Subject: Re: bug#24639: 26.0.50;
 Terminal paste doesn't work right in term char mode
Date: Sun,  6 Nov 2016 19:43:04 +0100

I've finally managed to implement a simpler solution for this.

Message #44 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: eliz <at> gnu.org
Cc: Philipp Stephani <phst <at> google.com>, 24639 <at> debbugs.gnu.org
Subject: [PATCH] Send text received by bracketed paste to process
Date: Sun,  6 Nov 2016 19:43:05 +0100

From: Philipp Stephani <phst <at> google.com>

Fixes #24639

* term.el (term--xterm-paste): New function.
(term-raw-map): Use it.
(xterm--pasted-text): Declare function from xterm.el.
---
 lisp/term.el | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lisp/term.el b/lisp/term.el
index 993e580..18d6775 100644
--- a/lisp/term.el
+++ b/lisp/term.el
@@ -845,6 +845,7 @@ term-raw-map
     (define-key map [S-insert] 'term-paste)
     (define-key map [prior] 'term-send-prior)
     (define-key map [next] 'term-send-next)
+    (define-key map [xterm-paste] #'term--xterm-paste)
     map)
   "Keyboard map for sending characters directly to the inferior process.")
 
@@ -1211,6 +1212,13 @@ term-paste
   (interactive)
    (term-send-raw-string (current-kill 0)))
 
+(defun term--xterm-paste ()
+  "Insert the text pasted in an XTerm bracketed paste operation."
+  (interactive)
+  (term-send-raw-string (xterm--pasted-text)))
+
+(declare-function xterm--pasted-text "term/xterm" ())
+
 ;; Which would be better:  "\e[A" or "\eOA"? readline accepts either.
 ;; For my configuration it's definitely better \eOA but YMMV. -mm
 ;; For example: vi works with \eOA while elm wants \e[A ...
-- 
2.10.1

Message #47 received at 24639 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: phst <at> google.com, 24639 <at> debbugs.gnu.org
Subject: Re: [PATCH] Send text received by bracketed paste to process
Date: Mon, 07 Nov 2016 20:35:47 +0200

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Cc: 24639 <at> debbugs.gnu.org,
> 	Philipp Stephani <phst <at> google.com>
> Date: Sun,  6 Nov 2016 19:43:05 +0100
> 
> From: Philipp Stephani <phst <at> google.com>
> 
> Fixes #24639
> 
> * term.el (term--xterm-paste): New function.
> (term-raw-map): Use it.
> (xterm--pasted-text): Declare function from xterm.el.

Thanks.  If there are no further comments in a few days, please push
to emacs-25.

Message #52 received at 24639-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: phst <at> google.com, 24639-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Send text received by bracketed paste to process
Date: Thu, 10 Nov 2016 21:57:35 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Mo., 7. Nov. 2016 um 19:35 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Cc: 24639 <at> debbugs.gnu.org,
> >       Philipp Stephani <phst <at> google.com>
> > Date: Sun,  6 Nov 2016 19:43:05 +0100
> >
> > From: Philipp Stephani <phst <at> google.com>
> >
> > Fixes #24639
> >
> > * term.el (term--xterm-paste): New function.
> > (term-raw-map): Use it.
> > (xterm--pasted-text): Declare function from xterm.el.
>
> Thanks.  If there are no further comments in a few days, please push
> to emacs-25.
>

Pushed.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.