GNU bug report logs - #24635
24.5; Missing preview of entered unicode codepoints (C-q codepoint SPC)

Previous Next

Full log

Message #19 received at 24635 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 24635 <at> debbugs.gnu.org, qqwy <at> gmx.com
Subject: Re: bug#24635: 24.5;
 Missing preview of entered unicode codepoints (C-q codepoint SPC)
Date: Mon, 21 Nov 2016 18:54:12 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: qqwy <at> gmx.com,  24635 <at> debbugs.gnu.org
> Date: Mon, 21 Nov 2016 11:26:43 -0500
> 
> > Stefan, do you see a way to make read-key or the functions it calls
> > echo the input characters?  I didn't see a way to do that, but maybe I
> > missed something.
> 
> Hmm... it would be good to find such a way, indeed, since the issue is
> likely to show at other places where we'd want to use read-key.

Agreed.

> > Failing that, I'm inclined to go back to using read-event in
> > read-quoted-char.  After all, we didn't have any bug reports due to
> > that, and the echo is a valuable feature, IMO.
> 
> Indeed, the scenarios where read-key is preferable to read-event in the
> context of read-quoted-char are fairly hypothetical.
> 
> So, we should probably revert that for now, but adding a comment about
> why we don't use read-key.

OK, will do in a couple of days if no one objects.

The commit I pointed to made 2 more changes in read-quoted-char,
related to the way unread-command-events is set.  I understand that
those two changes also need to be reverted when we go back to using
read-event, right?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.