From unknown Sat Sep 06 14:23:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24620 <24620@debbugs.gnu.org> To: bug#24620 <24620@debbugs.gnu.org> Subject: Status: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters Reply-To: bug#24620 <24620@debbugs.gnu.org> Date: Sat, 06 Sep 2025 21:23:58 +0000 retitle 24620 26.0.50; In dired: 'dired-do-compress-to' fails when filename= s cotains space characters reassign 24620 emacs submitter 24620 Jos=C3=A9 L. Dom=C3=A9nech severity 24620 minor tag 24620 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 05 03:06:49 2016 Received: (at submit) by debbugs.gnu.org; 5 Oct 2016 07:06:49 +0000 Received: from localhost ([127.0.0.1]:45143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brgHw-0004ro-Rr for submit@debbugs.gnu.org; Wed, 05 Oct 2016 03:06:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brgHv-0004rb-Ry for submit@debbugs.gnu.org; Wed, 05 Oct 2016 03:06:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brgHp-0001XX-7J for submit@debbugs.gnu.org; Wed, 05 Oct 2016 03:06:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_50,FORGED_YAHOO_RCVD, FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brgHp-0001XR-4R for submit@debbugs.gnu.org; Wed, 05 Oct 2016 03:06:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brgHm-00054y-RP for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2016 03:06:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brgHg-0001Wa-Of for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2016 03:06:37 -0400 Received: from nm36-vm8.bullet.mail.bf1.yahoo.com ([72.30.239.70]:48719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brgHg-0001WT-JR for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2016 03:06:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1475651191; bh=0T7btXdsU+vJ1IaA8JMsFOz7o4nEIMu8vbDxeBshGdA=; h=Date:From:To:Subject:From:Subject; b=c3Sri6/GmU/QSqe1ye6skQ10FlS9dZHGorKrFwZfvLR5XerkUa44qMggw5VoFli3JXod3EjqOnmDBI41MaQITGO7OJhsPP7lN5ZZToecAG+U+7wEJaeW4muGLfoV7fOwVeSGfxs/3oiX+pd2guGcHe1JYQIZfb55nVxlNoTmq4dHtFGSf2MeFzx/1XhqMRxe9O7aSovMHADfLfWdSfixtfdJeebhCyNEs06l+b1O7S1A1cHuVlZ1VjiMa4PrMpD+apGo0DDfJiFxZOSc5jacF7kvO3sA6sfHYkBggghKaGxQRpLTncSz5za0/mv5hXSTDpSBTtSlyDnKadyEle1hcA== Received: from [98.139.170.181] by nm36.bullet.mail.bf1.yahoo.com with NNFMP; 05 Oct 2016 07:06:31 -0000 Received: from [98.139.213.13] by tm24.bullet.mail.bf1.yahoo.com with NNFMP; 05 Oct 2016 07:06:31 -0000 Received: from [127.0.0.1] by smtp113.mail.bf1.yahoo.com with NNFMP; 05 Oct 2016 07:06:31 -0000 X-Yahoo-Newman-Id: 46647.98693.bm@smtp113.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: kHnL4gIVM1lkNDle760pvejs2FB6itP9CB_8BXRcKNTBHve FbKXJUbSdxHLwFjPiyta5YJvKpkb_Ty.6Zmog7QI461luD.hbZWI6omkycDZ uF6mRWqqtnqNMsI8y5r.Efp8iGbhD93CH0.KdfvUWUvoJvnL58wEdxjXpUPs n6fPy01USpXC3c0uFrrvA_uSev6AIk1JXDP0WBKD6Jn33DgP4BJt.16Jpqo_ XmiLvmKa3a4JkRIeLgpULHaIaJ0F10kPo71lvUdph9KEC7V0aNnjK9RObGPA nQDjLOq6C5PkABy9VuKyKu4ftICbpqajsDE42TnaQgLZRbfTRwavnI_ru3s3 fF..fNKqx.Wo55kJsJY2Sdjjz8KzBXpRV_fp8pHoyCX7t7G2wBqZPT57VkTM wQAdzFNeO6qRfDdgRmKiGgdptW0ifCqEOsocSCpt32Tlv0.u3GJ0AR3wAW_. K_9._iQ8GP91mt6hGNdQBQxMZWpK7S_t5LDCLFBT7VCJNh3Xpu88JcYO1M7f xHd20.IjL6MPqDbsGp.kLsuTkGryoMLCjFknPcQj9Nu7a3OZOaOB43lW7Eg- - X-Yahoo-SMTP: n.2qYIGswBDQvroAqXRDXOU9h7L9IqL3Jg-- Date: Wed, 05 Oct 2016 09:06:29 +0200 Message-ID: <87ponfi8ay.wl-j_l_domenech@yahoo.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: bug-gnu-emacs@gnu.org Subject: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) 1) C-x d ;; Open a directory in dired mode 2) ;; Mark any file/s whose filenames contains space characters 3) c ;; run dired-do-compress-to 4) kk.tar.gz ;; Enter a name for the file output (the output type seems irrelevant) 5) g ;; refresh dired Check that a 45 bytes size file has been created. Note that it is not a valid compressed file ;). Thankful for your amazing work: Jos=E9 L. Dom=E9nech In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30) of 2016-10-03 built on jose-ThinkPad-Edge-E330 Repository revision: 8cd975cebd588d5435fa2b333dba6c526e602933 Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: Linux Mint 18 Sarah Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Compressed 1 file(s) to rsefsosf.webm.tar.gz Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LANG: es_ES.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-seq dired-aux cl-loaddefs pcase cl-lib dired dired-loaddefs time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 101053 10054) (symbols 48 20412 0) (miscs 40 44 136) (strings 32 17874 3826) (string-bytes 1 567807) (vectors 16 13601) (vector-slots 8 448903 4223) (floats 8 184 163) (intervals 56 281 0) (buffers 976 13) (heap 1024 20269 1028)) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 11:43:25 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 15:43:25 +0000 Received: from localhost ([127.0.0.1]:60918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzmpx-0007Ly-0Y for submit@debbugs.gnu.org; Thu, 27 Oct 2016 11:43:25 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzlHf-00055a-BE for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 10:03:55 -0400 Received: by mail-wm0-f53.google.com with SMTP id n67so44822938wme.1 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 07:03:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:newsgroups:subject :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=btIMEgLt/9q48xf7+gQJsn4WSo/IOUAEUGVQHOja9Bk=; b=Kw/R1114v3HXamQfFzHbmsMCPxyhPCgjA5bILZHrJBmTDc3lZUZ/f1FIFaFrZo0mBj iNiCG+dROcyuPvT9thYmo3Umv0Bx8uz8gZDgpQ+5FRu3wsorogH9+j3H+XFWAvqtTGuU q22IVATRATU4fE3XNYtbv8tX1kkbZ7kvKXSpNXWGK49fA6+tMelR9U2ttEzqe00KQKIO rTi5e93V6R5R0JMrE6OAW5tL5QRgiYOqgeeArtGouxBplaxjS4YVPBanlFCdxf6bV79S YmsBv/NZoi2eUErSj1hNmuPBqabZgNgaXmOe4+5VC85ostHnAiPRWv3+8X/f0knIuuq4 /CWQ== X-Gm-Message-State: ABUngvd+AiCg8FR00KLHw9NA1/wPzFiaCn+YqI11q7oVY5vRNYxLZMOgsPZfHWzgzt5XGQ== X-Received: by 10.194.68.106 with SMTP id v10mr7149635wjt.149.1477577029368; Thu, 27 Oct 2016 07:03:49 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id wh3sm8635386wjb.49.2016.10.27.07.03.48 for <24620@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 07:03:48 -0700 (PDT) Date: Thu, 27 Oct 2016 16:03:47 +0200 Message-ID: <878tt9zy64.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: 24620@debbugs.gnu.org Newsgroups: gmane.emacs.bugs Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87ponfi8ay.wl-j_l_domenech@yahoo.com> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Thu_Oct_27_16:03:47_2016-1" Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 X-Mailman-Approved-At: Thu, 27 Oct 2016 11:43:23 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Multipart_Thu_Oct_27_16:03:47_2016-1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I wrote a little patch to get a workaround around dired having some trouble= compressing files with space characters in its name (bug #24620). I am not sure if this will useful to someone. Please NOTE that I am using a= postrophes to surround the file name's. While it works on my system (GNU/Li= nux) it could not work on other systems. Best Regards: Jos=E9 L. Dom=E9nech --Multipart_Thu_Oct_27_16:03:47_2016-1 Content-Type: text/plain; type=patch; name="dired-aux.el.patch"; charset=US-ASCII Content-Disposition: attachment; filename="dired-aux.el.patch" Content-Transfer-Encoding: 8bit diff -u dired-aux.el dired-aux-mod.el --- dired-aux.el 2016-10-27 15:50:50.428634418 +0200 +++ dired-aux-mod.el 2016-10-27 15:49:07.075635431 +0200 @@ -974,10 +974,10 @@ ARGS are command switches passed to PROGRAM.") (defvar dired-compress-files-alist - '(("\\.tar\\.gz\\'" . "tar -c %i | gzip -c9 > %o") - ("\\.tar\\.bz2\\'" . "tar -c %i | bzip2 -c9 > %o") - ("\\.tar\\.xz\\'" . "tar -c %i | xz -c9 > %o") - ("\\.zip\\'" . "zip %o -r --filesync %i")) + '(("\\.tar\\.gz\\'" . "tar -c %i | gzip -c9 > '%o'") + ("\\.tar\\.bz2\\'" . "tar -c %i | bzip2 -c9 > '%o'") + ("\\.tar\\.xz\\'" . "tar -c %i | xz -c9 > '%o'") + ("\\.zip\\'" . "zip '%o' -r --filesync %i")) "Control the compression shell command for `dired-do-compress-to'. Each element is (REGEXP . CMD), where REGEXP is the name of the @@ -1015,7 +1015,9 @@ (replace-regexp-in-string "%o" out-file (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") + "%i" (mapconcat (lambda (file-desc) + (concat "'" + (file-name-nondirectory file-desc) "'")) in-files " ") (cdr rule))))) (message "Compressed %d file(s) to %s" (length in-files) Diff finished. Thu Oct 27 15:53:44 2016 --Multipart_Thu_Oct_27_16:03:47_2016-1 Content-Type: text/plain; charset=US-ASCII --Multipart_Thu_Oct_27_16:03:47_2016-1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 13:19:43 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 17:19:43 +0000 Received: from localhost ([127.0.0.1]:60995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzoL9-00017M-6t for submit@debbugs.gnu.org; Thu, 27 Oct 2016 13:19:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzoL8-00017A-B9 for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 13:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzoKy-00061j-AC for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 13:19:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzoKy-00061d-6p; Thu, 27 Oct 2016 13:19:32 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3291 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bzoKx-0005ah-CX; Thu, 27 Oct 2016 13:19:31 -0400 Date: Thu, 27 Oct 2016 20:19:35 +0300 Message-Id: <837f8tu2u0.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?Jos=E9?= L. =?iso-8859-1?Q?Dom=E9nech?= In-reply-to: <878tt9zy64.wl-domenechjosel@gmail.com> Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Thu, 27 Oct 2016 16:03:47 +0200 > From: José L. Doménech > > > I wrote a little patch to get a workaround around dired having some trouble compressing files with space characters in its name (bug #24620). Thanks. > I am not sure if this will useful to someone. Please NOTE that I am using apostrophes to surround the file name's. While it works on my system (GNU/Linux) it could not work on other systems. I suggest to use shell-quote-argument for that, because that function already supports all the systems where Emacs can be built. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 13:34:59 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 17:34:59 +0000 Received: from localhost ([127.0.0.1]:32772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzoZu-0001UA-SO for submit@debbugs.gnu.org; Thu, 27 Oct 2016 13:34:58 -0400 Received: from mout.gmx.net ([212.227.15.15]:63776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzoZt-0001Tw-B6 for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 13:34:57 -0400 Received: from detlef.gmx.de ([87.146.62.26]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MWC9x-1cOIWx0z6H-00XHeT; Thu, 27 Oct 2016 19:34:50 +0200 From: Michael Albinus To: =?utf-8?Q?Jos=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech?= Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> Date: Thu, 27 Oct 2016 19:34:49 +0200 In-Reply-To: <878tt9zy64.wl-domenechjosel@gmail.com> (=?utf-8?Q?=22Jos?= =?utf-8?Q?=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech=22's?= message of "Thu, 27 Oct 2016 16:03:47 +0200") Message-ID: <87funhd7ba.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:nLFzODqTmTVV699QKV6xZ1cfrPGAH3jhg/VNi0gqT+u/LFhkBjY HOxRg3GfhtT2iKwas9UnaM8hS31QMdKHtTHtzul9oY/YtHo9Odu+JmhTFXKH87vEJILOlyA 9Ksc5Op6DCPm7nKSxX3jxnLhkvWDdenMuXJTpfL91SFqM6u/346ARSU9NiretUlD2RbktI/ Rbtt+zTf6nsJJ1X9Tsdag== X-UI-Out-Filterresults: notjunk:1;V01:K0:01dA7zKIHrk=:qXh05na6yzixsFiUPlBT7j 66uBGuIUrkTWMdbDnDAq+kuV4xGScEoBQ16BihYDwuXuOcBoOediN2hbh6ixdTvjM7lUQfUqK 1vm+NYGA/7xyaWEwGcQ4/+FjPvyovqDANEAGhAxMl4Cd13yPBzYXG6+ejBlsxluMXLbtmWbt4 fbRkdfv/XihdaitbH2z43URuC4cU/Y4ePkAw8jzulDxZN6q0G0iW44mPkM9S2N4VWNKzMsRKg 1cHH928YfrxvJY03v671psBrv4ytbdEsnU2YtZ5Gagc3kjREpUPykyWT5rLVib6mWTtHKSb3A u5hd+mghQyhmJ6U3mb1ySc/Rym4JRT1FaGtP+r7mzZ/rrYxk7cO/rB96mRK9Io+NDHfbMZkeJ YjynG+tNmXbfFlfXGx2SP62oZF5DPhZtOTVX+qopVEOOqf0JigZv/7yjlqL/jg3c33aiI8G9G b8Ljmuol4oz1JNKxP7easMMsW0ndFE6dXwSsR4L97SXBX0OYd8+wzLQPh+Pega9/Y9GL07FDJ uy16o62J2n9yGo6D+lAn0Sgm+AoM4UCu5hmedX5U7PHTXj9VJB6k+RDpkXxN7XPIeJEeaVxGn HL4bUlx1E1xwOzILBr+oiy92ISAZ6C0ZPN0T2vZevYJut5lCWE4h8SivoNJTR999eV+LRIfiP duJPUzC1nAEWgJyPRcBKxAsmRccHSwEhX/lZIhDoi5srmFG8HxyGJuzqVmYG4rzoY+YTeUkAU Eh4sMFPJZtTOXXlv4nbx2xLmNUMmVH0G92DO7PofQyrhCLo8fb6UfHs7fSf5JMo5DXbt1pJQn /X7wxiX X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jos=C3=A9 L. Dom=C3=A9nech writes: Hi Jos=C3=A9, > I wrote a little patch to get a workaround around dired having some > trouble compressing files with space characters in its name (bug > #24620). Thanks for this! > I am not sure if this will useful to someone. Please NOTE that I am > using apostrophes to surround the file name's. While it works on my > system (GNU/Linux) it could not work on other systems. I believe it is better not to touch `dired-compress-files-alist'. Instead, at places where "%i and %o are replaced, one shall call `shell-quote-argument', as it is applied already in `dired-compress-file'. > Best Regards: > Jos=C3=A9 L. Dom=C3=A9nech Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 14:39:45 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 18:39:46 +0000 Received: from localhost ([127.0.0.1]:32824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzpab-0004cF-NP for submit@debbugs.gnu.org; Thu, 27 Oct 2016 14:39:45 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzpaa-0004c4-5v for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 14:39:44 -0400 Received: by mail-wm0-f43.google.com with SMTP id 140so37195116wmv.0 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 11:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=U0bdwklmapp/+mOA+r5/CI4CLSPgQGit6IcL/9eIIFI=; b=hR47BvVC2ubp1N7mAIbYhilen8RXry4qG9JX8EkUKOPx50sPjNhwuWxCOR66pDbZ2x wc4vCbGtwL6j9Fl32TsMJl6xaOKONztTb9rNVw1Q3mTw7fN/EtLNpRGG95dZD6XLKGUx KRBbN78X20y68Bp/RNv5jDSho2nI3Nm2K/yGMRlWGoU2+CcYD7IdhxWhbgSTjw0IXlD9 Bru7l74mStKu3osZq8BBT0qJ+bEGmDPFgicjs+K3bB4MVJJ7CuFZCovho2RUPtOE8R5O 56DaiqHUkUlmaMyGYnIxWzUL8eNJ4dWyBTS7iys+ddrJU5S6KEBGhEQgK2NqIWxvslYT 0mng== X-Gm-Message-State: ABUngvcdses4XRKUxDdTE5XKhaU2jZOWbysnmUUGNim6JXezFrIuYsll1HkxYmHcDMZYZw== X-Received: by 10.28.193.129 with SMTP id r123mr142432wmf.12.1477593574134; Thu, 27 Oct 2016 11:39:34 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id au8sm9922042wjc.12.2016.10.27.11.39.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 11:39:33 -0700 (PDT) Date: Thu, 27 Oct 2016 20:39:32 +0200 Message-ID: <87bmy5bpqz.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: Michael Albinus , Eli Zaretskii Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87funhd7ba.fsf@gmx.de> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: base64 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, "=?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) T24gVGh1LCAyNyBPY3QgMjAxNiAxOTozNDo0OSArMDIwMCwNCk1pY2hhZWwgQWxiaW51cyB3cm90 ZToNCj4gDQo+IEpvc6imIEwuIERvbaimbmVjaCA8ZG9tZW5lY2hqb3NlbEBnbWFpbC5jb20+IHdy aXRlczoNCj4gDQo+IEhpIEpvc6imLA0KPiANCj4gPiBJIHdyb3RlIGEgbGl0dGxlIHBhdGNoIHRv IGdldCBhIHdvcmthcm91bmQgYXJvdW5kIGRpcmVkIGhhdmluZyBzb21lDQo+ID4gdHJvdWJsZSBj b21wcmVzc2luZyBmaWxlcyB3aXRoIHNwYWNlIGNoYXJhY3RlcnMgaW4gaXRzIG5hbWUgKGJ1Zw0K PiA+ICMyNDYyMCkuDQo+IA0KPiBUaGFua3MgZm9yIHRoaXMhDQo+IA0KPiA+IEkgYW0gbm90IHN1 cmUgaWYgdGhpcyB3aWxsIHVzZWZ1bCB0byBzb21lb25lLiBQbGVhc2UgTk9URSB0aGF0IEkgYW0N Cj4gPiB1c2luZyBhcG9zdHJvcGhlcyB0byBzdXJyb3VuZCB0aGUgZmlsZSBuYW1lJ3MuIFdoaWxl IGl0IHdvcmtzIG9uIG15DQo+ID4gc3lzdGVtIChHTlUvTGludXgpIGl0IGNvdWxkIG5vdCB3b3Jr IG9uIG90aGVyIHN5c3RlbXMuDQo+IA0KPiBJIGJlbGlldmUgaXQgaXMgYmV0dGVyIG5vdCB0byB0 b3VjaCBgZGlyZWQtY29tcHJlc3MtZmlsZXMtYWxpc3QnLiBJbnN0ZWFkLA0KPiBhdCBwbGFjZXMg d2hlcmUgIiVpIGFuZCAlbyBhcmUgcmVwbGFjZWQsIG9uZSBzaGFsbCBjYWxsDQo+IGBzaGVsbC1x dW90ZS1hcmd1bWVudCcsIGFzIGl0IGlzIGFwcGxpZWQgYWxyZWFkeSBpbiBgZGlyZWQtY29tcHJl c3MtZmlsZScuDQo+DQoNCkkgYW0gZ2V0dGluZyBhICJyZXBsYWNlLXJlZ2V4cC1pbi1zdHJpbmc6 IEludmFsaWQgdXNlIG9mIKGuXKGvIGluIHJlcGxhY2VtZW50IHRleHQiDQplcnJvciB1c2luZyAn c2hlbGwtcXVvdGUtYXJndW1lbnQnIG9uIHRoaXMgY2FzZS4NCg0KSXQgc2VlbXMgdGhhdCAnc2hl bGwtcXVvdGVkLWFyZ3VtZW50JyBpcyBhZGRpbmcgZG91YmxlICdcJywgdGhhdCBpcywNCidcXCcs IGluIGZyb250IG9mIHRoZSBzcGFjZXMgaW5zdGVhZCBvZiBzdXJyb3VuZGluZyB0aGUgYXJndW1l bnQgd2l0aCBxdW90ZXMuDQoNCkFuZCAncmVwbGFjZS1tYXRjaCcgd2hpY2ggaXMgY2FsbGVkIGJ5 ICdyZXBsYWNlLXJlZ2V4cC1pbi1zdHJpbmcnIGZvciB0aGUgcGFyYW1ldGVyDQpzdWJzdGl0dXRp b24gKCIlaSIsICIlbyIpIGluIHRoZSBmdW5jdGlvbiAnZGlyZWQtZG8tY29tcHJlc3MtdG8nIGRv ZXNuJ3QgbGlrZSBpdC4NCiAgDQo+ID4gQmVzdCBSZWdhcmRzOg0KPiA+IEpvc6imIEwuIERvbaim bmVjaA0KPiANCj4gQmVzdCByZWdhcmRzLCBNaWNoYWVsLg0K From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 14:51:22 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 18:51:23 +0000 Received: from localhost ([127.0.0.1]:32828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzplq-0004sj-PN for submit@debbugs.gnu.org; Thu, 27 Oct 2016 14:51:22 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:33806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzplp-0004sX-CM for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 14:51:21 -0400 Received: by mail-oi0-f51.google.com with SMTP id p136so17140567oic.1 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 11:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=if9BBmwb7SfvENMhy5Ty6gqlrNUwJT0wtsLSv1XBLOk=; b=PS2MamxbvI/sD9NjQYbCe3oV2/QZwFsbm6YstRxDl5UqXzu/6ScmG0aH+DAMvkAVKO iZPozFv9Y4F+Mr/CY1GZOKu0Zu1tQGEFOHFgMM1EC0u6iX7YzFtzdeGEXUXVb5aJ3c4O 7srW4NCTORsG9Cex87svDnYRKNNmnBoCVW36hAAnj4kvBi3G2a7PNNEftC2yvcXIfhLh WFatbk416xa3UuCSNBDDtkQ4NfiX8XCU9Q6s72litSGKc4HwC76DfunV84bP/ThaHbui RqgRjJdJYl4G/lcZaq2E3EqDw82CuAB/h2s2+WtnMhnBElm6Cs7N7R1ZC1CQIIaALJnD iBCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=if9BBmwb7SfvENMhy5Ty6gqlrNUwJT0wtsLSv1XBLOk=; b=C3tiaaXPORbjuD4oPPJJ6XIky3mkV/aJyTp46z5DXLWW/Y/QPcUOJO/H6RRavdItRi 4qKsIZkm3ql0Ggh56zRWM5koptsA1mcDnfWLiMW6qtAGmF5TJuab/pZusmzle9buQoGI uKOLMz5MhFMh8zdR03u0ik1X/F0LLynz4spfpZ0NlFVQWm6j5x0cVF2iqh/FsWRtYcde 5Ww4+0acVAXQWZeFBsFQYulR30UbMueyXw52gg+/oeNG4I6IT9EGDGxYZXnn8j9pFo0n 5uZJPhCEjMf/vsuS+dEy7xNZdVXWccOm5/a486aU9CO7SSIxjjTpNT3NVd6SPWIK5Tpc gqbw== X-Gm-Message-State: ABUngvcOTkWAYAimUltU6rwMVa0CD4vVAxLnmMzQxIksof4Hxx/mwBJ3xI5Cvs716GlaC5ZlLM+6+BcelQyrlQ== X-Received: by 10.157.22.145 with SMTP id c17mr7070916ote.37.1477594275484; Thu, 27 Oct 2016 11:51:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.29.239 with HTTP; Thu, 27 Oct 2016 11:51:15 -0700 (PDT) In-Reply-To: <87bmy5bpqz.wl-domenechjosel@gmail.com> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> From: Noam Postavsky Date: Thu, 27 Oct 2016 14:51:15 -0400 X-Google-Sender-Auth: sNrrE4HCgdj1dhONBb-rPALGPrw Message-ID: Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters To: =?UTF-8?B?Sm9zw6kgTC4gRG9tw6luZWNo?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Eli Zaretskii , Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On Thu, Oct 27, 2016 at 2:39 PM, Jos=C3=A9 L. Dom=C3=A9nech wrote: > I am getting a "replace-regexp-in-string: Invalid use of =E2=80=98\=E2=80= =99 in replacement text" > error using 'shell-quote-argument' on this case. > > It seems that 'shell-quoted-argument' is adding double '\', that is, > '\\', in front of the spaces instead of surrounding the argument with quo= tes. > > And 'replace-match' which is called by 'replace-regexp-in-string' for the= parameter > substitution ("%i", "%o") in the function 'dired-do-compress-to' doesn't = like it. Does passing non-nil for the LITERAL parameter to replace-regexp-in-string = help? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 15:29:42 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 19:29:43 +0000 Received: from localhost ([127.0.0.1]:32849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzqMw-0005lg-Ox for submit@debbugs.gnu.org; Thu, 27 Oct 2016 15:29:42 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzqMv-0005lT-BB for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 15:29:41 -0400 Received: by mail-wm0-f46.google.com with SMTP id 140so39184990wmv.0 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 12:29:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:newsgroups:subject :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=1L9TImq8EUhtJlL5x7OqLCB9JISRYwhENts4xZ8t1LM=; b=ih6SqZ1J/nriSPW1e3YT4vUZvnvUkmk2ZaCVs5jDGJzZHARlVmCArloHLQm0bbHl/P II8YbdOUfAPqr/O5vasCLCdkaqBSfU4PBGuoN08jwslcIfuoFzwFCdaUJiHnc2trNXPC YRiLlI+2PK2D3GCNiWKpStVxlbR1OvFNS4EmLEkgJi32igPvkCRBm3MJXb8OtAJ44VSn voSqJq2butoJpBt1RsTJOqtGGpfkIgPCYA28AKYByHJNq+vlwfaaqbx1J0YC57YMbhlV XRkf5uMWri90H6YMZ+mEGAI0YeeIIRSVJR1FtbLx1MLYEQas2GPqL5hJEItWEsQoVu88 YxwA== X-Gm-Message-State: ABUngvcJfKBNAaCvuDgQet0yeHi2LZ/o/SOsi7/1zfG2qgLLfPWANNSk56TF/gR6rXaDEA== X-Received: by 10.194.153.66 with SMTP id ve2mr8181927wjb.82.1477596572418; Thu, 27 Oct 2016 12:29:32 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id 135sm4936020wmq.8.2016.10.27.12.29.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 12:29:31 -0700 (PDT) Date: Thu, 27 Oct 2016 21:29:30 +0200 Message-ID: <87insdpp45.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= Newsgroups: gmane.emacs.bugs Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Thu_Oct_27_21:29:30_2016-1" Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Multipart_Thu_Oct_27_21:29:30_2016-1 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: base64 T24gVGh1LCAyNyBPY3QgMjAxNiAyMDo1MToxNSArMDIwMCwNCk5vYW0gUG9zdGF2c2t5IHdyb3Rl Og0KPiANCj4gT24gVGh1LCBPY3QgMjcsIDIwMTYgYXQgMjozOSBQTSwgSm9zqKYgTC4gRG9tqKZu ZWNoDQo+IDxkb21lbmVjaGpvc2VsQGdtYWlsLmNvbT4gd3JvdGU6DQo+ID4gSSBhbSBnZXR0aW5n IGEgInJlcGxhY2UtcmVnZXhwLWluLXN0cmluZzogSW52YWxpZCB1c2Ugb2Ygoa5coa8gaW4gcmVw bGFjZW1lbnQgdGV4dCINCj4gPiBlcnJvciB1c2luZyAnc2hlbGwtcXVvdGUtYXJndW1lbnQnIG9u IHRoaXMgY2FzZS4NCj4gPg0KPiA+IEl0IHNlZW1zIHRoYXQgJ3NoZWxsLXF1b3RlZC1hcmd1bWVu dCcgaXMgYWRkaW5nIGRvdWJsZSAnXCcsIHRoYXQgaXMsDQo+ID4gJ1xcJywgaW4gZnJvbnQgb2Yg dGhlIHNwYWNlcyBpbnN0ZWFkIG9mIHN1cnJvdW5kaW5nIHRoZSBhcmd1bWVudCB3aXRoIHF1b3Rl cy4NCj4gPg0KPiA+IEFuZCAncmVwbGFjZS1tYXRjaCcgd2hpY2ggaXMgY2FsbGVkIGJ5ICdyZXBs YWNlLXJlZ2V4cC1pbi1zdHJpbmcnIGZvciB0aGUgcGFyYW1ldGVyDQo+ID4gc3Vic3RpdHV0aW9u ICgiJWkiLCAiJW8iKSBpbiB0aGUgZnVuY3Rpb24gJ2RpcmVkLWRvLWNvbXByZXNzLXRvJyBkb2Vz bid0IGxpa2UgaXQuDQo+IA0KPiBEb2VzIHBhc3Npbmcgbm9uLW5pbCBmb3IgdGhlIExJVEVSQUwg cGFyYW1ldGVyIHRvIHJlcGxhY2UtcmVnZXhwLWluLXN0cmluZyBoZWxwPw0KPiANClllcyBpbmRl ZWQhDQoNClNvIHRoZSBwYXRjaCBiZWNvbWVzIHNvbWV0aGluZyBsaWtlOg0KDQo= --Multipart_Thu_Oct_27_21:29:30_2016-1 Content-Type: text/plain; type=patch; name="dired-aux.el.patch"; charset=US-ASCII Content-Disposition: attachment; filename="dired-aux.el.patch" Content-Transfer-Encoding: 8bit diff -u /usr/local/share/emacs/26.0.50/lisp/dired-aux.orig.el /usr/local/share/emacs/26.0.50/lisp/dired-aux.el --- /usr/local/share/emacs/26.0.50/lisp/dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 +++ /usr/local/share/emacs/26.0.50/lisp/dired-aux.el 2016-10-27 21:24:29.022566630 +0200 @@ -1013,10 +1013,13 @@ (when (zerop (dired-shell-command (replace-regexp-in-string - "%o" out-file + "%o" (shell-quote-argument out-file) (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + "%i" (mapconcat (lambda (file-desc) + (shell-quote-argument + (file-name-nondirectory file-desc))) + in-files " ") + (cdr rule) nil t) nil t))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) Diff finished. Thu Oct 27 21:24:43 2016 --Multipart_Thu_Oct_27_21:29:30_2016-1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 15:31:43 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 19:31:43 +0000 Received: from localhost ([127.0.0.1]:32863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzqOr-0005qB-UF for submit@debbugs.gnu.org; Thu, 27 Oct 2016 15:31:42 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzqOp-0005py-NN for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 15:31:40 -0400 Received: by mail-wm0-f51.google.com with SMTP id b80so54133779wme.1 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 12:31:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:newsgroups:subject :in-reply-to:references:user-agent:mime-version; bh=24UeNzn/k2hD5P7yzFkarGHdsXjQrqzF6f2og0G2ij8=; b=lp+6vrWTj9wSyDgdK6fksN1127E49aKI0bZh1xQaBCgISkCwcTDYAoKApDrMIcFsjQ UMb/H30dcT3nazOD6aFsT43K/eKduWRp105dwRESyBHuV2WZFhg6MyIU09uluiJfveQa k24nbXuNQ3TFxgthrIHPICVzxNReXKPhetj5Ibs1e8MuXUslOLmc6pVskhkn0BO18W8O gbdh8l+HTtA+Mio9IaU3JxV8ga3P/ilYd/50WJ1s3d4CxYyDjpJ9hvlOjbdj3bcRV132 jmZdanI9KVvJb/6ScK+QOFgyXu5gp6PLA9GsmAWN1SwLoeZcf6cUBjOkuwi7d5JEOv/o F/MA== X-Gm-Message-State: ABUngvc7+iciTTziuYi5ZtzAW+nBKVj80RrSajn9EHu2n3lGAl3ysOCfghQSxVKyFprh0g== X-Received: by 10.194.201.227 with SMTP id kd3mr9909531wjc.74.1477596693978; Thu, 27 Oct 2016 12:31:33 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id r72sm4922925wmd.21.2016.10.27.12.31.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 12:31:33 -0700 (PDT) Date: Thu, 27 Oct 2016 21:31:32 +0200 Message-ID: <87h97xpp0r.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= Newsgroups: gmane.emacs.bugs Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Thu, 27 Oct 2016 20:51:15 +0200, Noam Postavsky wrote: > > Does passing non-nil for the LITERAL parameter to replace-regexp-in-string help? > Yes indeed! So the patch becomes something like: diff -u /usr/local/share/emacs/26.0.50/lisp/dired-aux.orig.el /usr/local/share/emacs/26.0.50/lisp/dired-aux.el --- /usr/local/share/emacs/26.0.50/lisp/dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 +++ /usr/local/share/emacs/26.0.50/lisp/dired-aux.el 2016-10-27 21:24:29.022566630 +0200 @@ -1013,10 +1013,13 @@ (when (zerop (dired-shell-command (replace-regexp-in-string - "%o" out-file + "%o" (shell-quote-argument out-file) (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + "%i" (mapconcat (lambda (file-desc) + (shell-quote-argument + (file-name-nondirectory file-desc))) + in-files " ") + (cdr rule) nil t) nil t))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) Diff finished. Thu Oct 27 21:24:43 2016 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 19:14:17 2016 Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 23:14:17 +0000 Received: from localhost ([127.0.0.1]:32920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bztsG-0002TH-VG for submit@debbugs.gnu.org; Thu, 27 Oct 2016 19:14:17 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:36409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bztsF-0002T5-2O for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 19:14:15 -0400 Received: by mail-oi0-f45.google.com with SMTP id n202so75151846oig.3 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 16:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=v8gS5dB1s40CPj+EzCDH9h9Ij/Ju6WR6+NAVM1I11yc=; b=cUDzPVipQ9LpoVYMqHAyfjuMH4X5DEfYsGVzzNrXqtP59uhxBJhXFSh1yoANdhXSFC YS0qqDfsZplpeIOTbjBGW5CAv5+jV3ijS2B1877Mkdx//1ESff0yNkaTEqM8a+2ECmID X5vkxm4UDRD0GfXQrpm1Lg6+TLLv3Z9Fq5QrkhkwxhlUHQurudXVM+i/mttupdCBykMQ n+6OXaKk4Obr/kxgA2Oq0vQdLOM2r6Um/sNFwr+bVQH5wkkFuFHs+SiU+7N0l3aDICEL GlTCSQc+CoZFUqfWFPsK4LDPfIn+ltNpgkSXGyXs7axUUri1/o0L8FxKTdl2/OGHB1Kx uqWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=v8gS5dB1s40CPj+EzCDH9h9Ij/Ju6WR6+NAVM1I11yc=; b=CKEiGevp9VBKMEX4xXsB5whAQ82LMoO5egDBMyXVQHGADd3RrrNyDqSPahAXPhPSGg DwZK/Jj4F9BULFuIpSYGZl7IOODB5+7CJE0f4iiUsI6cC3qC7l31GpUnwRJ++aj/qs8s L8hh05L1+n1myG1EqVJ6IQkXN1LE1LliVoWsP6k7M7hmtVGcM7yrGcWsqoKQ23Mc6MB7 cShTDhALPgaQbpyTpkVpo0W4OuCTG1ejrQeGo+FKhoAsZ60RBpg8Ba1j6FydfmJfKJOP naWOwa0t/6nTf5SWEbLbGoX41NdESI7dlccfQ+1OggVB2bCGPI6ssoXt1K1BnRe/y9w7 uckQ== X-Gm-Message-State: ABUngveSkSRTr9R2Vt49+SD3QrfmRn24KvsFWQHS17R5aRR6X4v8FZ4UTJfTpwOc/PPlGw== X-Received: by 10.107.183.149 with SMTP id h143mr8448018iof.43.1477610049410; Thu, 27 Oct 2016 16:14:09 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id q77sm1859046itb.22.2016.10.27.16.14.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Oct 2016 16:14:08 -0700 (PDT) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Jos=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech?= Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> Date: Thu, 27 Oct 2016 19:14:49 -0400 In-Reply-To: <87insdpp45.wl-domenechjosel@gmail.com> (=?utf-8?Q?=22Jos?= =?utf-8?Q?=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech=22's?= message of "Thu, 27 Oct 2016 21:29:30 +0200") Message-ID: <87wpgtqt92.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Jos=C3=A9 L. Dom=C3=A9nech writes: > > So the patch becomes something like: > > (dired-shell-command > (replace-regexp-in-string > - "%o" out-file > + "%o" (shell-quote-argument out-file) > (replace-regexp-in-string > - "%i" (mapconcat #'file-name-nondirectory in-files "= ") > - (cdr rule))))) > + "%i" (mapconcat (lambda (file-desc) > + (shell-quote-argument > + (file-name-nondirectory file-des= c))) > + in-files " ") > + (cdr rule) nil t) nil t))) That looks pretty good. I think it would be even nicer to use the `format-spec' function instead of calling `replace-regexp-in-string' twice. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 03:06:41 2016 Received: (at 24620) by debbugs.gnu.org; 28 Oct 2016 07:06:41 +0000 Received: from localhost ([127.0.0.1]:33090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c01FR-0005LC-J8 for submit@debbugs.gnu.org; Fri, 28 Oct 2016 03:06:41 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c01FQ-0005Kz-2O for 24620@debbugs.gnu.org; Fri, 28 Oct 2016 03:06:40 -0400 Received: by mail-wm0-f48.google.com with SMTP id b80so77984206wme.1 for <24620@debbugs.gnu.org>; Fri, 28 Oct 2016 00:06:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:newsgroups:subject :in-reply-to:references:user-agent:mime-version; bh=iguQ0OuQ7J0C8qOuEmPLouB0CNzR11WpznMfmdHAZeM=; b=jawsVc16sZUXpybpiNd1d3yBWDu9Zu3gewy5+LwiC39vAM0pyEPcoEWgObud1nsYxy u9/t1gbCPjpS2Nd7GrzKA1DpXCXyF/IYYvkL1TaW/anbofNhy3di7KFlH7lShsACsRsl 0L4QyElZ1Lk5Jji7BtGBCKJdJoRRKhGG1I4zerzUoeMD5m2kJlbjxDc27vMZ5aaS+gGF g8hGVezd2CXqLuf8/DwJGdnC0P6ki29shomxeZlZhcNlbuG34xZ+Lr8z1msuprpyxdwy NU9XvQLWIvZVxGk8MhZEHWY12EgDPgu4TdzDrl0wDGkQN6LRNHYSyogw6w7GUcW/WS+g +Y0Q== X-Gm-Message-State: ABUngvcJ+HvKXTW4c6KGk8Na92NHLM7QnYEFHepLHhXkdHOUJG9NbGNRsomClcf13OeBxw== X-Received: by 10.28.209.142 with SMTP id i136mr2234361wmg.1.1477638394081; Fri, 28 Oct 2016 00:06:34 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id 130sm7316991wmf.0.2016.10.28.00.06.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 00:06:33 -0700 (PDT) Date: Fri, 28 Oct 2016 09:06:32 +0200 Message-ID: <87a8dp0x6v.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= Newsgroups: gmane.emacs.bugs Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87wpgtqt92.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Fri, 28 Oct 2016 01:14:49 +0200, npostavs@users.sourceforge.net wrote: > > > That looks pretty good. I think it would be even nicer to use the > `format-spec' function instead of calling `replace-regexp-in-string' > twice. > > Here are the changes: --- dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 +++ dired-aux.el 2016-10-28 09:01:08.413024427 +0200 @@ -1012,11 +1012,15 @@ (t (when (zerop (dired-shell-command - (replace-regexp-in-string - "%o" out-file - (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + (format-spec + (cdr rule) + (list (cons ?o (shell-quote-argument out-file)) + (cons ?i + (mapconcat + (lambda (filename) + (shell-quote-argument + (file-name-nondirectory filename))) + in-files " ")))))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) Diff finished. Fri Oct 28 09:01:25 2016 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 05:22:50 2016 Received: (at 24620) by debbugs.gnu.org; 28 Oct 2016 09:22:50 +0000 Received: from localhost ([127.0.0.1]:33176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c03NB-0001jX-T9 for submit@debbugs.gnu.org; Fri, 28 Oct 2016 05:22:50 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c03NB-0001jL-5Y for 24620@debbugs.gnu.org; Fri, 28 Oct 2016 05:22:49 -0400 Received: by mail-wm0-f68.google.com with SMTP id m83so6532567wmc.0 for <24620@debbugs.gnu.org>; Fri, 28 Oct 2016 02:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:subject:references :user-agent:in-reply-to:references:disposition-notification-to :return-receipt-to:mime-version; bh=iguQ0OuQ7J0C8qOuEmPLouB0CNzR11WpznMfmdHAZeM=; b=NOGvT/mSnIFU0CZVZ81e78sfvRmrit+V80GsbhrTB68SKjFWJGzIAZqPXBikUSKQe8 PYOkYLhj0p7tlxcrqsOmdy84DsbvnG/zitQaVdFTImjZ0NHlC4cV+RAO3NrbPSfVjxX5 29XZUfgmWFk62iEAAGvvefjoWu2bToERZYbxMyzokNetQsvkP4QmS/s1rZrZddmRVMSW PasEnvIqOEqvouPrSN51oa3DF4NlZty3S9twS1N0xgYL2enTahJkcHzRfwop6+0+wVAa gpcea8yK2dDrzyKKLi9pQzTrT3f9jg4D0K9sWu1Jf7MDUtQrD1Zny6uqRODWpj03hxuX CWcg== X-Gm-Message-State: ABUngvcgo7o5MANl/Cy9dXB27/3CPLlvpgtBr6+Me5ZKm215Nmoo8l2z9iPZeg9Zs2rmZw== X-Received: by 10.28.135.84 with SMTP id j81mr1887733wmd.127.1477646563061; Fri, 28 Oct 2016 02:22:43 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.gmail.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id e5sm7894795wma.10.2016.10.28.02.22.42 for <24620@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 02:22:42 -0700 (PDT) Date: Fri, 28 Oct 2016 11:22:41 +0200 Message-ID: <87a8dog74u.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: 24620@debbugs.gnu.org Subject: Forward: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) In-Reply-To: <87wpgtqt92.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Fri, 28 Oct 2016 01:14:49 +0200, npostavs@users.sourceforge.net wrote: > > > That looks pretty good. I think it would be even nicer to use the > `format-spec' function instead of calling `replace-regexp-in-string' > twice. > > Here are the changes: --- dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 +++ dired-aux.el 2016-10-28 09:01:08.413024427 +0200 @@ -1012,11 +1012,15 @@ (t (when (zerop (dired-shell-command - (replace-regexp-in-string - "%o" out-file - (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + (format-spec + (cdr rule) + (list (cons ?o (shell-quote-argument out-file)) + (cons ?i + (mapconcat + (lambda (filename) + (shell-quote-argument + (file-name-nondirectory filename))) + in-files " ")))))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) Diff finished. Fri Oct 28 09:01:25 2016 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 22:06:21 2016 Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 02:06:21 +0000 Received: from localhost ([127.0.0.1]:34500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0J2L-0008S1-IB for submit@debbugs.gnu.org; Fri, 28 Oct 2016 22:06:21 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:36433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0J2K-0008Rh-0L; Fri, 28 Oct 2016 22:06:20 -0400 Received: by mail-it0-f45.google.com with SMTP id m138so6428949itm.1; Fri, 28 Oct 2016 19:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7xsUPdM9EsMxX//8gqOTnl+grE4ZZZ7g9PqlJ9Si1sU=; b=gnF2SigRejdbCa/ukfau6w2VPUGLtqtfFDUBxu518KlSRWuF6wll2zWi4cwpi3ev67 6FEKxnnVG3Z7vjFoj0bkHs+0nkiPhTZ+wQnH3zNHEFADzxiVInHsol7L9m/kKk166qDz RlKFmVVgkfPoj9p8geHaTwIqIeRLkKLG4/BQ7nZaJJJyUQl+FLWgmAfqswWjFyz+3AT0 okxTnlNMuJKE+IpPeY65Zmgt+GJwKeG3r0vrnaByPudkV/lMLhEjGePbA/XN9ZDEH302 RC7/ez3PhbU4y/ommAeucHyAP1QdvmIeB6IofuKguP/vEWInC4mDEqIdKIfacaN+jmai TPsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=7xsUPdM9EsMxX//8gqOTnl+grE4ZZZ7g9PqlJ9Si1sU=; b=Co4I+5mVi0wLF9yoFkmEon+83VAjjlu2VYIwXy5OymA1ojpd2FiXu2UiBowNJqoAhk Wzr59+ZkjIHMIVayTkkM9DYjB2icNQoARHuJX3anxBHkhI3rC9OTdDA1RApvh8e4q/r1 0syfODw1NvoIh4jot4AHvrsPvvrG3N4cExY454MQ+SmnZfHgv3shTvgi1rw5TWf3NCNp QvWxa6hBsU8aa0V+GJpg/i++sEe2CWjnYLbSLPUUJD5Eaz01m8I4YG/UkATx2XJbtHYE s1k/wZaELcTEiiGT6IsrBjiSDBli7k70DZeHCYIdzo8apJmBA2HfU04vAmLZgbHSvcIY Nvfg== X-Gm-Message-State: ABUngvcEdfTxhs+h8D4AV7iXJFC6eILcr4jyiqWym2cBB5WOVPXcTb5clVMq84rSMMGB7g== X-Received: by 10.107.34.144 with SMTP id i138mr12726711ioi.197.1477706774597; Fri, 28 Oct 2016 19:06:14 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id x69sm4112387ite.10.2016.10.28.19.06.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Oct 2016 19:06:14 -0700 (PDT) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Jos=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech?= Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> Date: Fri, 28 Oct 2016 22:06:55 -0400 In-Reply-To: <87a8dp0x6v.wl-domenechjosel@gmail.com> (=?utf-8?Q?=22Jos?= =?utf-8?Q?=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech=22's?= message of "Fri, 28 Oct 2016 09:06:32 +0200") Message-ID: <87r36zrjr4.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 24620 patch quit Jos=C3=A9 L. Dom=C3=A9nech writes: > On Fri, 28 Oct 2016 01:14:49 +0200, > npostavs@users.sourceforge.net wrote: >>=20 >>=20 >> That looks pretty good. I think it would be even nicer to use the >> `format-spec' function instead of calling `replace-regexp-in-string' >> twice. >>=20 >>=20 > Here are the changes: > > --- dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 > +++ dired-aux.el 2016-10-28 09:01:08.413024427 +0200 > @@ -1012,11 +1012,15 @@ > (t > (when (zerop > (dired-shell-command > - (replace-regexp-in-string > - "%o" out-file > - (replace-regexp-in-string > - "%i" (mapconcat #'file-name-nondirectory in-files "= ") > - (cdr rule))))) > + (format-spec > + (cdr rule) > + (list (cons ?o (shell-quote-argument out-file)) > + (cons ?i > + (mapconcat > + (lambda (filename) > + (shell-quote-argument > + (file-name-nondirectory filename))) > + in-files " ")))))) > (message "Compressed %d file(s) to %s" > (length in-files) > (file-name-nondirectory out-file))))))) > > Diff finished. Fri Oct 28 09:01:25 2016 Looks good. Would you like to try writing a commit message too? (see "Commit messages" in CONTRIBUTE). Just a minor style suggestion: In cases like these, I like to use the backquote syntax instead of explicit (list (cons ...)) because it saves a bit of indentation. Have you signed copyrigh assignment for Emacs? This patch is small enough to merge anyway, but if you'll be writing more patches in the future, consider filling out the form at git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.prog= ram to get the process started. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 05:17:26 2016 Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 09:17:26 +0000 Received: from localhost ([127.0.0.1]:35600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0PlW-0005cp-6e for submit@debbugs.gnu.org; Sat, 29 Oct 2016 05:17:26 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0PlU-0005cb-Nx for 24620@debbugs.gnu.org; Sat, 29 Oct 2016 05:17:25 -0400 Received: by mail-wm0-f44.google.com with SMTP id e69so147941306wmg.0 for <24620@debbugs.gnu.org>; Sat, 29 Oct 2016 02:17:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:mime-version; bh=zBaIQ6sNkNYPAFACfDjhWjWCnEFj7lqR/9eamX+UF6o=; b=E1MN0vbAdA5kAGovfo6VDSLwIH0IDkl9klB4l3iEqc/07UEqvtCvZYvDUQY7C+iVOw 35OaCIKtOhBvvtLV1uBL1ffG2M6tqlzXj+PWdZJ35kf4NAir4VlDCxbQ/dJiRWIWO53F ogJ0pr1iN6amvnZEGjXHUXnSTEhX/OTUrFKiZNOeJzoGWR+BN4D2KGrCOK8BKdDHxaC2 qnFPRyXtFeNa302TawdQqqTGg+s1BVkwXlu6PsbtT8LH2f2SVs+jFzD0xtHqYTmqwZoC /ou8mqwmp4qCrF/z9aTE8CatkFewX6fQiXlDLCIw8ARCA7GjwsMainbvBisimkTucBcC aPDA== X-Gm-Message-State: ABUngveH+RLlS+WVQxWzowta0py4r6ICt8LcjNjPITTW1lSEeTxv/wWWNeBq7UCiog2EYw== X-Received: by 10.194.153.228 with SMTP id vj4mr14908828wjb.204.1477732639140; Sat, 29 Oct 2016 02:17:19 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id jq10sm18423320wjb.46.2016.10.29.02.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Oct 2016 02:17:18 -0700 (PDT) Date: Sat, 29 Oct 2016 11:17:17 +0200 Message-ID: <8737jfjyzm.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: npostavs@users.sourceforge.net Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87r36zrjr4.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus , "=?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, 29 Oct 2016 04:06:55 +0200, npostavs@users.sourceforge.net wrote: > > tags 24620 patch > quit > > > Looks good. Would you like to try writing a commit message too? (see > "Commit messages" in CONTRIBUTE). > Something like this? Fix Bug#24620 * lisp/dired-aux.el (dired-do-compress-to): Change the string used as shell command for compression by quoting the filenames used for input and output > Just a minor style suggestion: In cases like these, I like to use the > backquote syntax instead of explicit (list (cons ...)) because it saves > a bit of indentation. > I changed it: modified lisp/dired-aux.el @@ -1012,11 +1012,13 @@ dired-do-compress-to (t (when (zerop (dired-shell-command - (replace-regexp-in-string - "%o" out-file - (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + (format-spec (cdr rule) + `((?\o . ,(shell-quote-argument out-file)) + (?\i . ,(mapconcat + (lambda (file-desc) + (shell-quote-argument (file-name-nondirectory + file-desc))) + in-files " ")))))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) > Have you signed copyrigh assignment for Emacs? This patch is small > enough to merge anyway, but if you'll be writing more patches in the > future, consider filling out the form at > git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program > to get the process started. Yes. I just started the process by sending a e-mail with the required data. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 08:06:25 2016 Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 12:06:25 +0000 Received: from localhost ([127.0.0.1]:35995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0SP2-0005w5-Ps for submit@debbugs.gnu.org; Sat, 29 Oct 2016 08:06:24 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:35327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0SP1-0005vs-4w for 24620@debbugs.gnu.org; Sat, 29 Oct 2016 08:06:23 -0400 Received: by mail-qk0-f182.google.com with SMTP id z190so115280557qkc.2 for <24620@debbugs.gnu.org>; Sat, 29 Oct 2016 05:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=MRIc22tgNbmsLJ73Wu1+k+OuPG95VXJ/fi6PLVSmbZI=; b=1Exmp59Eo+k9Yo64V1c0Xa7hp42gwqcqkpWBsY0ObkxeRFRrLIECvwpHpFfNRXpwQI DaWgParrZ/7tzWsRpbIhf2I2SjJvAWrl1pqvP+UImSn7FmPKQGTDFY40HKPLJJqGQV6x Z7ZOZttgYtXT4i27qWpSS7pgu0nAEr3ft1i+vjtGDDeYfOT8sz1WQgKp1bERwmgmccqG 2IRudJU8zicRtdjxcbn941h/iqFQZ/EdpxsuGktPWrQsaQfWK/FmyufRcjL5X8zTKfvt M45fQAzDaFkBm8UUfSS9gnAR6alnmZcdp73IkD1SY7XZr4JXEEbUnXaewZ0rGjsu2iNO 0PvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=MRIc22tgNbmsLJ73Wu1+k+OuPG95VXJ/fi6PLVSmbZI=; b=kpcOCpf3+iVUDxvfbKEKkrVn5gopilm1kuhbsceifTjK22x1SI6hKj0QbwCosP0bPh fJjAPAv29dNEcqK5WDtFoB6PVUtryAdgg70RKtFLMbvL2DKNX6acF4YAALoiS4ygZnDb v47lp1lDerU1T9WWQXx3BPBXGwIa/ViSqE7Ova20bunCRQS3b+R+CjQoTY3Jr6AnpirM t/7UFKU+INifEzKhED87zBQ08i9pD/kZQFsH9e/mbiOtG8ZGzlThrbSK9PDHwwQJR82d dTk+RCzIkYIsNoTsMOwLOTfFQpBun+JTqSx2aiwModcC19V9ilRRA4obfxbh01UfQtca 9okA== X-Gm-Message-State: ABUngvdkDrAdYSH+gbSbk6xxAL9ct0s3wR5HwgroLNgUKHjrqGLUyhCCkgAn6SDya2dMyA== X-Received: by 10.55.146.198 with SMTP id u189mr14990175qkd.83.1477742777752; Sat, 29 Oct 2016 05:06:17 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id u4sm8584387qka.9.2016.10.29.05.06.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Oct 2016 05:06:16 -0700 (PDT) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Jos=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech?= Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> Date: Sat, 29 Oct 2016 08:06:58 -0400 In-Reply-To: <8737jfjyzm.wl-domenechjosel@gmail.com> (=?utf-8?Q?=22Jos?= =?utf-8?Q?=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech=22's?= message of "Sat, 29 Oct 2016 11:17:17 +0200") Message-ID: <87k2crqrz1.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Jos=C3=A9 L. Dom=C3=A9nech writes: > Something like this? > > Fix Bug#24620 > > * lisp/dired-aux.el (dired-do-compress-to): Change the string used as > shell command for compression by quoting the filenames used for input > and output > Almost: the summary line should ideally be readable without having to lookup what Bug#24620 is (and the ChangeLog entry should end with a period). >> Have you signed copyrigh assignment for Emacs? This patch is small >> enough to merge anyway, but if you'll be writing more patches in the >> future, consider filling out the form at >> git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.p= rogram >> to get the process started. > > Yes. I just started the process by sending a e-mail with the required dat= a. Great! From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 14:41:01 2016 Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 18:41:01 +0000 Received: from localhost ([127.0.0.1]:36812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0YYv-0000Io-58 for submit@debbugs.gnu.org; Sat, 29 Oct 2016 14:41:01 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0YYs-0000IY-Or for 24620@debbugs.gnu.org; Sat, 29 Oct 2016 14:40:59 -0400 Received: by mail-wm0-f65.google.com with SMTP id 68so5387471wmz.2 for <24620@debbugs.gnu.org>; Sat, 29 Oct 2016 11:40:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:newsgroups:subject :in-reply-to:references:user-agent:disposition-notification-to :return-receipt-to:mime-version:content-transfer-encoding; bh=j+fxSW6XDr6JeMhO95UNJ1wRNe6vCvGecxhTWvuBuSw=; b=S/gwdGAqDxtuJ4kDefdyjF4aeG6hQ0VRbgAilW6wfd8ECJeW4JEVK1HzEnaT7o1tp9 44RTmK/DLE5TYbBZzFMoPC+nRmE21VuwnbyFC9lzkA1Zaoc08ZOrvvimpABGPyAvkrWq mJWH8qk5rZ550yoh0SqZGjOWJiEazn2EBoRMFcRefAMBK9G6Sjz3HS6MifZESfs7qmX3 NejOUwxwaUJhaZHU6eD+zmskctfR/k2NAJXeiLAkJQdeYeeA3a/PvQYiK76CT8gajEQc 8jw/rVfGp56X9KsoFCVLfB+DefJvAx/Aa4zbHliErchYIv98yHHRzz393XGRWc0DZqiv 5C9Q== X-Gm-Message-State: ABUngvcUc+JRZk4ZPe/TUuHL5UycWcMg8LUpgBA2Z7Rbeq2sja9WOCdW6kHfU6PZqG31JQ== X-Received: by 10.194.115.38 with SMTP id jl6mr15837341wjb.52.1477766452943; Sat, 29 Oct 2016 11:40:52 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.gmail.com (110.red-79-144-230.dynamicip.rima-tde.net. [79.144.230.110]) by smtp.gmail.com with ESMTPSA id uq6sm20666748wjc.37.2016.10.29.11.40.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Oct 2016 11:40:52 -0700 (PDT) Date: Sat, 29 Oct 2016 20:40:51 +0200 Message-ID: <87insbdmmk.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= Newsgroups: gmane.emacs.bugs Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87k2crqrz1.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> <87k2crqrz1.fsf@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, 29 Oct 2016 14:06:58 +0200, npostavs@users.sourceforge.net wrote: >=20 > Jos=E9 L. Dom=E9nech writes: > > Something like this? > > > > Fix Bug#24620 > > > > * lisp/dired-aux.el (dired-do-compress-to): Change the string used as > > shell command for compression by quoting the filenames used for input > > and output > > >=20 > Almost: the summary line should ideally be readable without having to > lookup what Bug#24620 is (and the ChangeLog entry should end with a > period). > Sorry for the delay. Perhaps this is more convenient: 2016-09-29 Jos=E9 L. Dom=E9nech Fix bug#24620: In dired enable compress to/from files whose filenames conta= ins space characters. * lisp/dired-aux.el (dired-do-compress-to): Change the string used as shell command for compression by quoting the filenames used for input and output Thanks for your patiente. > >> Have you signed copyrigh assignment for Emacs? This patch is small > >> enough to merge anyway, but if you'll be writing more patches in the > >> future, consider filling out the form at > >> git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign= .program > >> to get the process started. > > > > Yes. I just started the process by sending a e-mail with the required d= ata. >=20 > Great! >=20 >=20 >=20 >=20 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 14:41:22 2016 Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 18:41:22 +0000 Received: from localhost ([127.0.0.1]:36816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0YZG-0000Jt-EZ for submit@debbugs.gnu.org; Sat, 29 Oct 2016 14:41:22 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0YZF-0000Jg-4y for 24620@debbugs.gnu.org; Sat, 29 Oct 2016 14:41:21 -0400 Received: by mail-wm0-f66.google.com with SMTP id p190so5895195wmp.1 for <24620@debbugs.gnu.org>; Sat, 29 Oct 2016 11:41:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:newsgroups:subject :in-reply-to:references:user-agent:disposition-notification-to :return-receipt-to:mime-version:content-transfer-encoding; bh=j+fxSW6XDr6JeMhO95UNJ1wRNe6vCvGecxhTWvuBuSw=; b=mN9kA5KfpSzHqXAy5xBfvUwCVLXDwGiA/PaeFv8rETLeS24pFWYW81qWslKTSbIIph Qdq4kYbOo88lSGtMlC3AqsgBI/gUq5RiVSJii/da0U7ohDFB/HTZ9Siz976Mgn3gWt10 SCRwP1mSWe/AqMTfav/NEuyMNS0MLvzRQgaRBd8+zVCauP3AtexxK6BHwJ2RQamw6xcA gBSr3ucRy+7NMRYPChorh8HmcDD4i2VkLPFoCdFYu15V/RdAZJjdc0J0ze4qY7S3ppIy v+YU0JjOmD2PeHrR4LZr7/mzppCQ7w1qn3FxFy+tq0YKjpZdisf5hP9Bxq8lsy0Vumua 2taA== X-Gm-Message-State: ABUngve1Chs38bIImNZnubudJjapMyoQi9tqHHLFOgT7A/7O+92WpZitc0wnVfvqAV2Puw== X-Received: by 10.194.103.41 with SMTP id ft9mr15873134wjb.8.1477766475403; Sat, 29 Oct 2016 11:41:15 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.gmail.com (110.red-79-144-230.dynamicip.rima-tde.net. [79.144.230.110]) by smtp.gmail.com with ESMTPSA id w1sm20666623wje.36.2016.10.29.11.41.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Oct 2016 11:41:14 -0700 (PDT) Date: Sat, 29 Oct 2016 20:41:13 +0200 Message-ID: <87h97vdmly.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= Newsgroups: gmane.emacs.bugs Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87k2crqrz1.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> <87k2crqrz1.fsf@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, 29 Oct 2016 14:06:58 +0200, npostavs@users.sourceforge.net wrote: >=20 > Jos=E9 L. Dom=E9nech writes: > > Something like this? > > > > Fix Bug#24620 > > > > * lisp/dired-aux.el (dired-do-compress-to): Change the string used as > > shell command for compression by quoting the filenames used for input > > and output > > >=20 > Almost: the summary line should ideally be readable without having to > lookup what Bug#24620 is (and the ChangeLog entry should end with a > period). > Sorry for the delay. Perhaps this is more convenient: 2016-09-29 Jos=E9 L. Dom=E9nech Fix bug#24620: In dired enable compress to/from files whose filenames conta= ins space characters. * lisp/dired-aux.el (dired-do-compress-to): Change the string used as shell command for compression by quoting the filenames used for input and output Thanks for your patiente. > >> Have you signed copyrigh assignment for Emacs? This patch is small > >> enough to merge anyway, but if you'll be writing more patches in the > >> future, consider filling out the form at > >> git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign= .program > >> to get the process started. > > > > Yes. I just started the process by sending a e-mail with the required d= ata. >=20 > Great! >=20 >=20 >=20 >=20 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 15:42:47 2016 Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 19:42:47 +0000 Received: from localhost ([127.0.0.1]:36826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ZWh-0001nD-Ds for submit@debbugs.gnu.org; Sat, 29 Oct 2016 15:42:47 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ZWf-0001n0-NB for 24620@debbugs.gnu.org; Sat, 29 Oct 2016 15:42:46 -0400 Received: by mail-wm0-f53.google.com with SMTP id e69so167330877wmg.0 for <24620@debbugs.gnu.org>; Sat, 29 Oct 2016 12:42:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:subject:references :user-agent:disposition-notification-to:return-receipt-to :mime-version; bh=l7A0nvCoU69NchoPUZLq21aMFnMk4J9JVrm93WCWIik=; b=Fe00Lf2KQKINMMyqfUpg/zJbxTQJ0auim6aYwoC9pU1/Py9UUS7KdIRspCwNjFs3oG MHiGofWd6T95N0DSkV6tsyAd03RF7iTVMp1VzPx8FFjAkt4KvLFxB+FWjchlGAsDjZ0z RTygqqtf2CdMRDVYFsrPofeTZxUKRa6AKYjWfGTq2rvdlMlWmTAyjx31XMlBDeFn8Mir oaJVJjc7CWBXM/YcBP+ZCXIniq7tBPriNyJkCJEaOrlH1RcLMov0e00G35Ce58Sisjut ngDw8pLCrV7VAnLIZ298Gy+xOwR2P1/Xy8P8S1owBFxZrR7JsS5IZll7PxHeUSby2wcf 9Pmw== X-Gm-Message-State: ABUngveMvw2hHzYyAKoA0lraW6CGG7nncUBsQGyxrUWXzanSoZIbux7oWG7stU7/QMCLzA== X-Received: by 10.28.144.130 with SMTP id s124mr4389803wmd.77.1477770160053; Sat, 29 Oct 2016 12:42:40 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.gmail.com (110.red-79-144-230.dynamicip.rima-tde.net. [79.144.230.110]) by smtp.gmail.com with ESMTPSA id s204sm15760222wmd.1.2016.10.29.12.42.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Oct 2016 12:42:39 -0700 (PDT) Date: Sat, 29 Oct 2016 21:42:38 +0200 Message-ID: <87ziln9c29.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: 24620@debbugs.gnu.org, Michael Albinus Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> <87k2crqrz1.fsf@users.sourceforge.net> <87insbdmmk.wl-domenechjosel@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: message/rfc822 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, 29 Oct 2016 14:06:58 +0200, npostavs@users.sourceforge.net wrote: > > Jose L. Domenech writes: > > Something like this? > > > > Fix Bug#24620 > > > > * lisp/dired-aux.el (dired-do-compress-to): Change the string used as > > shell command for compression by quoting the filenames used for input > > and output > > >=20 > Almost: the summary line should ideally be readable without having to > lookup what Bug#24620 is (and the ChangeLog entry should end with a > period). > Sorry for the delay. Perhaps this is more convenient: 2016-09-29 Jos=E9 L. Dom=E9nech Fix bug#24620: In dired enable compress to/from files whose filenames conta= ins space characters. * lisp/dired-aux.el (dired-do-compress-to): Change the string used as shell command for compression by quoting the filenames used for input and output Thanks for your patiente. > >> Have you signed copyrigh assignment for Emacs? This patch is small > >> enough to merge anyway, but if you'll be writing more patches in the > >> future, consider filling out the form at > >> git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign= .program > >> to get the process started. > > > > Yes. I just started the process by sending a e-mail with the required d= ata. > > Great! > > > > From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 21:38:29 2016 Received: (at 24620) by debbugs.gnu.org; 30 Oct 2016 01:38:29 +0000 Received: from localhost ([127.0.0.1]:36903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0f4v-0001mm-5D for submit@debbugs.gnu.org; Sat, 29 Oct 2016 21:38:29 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:38392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0f4s-0001mT-Ut; Sat, 29 Oct 2016 21:38:27 -0400 Received: by mail-it0-f52.google.com with SMTP id q124so44104006itd.1; Sat, 29 Oct 2016 18:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=K+/Q2xVKK7e0oFcXSAzvIz9zgXJDYeRdu4ADtpz49Ao=; b=iRb6aEIHIfSnKWEe3vdqSpFUmCRIKTJUqW9MCxBmAq84fhIW993WRjfAq2l5PI89yM mPZrqT0FWw8d8oW1YVANPMSXFvWRG3V137QxhDnrjVqKgCeLyU4KsTYf3JWexpBnyx6y R4Wgg2/zGRaqqC0z4YQ/wQDI7EgDGBUsIytma4afP7HoLSmi7c18kpji4kfUhaOrKNH6 nnGAUdzc6hxCCbXFXGqKR/AAIIOoHK3WAWHJBvGKbG7nssmc/CR9UapjavWXBpxkr369 YQ6TJAbVASYb8tHo7p1fdJUDnTCglkCRUjYim/TyKdHZnCGN3EKUZd/TsHcEid2/LKVW nFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=K+/Q2xVKK7e0oFcXSAzvIz9zgXJDYeRdu4ADtpz49Ao=; b=Qy8CDNdxW7tYrZ+ZIUYNA17HBxnl98lvKxcKNrm0MO4zTV6XvjgSwxDqxbBujgd8Ij 8K4iaU/gwMA4PDiQ39J1dRAod3CtwMbbpDX8mWn4WW7aveuXMM1HfusVHuy8RQcVe25i /XwhTHUzsvXaYwlvksDcBXR7a2rGELBawRPsx1L4viF0W3KemU/IgQMXNbRZo3jZ/fnc WCxmjvkutbE0g0ByBIxxlZ6YJfApQ+1cubhNdLBCGjgucuveLN+iruMrud8A1facPeh/ LcXWlPnAgCYbFRVwHZxbe/0kUklGBHVKSPYB4e6hwNscJpQeMpXUUdks9VNhEgqxHHVW dMvQ== X-Gm-Message-State: ABUngvf4IcCrt2Qc5pP759+wxbybQ4/nKM/44pZhkw8U/ZCDKIBa8F62dUxUjzqclpi0HA== X-Received: by 10.36.73.134 with SMTP id e6mr3916341itd.109.1477791501362; Sat, 29 Oct 2016 18:38:21 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id e21sm7890820iof.23.2016.10.29.18.38.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Oct 2016 18:38:20 -0700 (PDT) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Jos=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech?= Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> <87k2crqrz1.fsf@users.sourceforge.net> <87insbdmmk.wl-domenechjosel@gmail.com> Date: Sat, 29 Oct 2016 21:39:01 -0400 In-Reply-To: <87insbdmmk.wl-domenechjosel@gmail.com> (=?utf-8?Q?=22Jos?= =?utf-8?Q?=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech=22's?= message of "Sat, 29 Oct 2016 20:40:51 +0200") Message-ID: <87bmy2r4y2.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable tags 24620 fixed close 24620 26 quit Jos=C3=A9 L. Dom=C3=A9nech writes: > Sorry for the delay. I don't worry about delays which are approximately 0 days long :) > Perhaps this is more convenient: > > 2016-09-29 Jos=C3=A9 L. Dom=C3=A9nech > > Fix bug#24620: In dired enable compress to/from files whose filenames con= tains space characters. Okay, now the summary line is a bit too long. I shortened the summary and pushed your patch to master. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Quote-file-names-in-dired-compression-commands.patch Content-Description: patch >From 27443df092bfb4ada559f8fc024e01f174a5bcb0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Dom=C3=A9nech?= Date: Sat, 29 Oct 2016 21:18:31 -0400 Subject: [PATCH] Quote file names in dired compression commands * lisp/dired-aux.el (dired-do-compress-to): Change the string used as shell command for compression by quoting the filenames used for input and output (Bug #24620). --- lisp/dired-aux.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index d25352e..972b6b1 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1012,11 +1012,13 @@ dired-do-compress-to (t (when (zerop (dired-shell-command - (replace-regexp-in-string - "%o" out-file - (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + (format-spec (cdr rule) + `((?\o . ,(shell-quote-argument out-file)) + (?\i . ,(mapconcat + (lambda (file-desc) + (shell-quote-argument (file-name-nondirectory + file-desc))) + in-files " ")))))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) -- 2.9.3 --=-=-= Content-Type: text/plain > > Thanks for your patiente. Thanks for your contribution. P.S. your mails seem to be getting duplicated (or even triplicated for the last one). --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 04:33:29 2016 Received: (at 24620) by debbugs.gnu.org; 30 Oct 2016 08:33:29 +0000 Received: from localhost ([127.0.0.1]:36968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0lYX-0002KG-F2 for submit@debbugs.gnu.org; Sun, 30 Oct 2016 04:33:29 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0lYV-0002Jp-S5 for 24620@debbugs.gnu.org; Sun, 30 Oct 2016 04:33:28 -0400 Received: by mail-wm0-f67.google.com with SMTP id 68so7073421wmz.2 for <24620@debbugs.gnu.org>; Sun, 30 Oct 2016 01:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:disposition-notification-to:return-receipt-to :mime-version; bh=6/8QiC0te7+h1Ndq1Z7gsiuHLI+0oDW7aYFGy3qWV8w=; b=TrMsjmrCmiR9KD44sF7gsLQPDSlxP8MqzfQ0j73MmOTNLcNFwQOo+UApaZWbYjiPhs s7GUlQiNx7CV2KkgnFaO8qT/NnDwHOfB4W1Le6rOuogkWcXf066Q7ldWpzoGYpjHntMe q5bg45K5tQg9p0Oo6ArlCDMGfncnvOSImapSlyarRfQWQoIW1Q7jWcF+iwqASWQtsXR/ 631sIJhY9tpQyrVGLVbiuPDxSncIainqx9bivvXn8gHLZ5XtClkRqj24RCLJhC1hpVpp RWi1sxxU+LdW6fO2y9mmN5E67BD0SymjybM5L4qNnu0IvEONPpz0ymJJB61mQZMPq8Gt VoMg== X-Gm-Message-State: ABUngvcUk9yM9pFwR5bJCO4c6DqBwMUNDo4djjdqTqiKifiFP2bOeMkrnxwgbulFhn/bsw== X-Received: by 10.194.104.168 with SMTP id gf8mr18141079wjb.31.1477816401966; Sun, 30 Oct 2016 01:33:21 -0700 (PDT) Received: from jose-ThinkPad-Edge-E330.gmail.com (110.red-79-144-230.dynamicip.rima-tde.net. [79.144.230.110]) by smtp.gmail.com with ESMTPSA id o143sm18311437wmd.7.2016.10.30.01.33.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Oct 2016 01:33:21 -0700 (PDT) Date: Sun, 30 Oct 2016 09:33:19 +0100 Message-ID: <87zilm1bjk.wl-domenechjosel@gmail.com> From: =?ISO-8859-1?Q?Jos=E9?= L. =?ISO-8859-1?Q?Dom=E9nech?= To: npostavs@users.sourceforge.net Subject: Re: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters In-Reply-To: <87bmy2r4y2.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> <87k2crqrz1.fsf@users.sourceforge.net> <87insbdmmk.wl-domenechjosel@gmail.com> <87bmy2r4y2.fsf@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24620 Cc: 24620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sun, 30 Oct 2016 02:39:01 +0100, npostavs@users.sourceforge.net wrote: > > [1 ] > tags 24620 fixed > close 24620 26 > quit > > > I don't worry about delays which are approximately 0 days long :) > > > Okay, now the summary line is a bit too long. I shortened the summary > and pushed your patch to master. > Thank you. > [2 patch ] > From 27443df092bfb4ada559f8fc024e01f174a5bcb0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Dom=C3=A9nech?= > Date: Sat, 29 Oct 2016 21:18:31 -0400 > Subject: [PATCH] Quote file names in dired compression commands > > * lisp/dired-aux.el (dired-do-compress-to): Change the string > used as shell command for compression by quoting the filenames > used for input and output (Bug #24620). > --- > lisp/dired-aux.el | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index d25352e..972b6b1 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -1012,11 +1012,13 @@ dired-do-compress-to > (t > (when (zerop > (dired-shell-command > - (replace-regexp-in-string > - "%o" out-file > - (replace-regexp-in-string > - "%i" (mapconcat #'file-name-nondirectory in-files " ") > - (cdr rule))))) > + (format-spec (cdr rule) > + `((?\o . ,(shell-quote-argument out-file)) > + (?\i . ,(mapconcat > + (lambda (file-desc) > + (shell-quote-argument (file-name-nondirectory > + file-desc))) > + in-files " ")))))) > (message "Compressed %d file(s) to %s" > (length in-files) > (file-name-nondirectory out-file))))))) > -- > 2.9.3 > > [3 ] > > > > Thanks for your contribution. > > P.S. your mails seem to be getting duplicated (or even triplicated for the > last one). Sorry, it is all my fault. I still has to get a configuration for the mailinglist+NNTP+gmane (with wanderlust) where I get comfortable so i don't resend the messages when a error occurs in the sending process. Thanks again. From unknown Sat Sep 06 14:23:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 27 Nov 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator