From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 00:49:07 2016 Received: (at submit) by debbugs.gnu.org; 1 Oct 2016 04:49:07 +0000 Received: from localhost ([127.0.0.1]:40134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqCEU-0003Iq-Tp for submit@debbugs.gnu.org; Sat, 01 Oct 2016 00:49:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqCET-0003IN-GG for submit@debbugs.gnu.org; Sat, 01 Oct 2016 00:49:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqCEN-0000Wf-ER for submit@debbugs.gnu.org; Sat, 01 Oct 2016 00:49:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqCEN-0000WR-BM for submit@debbugs.gnu.org; Sat, 01 Oct 2016 00:48:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqCEL-0005Sx-7F for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 00:48:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqCEG-0000U6-6W for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 00:48:56 -0400 Received: from mail-lf0-x230.google.com ([2a00:1450:4010:c07::230]:35317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqCEF-0000Tt-VH for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 00:48:52 -0400 Received: by mail-lf0-x230.google.com with SMTP id l131so121302848lfl.2 for ; Fri, 30 Sep 2016 21:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version; bh=O3guGx3EhUc51jurvVSSZk+wRSi7mSENISHxISF9TcU=; b=Ogezp0lEqKeVC7PKFYFdPKSUTtV7SIm2JAd7FTDYUIe1TrTMSVVIt3ZPDvDB97pz8W G0RhkicEMoa+AynpVzywLISBNXgWq4S8oDmngYsPrvOPqrya8W56B+uz4ZL8Qtu9R6R4 udnp+zeBGruGnb3Egp+ob3i+2HQosEVaejXKnKw+YQlA/rvsQnvlfIi8Q6oNBP3LaZsx fm1Y/b5x2uQmtMfdxF1vbVTU9fTmsXGMxNsNnKekQYu1U30QJCC2TpPJyWErxGUVzUE0 FGr2TLdgAHAh+q2nnqUw7iVjJRzjSjAbFC+nhg6j7xejDjV0ruUF5e+pzLEf48ucW24e 3c3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=O3guGx3EhUc51jurvVSSZk+wRSi7mSENISHxISF9TcU=; b=m3tisV7UC6I8MwUU4Xhd/t0DBkZIDNIBLij7UnjZvc3G5RlI6nPwt4E1tDm9EGOyyv q3CwbU4TpbQMCPX2HAMpf4pigPwHXhvOF60KTRvq68422pKIh4Xt1AbY8ExUJ2iIlEIT dNjlf2vAcJrMr2Cy7RhjKJ1ZL3+Veoe7AxNaiNiC//cKxq9+xv2gPCOUbfJA6WUWmNii odza6tsPo25mi+VXr+Z7AdSUQHMA/iXquLNagh/3A7KPetHqa4F2/wlBun2qgTOqPWrO Y5tIVtWZUfnEw3+1bq36MJpmoFeUGLZoWvNEBgAyXyjcw78qcQUvq/se54rSvJNUok9h T0Iw== X-Gm-Message-State: AA6/9RnO3DjoD7lKaoOEyzFeD3K+uRZPwV22L3oxcEJZjsSQLKDp0614u+arEvmAH6IAvg== X-Received: by 10.46.9.69 with SMTP id 66mr4144746ljj.63.1475297330375; Fri, 30 Sep 2016 21:48:50 -0700 (PDT) Received: from gmail.com ([46.48.49.226]) by smtp.gmail.com with ESMTPSA id f65sm3541433lji.32.2016.09.30.21.48.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Sep 2016 21:48:49 -0700 (PDT) From: Dmitri Paduchikh To: bug-gnu-emacs@gnu.org Subject: 25.1; desktop.el does not fully preserve registers with macros Date: Sat, 01 Oct 2016 09:48:48 +0500 Message-ID: <874m4wwu6n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, Register ?a contains keyboard macro. After loading desktop file: (registerv-insert-func (get-register ?a)) => "Unprintable entity" (registerv-print-func (get-register ?a)) => "Unprintable entity" This makes M-x list-registers and register insertion to fail. Using interpreted version of kmacro-to-register fixes this problem. (registerv-insert-func (get-register ?b)) => (lambda (k) (insert (format-kbd-macro k))) (registerv-print-func (get-register ?b)) => (lambda (k) (princ (format "a keyboard macro: %s" (format-kbd-macro k)))) In GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9) of 2016-09-18 built on juergen Regards, Dmitri Paduchikh From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 18:41:22 2019 Received: (at 24576) by debbugs.gnu.org; 10 May 2019 22:41:22 +0000 Received: from localhost ([127.0.0.1]:39393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPECg-000702-EI for submit@debbugs.gnu.org; Fri, 10 May 2019 18:41:22 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:35637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPCWq-0002Ja-IZ for 24576@debbugs.gnu.org; Fri, 10 May 2019 16:54:05 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8624740B; Fri, 10 May 2019 16:53:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 10 May 2019 16:53:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=knosis.org; h= from:content-type:content-transfer-encoding:mime-version:subject :message-id:date:cc:to; s=fm3; bh=rnx2/0vBCfmWu+ODFLp/MI1WKhyWy0 eZTiAPXQEniyY=; b=TnmPmZrj4kvqBCLMaDESdyrQfN4rHb/DAEgmqyP/HsSVSw 5OjKNV51GV0aYBQt8osmoGrVRMtlZJCXpj635aiRXv8mv3jW8YAXxisJfGHqzomX COBObKt4A2a8N5jcdWJrWPXV4eUp3r6yo+lwYygL5XjwP5txfLTWkwdhY2ZHyJoh y/QlnBUM9tj2vPcW7qODBtNRsTUIk0a1jMUMxoVisn3kKePe7oQFeNKabHPHFCld lyMmtZEH6x1h+wgkaNFIr8TrLXUVKskiqcMuFZzlyePLGwFvQ+8K2bb6CcEx17EY YnJCGMOk5c1XgjPgg7JDgm6zk3QofeiwmCAwPUUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rnx2/0 vBCfmWu+ODFLp/MI1WKhyWy0eZTiAPXQEniyY=; b=Tdg0nCoo+9lAKKgAeRrZ3J Z7g5IdfKMfF4lA0VgBHZDeHYNUj2bllNEF7poRIP5Efu9Hs5QvsnYYOAX8pKdhY1 D/Uzu3cAeZzd+wqoS6CI8Fr4WuojrDLK3SX1aW1aB8cJ2C2MUFgkt7rDzszDKS5c JCkMdukW93Ie6cjMgxnKtFM2rhi2PAsC1gTWRnry+cfXF7IhdSqXn68zolnboRWP 8RYylyAbIXGBQMQM84IEOOwtk5sJoSLuZz//IjpgY0Z/DtMceJY9cBmLSve7hzHW rvyPht7Py+N4PNhwpCpGbsGgD2OGwFiGH4F8U5bzK+z/Uu6+R7LW4IZfaki/N+HA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeekgdduheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtgfgggfukfffvffosehtqhhmtd hhtdejnecuhfhrohhmpeforghtthhhvgifucfpvgifthhonhcuoehmrghttheskhhnohhs ihhsrdhorhhgqeenucfkphepudehjedrudefuddrvdehuddrgeelnecurfgrrhgrmhepmh grihhlfhhrohhmpehmrghttheskhhnohhsihhsrdhorhhgnecuvehluhhsthgvrhfuihii vgeptd X-ME-Proxy: Received: from [192.168.0.112] (157-131-251-49.fiber.dynamic.sonic.net [157.131.251.49]) by mail.messagingengine.com (Postfix) with ESMTPA id 8065110379; Fri, 10 May 2019 16:53:57 -0400 (EDT) From: Matthew Newton Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: bug#24576: 25.1; desktop.el does not fully preserve registers with macros Message-Id: Date: Fri, 10 May 2019 13:53:54 -0700 To: 24576@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.8) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24576 X-Mailman-Approved-At: Fri, 10 May 2019 18:41:21 -0400 Cc: dpaduchikh@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Apologies for reviving a stale bug but it appears to not be resolved = yet. Here is my experience with this, running my own build from a recent = master: GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin18.5.0, NS appkit-1671.40 = Version 10.14.4 (Build 18E226)) of 2019-04-22 ;; .emacs (require =E2=80=98desktop) (desktop-save-mode 1) ;; before killing Emacs (pp register-alist) ((107 . #s(registerv "=05" #[257 "\300\301\302\303=04!\"!\207" [princ format "a keyboard macro:\n %s" = format-kbd-macro] 6 "\n\n(fn K)"] kmacro-execute-from-register #[257 "\300=01!c\207" [format-kbd-macro] 3 "\n\n(fn K)"]))) `M-x list-registers` Register k contains a keyboard macro: C-e Register p contains a buffer position: buffer t.el, position 21 ;; after killing Emacs and running it again (pp register-alist) ((107 . #s(registerv "=05" "Unprintable entity" = kmacro-execute-from-register "Unprintable entity"))) `M-x list-registers` Invalid function: "Unprintable entity=E2=80=9D ;; Abbreviated stack trace Debugger entered--Lisp error: (invalid-function "Unprintable entity") "Unprintable entity"("\5") #f(compiled-function (val verbose) #)(#s(registerv :data "\5" :print-func "Unprintable entity" = :jump-func kmacro-execute-from-register :insert-func "Unprintable = entity") nil) apply(#f(compiled-function (val verbose) #) = #s(registerv :data "\5" :print-func "Unprintable entity" :jump-func = kmacro-execute-from-register :insert-func "Unprintable entity") nil) register-val-describe(#s(registerv :data "\5" :print-func "Unprintable = entity" :jump-func kmacro-execute-from-register :insert-func = "Unprintable entity") nil) describe-register-1(107) list-registers() funcall-interactively(list-registers) call-interactively(list-registers record nil) command-execute(list-registers record) (closure ((externs) (initial-input) smex-ido-cache smex-initialized-p = amx-cache amx-initialized info-lookup-mode t) (cmd) (setq cmd (intern = cmd)) (cond ((and (boundp 'amx-initialized) amx-initialized) (amx-rank = cmd)) ((and (boundp 'smex-initialized-p) smex-initialized-p) (smex-rank = cmd))) (setq prefix-arg current-prefix-arg) (setq this-command cmd) = (setq real-this-command cmd) (command-execute cmd = 'record))("list-registers") #f(compiled-function (x) #)("list-registers") So there seem to be two bugs: 1. `desktop-save-mode` doesn=E2=80=99t serialize/deserialize keyboard = macros properly (is it difficult to serialize a function object?) 2. Either :print-func and :insert-func should never be set to = =E2=80=9CUnprintable entity=E2=80=9D or `register-val-describe` should = handle the case where they are set to that value instead of a function. = I=E2=80=99ve also seen =E2=80=9CUnprintable entity=E2=80=9D show up when = a buffer position register points to a nonexistent buffer. Not sure how = to reproduce that one. I could probably dive deeper and see if I can fix this. But I would = appreciate some thoughts from experienced Emacs devs about whether I = understand the problem correctly. Any hints as to the best solution = would also be great. Cheers, Matt= From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 08:16:00 2019 Received: (at 24576) by debbugs.gnu.org; 11 May 2019 12:16:00 +0000 Received: from localhost ([127.0.0.1]:40020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPQv2-00051W-Bq for submit@debbugs.gnu.org; Sat, 11 May 2019 08:16:00 -0400 Received: from mail-it1-f176.google.com ([209.85.166.176]:34011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPQv0-00051J-FY for 24576@debbugs.gnu.org; Sat, 11 May 2019 08:15:58 -0400 Received: by mail-it1-f176.google.com with SMTP id p18so9761790itm.1 for <24576@debbugs.gnu.org>; Sat, 11 May 2019 05:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=UhT5p/6pi7i7oYfDhhdPU/M4UXofqMt7pveUBRU7VVo=; b=NdlwAKwUxJJWJjUEe56spSr+p+dROr/PeC9cTSOqctjbSzv596y6H6fZBXVdnnZxjF CBqX+wC58rWUw4XM9uFL+LEDcEDsQ6rYYLgRHrxuzkSwh89YWG5mZFZMH8+E4l52qWv6 upMZ/jMxVywbI30/Ab1pxmJCrTQkJ+hIoThHAl1VAgHVU5lcYAwKvGMkiW3Mni8nWrrO qUW51LycETksh1wpzMWZjBaqA/jzEHQCe6eGUZkSnLS8lUN2n33+9KGL2+D0y0hYm1fh c5s8IZUv0dBjsq3eZVxJI7fug8Nfr4S1W3Pju4Mq2SeZ1DLTDFJrVqou17j9/3U5Ytd4 4tsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=UhT5p/6pi7i7oYfDhhdPU/M4UXofqMt7pveUBRU7VVo=; b=Tq5g/ApZcKq5kvQDTjDixdZSq+Y1cR4twOumYAeSie+89m61EJx6y+2tRuSyHt4jrL pVCtx3zZYYt46GOJyvxQ3tEFOxyzwp7FuiBfAI9EnewCRsZfxb1Ml9TznfDF6t547CxG tXdZThFdFzamvNdafk93OWqqK1zPT0VX5Aj+aBHmkloh5DcMGEoG95ZJANQdXxfPZHMh IQwePoeIFEOxwuxH5a2nSjyCedUndsmcDTN21QUI0/XiKkTzmABhdAYW0GYDsPI0dabJ htVBdEODQLgcS73KTVwk/icQr1+g9vyUy/0PL3/751bdVNHJ/TO0Mx+StD4Z0CAB9BMU km4w== X-Gm-Message-State: APjAAAUCVb2QiiFhkGA0Z1zv+QMQy+vsmzU+L4O1jqEpehi0cpK37Bm+ Da2V+whgm+tN991JVeTPoRg= X-Google-Smtp-Source: APXvYqxXestjV7k4dWA6z2suyr4FY7uZ0K36hDkDFHe6dT2jJr+RVOaelOW1ndrWDkke4t29bZWsxA== X-Received: by 2002:a24:8748:: with SMTP id f69mr3339833ite.39.1557576951901; Sat, 11 May 2019 05:15:51 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u205sm3419009itc.44.2019.05.11.05.15.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 May 2019 05:15:51 -0700 (PDT) From: Noam Postavsky To: Matthew Newton Subject: Re: bug#24576: 25.1; desktop.el does not fully preserve registers with macros References: <874m4wwu6n.fsf@gmail.com> Date: Sat, 11 May 2019 08:15:50 -0400 In-Reply-To: (Matthew Newton's message of "Fri, 10 May 2019 13:53:54 -0700") Message-ID: <87v9yhi3ux.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24576 Cc: dpaduchikh@gmail.com, 24576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthew Newton writes: > Apologies for reviving a stale bug but it appears to not be resolved yet. No apologies needed, on the contrary, thank you for looking at it. > So there seem to be two bugs: > > 1. `desktop-save-mode` doesn=E2=80=99t serialize/deserialize keyboard mac= ros > properly (is it difficult to serialize a function object?) > 2. Either :print-func and :insert-func should never be set to > =E2=80=9CUnprintable entity=E2=80=9D or `register-val-describe` should ha= ndle the case > where they are set to that value instead of a function. The "unprintable entity" comes from desktop--v2s, looks like it doesn't handle compiled function values, so that's why :print-func and :insert-func get messed up like that. > I=E2=80=99ve also seen =E2=80=9CUnprintable entity=E2=80=9D show up when = a buffer position > register points to a nonexistent buffer. Not sure how to reproduce > that one. I guess if you save a position in a buffer, then kill the buffer. From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 16:58:16 2019 Received: (at 24576) by debbugs.gnu.org; 22 May 2019 20:58:16 +0000 Received: from localhost ([127.0.0.1]:43127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTYJT-0006vp-KS for submit@debbugs.gnu.org; Wed, 22 May 2019 16:58:16 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTYJR-0006vZ-Qz for 24576@debbugs.gnu.org; Wed, 22 May 2019 16:58:14 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 49BBE21B2A; Wed, 22 May 2019 16:58:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 22 May 2019 16:58:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=knosis.org; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=X i7TyfFJJUbPdKZtmJ4Rmp8i6hTa9gjRbUzaAhO+JeQ=; b=0BW7kfvQWowOts03s KLjMUD1DZR8VSlcXBMioXM4v1jvf4ZjMpXymwtuK/aKYGE3K8ovNl4cuIYXgSIW0 nmc5ga23sWQ22oS/+eLMcBpmY1UJs4l5Vd0VVZKXr+riC/aBTZ5ce+/mz//GZXAc QEXmZHr4N/4gTEaMn/XDPwDh3W/JZTg146+nnxjksCatPWqpSHeZC46zvkgtTcxE PUiwQwCO0xMDqeZ7nzETmHpxLMaVxDv/x5eATvmGSdllxULpjv5ljUIfpSYePp8V wvWwdng+0tdfJeJVmtpU+jbG0n/kim3Jrd6rLXU+O3eonGPE5/4c0BlL/UY8UAcS 5tcSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Xi7TyfFJJUbPdKZtmJ4Rmp8i6hTa9gjRbUzaAhO+J eQ=; b=rHs2uBV/L19W6+VGX1GCQgxky2BUfXTmXPWsfR7socjTdIDnt+BB/ZTCV cGIG1XjBWMGc9MwUF9J3sItGHorcnu+jGWFDoHzxbQH4hSuoyiubwcVzJpUyuqIX DNb4pCs7f3odlIOqYO+CciMFhh+DJ+ohF4Xjk+dTHZ663McNrLTuynbufYztptXX j1oOYQrurMKN8GbQZaBubN8sqO5Wy5FbgJZhfY6E4oDvNeTPuuJmw9gZkTEkWxsQ wkcuz77IJoVEk2GtNsp9/cN/D6rqOSrwklXWtvv8UBGk61AeXynzFQJqgKAN2jwQ uYnSggUySYS24gfY3UW+8kqprFb9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudduvddgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeforght thhhvgifucfpvgifthhonhcuoehmrghttheskhhnohhsihhsrdhorhhgqeenucfkphepud ehjedrudefuddrvdehuddrgeelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghtthes khhnohhsihhsrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from [192.168.0.112] (157-131-251-49.fiber.dynamic.sonic.net [157.131.251.49]) by mail.messagingengine.com (Postfix) with ESMTPA id 643028005B; Wed, 22 May 2019 16:58:07 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#24576: 25.1; desktop.el does not fully preserve registers with macros From: Matthew Newton In-Reply-To: <87v9yhi3ux.fsf@gmail.com> Date: Wed, 22 May 2019 13:58:06 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org> References: <874m4wwu6n.fsf@gmail.com> <87v9yhi3ux.fsf@gmail.com> To: Noam Postavsky X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24576 Cc: dpaduchikh@gmail.com, 24576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) It seems that the more pressing issue is desktop handling byte code. > On May 11, 2019, at 5:15 AM, Noam Postavsky = wrote: >=20 > Matthew Newton writes: >=20 >> Apologies for reviving a stale bug but it appears to not be resolved = yet. >=20 > No apologies needed, on the contrary, thank you for looking at it. >=20 >> So there seem to be two bugs: >>=20 >> 1. `desktop-save-mode` doesn=E2=80=99t serialize/deserialize keyboard = macros >> properly (is it difficult to serialize a function object?) Would it make sense to simply do something like this? (defun desktop--v2s (value) ... (cond ((byte-code-function-p value) (let* ((pass1 (mapcar #'desktop--v2s value)) (special (assq nil pass1))) (if special (cons nil `(make-byte-code ,@(mapcar (lambda (el) (if (eq (car el) 'must) `',(cdr el) (cdr el))) pass1))) (cons 'may `[,@(mapcar #'cdr pass1)])))) =E2=80=A6)) I copied that from the `cond` clause for vector. It works in my limited = testing. Are there security concerns or other considerations? >=20 >> 2. Either :print-func and :insert-func should never be set to >> =E2=80=9CUnprintable entity=E2=80=9D or `register-val-describe` = should handle the case >> where they are set to that value instead of a function. >=20 > The "unprintable entity" comes from desktop--v2s, looks like it = doesn't > handle compiled function values, so that's why :print-func and > :insert-func get messed up like that. >=20 >> I=E2=80=99ve also seen =E2=80=9CUnprintable entity=E2=80=9D show up = when a buffer position >> register points to a nonexistent buffer. Not sure how to reproduce >> that one. >=20 > I guess if you save a position in a buffer, then kill the buffer. >=20 Here is what I found: if the killed buffer visits a file, it gets = converted into a file-query. If there is no `buffer-file-name` then it = stays a file marker pointing to nowhere. Desktop handles both of those = cases correctly. So while I have seen it happen I=E2=80=99m not sure of = the case where a buffer position register becomes an =E2=80=9CUnprintable = entity=E2=80=9D. Did you find reproduction steps? Cheers, Matt From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 23:43:21 2019 Received: (at 24576) by debbugs.gnu.org; 23 May 2019 03:43:22 +0000 Received: from localhost ([127.0.0.1]:43625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTedV-00028K-J0 for submit@debbugs.gnu.org; Wed, 22 May 2019 23:43:21 -0400 Received: from mail-it1-f176.google.com ([209.85.166.176]:56055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTedU-000285-1U for 24576@debbugs.gnu.org; Wed, 22 May 2019 23:43:20 -0400 Received: by mail-it1-f176.google.com with SMTP id g24so415637iti.5 for <24576@debbugs.gnu.org>; Wed, 22 May 2019 20:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5vDbv8D1c6HFKfa0z7HeS7rbLAxjV1qAhBwzFcDEmf0=; b=GekGvhCjtUxA27PIDxEEJpL/O+j55T6unIm+Eor1gqaV89Gs2BGvTxq7U6nFeopE2l +d9qeQ2kTmZ3adrLzP7bYIRzqRe9U8C/NBvZ8oNUvAHfkkQdDjaPJreC4uLzA2MuHsi6 dMZ5cOQ5wArV1DZwoTQjDheIvoaLJ0fI+xB95Wm7c45p1PQzW04j24SYngKALE/mpC7O nmjymJpdKJLot57QJh0Zc/Mwdy0soUy/xtR13iJvqz/qruLW+i2HyPMBMsYaD2886EU5 hAMv2HL2WtBnSChH8MgDdr7xmUZdaLPKEAB5WHNHeJ9rM2LXNJ63LcJ/BHzAHBQrL4/1 HylQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5vDbv8D1c6HFKfa0z7HeS7rbLAxjV1qAhBwzFcDEmf0=; b=EJPIy5q3YQzE2WXtXcS1UKpTJSdfWRZ0KHUZkS3c4Vfcf9t4dXSgLU4cIftlDLm6Kk Zh589oIcbr7KLYup+VGVvy3aErdQNrf96fDrN1B8icV/G845CiqH/W6PW9KcZ8FHSMu2 wiL8yfKvblSfklwYT1EjvWIS9kfkgY4ZI+4h1WkpalTORSkNd0jyBZrVLIjzb7AtRgqk Ofr+YGV/vzuUsrUpcT4RZiCgGxL5+MXLVeUXlzkSdvFRAq6xA6qraMPp8wXnX9AIoAzF fGqcKnrSzmt32xXgLN/Cvi8gqj/+MOyXyCERV58UiC19viXfDabf+OZb/XQnM28Wxssk 3vWA== X-Gm-Message-State: APjAAAWKCoocbO6lL4QkpddMuVwp43wtLLYv2E/QMToQ5DQNlrktPFng o5TCcg/jqcPZbmQphseJyAlZxC2f X-Google-Smtp-Source: APXvYqznqeTXYZlACxELNqtagjdblL3il4PPLskC6qX1sxwfXauOJyWHvtudLpwcbUQDSye1r5CHXg== X-Received: by 2002:a24:27c6:: with SMTP id g189mr11314197ita.114.1558582994057; Wed, 22 May 2019 20:43:14 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id p129sm3559883itg.14.2019.05.22.20.43.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 May 2019 20:43:13 -0700 (PDT) From: Noam Postavsky To: Matthew Newton Subject: Re: bug#24576: 25.1; desktop.el does not fully preserve registers with macros References: <874m4wwu6n.fsf@gmail.com> <87v9yhi3ux.fsf@gmail.com> <45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org> Date: Wed, 22 May 2019 23:43:12 -0400 In-Reply-To: <45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org> (Matthew Newton's message of "Wed, 22 May 2019 13:58:06 -0700") Message-ID: <87a7fdal9r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24576 Cc: dpaduchikh@gmail.com, 24576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthew Newton writes: > (defun desktop--v2s (value) > ... > (cond > ((byte-code-function-p value) > (let* ((pass1 (mapcar #'desktop--v2s value)) > (special (assq nil pass1))) > (if special > (cons nil `(make-byte-code > ,@(mapcar (lambda (el) > (if (eq (car el) 'must) > `',(cdr el) (cdr el))) > pass1))) > (cons 'may `[,@(mapcar #'cdr pass1)])))) I don't think `[...] will ever return a byte code function, so the non-special case doesn't seem quite right. > Are there security concerns or other considerations? Well, as (info "(elisp) Byte-Code Objects") mentions, passing the wrong args to make-byte-code can produce a function which will crash Emacs when called, so it's somewhat high risk. >> The "unprintable entity" comes from desktop--v2s, looks like it doesn't >> handle compiled function values, so that's why :print-func and >> :insert-func get messed up like that. I note that the functions in question come from this code in kmacro.el: (defun kmacro-to-register (r) ... (registerv-make last-kbd-macro :jump-func 'kmacro-execute-from-register :print-func (lambda (k) (princ (format "a keyboard macro:\n %s" (format-kbd-macro k)))) :insert-func (lambda (k) (insert (format-kbd-macro k)))) While in register.el we have: (cl-defun registerv-make (data &key print-func jump-func insert-func) ... (declare (obsolete "Use your own type with methods on register-val-(inser= t|describe|jump-to)" "27.1")) So perhaps this is a good opportunity to change the kmacro register stuff to use the non-obsolete way. =20 >>> I=E2=80=99ve also seen =E2=80=9CUnprintable entity=E2=80=9D show up whe= n a buffer position >>> register points to a nonexistent buffer. Not sure how to reproduce >>> that one. >>=20 >> I guess if you save a position in a buffer, then kill the buffer. >>=20 > Here is what I found: if the killed buffer visits a file, it gets > converted into a file-query. If there is no `buffer-file-name` then it > stays a file marker pointing to nowhere. Desktop handles both of those > cases correctly. So while I have seen it happen I=E2=80=99m not sure of t= he > case where a buffer position register becomes an =E2=80=9CUnprintable > entity=E2=80=9D. Did you find reproduction steps? Ah, no, I was just guessing based on your initial description, no idea how to reproduce it if desktop.el is already handling these cases. From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 13:41:03 2019 Received: (at 24576) by debbugs.gnu.org; 29 May 2019 17:41:03 +0000 Received: from localhost ([127.0.0.1]:59798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW2ZS-0005dN-Vg for submit@debbugs.gnu.org; Wed, 29 May 2019 13:41:03 -0400 Received: from mail-lj1-f174.google.com ([209.85.208.174]:40047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW2ZQ-0005ck-TE for 24576@debbugs.gnu.org; Wed, 29 May 2019 13:41:01 -0400 Received: by mail-lj1-f174.google.com with SMTP id q62so3333324ljq.7 for <24576@debbugs.gnu.org>; Wed, 29 May 2019 10:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PKBbdSUIXGMVAVpwI/G5da3gnJ1Eslij3CTSAavKL88=; b=oh6AKNWl68ho0LnLrrohlAeUwcsW8pAnV19j52P3zEdX+Lb98zCjXfcrrdXzJYjNdq Qgj9rbAItuRm5aTE+PoB1gVQ5afaNEKFGwIDqvz+20xNg/ELdZ5Ab4TRy1zKRTuaE6gT pQQjWObQOnXTbacbJfxhby8IyRFhUYDcD26Jg/5A/gH6WCSTmATLxKtihhCRIm0wRouG 5U1vZKzoiOq+Y8kUiYhgA6w5XkeXV+bxOFJoDdsGVzj+nk+EZr/wEViRqai108bBU/Th viI27qgYHFQkZxeOz9EXJQTKURo9sRtbRcHMKiIb3bHiske88enlQkniM/AvlWeCWmXL ccjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PKBbdSUIXGMVAVpwI/G5da3gnJ1Eslij3CTSAavKL88=; b=XcgCtXXH/8ZzJ1bof1pnAmHJDIks4/eq/qVGTB0GUX4Kif9CqW176BVexoVbHhEY+a mAGhvmI55yj8Dfxhmgn/8G+hKJxPW5eBaAq+jGIzalFAV8mIdIpbqpEEaOltZAkWcztA FE2tueMPWMLqp+jNOmtSEf5+ESwRq2jAgr8Q82/43bbyp/aFFeUnPY3ZjMB5r/M8qGJF iD/z5QZu9JvUjj2nnDxRM4pEmIAPh78+ntGlO4+c1kez+rIsd/2S7zw7zin3lEH8rb0N nAoDp9fqBfoB5Iuw1mjL5WwMVtqKs+kOeVR5N9mdTiifzUdpf69WBcmeCrrytdX9JbeM jZIA== X-Gm-Message-State: APjAAAXmb0pIJ/99MC/KcBOMGuJxinMBOzPsrKdIiVDyNRafC8/NCcAc eS1jc4YdX70VCa4SOQ4t8Lg= X-Google-Smtp-Source: APXvYqzZM4TjjOJRq7hlFmaPjmzYkeXxVx92hZPabbH8d1x+NnKXLJg9UZjftQkB8bEfxr8fykJNkw== X-Received: by 2002:a2e:8954:: with SMTP id b20mr23603594ljk.10.1559151654871; Wed, 29 May 2019 10:40:54 -0700 (PDT) Received: from gmail.com ([188.226.13.13]) by smtp.gmail.com with ESMTPSA id s12sm3582869lji.34.2019.05.29.10.40.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 10:40:53 -0700 (PDT) From: Dmitri Paduchikh To: Noam Postavsky Subject: Re: bug#24576: 25.1; desktop.el does not fully preserve registers with macros References: <874m4wwu6n.fsf@gmail.com> <87v9yhi3ux.fsf@gmail.com> <45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org> <87a7fdal9r.fsf@gmail.com> Date: Wed, 29 May 2019 22:41:58 +0500 In-Reply-To: <87a7fdal9r.fsf@gmail.com> (Noam Postavsky's message of "Wed, 22 May 2019 23:43:12 -0400") Message-ID: <87imttximx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Noam Postavsky wrote: >>> The "unprintable entity" comes from desktop--v2s, looks like it doesn't >>> handle compiled function values, so that's why :print-func and >>> :insert-func get messed up like that. Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.8 FSL_HELO_FAKE No description available. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dpaduchikh[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.174 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 24576 Cc: Matthew Newton , 24576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Noam Postavsky wrote: >>> The "unprintable entity" comes from desktop--v2s, looks like it doesn't >>> handle compiled function values, so that's why :print-func and >>> :insert-func get messed up like that. Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.174 listed in list.dnswl.org] 3.8 FSL_HELO_FAKE No description available. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dpaduchikh[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Noam Postavsky wrote: >>> The "unprintable entity" comes from desktop--v2s, looks like it doesn't >>> handle compiled function values, so that's why :print-func and >>> :insert-func get messed up like that. NP> I note that the functions in question come from this code in kmacro.el: NP> (defun kmacro-to-register (r) NP> ... (registerv-make NP> last-kbd-macro NP> :jump-func 'kmacro-execute-from-register NP> :print-func (lambda (k) NP> (princ (format "a keyboard macro:\n %s" NP> (format-kbd-macro k)))) NP> :insert-func (lambda (k) NP> (insert (format-kbd-macro k)))) This must be easy to fix. Just defun these anonymous functions and use their names in place of lambdas. Or any newer approach, of course. All the best. Dmitri Paduchikh From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 13:44:04 2019 Received: (at 24576) by debbugs.gnu.org; 12 Jun 2019 17:44:04 +0000 Received: from localhost ([127.0.0.1]:34024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb7I4-00005l-Hc for submit@debbugs.gnu.org; Wed, 12 Jun 2019 13:44:04 -0400 Received: from mail-it1-f182.google.com ([209.85.166.182]:38121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb7I1-00004s-OK; Wed, 12 Jun 2019 13:44:02 -0400 Received: by mail-it1-f182.google.com with SMTP id e25so11948167itk.3; Wed, 12 Jun 2019 10:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pvbz+IlkRjySlhwX2gGpBTw2QCj17f7V5gW+HKAMYiY=; b=r68E4g0djAgp0epnd7hmnyuQBoUxvXFr2AdLaeaHAJ5taMc7AmP2AFa4/8A5ge0MNQ OVlq5xmbXPoGI/uaCSQqz9GVQeRj1ZGCROjw0rjQE5Ba+g3NjrF/HqAf7Psav9Qgc1jR I+0yc4wbR8KKFaf3Uf7EnRpH+rF19BviiUWjZJ2PlooLKxYUpFr6Xl66QRZHEy8xIVQU 9H45dSzateVKCt8jvxfKIAxTsifBK/pexm+y3a2vIo8AwHVFhv5pyFFiy2rim0fnJxVM WxKXmv1bq07XEsQiTafpeuX4ZiaMm2MwDAV3XQeSuV/c+zyLr0+tnUJBbfCtMjlap3DK Ce+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pvbz+IlkRjySlhwX2gGpBTw2QCj17f7V5gW+HKAMYiY=; b=Qqkhgb5m8ytemXsj2gIdD5ZHkBFa6l01UCss5wyicBlRvUMgU/O+WQJeGyEx5fPB/J pYiwo4Ijjbm4355MuuEn7XSa4nzBy63uVEx9vZOEMPtma3/8UtuI8/NeR2fcPXcJc7si hIUI1dPgIKqI+k3wZgC6BxJDeXydnzqNbA7sSSMttZCOyIthPEQu5RUnu5AGCj7ziBaZ WyivLNyASdBB+0OWKIxx9AWVUY2wl9ix4s4YRGBzYiIBZ+/+qQawnU91OYPEysJJgmo3 LhGlc0YFucHWJhKgry+Rbq5baTloQtC8RGVj+140IsBNzYEUJqBE6yidW7h5FE71j1cc IPlA== X-Gm-Message-State: APjAAAUdfLgEk3O5UIYWiKvbDOtLZiuKq0jsDiCybLN0uRXpExZ4xSeM KbMJCxJeb9pdE8qXarquUqRefRTd X-Google-Smtp-Source: APXvYqxgti5mxsNUgq39W4jUK04klvdq2LZq6Q6CNhwSnWBKv6m78HUBxau6UqRlLvINAhM+h0SJtA== X-Received: by 2002:a24:2bcc:: with SMTP id h195mr252452ita.108.1560361435927; Wed, 12 Jun 2019 10:43:55 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id f20sm170595ioh.17.2019.06.12.10.43.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 10:43:54 -0700 (PDT) From: npostavs@gmail.com To: Noam Postavsky Subject: Re: bug#24576: 25.1; desktop.el does not fully preserve registers with macros References: <874m4wwu6n.fsf@gmail.com> <87v9yhi3ux.fsf@gmail.com> <45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org> <87a7fdal9r.fsf@gmail.com> Date: Wed, 12 Jun 2019 13:43:54 -0400 In-Reply-To: <87a7fdal9r.fsf@gmail.com> (Noam Postavsky's message of "Wed, 22 May 2019 23:43:12 -0400") Message-ID: <85r27yaecl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24576 Cc: Matthew Newton , dpaduchikh@gmail.com, 24576@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24576 fixed close 24576 27.1 quit > So perhaps this is a good opportunity to change the kmacro register > stuff to use the non-obsolete way. Lars did this, so I think the bug should be fixed now. [1: 26f2b1f]: 2019-06-12 18:21:35 +0200 Rewrite the kmacro register function to avoid using obsolete functions https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=26f2b1faaa1dc8847f2013268c20f51c144ae711 From unknown Sun Sep 07 16:50:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jul 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator