GNU bug report logs - #24555
[PATCH] Remove unused variable `command-debug-status'

Previous Next

Full log

Message #8 received at 24555 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philippe Vaucher <philippe.vaucher <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 24555 <at> debbugs.gnu.org
Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Wed, 28 Sep 2016 17:58:41 +0300

> From: Philippe Vaucher <philippe.vaucher <at> gmail.com>
> Date: Wed, 28 Sep 2016 14:39:02 +0200
> 
> For information, I did the procedure for copyright assignment to Emacs and it is complete.

Indeed, your assignment is on file.

> This patch removes the variable `command-debug-status', which really seems to be unused since a long time
> to me (that's what "git -G Vcommand-debug-status" says).

Thanks for bringing this up.

I looked into the history of this variable, and found that it was
still supported in Emacs 24.5, and was removed during development of
Emacs 25 by this commit:

  commit 0e4857b7d84f958f66e726ed57b824427b272681
  Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
  Date:   Tue May 27 20:09:14 2014 -0400

      * src/callint.c (Ffuncall_interactively): New function.
      (Qfuncall_interactively): New var.
      (Qcall_interactively): Remove.
      (Fcall_interactively): Use it.
      (syms_of_callint): Defsubr it.
      * lisp/subr.el (internal--funcall-interactively): New.
      (internal--call-interactively): Remove.
      (called-interactively-p): Detect funcall-interactively instead of
      call-interactively.
      * lisp/simple.el (repeat-complex-command): Use funcall-interactively.
      (repeat-complex-command--called-interactively-skip): Remove.

As you see, the commit log doesn't mention the removal of the
variable.  Stefan, was it removed on purpose?  If so, can you tell
why?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.