GNU bug report logs - #24555
[PATCH] Remove unused variable `command-debug-status'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24588: closed ([PATCH 1/2] Restore command-debug-status
 functionality)
Date: Tue, 04 Oct 2016 14:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 04 Oct 2016 17:43:18 +0300
with message-id <83r37wmayh.fsf <at> gnu.org>
and subject line Re: bug#24555: [PATCH] Remove unused variable `command-debug-status'
has caused the debbugs.gnu.org bug report #24555,
regarding [PATCH 1/2] Restore command-debug-status functionality
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24555: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24555
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philippe Vaucher <philippe.vaucher <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH 1/2] Restore command-debug-status functionality
Date: Sun,  2 Oct 2016 18:59:54 +0200

---
 src/callint.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/callint.c b/src/callint.c
index 053ee6c..4652151 100644
--- a/src/callint.c
+++ b/src/callint.c
@@ -837,7 +837,10 @@ invoke it.  If KEYS is omitted or nil, the return value of
   kset_last_command (current_kboard, save_last_command);
 
   {
-    Lisp_Object val = Ffuncall (nargs, args);
+    Lisp_Object val;
+    specbind (Vcommand_debug_status, Qnil);
+
+    val = Ffuncall (nargs, args);
     val = unbind_to (speccount, val);
     SAFE_FREE ();
     return val;
-- 
2.10.0

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philippe Vaucher <philippe.vaucher <at> gmail.com>
Cc: monnier <at> iro.umontreal.ca, 24555-done <at> debbugs.gnu.org
Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Tue, 04 Oct 2016 17:43:18 +0300

> From: Philippe Vaucher <philippe.vaucher <at> gmail.com>
> Date: Mon, 3 Oct 2016 09:42:14 +0200
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 24555 <at> debbugs.gnu.org
> 
> And again new patches without a typo :-)

Thanks, I pushed this to the emacs-25 branch, and I'm marking this
bug done.

Please note that your patch had a fatal flaw: specbind needs a
(quoted) symbol, not its value.  Using Vcommand_debug_status there
produced a broken binary that would display an error message and
become unresponsive.  See what I actually committed for the details.

Also, the obsolescence warning needed some minor tweaks (it turns out
that my advice to prepend a semi-colon was a bad idea, as a semi-colon
and a newline are produced by Emacs automatically).

Please always test the build after you patch it, to make sure the
behavior is correct and no bugs creep in.

Finally, in the future please provide commit log messages for the
changes formatted in the ChanegLog style, as described in CONTRIBUTE.
I wrote them for this commit, please see the commit for the details of
the formatting we use.

Thanks a lot for working on this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.