GNU bug report logs - #24555
[PATCH] Remove unused variable `command-debug-status'

Previous Next

Full log

Message #41 received at 24555 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philippe Vaucher <philippe.vaucher <at> gmail.com>
Cc: monnier <at> iro.umontreal.ca, 24555 <at> debbugs.gnu.org
Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Sat, 01 Oct 2016 18:50:49 +0300

> From: Philippe Vaucher <philippe.vaucher <at> gmail.com>
> Date: Sat, 1 Oct 2016 15:09:33 +0200
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 24555 <at> debbugs.gnu.org
> 
> >> Philippe, can you do this, please?  It should be done on the emacs-25
> >> branch, since the specbind was deleted in 25.1.
> 
> Okay, here we go.
> 
> https://github.com/Silex/emacs/compare/emacs-25~2...Silex:emacs-25
> 
> https://github.com/Silex/emacs/commit/c8566ff77a347e7efc4cb2819cd7f58b68876e6f.patch
> https://github.com/Silex/emacs/commit/e34b40dc4d12a0d806e59ccbf682b0980480ff88.patch
> 
> What is your prefered way to receive patches?

Either "git diff" with the commit log message prepended, or
"git format-patch", whatever works best for you.

I think your patch lacks the call to make-obsolete-variable.  We need
that to warn users of this variable about it being obsoleted.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.