From unknown Sun Jun 15 08:37:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24555 <24555@debbugs.gnu.org> To: bug#24555 <24555@debbugs.gnu.org> Subject: Status: [PATCH] Remove unused variable `command-debug-status' Reply-To: bug#24555 <24555@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:37:14 +0000 retitle 24555 [PATCH] Remove unused variable `command-debug-status' reassign 24555 emacs submitter 24555 Philippe Vaucher severity 24555 minor tag 24555 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 08:39:49 2016 Received: (at submit) by debbugs.gnu.org; 28 Sep 2016 12:39:49 +0000 Received: from localhost ([127.0.0.1]:37676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpE9N-0004Lu-0j for submit@debbugs.gnu.org; Wed, 28 Sep 2016 08:39:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpE9M-0004Le-1E for submit@debbugs.gnu.org; Wed, 28 Sep 2016 08:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpE9F-0007JT-Iu for submit@debbugs.gnu.org; Wed, 28 Sep 2016 08:39:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpE9F-0007J9-Et for submit@debbugs.gnu.org; Wed, 28 Sep 2016 08:39:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpE9C-0003UZ-UE for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 08:39:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpE98-0007Gn-35 for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 08:39:38 -0400 Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:33032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpE97-0007Ge-PC for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 08:39:34 -0400 Received: by mail-vk0-x235.google.com with SMTP id z126so42497534vkd.0 for ; Wed, 28 Sep 2016 05:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=axU/RV/SQDyeOeTBZ8L4VW5k/K4aCYxC4IlsgcHiIas=; b=jNb2O9iE7MpaOSkvz/dXA78STkbV8KqnPTu2TGhV5gmANcpb3cQdKINCVoS1Cef0dy r5G+CPs1ycpKJxgQPfnJdeXJlFOGV/Ueukg68so9HigbDDaMLbh4uORkERGU5COAJneQ YPKDxzH3ZcYe9PghqcIl/pRevxKh6oowT2GRuWALxKjv4ZGhf/w5qNGcyMxvgZQyA8+W hWGc764OSeheNoN/WjSBpCv53mjDShRtCt561yTN3ag4Rg4EaR6BjEd7npJQsn0Gr2DZ TBzQTaVEUD9XT8YntKfCFgnVkWCy5H5YkerXLJ9SFNd6JyfiuwsBlT9ZtA+mxZBegQH9 GswA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=axU/RV/SQDyeOeTBZ8L4VW5k/K4aCYxC4IlsgcHiIas=; b=j5L9Wh2D9RjL7jf1lcGFpB4H7BPqzjdPr9O1KC/MXNJeJhH0zxiP4cdQOkcg+BdxiE /UDs/Kk2ER3MKIYC524M9GMU7ojjKuz1QR4/5fsC8/jtfI4b2EDvnluf1eMvQ5IscgAS +PTE6DBIdOl4WbAZ43bljEhWBcjOfNkNkoebCO1ywLY2lDHhPzGp9pvZ0Eh2d40PjZsZ 6ymexfPy2qH0vz5RbGbeXZO4pQ2zq/U2a0hyn/U0jSQgj1JlaS6bRVHJmOqKd2duPcWu Co71nZY+XZVgMnQxVfDW1caFdK6hNDaS4c0aw6IP/nPavr7XAGvj4kW31yYxsQiV+Xgk +3sw== X-Gm-Message-State: AA6/9Rl7tOtn7rBF+oSgAyKRxnz6PzAVMBjL1F274qdwh+N9YMlWCgK2YK3Pa3Od0ALzwBpgo7tuxrPE5Mxc7w== X-Received: by 10.31.154.22 with SMTP id c22mr17164573vke.52.1475066373014; Wed, 28 Sep 2016 05:39:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Wed, 28 Sep 2016 05:39:02 -0700 (PDT) From: Philippe Vaucher Date: Wed, 28 Sep 2016 14:39:02 +0200 Message-ID: Subject: [PATCH] Remove unused variable `command-debug-status' To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=001a1140f5b42f5d90053d90a7b7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1140f5b42f5d90053d90a7b7 Content-Type: multipart/alternative; boundary=001a1140f5b42f5d8a053d90a7b5 --001a1140f5b42f5d8a053d90a7b5 Content-Type: text/plain; charset=UTF-8 Hello, For information, I did the procedure for copyright assignment to Emacs and it is complete. This patch removes the variable `command-debug-status', which really seems to be unused since a long time to me (that's what "git -G Vcommand-debug-status" says). Philippe --001a1140f5b42f5d8a053d90a7b5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

For information, = I did the procedure for copyright assignment to Emacs and it is complete.
This patch removes the variable=C2=A0`command-debug-status', which = really seems to be unused since a long=C2=A0time to me (that's what &qu= ot;git -G Vcommand-debug-status" says).

Philippe
--001a1140f5b42f5d8a053d90a7b5-- --001a1140f5b42f5d90053d90a7b7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Remove-unused-variable-command-debug-status.patch" Content-Disposition: attachment; filename="0001-Remove-unused-variable-command-debug-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itmwefeb0 RnJvbSBlYWU2Mzc0ZTVhM2YwNTJjNTVlNGU5ZThiODIxNTM5YjZmMTkwMGFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyOCBTZXAgMjAxNiAxMjoxNDoyOCArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIFJlbW92ZSB1bnVzZWQgdmFyaWFibGUgYGNvbW1hbmQtZGVidWctc3RhdHVzJwoKLS0t CiBkb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aSB8IDEyIC0tLS0tLS0tLS0tLQogc3JjL2NhbGxp bnQuYyAgICAgICAgICAgICAgfCAgNiAtLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgYi9kb2MvbGlz cHJlZi9kZWJ1Z2dpbmcudGV4aQppbmRleCAyZjgzYjQwLi5mNGU2M2FlIDEwMDY0NAotLS0gYS9k b2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4 aQpAQCAtNjQ0LDE4ICs2NDQsNiBAQCB0aGUgZGVidWdnZXIuCiBUaGlzIGZ1bmN0aW9uIGlzIHVz ZWQgb25seSBieSB0aGUgZGVidWdnZXIuCiBAZW5kIGRlZnVuCiAKLUBkZWZ2YXIgY29tbWFuZC1k ZWJ1Zy1zdGF0dXMKLVRoaXMgdmFyaWFibGUgcmVjb3JkcyB0aGUgZGVidWdnaW5nIHN0YXR1cyBv ZiB0aGUgY3VycmVudCBpbnRlcmFjdGl2ZQotY29tbWFuZC4gIEVhY2ggdGltZSBhIGNvbW1hbmQg aXMgY2FsbGVkIGludGVyYWN0aXZlbHksIHRoaXMgdmFyaWFibGUgaXMKLWJvdW5kIHRvIEBjb2Rl e25pbH0uICBUaGUgZGVidWdnZXIgY2FuIHNldCB0aGlzIHZhcmlhYmxlIHRvIGxlYXZlCi1pbmZv cm1hdGlvbiBmb3IgZnV0dXJlIGRlYnVnZ2VyIGludm9jYXRpb25zIGR1cmluZyB0aGUgc2FtZSBj b21tYW5kCi1pbnZvY2F0aW9uLgotCi1UaGUgYWR2YW50YWdlIG9mIHVzaW5nIHRoaXMgdmFyaWFi bGUgcmF0aGVyIHRoYW4gYW4gb3JkaW5hcnkgZ2xvYmFsCi12YXJpYWJsZSBpcyB0aGF0IHRoZSBk YXRhIHdpbGwgbmV2ZXIgY2Fycnkgb3ZlciB0byBhIHN1YnNlcXVlbnQgY29tbWFuZAotaW52b2Nh dGlvbi4KLUBlbmQgZGVmdmFyCi0KIEBkZWZ1biBiYWNrdHJhY2UtZnJhbWUgZnJhbWUtbnVtYmVy CiBUaGUgZnVuY3Rpb24gQGNvZGV7YmFja3RyYWNlLWZyYW1lfSBpcyBpbnRlbmRlZCBmb3IgdXNl IGluIExpc3AKIGRlYnVnZ2Vycy4gIEl0IHJldHVybnMgaW5mb3JtYXRpb24gYWJvdXQgd2hhdCBj b21wdXRhdGlvbiBpcyBoYXBwZW5pbmcKZGlmZiAtLWdpdCBhL3NyYy9jYWxsaW50LmMgYi9zcmMv Y2FsbGludC5jCmluZGV4IDA1M2VlNmMuLmNjYjVjNmEgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxsaW50 LmMKKysrIGIvc3JjL2NhbGxpbnQuYwpAQCAtOTI4LDEyICs5MjgsNiBAQCBNYXhpbXVtIGxlbmd0 aCBvZiB0aGUgaGlzdG9yeSBsaXN0IGlzIGRldGVybWluZWQgYnkgdGhlIHZhbHVlCiBvZiBgaGlz dG9yeS1sZW5ndGgnLCB3aGljaCBzZWUuICAqLyk7CiAgIFZjb21tYW5kX2hpc3RvcnkgPSBRbmls OwogCi0gIERFRlZBUl9MSVNQICgiY29tbWFuZC1kZWJ1Zy1zdGF0dXMiLCBWY29tbWFuZF9kZWJ1 Z19zdGF0dXMsCi0JICAgICAgIGRvYzogLyogRGVidWdnaW5nIHN0YXR1cyBvZiBjdXJyZW50IGlu dGVyYWN0aXZlIGNvbW1hbmQuCi1Cb3VuZCBlYWNoIHRpbWUgYGNhbGwtaW50ZXJhY3RpdmVseScg aXMgY2FsbGVkOwotbWF5IGJlIHNldCBieSB0aGUgZGVidWdnZXIgYXMgYSByZW1pbmRlciBmb3Ig aXRzZWxmLiAgKi8pOwotICBWY29tbWFuZF9kZWJ1Z19zdGF0dXMgPSBRbmlsOwotCiAgIERFRlZB Ul9MSVNQICgibWFyay1ldmVuLWlmLWluYWN0aXZlIiwgVm1hcmtfZXZlbl9pZl9pbmFjdGl2ZSwK IAkgICAgICAgZG9jOiAvKiBOb24tbmlsIG1lYW5zIHlvdSBjYW4gdXNlIHRoZSBtYXJrIGV2ZW4g d2hlbiBpbmFjdGl2ZS4KIFRoaXMgb3B0aW9uIG1ha2VzIGEgZGlmZmVyZW5jZSBpbiBUcmFuc2ll bnQgTWFyayBtb2RlLgotLSAKMi4xMC4wCgo= --001a1140f5b42f5d90053d90a7b7-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 10:58:57 2016 Received: (at 24555) by debbugs.gnu.org; 28 Sep 2016 14:58:57 +0000 Received: from localhost ([127.0.0.1]:38043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGK1-0007b6-Ih for submit@debbugs.gnu.org; Wed, 28 Sep 2016 10:58:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGJz-0007at-RG for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 10:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpGJt-0006gT-Np for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 10:58:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGJo-0006eQ-N9; Wed, 28 Sep 2016 10:58:44 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1194 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpGJk-000098-RS; Wed, 28 Sep 2016 10:58:41 -0400 Date: Wed, 28 Sep 2016 17:58:41 +0300 Message-Id: <837f9woyu6.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Wed, 28 Sep 2016 14:39:02 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Philippe Vaucher > Date: Wed, 28 Sep 2016 14:39:02 +0200 > > For information, I did the procedure for copyright assignment to Emacs and it is complete. Indeed, your assignment is on file. > This patch removes the variable `command-debug-status', which really seems to be unused since a long time > to me (that's what "git -G Vcommand-debug-status" says). Thanks for bringing this up. I looked into the history of this variable, and found that it was still supported in Emacs 24.5, and was removed during development of Emacs 25 by this commit: commit 0e4857b7d84f958f66e726ed57b824427b272681 Author: Stefan Monnier Date: Tue May 27 20:09:14 2014 -0400 * src/callint.c (Ffuncall_interactively): New function. (Qfuncall_interactively): New var. (Qcall_interactively): Remove. (Fcall_interactively): Use it. (syms_of_callint): Defsubr it. * lisp/subr.el (internal--funcall-interactively): New. (internal--call-interactively): Remove. (called-interactively-p): Detect funcall-interactively instead of call-interactively. * lisp/simple.el (repeat-complex-command): Use funcall-interactively. (repeat-complex-command--called-interactively-skip): Remove. As you see, the commit log doesn't mention the removal of the variable. Stefan, was it removed on purpose? If so, can you tell why? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 12:56:19 2016 Received: (at 24555) by debbugs.gnu.org; 28 Sep 2016 16:56:19 +0000 Received: from localhost ([127.0.0.1]:38098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpI9b-0001qd-6l for submit@debbugs.gnu.org; Wed, 28 Sep 2016 12:56:19 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:30624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpI9Z-0001qR-E0 for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 12:56:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BHAgALW9BX/9SGSC1dGwEBAQMBAQGDLQEBAQEBHoRNhVCEZakCgg+CA4YWBAICgWk5FAECAQEBAQEBAV4nhGIBAQMBViMFCws0EhQYDSSIVQi8VQEBAQcCJYp9ihwBBJlZkRUBh3eGC5BLHjaEbCCGCgEBAQ X-IPAS-Result: A0BHAgALW9BX/9SGSC1dGwEBAQMBAQGDLQEBAQEBHoRNhVCEZakCgg+CA4YWBAICgWk5FAECAQEBAQEBAV4nhGIBAQMBViMFCws0EhQYDSSIVQi8VQEBAQcCJYp9ihwBBJlZkRUBh3eGC5BLHjaEbCCGCgEBAQ X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="273891213" Received: from 45-72-134-212.cpe.teksavvy.com (HELO pastel.home) ([45.72.134.212]) by smtp.teksavvy.com with ESMTP; 28 Sep 2016 12:56:11 -0400 Received: by pastel.home (Postfix, from userid 20848) id C9BE564BD6; Wed, 28 Sep 2016 12:14:24 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' Message-ID: References: <837f9woyu6.fsf@gnu.org> Date: Wed, 28 Sep 2016 12:14:24 -0400 In-Reply-To: <837f9woyu6.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Sep 2016 17:58:41 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 24555 Cc: Philippe Vaucher , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > As you see, the commit log doesn't mention the removal of the > variable. Stefan, was it removed on purpose? If so, can you tell > why? Hmm... I can't remember making such a conscious choice, no. Must have been an oversight on my part. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 13:25:18 2016 Received: (at 24555) by debbugs.gnu.org; 28 Sep 2016 17:25:18 +0000 Received: from localhost ([127.0.0.1]:38118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpIbe-0002XK-9G for submit@debbugs.gnu.org; Wed, 28 Sep 2016 13:25:18 -0400 Received: from mail-vk0-f43.google.com ([209.85.213.43]:35570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpIbd-0002X3-7w for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 13:25:17 -0400 Received: by mail-vk0-f43.google.com with SMTP id 192so50681873vkl.2 for <24555@debbugs.gnu.org>; Wed, 28 Sep 2016 10:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ULKM1+3X/La0UO9/d+bE+8MrnIFz90JI0WCiA48w1l8=; b=VlTLBpki5nGCvfWpFyt9fz8Ui6hPzwnohVWVJoLVcECSocUMXLUHP6GUidYnOxhLob JKJpxoouspe1dzxkbrRdmggEfH3QBHw7G631m4r0nzs0BpdDZSw23az1+NoAW2J+7txv +1s3+B2LYyx89xf864WBVQch4pRCVPI3mrVOfrWwnDCj+zQUYSvOf2oTP0AwsRkjbLuw 1EsW6azpqYEiKzI6QThZiWHnGJPkWcrdc5Jdi8WuNyhFBR7NnxDu2Vr4t5CUYgk6+SLc eoO9VrDRGR6lUgNnO8JRdgLxQOMF4cWfq2fd6hmTfUCb2l2ebiM3r0C1gfELmp7Xg6dt RE/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ULKM1+3X/La0UO9/d+bE+8MrnIFz90JI0WCiA48w1l8=; b=b6zMWq7iqAeDWwSSm2IPZ4Hr5XiytVyq0iwBcJeB4NT+ptdYnx6JgFjdTjHVmszv2P +n9tp+MZx0OK9gzkH437s2Cl4CUBBvg8Xn5E6caPJly8b3cFFB2/uWXth8I5XGswd9ZS uGqKeRvVPBFQe34+caqEFrHwv9NjiGSkxP1vrq+ELKixH/cPH59HaEk/g94AlwjBZsXe uq3+lZ39syXVOS2u2MJ30auaJGHs6t0dhlSPzYhrrlBqv/lywvuLf+dJ80NP+L5Y7zKk kXXJM3fG1NW9dQWzWihUPX2Lblmmd5SKDnmvbugkPNnaYlYjs5evxNDsAivE9fp+zGxK DAxQ== X-Gm-Message-State: AA6/9RmcNUX7se2kx/r222iIpZMX/7RHoW7NwwQ4Op3QZmeMqRaL2IBvbAdT2OukyTr7U11OrdEIT/u/c/xXtg== X-Received: by 10.31.217.3 with SMTP id q3mr1205268vkg.150.1475083511838; Wed, 28 Sep 2016 10:25:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Wed, 28 Sep 2016 10:24:41 -0700 (PDT) In-Reply-To: References: <837f9woyu6.fsf@gnu.org> From: Philippe Vaucher Date: Wed, 28 Sep 2016 19:24:41 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24555 Cc: Eli Zaretskii , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > > As you see, the commit log doesn't mention the removal of the > > variable. Stefan, was it removed on purpose? If so, can you tell > > why? > > Hmm... I can't remember making such a conscious choice, no. > Must have been an oversight on my part. What is/was the use of `command-debug-status' ? its docstring does not really help figure much what data was stored there and what it was used for. Philippe From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 16:06:11 2016 Received: (at 24555) by debbugs.gnu.org; 28 Sep 2016 20:06:11 +0000 Received: from localhost ([127.0.0.1]:38192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpL7L-0006Ko-AG for submit@debbugs.gnu.org; Wed, 28 Sep 2016 16:06:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpL7J-0006Kb-23 for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 16:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpL7A-0007kz-Iw for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 16:06:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpL7A-0007kM-Fm; Wed, 28 Sep 2016 16:06:00 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1341 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpL78-0003u5-2j; Wed, 28 Sep 2016 16:05:59 -0400 Date: Wed, 28 Sep 2016 23:05:55 +0300 Message-Id: <83wphvokm4.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Wed, 28 Sep 2016 12:14:24 -0400) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24555 Cc: philippe.vaucher@gmail.com, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Stefan Monnier > Cc: Philippe Vaucher , 24555@debbugs.gnu.org > Date: Wed, 28 Sep 2016 12:14:24 -0400 > > > As you see, the commit log doesn't mention the removal of the > > variable. Stefan, was it removed on purpose? If so, can you tell > > why? > > Hmm... I can't remember making such a conscious choice, no. > Must have been an oversight on my part. That's what I thought. So restoring the specbind call that was lost in that commit is TRT, do you agree? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 16:11:39 2016 Received: (at 24555) by debbugs.gnu.org; 28 Sep 2016 20:11:39 +0000 Received: from localhost ([127.0.0.1]:38197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpLCd-0006SC-2C for submit@debbugs.gnu.org; Wed, 28 Sep 2016 16:11:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpLCb-0006Rw-AF for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 16:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpLCS-0001O6-Gi for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 16:11:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpLCS-0001NJ-EV; Wed, 28 Sep 2016 16:11:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1343 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpLCQ-0004qy-5R; Wed, 28 Sep 2016 16:11:26 -0400 Date: Wed, 28 Sep 2016 23:11:20 +0300 Message-Id: <83twczokd3.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Wed, 28 Sep 2016 19:24:41 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24555 Cc: monnier@iro.umontreal.ca, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Philippe Vaucher > Date: Wed, 28 Sep 2016 19:24:41 +0200 > Cc: Eli Zaretskii , 24555@debbugs.gnu.org > > What is/was the use of `command-debug-status' ? its docstring does not > really help figure much what data was stored there and what it was > used for. Which parts of the documentation are not clear? In a nutshell, it's a variable provided for storing arbitrary data that persists for the duration of the current interactive command. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 20:12:48 2016 Received: (at 24555) by debbugs.gnu.org; 29 Sep 2016 00:12:48 +0000 Received: from localhost ([127.0.0.1]:38334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpOy0-0006yn-0n for submit@debbugs.gnu.org; Wed, 28 Sep 2016 20:12:48 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:5360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpOxy-0006ya-Ka for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 20:12:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DgBQALW9BX/4Pjr2xdGwEBAQMBAQGDLQEBAQEBHoRNhVCtZ4QShhYEAgKBaTwRAQIBAQEBAQEBXieEYgEBAwFWIwULCzQSFBgNJIhVCLxVAQEIAgEkin2KHAEEmVmRFQGHd4YLjw2BPjQghGwghgoBAQE X-IPAS-Result: A0DgBQALW9BX/4Pjr2xdGwEBAQMBAQGDLQEBAQEBHoRNhVCtZ4QShhYEAgKBaTwRAQIBAQEBAQEBXieEYgEBAwFWIwULCzQSFBgNJIhVCLxVAQEIAgEkin2KHAEEmVmRFQGHd4YLjw2BPjQghGwghgoBAQE X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="273936020" Received: from 108-175-227-131.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([108.175.227.131]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Sep 2016 20:12:40 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id B71EBAE8B2; Wed, 28 Sep 2016 20:12:48 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' Message-ID: References: <837f9woyu6.fsf@gnu.org> <83wphvokm4.fsf@gnu.org> Date: Wed, 28 Sep 2016 20:12:48 -0400 In-Reply-To: <83wphvokm4.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Sep 2016 23:05:55 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 24555 Cc: philippe.vaucher@gmail.com, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > So restoring the specbind call that was lost in that commit is TRT, do > you agree? Could be. At the same time, I have no recollection of ever noticing this variable anywhere, and reading its docstring doesn't trigger any recollection of a scenario where I could make use of it, so maybe it can just be dropped. What's the use case? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 20:16:25 2016 Received: (at 24555) by debbugs.gnu.org; 29 Sep 2016 00:16:25 +0000 Received: from localhost ([127.0.0.1]:38338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpP1V-000754-Hw for submit@debbugs.gnu.org; Wed, 28 Sep 2016 20:16:25 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpP1U-00074q-EL for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 20:16:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DyAQALW9BX/4Pjr2xdGgEBAQECAQEBAYMtAQEBAQEehE2FUIRlqQKCD4IDhhYEAgKBaTkUAQIBAQEBAQEBXieEYgEBAwFWIwULCzQSFBgNJIhVCLxVAQEIAgEkin2KHAEEjieLMpEVAYd3hguPDYE+HjaEbCCGCgEBAQ X-IPAS-Result: A0DyAQALW9BX/4Pjr2xdGgEBAQECAQEBAYMtAQEBAQEehE2FUIRlqQKCD4IDhhYEAgKBaTkUAQIBAQEBAQEBXieEYgEBAwFWIwULCzQSFBgNJIhVCLxVAQEIAgEkin2KHAEEjieLMpEVAYd3hguPDYE+HjaEbCCGCgEBAQ X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="273936224" Received: from 108-175-227-131.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([108.175.227.131]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Sep 2016 20:16:18 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id CEF62AE8B2; Wed, 28 Sep 2016 20:16:26 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' Message-ID: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> Date: Wed, 28 Sep 2016 20:16:26 -0400 In-Reply-To: <83twczokd3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Sep 2016 23:11:20 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 24555 Cc: Philippe Vaucher , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > In a nutshell, it's a variable provided for storing arbitrary data > that persists for the duration of the current interactive command. Can't think of any situation where I'd want/need that. The name seems to indicate it could be used that way in the context of debugging, but even in that kind of scenario I'm unable to come up with a use-case. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 02:50:46 2016 Received: (at 24555) by debbugs.gnu.org; 29 Sep 2016 06:50:46 +0000 Received: from localhost ([127.0.0.1]:38427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpVB8-0008Hl-JH for submit@debbugs.gnu.org; Thu, 29 Sep 2016 02:50:46 -0400 Received: from mail-ua0-f172.google.com ([209.85.217.172]:33120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpVB6-0008HV-OY for 24555@debbugs.gnu.org; Thu, 29 Sep 2016 02:50:45 -0400 Received: by mail-ua0-f172.google.com with SMTP id i25so57821059uab.0 for <24555@debbugs.gnu.org>; Wed, 28 Sep 2016 23:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BeuLGeF2ja17MHf/sAeRaNFJpn8odGiabrkqiWeZf04=; b=q0/gidwEWQF1Gkh01henwKEDkBaU8IPKMyVLmAdFVBYifNRM3XWEhoifx1Me1SHLqI hQ3r/L7ovhF8e9QPYVuhZ/GMBPXZZGnOEQ4UHeV4aVrtjnNon+QSpSlIhg7jiof21RPY +LUU00Y4p1vr6Y22IyXkDbjv9WYdZqD5vhzuXurAR1wpL02GfwTF6wcHeDxRvtMwHYym 4NcFpl7+oFkUpMq2UvpRRNUFJljNQi+ycMfDNKksQTAXLiVy703mFUPiI7YqWMvDW2bn VC3i500FIFhPKit1zqLorN0oGnbjHGmNhglLnQIY3+0FCfpwyEbxcgLurfIgGPydCQRN HusQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BeuLGeF2ja17MHf/sAeRaNFJpn8odGiabrkqiWeZf04=; b=K8/p57OJlie70N6mTOzWXytPaTS9eLGAd2IZbUaDBhhqZsQo9EB8Kyrco1I3wa/yvX bk6b3J5jSYOJ3wrW9T38CM0cQJGI98wHkZiOUPuqFOiZbRLlJoaVDotl4BmlHzpIw12t D1QBEqMKLLmduChPpQWFgtczLW/C7eu6TYtT6uDPZop/UhrtH4g41zB7VOHUO7NHMWCQ MSzDPaka84EudP+cmu4meWp6QTPgw+VqOyR30CPTsh+WsiK9YuWUacJJA8Jt4ik42aCa cMKdu9eFoJx7zBgWkhthgu7WIVRXziSk3DAM0DCfgMHHkSUxiUc6+pnshjUeyPlaQeI3 nRGA== X-Gm-Message-State: AA6/9RkLB48Ifd24llD7gsaz3Y1r2wJebOD1G+4zubeC9bZ7SK7wCJ8jpUBVZoJaXzXn5+JCO8G4rZCPaY3REw== X-Received: by 10.176.0.20 with SMTP id 20mr6953968uai.83.1475131839258; Wed, 28 Sep 2016 23:50:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Wed, 28 Sep 2016 23:50:08 -0700 (PDT) In-Reply-To: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> From: Philippe Vaucher Date: Thu, 29 Sep 2016 08:50:08 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24555 Cc: Eli Zaretskii , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> In a nutshell, it's a variable provided for storing arbitrary data >> that persists for the duration of the current interactive command. > > Can't think of any situation where I'd want/need that. The name seems > to indicate it could be used that way in the context of debugging, but > even in that kind of scenario I'm unable to come up with a use-case. That's why I asked what was the use of such variable... even if we restore the code that sets it, it is not used anywhere else. The commit history suggest it might have been useful near the start of the development of Emacs, but I don't think it is anymore. I vote for dropping it. Philippe From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 11:05:04 2016 Received: (at 24555) by debbugs.gnu.org; 29 Sep 2016 15:05:04 +0000 Received: from localhost ([127.0.0.1]:38908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpctQ-0005TB-Dh for submit@debbugs.gnu.org; Thu, 29 Sep 2016 11:05:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpctL-0005Sl-6e for 24555@debbugs.gnu.org; Thu, 29 Sep 2016 11:04:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpctB-0000Oc-Vr for 24555@debbugs.gnu.org; Thu, 29 Sep 2016 11:04:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpctB-0000OW-U3; Thu, 29 Sep 2016 11:04:45 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1922 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpct8-0002Dm-1f; Thu, 29 Sep 2016 11:04:44 -0400 Date: Thu, 29 Sep 2016 18:04:31 +0300 Message-Id: <83fuoioigw.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Thu, 29 Sep 2016 08:50:08 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24555 Cc: monnier@iro.umontreal.ca, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Philippe Vaucher > Date: Thu, 29 Sep 2016 08:50:08 +0200 > Cc: Eli Zaretskii , 24555@debbugs.gnu.org > > > Can't think of any situation where I'd want/need that. The name seems > > to indicate it could be used that way in the context of debugging, but > > even in that kind of scenario I'm unable to come up with a use-case. > > That's why I asked what was the use of such variable... even if we > restore the code that sets it, it is not used anywhere else. > > The commit history suggest it might have been useful near the start of > the development of Emacs, but I don't think it is anymore. > > I vote for dropping it. I don't think we can drop features just because no use case presents itself for the moment. IME, a debugging aid could be of no use until you are in a situation where it is something to kill for. But we don't need to argue about this now, because the way we remove features from Emacs is by first declaring them obsolete, and keeping them like that for a few releases; we don't just drop them without a previous notice. So I'm okay with declaring this variable obsolete, and even removing its documentation from the manual, but we do need to restore the specbind call that was deleted. Philippe, can you do this, please? It should be done on the emacs-25 branch, since the specbind was deleted in 25.1. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 05:09:07 2016 Received: (at 24555) by debbugs.gnu.org; 30 Sep 2016 09:09:07 +0000 Received: from localhost ([127.0.0.1]:39266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bptoZ-0000Cn-Lk for submit@debbugs.gnu.org; Fri, 30 Sep 2016 05:09:07 -0400 Received: from mail-ua0-f174.google.com ([209.85.217.174]:35273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bptoX-0000CI-RX for 24555@debbugs.gnu.org; Fri, 30 Sep 2016 05:09:06 -0400 Received: by mail-ua0-f174.google.com with SMTP id q42so88789920uaq.2 for <24555@debbugs.gnu.org>; Fri, 30 Sep 2016 02:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iIp3I/a0b1ZJ/ldJLYzzSa6dCPy9gZs84rjIFTSlbZg=; b=mGQ3WE5CO9Hq9fpZyGsm2JpnucNpSzg9XGfju23Tc9XD3np0555R+BnmCwLczhdHcR Ns98ubYBr4EtIYA7OzUFHh96CNvzUX2ozKwM+csqa81gSLC9B1zvYmnPFamcOlXcARFy 89zM+oJrIaYe0Ri3Swx+cxxYZu8taZgRi71tzXguqg3D+bUhXmpMDIU3ZwIHgfUxVHgt Ewa+ZJU3MmYIUMJiN1UthtVbfYMe5ywYGtL8BaAODtuq1hkSWSsmT4Cn/uQ8AtYwsVjE Fl2xdN9uRbHvwZIuAtOtYtmAgCyymNjbcJsJO/jI9Xh1uf+XYEzbKnDWb+xNhRUVywmL /pOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iIp3I/a0b1ZJ/ldJLYzzSa6dCPy9gZs84rjIFTSlbZg=; b=D34VUdM+NnuwCmkftjuQZEidULDQmPSyrRQ4UtRsePU3C9M1qCaHRFkBW+7n0AkGgR Vtf8tBM4FMhtdoBtSRe836LHwHhbBZd54yQPAUaUxiBN3AVTMF5jqEWbtkbazDoNd6Gd TiNpAQXwCaHoVke/rSr4ZMhQPMAdP/iAAPnc3Ka+MxoReGoel+Fhw4F7AuXXnpfpu9nL aFPBJQ4o7WiP9FDn8A0la/KCXlOHRblaUEYozEm2TPF3oIJ8zzthCBxXmPp0EmBnQzRC n+jBtfu55GdchD5AoIUtJKbnG1KwGwR7XV+54kqCu6enzmtGGeJRzk5W4cUxKv1pXbbs qm8Q== X-Gm-Message-State: AA6/9RmRKU5I/MZM1szgspu3sCWuQht0iUPjQxj170Dg3jfSBCzUL2AIPg9fnrCO3giLkteyK13TGAImtJxJWw== X-Received: by 10.176.4.40 with SMTP id 37mr971232uav.89.1475226540418; Fri, 30 Sep 2016 02:09:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Fri, 30 Sep 2016 02:08:30 -0700 (PDT) In-Reply-To: <83fuoioigw.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> From: Philippe Vaucher Date: Fri, 30 Sep 2016 11:08:30 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c06b716e7ab47053db5f17d X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --94eb2c06b716e7ab47053db5f17d Content-Type: text/plain; charset=UTF-8 > > So I'm okay with declaring this variable obsolete, and even removing > its documentation from the manual, but we do need to restore the > specbind call that was deleted. > > Philippe, can you do this, please? It should be done on the emacs-25 > branch, since the specbind was deleted in 25.1. > Okay, I'll start working on this. Philippe --94eb2c06b716e7ab47053db5f17d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
So I'm okay with declaring this variable obs= olete, and even removing
its documentation from the manual, but we do need to restore the
specbind call that was deleted.

Philippe, can you do this, please?=C2=A0 It should be done on the emacs-25<= br> branch, since the specbind was deleted in 25.1.

Okay, I'll start working on this.

Phi= lippe
--94eb2c06b716e7ab47053db5f17d-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 09:10:10 2016 Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 13:10:10 +0000 Received: from localhost ([127.0.0.1]:40410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqK3O-0002DQ-G1 for submit@debbugs.gnu.org; Sat, 01 Oct 2016 09:10:10 -0400 Received: from mail-ua0-f171.google.com ([209.85.217.171]:35709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqK3N-0002DE-At for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 09:10:09 -0400 Received: by mail-ua0-f171.google.com with SMTP id q42so116452986uaq.2 for <24555@debbugs.gnu.org>; Sat, 01 Oct 2016 06:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Sdoi4AwlAbkbuGiEWwCsy0AaPI2/Awqr78mVSeu0Jmo=; b=Ot4sVEPdGPydGw69LdvmwWyrg82zj99GjxGkEPheNPLhfI0RyEM7HuMvBTzimnt6/w 2kby5FyvCDkU9Y8ICuHYT+gmjb8pDPHyt7e2THMuGql2DOA6fE0Xb07yWluqrF/TXD7+ rKoGOMNE4LP3N+zPwAbtxRiKB4VXaBNhUDoahWlMNOIBKwYxOduj+B86k2qB5Pfc6qB5 u9rPRI5JoGYvmgg/3iKicKWkEVJTud/Vb5GRx7xiBA5OsappIwRjZpwQiqHgy7Ih0Mlt CEIXBlziz3RVty7IobiqAoZGEHz+8iwAAO9h0rsXWNjm3L2SnXSCiSv9j30UlnOnGcoq CkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Sdoi4AwlAbkbuGiEWwCsy0AaPI2/Awqr78mVSeu0Jmo=; b=i8Lkh1C7oI//54FfZjyg1Kww4i2BUKGCUrd1s9SHwIfuWns1/LxrhTXS3KXweY3GYy 0G5MWLFiTnbA4bh78UPguPXpy6uNHrzdID0Ef0ACU6/FESbYsc40oDHPVCWEi8tZfLbH dQjEFDylThwQQeQ9CoHlbi18mYJpr/dzau2mK12HNNcZtp6SMXI1MykAcFB9MxEfqGt8 tfDMz9B8PhTjQZ+iQUY4M7o/m4SiBdSgUFAceMYPH71kep9JXPgM8pm1s9jpM7FciW5w WD/Q6R9qKxs3mDXcBA9c342WdZlKFRoRnDtASY9Xzv277VkUU9KuxAikcNfGf8QslND2 +cAQ== X-Gm-Message-State: AA6/9RldJNDZh6nKSpitMGORdjyDlll7eWfAiVMq8S3caFxtWg4nJ75fm96f2SsfX/EKZyrGfxZWkj/7qBJM2g== X-Received: by 10.176.86.23 with SMTP id y23mr8478125uaa.8.1475327403951; Sat, 01 Oct 2016 06:10:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Sat, 1 Oct 2016 06:09:33 -0700 (PDT) In-Reply-To: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> From: Philippe Vaucher Date: Sat, 1 Oct 2016 15:09:33 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> Philippe, can you do this, please? It should be done on the emacs-25 >> branch, since the specbind was deleted in 25.1. Okay, here we go. https://github.com/Silex/emacs/compare/emacs-25~2...Silex:emacs-25 https://github.com/Silex/emacs/commit/c8566ff77a347e7efc4cb2819cd7f58b68876e6f.patch https://github.com/Silex/emacs/commit/e34b40dc4d12a0d806e59ccbf682b0980480ff88.patch What is your prefered way to receive patches? --- src/callint.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/callint.c b/src/callint.c index 053ee6c..4652151 100644 --- a/src/callint.c +++ b/src/callint.c @@ -837,7 +837,10 @@ invoke it. If KEYS is omitted or nil, the return value of kset_last_command (current_kboard, save_last_command); { - Lisp_Object val = Ffuncall (nargs, args); + Lisp_Object val; + specbind (Vcommand_debug_status, Qnil); + + val = Ffuncall (nargs, args); val = unbind_to (speccount, val); SAFE_FREE (); return val; --- doc/lispref/debugging.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi index 2f83b40..322acd0 100644 --- a/doc/lispref/debugging.texi +++ b/doc/lispref/debugging.texi @@ -654,6 +654,8 @@ invocation. The advantage of using this variable rather than an ordinary global variable is that the data will never carry over to a subsequent command invocation. + +This variable is obsolete and should be removed in future versions. @end defvar @defun backtrace-frame frame-number From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 11:50:56 2016 Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 15:50:56 +0000 Received: from localhost ([127.0.0.1]:41272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMYx-0006Ne-Dc for submit@debbugs.gnu.org; Sat, 01 Oct 2016 11:50:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMYw-0006NT-9n for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 11:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqMYm-0007Bf-OI for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 11:50:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqMYm-0007BT-FP; Sat, 01 Oct 2016 11:50:44 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1954 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqMYk-000075-8Q; Sat, 01 Oct 2016 11:50:42 -0400 Date: Sat, 01 Oct 2016 18:50:49 +0300 Message-Id: <83k2dskqzq.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Sat, 1 Oct 2016 15:09:33 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24555 Cc: monnier@iro.umontreal.ca, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Philippe Vaucher > Date: Sat, 1 Oct 2016 15:09:33 +0200 > Cc: Stefan Monnier , 24555@debbugs.gnu.org > > >> Philippe, can you do this, please? It should be done on the emacs-25 > >> branch, since the specbind was deleted in 25.1. > > Okay, here we go. > > https://github.com/Silex/emacs/compare/emacs-25~2...Silex:emacs-25 > > https://github.com/Silex/emacs/commit/c8566ff77a347e7efc4cb2819cd7f58b68876e6f.patch > https://github.com/Silex/emacs/commit/e34b40dc4d12a0d806e59ccbf682b0980480ff88.patch > > What is your prefered way to receive patches? Either "git diff" with the commit log message prepended, or "git format-patch", whatever works best for you. I think your patch lacks the call to make-obsolete-variable. We need that to warn users of this variable about it being obsoleted. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 12:12:45 2016 Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 16:12:45 +0000 Received: from localhost ([127.0.0.1]:41299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMu5-0006vY-AR for submit@debbugs.gnu.org; Sat, 01 Oct 2016 12:12:45 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:36345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMu3-0006vL-Pv for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 12:12:44 -0400 Received: by mail-vk0-f52.google.com with SMTP id y190so97305294vkd.3 for <24555@debbugs.gnu.org>; Sat, 01 Oct 2016 09:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BkTOYcIot+QfGOy4jwonqwRXdlJF5NsdW+dN+YyfyvY=; b=ytJx8mtRzQAeSD+iS3+ilOnCPzAgu3TK6YI3LfFw3rVRx8uCrTr9GN94uHDn20O6Rb T/OyhLg4EfpBrZgKcwi2D/UydF+QEV0FyeAzfj33401Vb3m4j8pNFCHJHGqfxCRnVinF UuKuTbAml1LsUf2Fa9y6g6QkjoJqPkmy68hkaJmqBkQ5hOdSHE27FDM9t+9pJVtnRNSk hNL18sGOAceyj6dD/thrnOUd+ptpPvBFcJUaIQjlHLnLTCOOFGmxoj9IVYoXIlc99f4e BjO582cTuOhy2nRg0oC0JP9cUHSV6qPcxO0RAw05QJA8o71Hr4RHphDN58E/AFmE04i5 gW6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BkTOYcIot+QfGOy4jwonqwRXdlJF5NsdW+dN+YyfyvY=; b=N2vbswUngfobWLeqOpww+Y5cDWvkjgGVx5qtKhH8LTwNPCMiVGtilcNMNuC/osblVC mTwfL76UZtf9PfOncLXNJz+lmJMsT6rDwKtgvutawCr/SuJR0q/gi047RVT+G4dZUR63 o68BlmomiWd5S/sVwqdoIv2x01X6QMT6sWHll6JOGWtU+R8uygVmtH3u6+uooRCgQcmh 8xQAQ5pXJnv5i2DjNufEZ2M+ga0WT7UXQnKXsjDS+aG1BkOKiCX48SpL1ZSzgyrRpznj 5g/7YmEW5HG2h/udZpDmtKfncry2noPHchRDKAXYEP8tJihWshfS5oZxps43Q86TqHMP 7RGw== X-Gm-Message-State: AA6/9RnPLnEGu2x3VtD1VGbTdqPBHKuidThOJeBigIH9cnfkeN/jo3KRQWGY9EgimJuGwoXIVx0GjGHb1/rtzA== X-Received: by 10.31.40.138 with SMTP id o132mr9164867vko.171.1475338357392; Sat, 01 Oct 2016 09:12:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Sat, 1 Oct 2016 09:12:06 -0700 (PDT) In-Reply-To: <83k2dskqzq.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> From: Philippe Vaucher Date: Sat, 1 Oct 2016 18:12:06 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a11415958b74ca6053dcffa57 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11415958b74ca6053dcffa57 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > Either "git diff" with the commit log message prepended, or > "git format-patch", whatever works best for you. Alright. > I think your patch lacks the call to make-obsolete-variable. We need > that to warn users of this variable about it being obsoleted. Well, I thought about it but was not sure about various things, so I didn't do it. Here are the things I'm unsure about: (make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN &optional ACCESS-TYPE) Make the byte-compiler warn that OBSOLETE-NAME is obsolete. The warning will say that CURRENT-NAME should be used instead. If CURRENT-NAME is a string, that is the =E2=80=98use instead=E2=80=99 mess= age. WHEN should be a string indicating when the variable was first made obsolete, for example a date or a release number. 1. Where should I make the `make-obsolete-variable` call (in which file)? Given it's defined in callint.c it's not really obvious in which = .el it should go. 2. I don't have a "current name". Should I make CURRENT-NAME something like "This variable will be removed in the future"? Should I pass "nil"? 3. What WHEN release number should I use? 25.2 ? Thanks, Philippe --001a11415958b74ca6053dcffa57 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> Either "git diff" with the commit log m= essage prepended, or
> "git format-patch", whatever works b= est for you.

Alright.

> I think your patch lacks the call = to make-obsolete-variable.=C2=A0 We need
> that to warn users of this= variable about it being obsoleted.

Well, I thought about it but was= not sure about various things, so I didn't do it. Here are the things = I'm unsure about:

(make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN &= amp;optional=C2=A0ACCESS-TYPE)

Make the byte-compiler warn that OBSO= LETE-NAME is obsolete.
The warning will say that CURRENT-NAME should be = used instead.
If CURRENT-NAME is a string, that is the =E2=80=98use inst= ead=E2=80=99 message.
WHEN should be a string indicating when the variab= le
was first made obsolete, for example a date or a release number.
<= /blockquote>
  1. Where should I make the `make-obsolete-variabl= e` call (in which file)? Given it's defined in callint.c it's not r= eally obvious in which .el it should go.
  2. I don't have a "c= urrent name". Should I make CURRENT-NAME something like "This var= iable will be removed in the future"? Should I pass "nil"?
  3. What WHEN release number should I use? 25.2 ?
Thanks,<= /div>
Philippe
--001a11415958b74ca6053dcffa57-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 13:39:59 2016 Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 17:39:59 +0000 Received: from localhost ([127.0.0.1]:41320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqOGU-0000Vn-Pa for submit@debbugs.gnu.org; Sat, 01 Oct 2016 13:39:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqOGS-0000VY-F6 for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 13:39:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqOGJ-0005CT-Vj for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 13:39:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqOGJ-0005C2-Sq; Sat, 01 Oct 2016 13:39:47 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2282 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqOGF-0007x1-Ub; Sat, 01 Oct 2016 13:39:46 -0400 Date: Sat, 01 Oct 2016 20:39:39 +0300 Message-Id: <83bmz4klyc.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Sat, 1 Oct 2016 18:12:06 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24555 Cc: monnier@iro.umontreal.ca, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Philippe Vaucher > Date: Sat, 1 Oct 2016 18:12:06 +0200 > Cc: Stefan Monnier , 24555@debbugs.gnu.org > > > I think your patch lacks the call to make-obsolete-variable. We need > > that to warn users of this variable about it being obsoleted. > > Well, I thought about it but was not sure about various things, so I didn't do it. Here are the things I'm unsure > about: > > (make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN &optional ACCESS-TYPE) > > Make the byte-compiler warn that OBSOLETE-NAME is obsolete. > The warning will say that CURRENT-NAME should be used instead. > If CURRENT-NAME is a string, that is the ‘use instead’ message. > WHEN should be a string indicating when the variable > was first made obsolete, for example a date or a release number. > > 1 Where should I make the `make-obsolete-variable` call (in which file)? Given it's defined in callint.c it's not > really obvious in which .el it should go. I'd say in subr.el; there's a bunch of those there already. > 2 I don't have a "current name". Should I make CURRENT-NAME something like "This variable will be > removed in the future"? Should I pass "nil"? The former, but I think the string should start with a lower-case letter, as it will be displayed after the standard text saying the variable is obsolete. I suggest to experiment with different strings and find the one which makes the most sense. > 3 What WHEN release number should I use? 25.2 ? Yes, 25.2. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 13:09:31 2016 Received: (at 24555) by debbugs.gnu.org; 2 Oct 2016 17:09:31 +0000 Received: from localhost ([127.0.0.1]:42180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqkGZ-0004KX-DB for submit@debbugs.gnu.org; Sun, 02 Oct 2016 13:09:31 -0400 Received: from mail-ua0-f172.google.com ([209.85.217.172]:32841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqkGX-0004KH-E9 for 24555@debbugs.gnu.org; Sun, 02 Oct 2016 13:09:30 -0400 Received: by mail-ua0-f172.google.com with SMTP id v7so58479305uaa.0 for <24555@debbugs.gnu.org>; Sun, 02 Oct 2016 10:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+qpz0elUExKmp1cEo3bsuk4jaFn8794fajZCdGCdlHc=; b=hbIakDk65z2JeTnXElkiyyD+bHzprF+qw1UJLZqIvm9jcjdL5c2Vt+yDYOlgZuTp3w ovJYAQL1KmfCs+9wCwjSMpNzWa3kgkHIaQNicU/z5oQwt2kqL2qz6Cqf+LLvM0B6P65u EdHo1elFn2jJlyedR2VX2G4X4EhrUXjv1h4e2P+++6cipnahh5jM1o+GsMgQmzon1w1Q EWTRX0hWNT49C3OL2XjaplcrgnNFGdmtqpxshqWytBS5tOn6or8XTl/d/bKmZ2riUazG uukQVCWFM1QaHfCCjp4zgUsfZLDkPx2h21DyZaVpwa/sj3ieaGk/tfNSIi65Hg/qd6dA qRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+qpz0elUExKmp1cEo3bsuk4jaFn8794fajZCdGCdlHc=; b=eCvvQyTOOWkmVq0t64cBVIhjkHhkmqHeOesc2Iz00j9lm10d2yiesBa3r9T1e8g1Sk G9aE0yHZoBbAKzK5t1jLmYqf4BtIMhq+7a6JFDCKvDp0T8mHv9d+YtI+0aJ/JdzjDgZt 1pDMPtM4yAEJ1LKh0KjcaHbju7G+ht7kYDjf/1+W2IvFG1MEOj5u7amFg2fMaI/bw6VG g49yeiia3dn03RlnC4x8LoFz2/MCEBw6sVntyKxVdh1PcjnApdFXjfqYqpPzPLdYskjs QJQFZCuUlAS/yECXf1h9/NfAuN1qHPf/N41OaKKX41l6mi94DVCZYAqrTDXOUkiqNeuf tcDQ== X-Gm-Message-State: AA6/9Rne2Onzu51t00O0HN+d1jDkRFCnONcNaUCAxj7cFbseMlFZWvt9Jmwni1YXzIokjwwCcjo4tZ8EIuo3Rw== X-Received: by 10.176.84.149 with SMTP id p21mr11173602uaa.42.1475428164091; Sun, 02 Oct 2016 10:09:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Sun, 2 Oct 2016 10:08:53 -0700 (PDT) In-Reply-To: <83bmz4klyc.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> From: Philippe Vaucher Date: Sun, 2 Oct 2016 19:08:53 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c1b074e9cc2c2053de4e338 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --94eb2c1b074e9cc2c2053de4e338 Content-Type: text/plain; charset=UTF-8 Hum. I wanted to use `git send-email` and now of course it created 3 tickets. So basically, I messed up. Sorry, is there a way I can close those 3 tickets myself? Which brings me to a second question, can I use `git send-email` and send it to 24555@debbugs.gnu.org instead or should I really copy-paste the patches? Thanks, Philippe --94eb2c1b074e9cc2c2053de4e338 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hum.

I wanted to use `git send-email` a= nd now of course it created 3 tickets.

So basicall= y, I messed up. Sorry, is there a way I can close those 3 tickets myself?

Which brings me to a second question, can I use `gi= t send-email` and send it to=C2=A024555@debbugs.gnu.org instead or shou= ld I really copy-paste the patches?

Thanks,
Philippe
--94eb2c1b074e9cc2c2053de4e338-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 14:32:48 2016 Received: (at 24555) by debbugs.gnu.org; 2 Oct 2016 18:32:48 +0000 Received: from localhost ([127.0.0.1]:42223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqlZA-0006q2-Gh for submit@debbugs.gnu.org; Sun, 02 Oct 2016 14:32:48 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqlZ8-0006pl-8k for 24555@debbugs.gnu.org; Sun, 02 Oct 2016 14:32:47 -0400 Received: by mail-oi0-f54.google.com with SMTP id n132so115605748oih.1 for <24555@debbugs.gnu.org>; Sun, 02 Oct 2016 11:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Ct8viok2oLAsNmFes9fvLKuSv7X3p5lSoM1tlurrCTU=; b=FF8DBnMzWk5OGUh8gt4ugNGqhkTyQ8bGB3ypBBVsyNrkgGosT1cOhynfFbrhuWTxB3 6xJlR1se0apUWvunKs4uzMPGG/ctyq9wNaoqFLYS2flRa1Nj0aJXJmHO/rAcc+C98tHh vhiClD+Z5VLDcnM2OTFQ67SLoO58EIRDxlwBLYzGXi1vKEk3Z0162EfLV8a9k4wBYzR7 dBlXClq4A60NcDxGFYpd7nGhQUjNgsmW2GYCzUkBItwT9xFculZ9qi+UNC96k9vWch4X aFpeXvC58LnYYvzIyy51nklFZROeRgJ9IfaD8RKP9wul+O8bVX9SK512BDtzv4o6PPa4 TOHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Ct8viok2oLAsNmFes9fvLKuSv7X3p5lSoM1tlurrCTU=; b=QfL2o74LyUwpkK9B8jy+j6z8QvlXtvt4Cg4zNSWQbVDMSXxpV5WHaXDwfTYB6nYKZH gdZP8dq8NehIJgK/kBw1AM8DAUu2tMo7+8i8384Y6x1GgJr+uZ3M8ud/XAMbAeK0cpyX R6jdTbggI59PVaqpkF5Fyn+dWzUiaLSIrEpgWFo/JxrjOVSa4uGTMJqytQX2VzOiSlF9 EXV5FMtk5EqaL6+rL8N8+RJXdGw4fmr2wjYVCP4/ke+mtK4oWtMzV1rRYVzlzDQ5y5lL yadYLeUHW6btLr3/TkW93PaJrHPfhYIHEQqBOytLWnVkAr9sKJ+YpkivcYoYMnHnIK5B bbnw== X-Gm-Message-State: AA6/9RnWlb5Z5k0RtQsUA4ksHg+OfnNWqsW61XKbpxWuWIP0xbHeZwaponOAhhVe+Ik3IN9KlGE1OYfv+4/RBg== X-Received: by 10.157.3.19 with SMTP id 19mr1661555otv.101.1475433160630; Sun, 02 Oct 2016 11:32:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.42.16 with HTTP; Sun, 2 Oct 2016 11:32:39 -0700 (PDT) In-Reply-To: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> From: Noam Postavsky Date: Sun, 2 Oct 2016 14:32:39 -0400 X-Google-Sender-Auth: yvHONW812v7y8qywTPl4jHjQCwo Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Philippe Vaucher Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24555 Cc: Eli Zaretskii , Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sun, Oct 2, 2016 at 1:08 PM, Philippe Vaucher wrote: > Hum. > > I wanted to use `git send-email` and now of course it created 3 tickets. > > So basically, I messed up. Sorry, is there a way I can close those 3 tickets > myself? Send email to with contents merge xxxxx yyyyy zzzzz quit Where x, y, and z are the 3 bug numbers. > > Which brings me to a second question, can I use `git send-email` and send it > to 24555@debbugs.gnu.org instead or should I really copy-paste the patches? Both should work, the problem with using "git send-email" is that the mails sometimes arrive out of order. I usually use "git format-patch" and send as attachments. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 14:48:51 2016 Received: (at 24555) by debbugs.gnu.org; 2 Oct 2016 18:48:51 +0000 Received: from localhost ([127.0.0.1]:42228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqlog-0007Jx-To for submit@debbugs.gnu.org; Sun, 02 Oct 2016 14:48:51 -0400 Received: from mail-ua0-f175.google.com ([209.85.217.175]:35721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqloe-0007Jg-Kd for 24555@debbugs.gnu.org; Sun, 02 Oct 2016 14:48:49 -0400 Received: by mail-ua0-f175.google.com with SMTP id q42so133965842uaq.2 for <24555@debbugs.gnu.org>; Sun, 02 Oct 2016 11:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=e0ZdpFcxL4qCwJkcPxaKRnema1o3EJQvO8OepKEFokg=; b=Bnb7e/GRAU48inST6QI98VVqcuBp/aYD366saeWW5X6w3+vNxSQayl6jvF+8s5pTky xex6VFymARHFDrmDFz9cqxFz5wGGvur2CAb3i5ytFdzcjzsoS975FM8Z40HA2wdq81ap yd8bGN7oqYH2VrMipgmjd/wv9WbS7eIzlOeGRkVLfoQt8h5x7lOba+Fshrofu+eXSvNk 5zls0UqfQiro83baPBCJMfZ01zVva5RjEf6WFyNVCCUDZB3S/mnTF8gyXVBGEywOHGJ9 j5/wxXWV2iWlINLP2/YnhybrZnZhv+gDDwp7cPVpZRh4eGTgBbUetC1j9W3T/pVbuOPw FU7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e0ZdpFcxL4qCwJkcPxaKRnema1o3EJQvO8OepKEFokg=; b=KlVcvbkDkAYj+1BA3V0tjeHl5Ld8un0Kc+t6qh9dkfRKMsTPVH01jxQ9DgPVfmZy9O pSdAu1WRVaHBb7WUSTX10BcB7lnHZN5FJx68lx6A2oDF3WxzqFukeQmQkWDhN8n2Ye3j MHpQF/9LF5W1cyaFs/7Np+LdKC6K7/ZhrZD1w+gwjTOpcEx7pf4CtHFY6QFsLqp/Sbtf Aku0fQcEYE9VSQliHvMB7LXDpXfkvy79tpMM8HP5PuSlpuF91+/5PwTuX5bUWo8JrHf0 dpIB2FK1rxitZF/P6AiVWT5cyUM4uJvGEVcR4Ra0ZB8OHDRJeyzA0tV4WWpndBv0TpWZ +5yw== X-Gm-Message-State: AA6/9RmhIdux41j6+WYq+a6SNK+ge5FxD+XJLevFUonUxWM0Eh6nEthEBRAaBk0HXzUZLKFEXCPykajnrd13hw== X-Received: by 10.176.66.199 with SMTP id j65mr10030741uaj.73.1475434123011; Sun, 02 Oct 2016 11:48:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Sun, 2 Oct 2016 11:48:12 -0700 (PDT) In-Reply-To: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> From: Philippe Vaucher Date: Sun, 2 Oct 2016 20:48:12 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Noam Postavsky Content-Type: multipart/alternative; boundary=94eb2c061646caad04053de6460b X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24555 Cc: Eli Zaretskii , Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --94eb2c061646caad04053de6460b Content-Type: text/plain; charset=UTF-8 > > > So basically, I messed up. Sorry, is there a way I can close those 3 > tickets > > myself? > > Send email to with contents > > merge xxxxx yyyyy zzzzz > quit > > Where x, y, and z are the 3 bug numbers. Will do, thanks! > > Which brings me to a second question, can I use `git send-email` and > send it > > to 24555@debbugs.gnu.org instead or should I really copy-paste the > patches? > > Both should work, the problem with using "git send-email" is that the > mails sometimes arrive out of order. I usually use "git format-patch" > and send as attachments. > Okay, I'll attach them from now on. Thanks, Philippe --94eb2c061646caad04053de6460b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> So basically, I messed up.= Sorry, is there a way I can close those 3 tickets
> myself?

Send email to <control= @debbugs.gnu.org> with contents

merge xxxxx yyyyy zzzzz
quit

Where x, y, and z are the 3 bug numbers.

Wi= ll do, thanks!
=C2=A0
=C2=A0
> Which brings me to a second question, can I= use `git send-email` and send it
> to 24555@debbugs.gnu.org = instead or should I really copy-paste the patches?

Both should work, the problem with using "git send-email" = is that the
mails sometimes arrive out of order. I usually use "git format-patch&q= uot;
and send as attachments.

Okay, I'll atta= ch them from now on.

Thanks,
Philippe
--94eb2c061646caad04053de6460b-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 15:35:13 2016 Received: (at control) by debbugs.gnu.org; 2 Oct 2016 19:35:13 +0000 Received: from localhost ([127.0.0.1]:42240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqmXY-0001tc-Pr for submit@debbugs.gnu.org; Sun, 02 Oct 2016 15:35:12 -0400 Received: from mail-ua0-f176.google.com ([209.85.217.176]:34584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqmXX-0001tO-4P for control@debbugs.gnu.org; Sun, 02 Oct 2016 15:35:11 -0400 Received: by mail-ua0-f176.google.com with SMTP id p25so13772234uaa.1 for ; Sun, 02 Oct 2016 12:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=rVcFNC9Qv2Q+6yxdnsExFYa2Nlic7bKKtjlWNOGdMsQ=; b=lMLIPpcXCCjnxjwveYuCJqcjHBY1HMVDcJ0RZICzDPCOYzw1eva5xLTlT0bEDE1zlz v7zvkkNAkAomzR56BJgUCuhYjToXf8goVOogqcm690xiRnBUwL9CJnwsNbdIYSxgdVjO JaoCtVr4w+/kO6qpwl+A1TubUCWapMyrvgI6b2/Pyf6xMQfCwVl7JPHa3jZI2RY0ZqBr xyWDgtYCGEASYl2MxFKtwQKf8ASVbiaHFh0UCtaOeLvslS0FrJqdw4FU+W8ueOaY6DkC btGvU8HM47mT0Pz8E3ZuqWZJ9ioqDs2JV9fa2O49EjGz4j4MP7E2rP599cicLaRJc5zS 6fWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rVcFNC9Qv2Q+6yxdnsExFYa2Nlic7bKKtjlWNOGdMsQ=; b=B82u+tcybihPLIcrfJnPUJK4jFjTxBbqW7LTNzsgwemxo5MwDbOlz7hlsV1BJzV71x LYJnzrCMRu81HD4cXG0whpFWFwZStwQIJCp8jXWO5iLQHaJqnBF3++GGhNeCdIRX7M5Z 1bg2J457JQJr7EhQGpkBIGqTe3AMc4vHdkamGePnByTGoBk5OsVFvGdb9/12nIk5vhbD zOj5kvStCqr1dthVj90pllOfFX4UCx3QH8JzSBSpzpDgB+WmT2vmmUBGgERN9KS26oE7 pjwGMvhU68QBZKUW2Ee9Una8OaIe9pM7q68Irk3RGtSPg3Ip8oMkk3AH3iwmSn82Rpxn 7I1w== X-Gm-Message-State: AA6/9RlRMlJ91+qi3qciEnqOJvqIJ9+6prJx59HikpxhuRL+sWtxkPq2pSlJtfeDL+2nB5SdTzpS9R9eFz9luQ== X-Received: by 10.176.84.217 with SMTP id q25mr10010096uaa.49.1475436905627; Sun, 02 Oct 2016 12:35:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Sun, 2 Oct 2016 12:34:35 -0700 (PDT) From: Philippe Vaucher Date: Sun, 2 Oct 2016 21:34:35 +0200 Message-ID: Subject: merge To: control@debbugs.gnu.org Content-Type: multipart/alternative; boundary=94eb2c1b1136a62580053de6ec14 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c1b1136a62580053de6ec14 Content-Type: text/plain; charset=UTF-8 forcemerge 24555 24588 24589 24590 quit --94eb2c1b1136a62580053de6ec14 Content-Type: text/html; charset=UTF-8
forcemerge 24555 24588 24589 24590
quit
--94eb2c1b1136a62580053de6ec14-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 02 15:41:55 2016 Received: (at 24555) by debbugs.gnu.org; 2 Oct 2016 19:41:55 +0000 Received: from localhost ([127.0.0.1]:42245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqme3-00025G-HB for submit@debbugs.gnu.org; Sun, 02 Oct 2016 15:41:55 -0400 Received: from mail-vk0-f48.google.com ([209.85.213.48]:35431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqme2-000251-C5 for 24555@debbugs.gnu.org; Sun, 02 Oct 2016 15:41:54 -0400 Received: by mail-vk0-f48.google.com with SMTP id 192so144662751vkl.2 for <24555@debbugs.gnu.org>; Sun, 02 Oct 2016 12:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZO5vmx1MgJ1gg39gtcfmrJZo+niV6twV7Xf0oTS8b4c=; b=RmFR0KuwcWP08in+FGWOTtVO4jIECpztfdfYy5dkhd77ponTeTW0lX+yYu7RvVk/mq uoLhKjOiSr87Y/fyLdujqn8Z5TPJI6ObwHOqxLLNoYTpFGsg6u6eE0WzfQh3BDUzlyZC U4uOc1E4anPeyWPcmqNkw5q6hOZmvQ26uJMpGEVm5SGyTrZ2E4mh3C07VIfo/0u7aoRf TsL16O/dig6QYVKAP8V5GZC6NoXetghr47NQ8HgAk3mMEVo0ggDSx8gu9pZANk6G7mJb WeiPOB06b9EVZ57fb+zYbi6aRYmWYi0PcSbi4uS1i5jFWM2hF/xeJhhFOww24MGZSEzr DytA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZO5vmx1MgJ1gg39gtcfmrJZo+niV6twV7Xf0oTS8b4c=; b=jcQ8u3qoc252ErY+bmlML3rTkYMBCVNNXXx8hJrajnuEB0b1syZL5xvbKZka69TIS4 DZq7RkZyxP8XJIePAVK6hunwaJDOccLdwh5pVx8FWSKpAv2gkWWtpgSmclqeXNtVuc7H gioCNN7a2r9kcgOHytcmhGe8uG0aDVITkbJJfmB0bshcqLEWEURGrVif9eFZIwsc/bcA BIflImALIou0fPcDxLV67r8Y6uVdT9zlfJq8ixuBuhGH1wzcQFBgsVf+TBx3W6Y2k5uG yKAoNfNDAdrUNvJ4A66DNhvQrI3PaR6plvQ+Rl1IvlOR7rwA9sEssu+nXaqfCT9SvSx1 whxg== X-Gm-Message-State: AA6/9RkbaAK+gGKoSD9Ri2+l/OIKcq+nPYKiR9fp8y0sAWRmtzJ15e8nTSvzzO0bQZIX08o/LUsydaGsNFHUkA== X-Received: by 10.31.76.5 with SMTP id z5mr11999316vka.69.1475437308822; Sun, 02 Oct 2016 12:41:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Sun, 2 Oct 2016 12:41:18 -0700 (PDT) In-Reply-To: <83bmz4klyc.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> From: Philippe Vaucher Date: Sun, 2 Oct 2016 21:41:18 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/mixed; boundary=001a114ddc0aaed1e4053de7045d X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a114ddc0aaed1e4053de7045d Content-Type: multipart/alternative; boundary=001a114ddc0aaed1e0053de7045b --001a114ddc0aaed1e0053de7045b Content-Type: text/plain; charset=UTF-8 > > > 1 Where should I make the `make-obsolete-variable` call (in which file)? > Given it's defined in callint.c it's not > > really obvious in which .el it should go. > > I'd say in subr.el; there's a bunch of those there already. > > > 2 I don't have a "current name". Should I make CURRENT-NAME something > like "This variable will be > > removed in the future"? Should I pass "nil"? > > The former, but I think the string should start with a lower-case > letter, as it will be displayed after the standard text saying the > variable is obsolete. I suggest to experiment with different strings > and find the one which makes the most sense. > > > 3 What WHEN release number should I use? 25.2 ? > > Yes, 25.2. > Okay, here attached are the patches. Philippe --001a114ddc0aaed1e0053de7045b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> 1 Where should I make the `make-obsolete-va= riable` call (in which file)? Given it's defined in callint.c it's = not
>=C2=A0 really obvious in which .el it should go.

I'd say in subr.el; there's a bunch of those there already.<= br>
> 2 I don't have a "current name". Should I make CURRENT-N= AME something like "This variable will be
>=C2=A0 removed in the future"? Should I pass &quo= t;nil"?

The former, but I think the string should start with a lower-case letter, as it will be displayed after the standard text saying the
variable is obsolete.=C2=A0 I suggest to experiment with different strings<= br> and find the one which makes the most sense.

> 3 What WHEN release number should I use? 25.2 ?

Yes, 25.2.

Okay, here attached are the = patches.

Philippe

=
--001a114ddc0aaed1e0053de7045b-- --001a114ddc0aaed1e4053de7045d Content-Type: text/x-patch; charset=US-ASCII; name="0001-Restore-command-debug-status-functionality.patch" Content-Disposition: attachment; filename="0001-Restore-command-debug-status-functionality.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itt191g20 RnJvbSAzZDZhZDc5NjBhNDAxNjAyMjIwZTQ4N2FiMjBlYzU4MmY2NjYwOWMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogU2F0LCAxIE9jdCAyMDE2IDEzOjExOjEzICswMjAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIFJlc3RvcmUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMgZnVuY3Rpb25hbGl0eQoKLS0t CiBzcmMvY2FsbGludC5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxsaW50LmMgYi9zcmMvY2FsbGlu dC5jCmluZGV4IDA1M2VlNmMuLjQ2NTIxNTEgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxsaW50LmMKKysr IGIvc3JjL2NhbGxpbnQuYwpAQCAtODM3LDcgKzgzNywxMCBAQCBpbnZva2UgaXQuICBJZiBLRVlT IGlzIG9taXR0ZWQgb3IgbmlsLCB0aGUgcmV0dXJuIHZhbHVlIG9mCiAgIGtzZXRfbGFzdF9jb21t YW5kIChjdXJyZW50X2tib2FyZCwgc2F2ZV9sYXN0X2NvbW1hbmQpOwogCiAgIHsKLSAgICBMaXNw X09iamVjdCB2YWwgPSBGZnVuY2FsbCAobmFyZ3MsIGFyZ3MpOworICAgIExpc3BfT2JqZWN0IHZh bDsKKyAgICBzcGVjYmluZCAoVmNvbW1hbmRfZGVidWdfc3RhdHVzLCBRbmlsKTsKKworICAgIHZh bCA9IEZmdW5jYWxsIChuYXJncywgYXJncyk7CiAgICAgdmFsID0gdW5iaW5kX3RvIChzcGVjY291 bnQsIHZhbCk7CiAgICAgU0FGRV9GUkVFICgpOwogICAgIHJldHVybiB2YWw7Ci0tIAoyLjEwLjAK Cg== --001a114ddc0aaed1e4053de7045d Content-Type: text/x-patch; charset=US-ASCII; name="0002-Deprecate-variable-command-debug-status.patch" Content-Disposition: attachment; filename="0002-Deprecate-variable-command-debug-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itt191gi1 RnJvbSBlZTljZWZmODllZmU1ZTcxYjk1NmQ3NWY2OWNlZjZmNTBkZDZiOGFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyOCBTZXAgMjAxNiAxMjoxNDoyOCArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBEZXByZWNhdGUgdmFyaWFibGUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMKCi0tLQog ZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgfCAyICsrCiBsaXNwL3N1YnIuZWwgICAgICAgICAg ICAgICB8IDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4 aQppbmRleCAyZjgzYjQwLi4zMjJhY2QwIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kZWJ1Z2dp bmcudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aQpAQCAtNjU0LDYgKzY1NCw4 IEBAIGludm9jYXRpb24uCiBUaGUgYWR2YW50YWdlIG9mIHVzaW5nIHRoaXMgdmFyaWFibGUgcmF0 aGVyIHRoYW4gYW4gb3JkaW5hcnkgZ2xvYmFsCiB2YXJpYWJsZSBpcyB0aGF0IHRoZSBkYXRhIHdp bGwgbmV2ZXIgY2Fycnkgb3ZlciB0byBhIHN1YnNlcXVlbnQgY29tbWFuZAogaW52b2NhdGlvbi4K KworVGhpcyB2YXJpYWJsZSBpcyBvYnNvbGV0ZSBhbmQgc2hvdWxkIGJlIHJlbW92ZWQgaW4gZnV0 dXJlIHZlcnNpb25zLgogQGVuZCBkZWZ2YXIKIAogQGRlZnVuIGJhY2t0cmFjZS1mcmFtZSBmcmFt ZS1udW1iZXIKZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbAppbmRleCBl OWUxOWQzLi4yNzFjZDJmIDEwMDY0NAotLS0gYS9saXNwL3N1YnIuZWwKKysrIGIvbGlzcC9zdWJy LmVsCkBAIC0xMzc3LDYgKzEzNzcsOCBAQCBpcyBjb252ZXJ0ZWQgaW50byBhIHN0cmluZyBieSBl eHByZXNzaW5nIGl0IGluIGRlY2ltYWwuIgogKG1ha2Utb2Jzb2xldGUgJ3Byb2Nlc3MtZmlsdGVy LW11bHRpYnl0ZS1wIG5pbCAiMjMuMSIpCiAobWFrZS1vYnNvbGV0ZSAnc2V0LXByb2Nlc3MtZmls dGVyLW11bHRpYnl0ZSBuaWwgIjIzLjEiKQogCisobWFrZS1vYnNvbGV0ZS12YXJpYWJsZSAnY29t bWFuZC1kZWJ1Zy1zdGF0dXMgInNob3VsZCBiZSByZW1vdmVkIGluIGZ1dHVyZSB2ZXJzaW9ucyIg IjI1LjIiKQorCiA7OyBMaXNwIG1hbnVhbCBvbmx5IHVwZGF0ZWQgaW4gMjIuMS4KIChkZWZpbmUt b2Jzb2xldGUtdmFyaWFibGUtYWxpYXMgJ2V4ZWN1dGluZy1tYWNybyAnZXhlY3V0aW5nLWtiZC1t YWNybwogICAiYmVmb3JlIDE5LjM0IikKLS0gCjIuMTAuMAoK --001a114ddc0aaed1e4053de7045d-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 03 03:13:09 2016 Received: (at 24555) by debbugs.gnu.org; 3 Oct 2016 07:13:09 +0000 Received: from localhost ([127.0.0.1]:42470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxQy-0000qw-Rm for submit@debbugs.gnu.org; Mon, 03 Oct 2016 03:13:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxQw-0000qQ-Pt for 24555@debbugs.gnu.org; Mon, 03 Oct 2016 03:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqxQo-0001zF-Ke for 24555@debbugs.gnu.org; Mon, 03 Oct 2016 03:13:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxQo-0001yX-HZ; Mon, 03 Oct 2016 03:12:58 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4992 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqxQl-0006EB-Pk; Mon, 03 Oct 2016 03:12:56 -0400 Date: Mon, 03 Oct 2016 10:13:08 +0300 Message-Id: <83k2dpq517.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Sun, 2 Oct 2016 21:41:18 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-Debbugs-Envelope-To: 24555 Cc: monnier@iro.umontreal.ca, 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) > From: Philippe Vaucher > Date: Sun, 2 Oct 2016 21:41:18 +0200 > Cc: Stefan Monnier , 24555@debbugs.gnu.org > > diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi > index 2f83b40..322acd0 100644 > --- a/doc/lispref/debugging.texi > +++ b/doc/lispref/debugging.texi > @@ -654,6 +654,8 @@ invocation. > The advantage of using this variable rather than an ordinary global > variable is that the data will never carry over to a subsequent command > invocation. > + > +This variable is obsolete and should be removed in future versions. I think "will be removed" is better here. > diff --git a/lisp/subr.el b/lisp/subr.el > index e9e19d3..271cd2f 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -1377,6 +1377,8 @@ is converted into a string by expressing it in decimal." > (make-obsolete 'process-filter-multibyte-p nil "23.1") > (make-obsolete 'set-process-filter-multibyte nil "23.1") > > +(make-obsolete-variable 'command-debug-status "should be removed in future versions" "25.2") And here I'd reword the message: "; expect it to be removed in a future version" Can someone please push this to the emacs-25 branch in Philippe's name? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 03 03:37:51 2016 Received: (at 24555) by debbugs.gnu.org; 3 Oct 2016 07:37:51 +0000 Received: from localhost ([127.0.0.1]:42485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxot-0001Xx-82 for submit@debbugs.gnu.org; Mon, 03 Oct 2016 03:37:51 -0400 Received: from mail-ua0-f174.google.com ([209.85.217.174]:33822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxor-0001Xj-H0 for 24555@debbugs.gnu.org; Mon, 03 Oct 2016 03:37:50 -0400 Received: by mail-ua0-f174.google.com with SMTP id p25so22439495uaa.1 for <24555@debbugs.gnu.org>; Mon, 03 Oct 2016 00:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rAW3ibyj4MJlSdWVVrLCWIGERoK9i8gABpVULMTpCNE=; b=vhY6XNSUpHFZ9Iw0CLj3PYEVu2DOLoR3xoDf+VSydgOt7QWj/ZDRw4Zk+NgJ3GTIMX 2QEya8j/+qBxT2PaYHfwLnWcvIA0V89YDlIYJ5IIymFpu6yX1iAOXFY0bErAsQgfyIE8 f/y+8s2sCUD/RPOz7AnRK1S624PluEraF0hyze//VJCt/kFP5cNT+HwpN5w0dBIOFVPT f5efx2CHU9mR6DID1q0voW6TDj1onbLOYwnqPr+zI1yG0PS6Y0Al/cDbZqU7D/6xwaLO nlQb/ubWWTNB4Wm2V6Aayq0kVP+fZYsLF478se2aPdT3OEn4GddIogl7gfH5K7w57YGw 10SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rAW3ibyj4MJlSdWVVrLCWIGERoK9i8gABpVULMTpCNE=; b=k2sBaDbJwd4x/31JVrMR55ZBm0QgOKsi8SrMz2yUUB/vTozXtwihDtoVvn600gDtmw kf81Dl3MBH8shu55v4yAswqqdFf6Xz401ZHm06/6WbqeNattGjngzCtScm0sXUm6vSZq U0flel3PB3BC6n+F+Ds/DdJLmj9SQme8L6wWTj5O5pzyrFJSaHxlUf0slhfmZyv9Ji3m VQs5+v4z6uBy92HGqekHyNAga9417pFC7UuKYgrBMxb1Zx4IFcMhpBIWqO7RsEd55LWm TJFiDDzGxNjRMrlD0TG8v7eFW3+AovPSRcjxzsXQ4RHh9OY+AY7opzXCCBhrwwqVUU9L WBqw== X-Gm-Message-State: AA6/9RkN4HK2U8YpFJEcz+gwdbBS1r6l2AW9QpoZkxHI1sUrxEXmLNzc56Iv/NnwOWgeb014w0KMZROxkEwBqw== X-Received: by 10.176.84.149 with SMTP id p21mr12646496uaa.42.1475480263927; Mon, 03 Oct 2016 00:37:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Mon, 3 Oct 2016 00:37:13 -0700 (PDT) In-Reply-To: <83k2dpq517.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> From: Philippe Vaucher Date: Mon, 3 Oct 2016 09:37:13 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/mixed; boundary=94eb2c1b074e01754a053df105a7 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --94eb2c1b074e01754a053df105a7 Content-Type: multipart/alternative; boundary=94eb2c1b074e017546053df105a5 --94eb2c1b074e017546053df105a5 Content-Type: text/plain; charset=UTF-8 > > > +This variable is obsolete and should be removed in future versions. > > I think "will be removed" is better here. > > > +(make-obsolete-variable 'command-debug-status "should be removed in > future versions" "25.2") > > And here I'd reword the message: > > "; expect it to be removed in a future version" > Here are the new patches with your modifications. Also viewable at https://github.com/Silex/emacs/compare/emacs-25~2...Silex:emacs-25 Philippe --94eb2c1b074e017546053df105a5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> += This variable is obsolete and should be removed in future versions.

I think "will be removed" is better here.

> +(make-obsolete-variable 'command-debug-status "should be= removed in future versions" "25.2")

And here I'd reword the message:

=C2=A0 "; expect it to be removed in a future version"

Here are the new patches with your modifications.=


Ph= ilippe

--94eb2c1b074e017546053df105a5-- --94eb2c1b074e01754a053df105a7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Restore-command-debug-status-functionality.patch" Content-Disposition: attachment; filename="0001-Restore-command-debug-status-functionality.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ittqt2zu0 RnJvbSAxNjUyNDQ3NmEyMWEwOWUwMTk1ZDJkYjM0ZTFlZDQwMDhiOTFkMzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogU2F0LCAxIE9jdCAyMDE2IDEzOjExOjEzICswMjAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIFJlc3RvcmUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMgZnVuY3Rpb25hbGl0eQoKLS0t CiBzcmMvY2FsbGludC5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxsaW50LmMgYi9zcmMvY2FsbGlu dC5jCmluZGV4IDA1M2VlNmMuLjQ2NTIxNTEgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxsaW50LmMKKysr IGIvc3JjL2NhbGxpbnQuYwpAQCAtODM3LDcgKzgzNywxMCBAQCBpbnZva2UgaXQuICBJZiBLRVlT IGlzIG9taXR0ZWQgb3IgbmlsLCB0aGUgcmV0dXJuIHZhbHVlIG9mCiAgIGtzZXRfbGFzdF9jb21t YW5kIChjdXJyZW50X2tib2FyZCwgc2F2ZV9sYXN0X2NvbW1hbmQpOwogCiAgIHsKLSAgICBMaXNw X09iamVjdCB2YWwgPSBGZnVuY2FsbCAobmFyZ3MsIGFyZ3MpOworICAgIExpc3BfT2JqZWN0IHZh bDsKKyAgICBzcGVjYmluZCAoVmNvbW1hbmRfZGVidWdfc3RhdHVzLCBRbmlsKTsKKworICAgIHZh bCA9IEZmdW5jYWxsIChuYXJncywgYXJncyk7CiAgICAgdmFsID0gdW5iaW5kX3RvIChzcGVjY291 bnQsIHZhbCk7CiAgICAgU0FGRV9GUkVFICgpOwogICAgIHJldHVybiB2YWw7Ci0tIAoyLjEwLjAK Cg== --94eb2c1b074e01754a053df105a7 Content-Type: text/x-patch; charset=US-ASCII; name="0002-Deprecate-variable-command-debug-status.patch" Content-Disposition: attachment; filename="0002-Deprecate-variable-command-debug-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ittqt3081 RnJvbSBjNjY2YWU3NThhYzU3Y2U0Njg0ZGEyNjY3ZmQ5MTJiMGFlN2JhNDI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyOCBTZXAgMjAxNiAxMjoxNDoyOCArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBEZXByZWNhdGUgdmFyaWFibGUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMKCi0tLQog ZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgfCAyICsrCiBsaXNwL3N1YnIuZWwgICAgICAgICAg ICAgICB8IDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4 aQppbmRleCAyZjgzYjQwLi5jODhhMmZhIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kZWJ1Z2dp bmcudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aQpAQCAtNjU0LDYgKzY1NCw4 IEBAIGludm9jYXRpb24uCiBUaGUgYWR2YW50YWdlIG9mIHVzaW5nIHRoaXMgdmFyaWFibGUgcmF0 aGVyIHRoYW4gYW4gb3JkaW5hcnkgZ2xvYmFsCiB2YXJpYWJsZSBpcyB0aGF0IHRoZSBkYXRhIHdp bGwgbmV2ZXIgY2Fycnkgb3ZlciB0byBhIHN1YnNlcXVlbnQgY29tbWFuZAogaW52b2NhdGlvbi4K KworVGhpcyB2YXJpYWJsZSBpcyBvYnNvbGV0ZSBhbmQgd2lsbCBiZSByZW1vdmVkIGluIGZ1dHVy ZSB2ZXJzaW9ucy4KIEBlbmQgZGVmdmFyCiAKIEBkZWZ1biBiYWNrdHJhY2UtZnJhbWUgZnJhbWUt bnVtYmVyCmRpZmYgLS1naXQgYS9saXNwL3N1YnIuZWwgYi9saXNwL3N1YnIuZWwKaW5kZXggZTll MTlkMy4uMjYwMDkwMSAxMDA2NDQKLS0tIGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5l bApAQCAtMTM3Nyw2ICsxMzc3LDggQEAgaXMgY29udmVydGVkIGludG8gYSBzdHJpbmcgYnkgZXhw cmVzc2luZyBpdCBpbiBkZWNpbWFsLiIKIChtYWtlLW9ic29sZXRlICdwcm9jZXNzLWZpbHRlci1t dWx0aWJ5dGUtcCBuaWwgIjIzLjEiKQogKG1ha2Utb2Jzb2xldGUgJ3NldC1wcm9jZXNzLWZpbHRl ci1tdWx0aWJ5dGUgbmlsICIyMy4xIikKIAorKG1ha2Utb2Jzb2xldGUtdmFyaWFibGUgJ2NvbW1h bmQtZGVidWctc3RhdHVzICI7IGV4cGVjdCBpdCB0byBiZSByZW1vdmVkIGEgZnV0dXJlIHZlcnNp b24iICIyNS4yIikKKwogOzsgTGlzcCBtYW51YWwgb25seSB1cGRhdGVkIGluIDIyLjEuCiAoZGVm aW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdleGVjdXRpbmctbWFjcm8gJ2V4ZWN1dGluZy1r YmQtbWFjcm8KICAgImJlZm9yZSAxOS4zNCIpCi0tIAoyLjEwLjAKCg== --94eb2c1b074e01754a053df105a7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 03 03:42:55 2016 Received: (at 24555) by debbugs.gnu.org; 3 Oct 2016 07:42:55 +0000 Received: from localhost ([127.0.0.1]:42499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxtn-0001h0-KF for submit@debbugs.gnu.org; Mon, 03 Oct 2016 03:42:55 -0400 Received: from mail-ua0-f170.google.com ([209.85.217.170]:36603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxtl-0001gm-8S for 24555@debbugs.gnu.org; Mon, 03 Oct 2016 03:42:53 -0400 Received: by mail-ua0-f170.google.com with SMTP id n13so143132454uaa.3 for <24555@debbugs.gnu.org>; Mon, 03 Oct 2016 00:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vqKxBi/UO80jev+kany3wxlgvQLwWXazR6YLP1ABki8=; b=EXkvO1RZQsZQK9fKZ+rb4jAstmS0IBUtOB7I5zugmjC9NHWm4Eo0v0RljvNOEJ48Jm 7p51tKzSijrxcdWG3KQdEbnZm1/dbBRiL4vTQY4HtdIf9pfygOGWopucJWfd5CSVW79i /pTruOlpguSBRZadGWe59HZTk3UZ/SX66lkQLHjpXMdSfAnSy3I4B37Fl8jmjhtimTY2 XnyABc3ENuPFv+H2q4Z/7Q0yJ5CyHVimu6RZ0sMu8msBI6UoC4hxAlr/roKcuAi1jGhj Td8ZbmgZtXeywUEJstKNUF789siuI5Q2xkuCO/vV/uY3ll33BN5O82hsl+S0ndVIcu3D Y2QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vqKxBi/UO80jev+kany3wxlgvQLwWXazR6YLP1ABki8=; b=jyCFLHNMFCmjWiS/ARzh1Fnwo3zZdhCn1gz2c1YJU1TvE2TCYyvigTrKd0Kbsyo2rX phKvdNcVAyw8SQBfdorzq3rVy7+2hzvYQOfbooEIXw2CoQyJak7+7lDs4+NxhMvFS83H 8B06NAaN2VsGaf7g1HZU52gogoJ+GJ9DCoSMBbX4VAWObVBkr3d79sTx9XYLHl1z6XRk eWbi7hHyMBaAvWLh86n7UsY3OiYFY7W7DtmAGNIzNOd2bbTzzolcObXHpjA6FRDs01sy mlI73EtnEcnCShypFz7Kx5udDXAC/s+bfEb7PLiYxsgIZ4iucDcLmBDgHmOnhc9h4Y0p g7BA== X-Gm-Message-State: AA6/9RkdBa5QTqZ8GtDvpMENMzhh4xM5QyjMe+ltdb8PY61Dkmew5QQB1ZhuxYKSLSp8CSD3tIAJ2sG+pnvtKg== X-Received: by 10.176.66.199 with SMTP id j65mr11093782uaj.73.1475480567847; Mon, 03 Oct 2016 00:42:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Mon, 3 Oct 2016 00:42:14 -0700 (PDT) In-Reply-To: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> From: Philippe Vaucher Date: Mon, 3 Oct 2016 09:42:14 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/mixed; boundary=94eb2c0616461ed95b053df11719 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24555 Cc: Stefan Monnier , 24555@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c0616461ed95b053df11719 Content-Type: multipart/alternative; boundary=94eb2c0616461ed956053df11717 --94eb2c0616461ed956053df11717 Content-Type: text/plain; charset=UTF-8 > > Here are the new patches with your modifications. > > Also viewable at https://github.com/Silex/emacs/compare/emacs-25~2... > Silex:emacs-25 > And again new patches without a typo :-) Philippe --94eb2c0616461ed956053df11717 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Here are the new patches with your modification= s.


And again ne= w patches without a typo :-)

Philippe

--94eb2c0616461ed956053df11717-- --94eb2c0616461ed95b053df11719 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Restore-command-debug-status-functionality.patch" Content-Disposition: attachment; filename="0001-Restore-command-debug-status-functionality.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ittr069x2 RnJvbSAxNjUyNDQ3NmEyMWEwOWUwMTk1ZDJkYjM0ZTFlZDQwMDhiOTFkMzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogU2F0LCAxIE9jdCAyMDE2IDEzOjExOjEzICswMjAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIFJlc3RvcmUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMgZnVuY3Rpb25hbGl0eQoKLS0t CiBzcmMvY2FsbGludC5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxsaW50LmMgYi9zcmMvY2FsbGlu dC5jCmluZGV4IDA1M2VlNmMuLjQ2NTIxNTEgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxsaW50LmMKKysr IGIvc3JjL2NhbGxpbnQuYwpAQCAtODM3LDcgKzgzNywxMCBAQCBpbnZva2UgaXQuICBJZiBLRVlT IGlzIG9taXR0ZWQgb3IgbmlsLCB0aGUgcmV0dXJuIHZhbHVlIG9mCiAgIGtzZXRfbGFzdF9jb21t YW5kIChjdXJyZW50X2tib2FyZCwgc2F2ZV9sYXN0X2NvbW1hbmQpOwogCiAgIHsKLSAgICBMaXNw X09iamVjdCB2YWwgPSBGZnVuY2FsbCAobmFyZ3MsIGFyZ3MpOworICAgIExpc3BfT2JqZWN0IHZh bDsKKyAgICBzcGVjYmluZCAoVmNvbW1hbmRfZGVidWdfc3RhdHVzLCBRbmlsKTsKKworICAgIHZh bCA9IEZmdW5jYWxsIChuYXJncywgYXJncyk7CiAgICAgdmFsID0gdW5iaW5kX3RvIChzcGVjY291 bnQsIHZhbCk7CiAgICAgU0FGRV9GUkVFICgpOwogICAgIHJldHVybiB2YWw7Ci0tIAoyLjEwLjAK Cg== --94eb2c0616461ed95b053df11719 Content-Type: text/x-patch; charset=US-ASCII; name="0002-Deprecate-variable-command-debug-status.patch" Content-Disposition: attachment; filename="0002-Deprecate-variable-command-debug-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ittr06a33 RnJvbSAyYWM1MjU5Nzc3NDYxNzNjMmRkM2JlNTUyOTYwYWIwYTA5OWI0ZGMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyOCBTZXAgMjAxNiAxMjoxNDoyOCArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBEZXByZWNhdGUgdmFyaWFibGUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMKCi0tLQog ZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgfCAyICsrCiBsaXNwL3N1YnIuZWwgICAgICAgICAg ICAgICB8IDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4 aQppbmRleCAyZjgzYjQwLi5jODhhMmZhIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kZWJ1Z2dp bmcudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aQpAQCAtNjU0LDYgKzY1NCw4 IEBAIGludm9jYXRpb24uCiBUaGUgYWR2YW50YWdlIG9mIHVzaW5nIHRoaXMgdmFyaWFibGUgcmF0 aGVyIHRoYW4gYW4gb3JkaW5hcnkgZ2xvYmFsCiB2YXJpYWJsZSBpcyB0aGF0IHRoZSBkYXRhIHdp bGwgbmV2ZXIgY2Fycnkgb3ZlciB0byBhIHN1YnNlcXVlbnQgY29tbWFuZAogaW52b2NhdGlvbi4K KworVGhpcyB2YXJpYWJsZSBpcyBvYnNvbGV0ZSBhbmQgd2lsbCBiZSByZW1vdmVkIGluIGZ1dHVy ZSB2ZXJzaW9ucy4KIEBlbmQgZGVmdmFyCiAKIEBkZWZ1biBiYWNrdHJhY2UtZnJhbWUgZnJhbWUt bnVtYmVyCmRpZmYgLS1naXQgYS9saXNwL3N1YnIuZWwgYi9saXNwL3N1YnIuZWwKaW5kZXggZTll MTlkMy4uNWE5NTQzZCAxMDA2NDQKLS0tIGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5l bApAQCAtMTM3Nyw2ICsxMzc3LDggQEAgaXMgY29udmVydGVkIGludG8gYSBzdHJpbmcgYnkgZXhw cmVzc2luZyBpdCBpbiBkZWNpbWFsLiIKIChtYWtlLW9ic29sZXRlICdwcm9jZXNzLWZpbHRlci1t dWx0aWJ5dGUtcCBuaWwgIjIzLjEiKQogKG1ha2Utb2Jzb2xldGUgJ3NldC1wcm9jZXNzLWZpbHRl ci1tdWx0aWJ5dGUgbmlsICIyMy4xIikKIAorKG1ha2Utb2Jzb2xldGUtdmFyaWFibGUgJ2NvbW1h bmQtZGVidWctc3RhdHVzICI7IGV4cGVjdCBpdCB0byBiZSByZW1vdmVkIGluIGEgZnV0dXJlIHZl cnNpb24iICIyNS4yIikKKwogOzsgTGlzcCBtYW51YWwgb25seSB1cGRhdGVkIGluIDIyLjEuCiAo ZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdleGVjdXRpbmctbWFjcm8gJ2V4ZWN1dGlu Zy1rYmQtbWFjcm8KICAgImJlZm9yZSAxOS4zNCIpCi0tIAoyLjEwLjAKCg== --94eb2c0616461ed95b053df11719-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 10:43:42 2016 Received: (at 24555-done) by debbugs.gnu.org; 4 Oct 2016 14:43:42 +0000 Received: from localhost ([127.0.0.1]:44540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brQwV-0000F0-2q for submit@debbugs.gnu.org; Tue, 04 Oct 2016 10:43:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brQwP-0000Ej-8O for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 10:43:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brQwE-0005mi-A3 for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 10:43:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brQwE-0005lu-6d; Tue, 04 Oct 2016 10:43:22 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1brQwC-0007QL-BB; Tue, 04 Oct 2016 10:43:20 -0400 Date: Tue, 04 Oct 2016 17:43:18 +0300 Message-Id: <83r37wmayh.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Mon, 3 Oct 2016 09:42:14 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: 24555-done Cc: monnier@iro.umontreal.ca, 24555-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.7 (-------) > From: Philippe Vaucher > Date: Mon, 3 Oct 2016 09:42:14 +0200 > Cc: Stefan Monnier , 24555@debbugs.gnu.org > > And again new patches without a typo :-) Thanks, I pushed this to the emacs-25 branch, and I'm marking this bug done. Please note that your patch had a fatal flaw: specbind needs a (quoted) symbol, not its value. Using Vcommand_debug_status there produced a broken binary that would display an error message and become unresponsive. See what I actually committed for the details. Also, the obsolescence warning needed some minor tweaks (it turns out that my advice to prepend a semi-colon was a bad idea, as a semi-colon and a newline are produced by Emacs automatically). Please always test the build after you patch it, to make sure the behavior is correct and no bugs creep in. Finally, in the future please provide commit log messages for the changes formatted in the ChanegLog style, as described in CONTRIBUTE. I wrote them for this commit, please see the commit for the details of the formatting we use. Thanks a lot for working on this. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:19:02 2016 Received: (at 24555-done) by debbugs.gnu.org; 4 Oct 2016 15:19:02 +0000 Received: from localhost ([127.0.0.1]:44664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRUk-0001D5-C9 for submit@debbugs.gnu.org; Tue, 04 Oct 2016 11:19:02 -0400 Received: from mail-ua0-f174.google.com ([209.85.217.174]:34703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRUi-0001Ci-3Y for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 11:19:00 -0400 Received: by mail-ua0-f174.google.com with SMTP id p25so61813750uaa.1 for <24555-done@debbugs.gnu.org>; Tue, 04 Oct 2016 08:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zjSzh1TaID9Lw6IY23x+pNhO2Gd1xqPTJdiu/SWgZ5w=; b=cp3h0Tgjt371Av4eBu6Sv/srRXHvn+46fclgsgtJo25qQwBO3IFV6YU25XvhQas1mx yu8j66WeT9cHyT+AXFvr9boNv6daK6hY72wHWKR3Re7nmAGh6SFRdR2LWm0yLbaSWp17 V3ALwzI8twmOE7NGirhU/GGeQCrfX/JFssSIhqPXnjgtp/PxxmrYDzjExb8SqW+yELLm PaMdcjFqaL3AFyVjZ2eWKGbBFGQjk9RV7fTfZ5aOesoHkP2zXbPB3VxuquOEpMMjOqo+ MkKVAqh8aEy2BH6gKociiOGYJKFqYanh6/ke1vjjWnOg4VFU4XviZkC6JgRqngdBEOf4 EYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zjSzh1TaID9Lw6IY23x+pNhO2Gd1xqPTJdiu/SWgZ5w=; b=b2qjViDyjkpceyWApvvWs0e1jkTP8l/NReV4R1pZXcEEttG4ikBEqUm4AtYLF2KCw5 9+q60Whmj+OdtibwEqJmEYL0uvFJyFb5xy32QbSK2BTXOChMy7WKs25jH7kBQVVR6SRH uwxPj3gockanAoGMVK018nxFVkQKopjAHcvIbrEDgNGOgI2bSWtfzo71ZkXVX3IfOnbb D9bGcNxmQkP8ELUz4xvZi8U9WVmBjiTq+RY6ZNpEa/IaUtdOuZ8DBJ3ef2YvsFv9G0uO YBY1jjgIm7qXzLX9YyO64SaeH4YKHfnwjtpI0hTG+yFsv2nIfMWRhsXUGh+AcXdror+7 ltiA== X-Gm-Message-State: AA6/9RnoUvlNb+k/09RcFSXnJRNKte/+dxLw3R5G1Wy+hfc+RhCkoGCZgVCKg48dgQZRhNXttFRctZ7npvfQBA== X-Received: by 10.176.66.199 with SMTP id j65mr2255540uaj.73.1475594334478; Tue, 04 Oct 2016 08:18:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Tue, 4 Oct 2016 08:18:23 -0700 (PDT) In-Reply-To: <83r37wmayh.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> <83r37wmayh.fsf@gnu.org> From: Philippe Vaucher Date: Tue, 4 Oct 2016 17:18:23 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c06164623a872053e0b94f7 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24555-done Cc: Stefan Monnier , 24555-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --94eb2c06164623a872053e0b94f7 Content-Type: text/plain; charset=UTF-8 > > Please note that your patch had a fatal flaw: specbind needs a > (quoted) symbol, not its value. Using Vcommand_debug_status there > produced a broken binary that would display an error message and > become unresponsive. See what I actually committed for the details. > Ah, you're right I missread the patch that removed Vcommand_debug_status and assumed "Q" variables got renamed to "V" in the emacs 25 transition. I understand now that variables and symbols are different things :-) I should have verified. > Please always test the build after you patch it, to make sure the > behavior is correct and no bugs creep in. > Yes, I should have. Sorry. > Finally, in the future please provide commit log messages for the > changes formatted in the ChanegLog style, as described in CONTRIBUTE. > I wrote them for this commit, please see the commit for the details of > the formatting we use. > Well, the commit f2144eef does not contain any ChangeLog entries... maybe you forgot to stage these changes? But yes, I understand what you mean. Regards, Philippe --94eb2c06164623a872053e0b94f7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Please note that your patch h= ad a fatal flaw: specbind needs a
(quoted) symbol, not its value.=C2=A0 Using Vcommand_debug_status there
produced a broken binary that would display an error message and
become unresponsive.=C2=A0 See what I actually committed for the details.

Ah, you're right I missread the patc= h that removed Vcommand_debug_status and assumed "Q" variables go= t renamed to "V" in the emacs 25 transition. I understand now tha= t variables and symbols are different things :-) I should have verified.

=C2=A0
Please always test the build after you patch it, to make sure th= e
behavior is correct and no bugs creep in.

Yes, I should have. Sorry.

=C2=A0
Finally, in the future please pro= vide commit log messages for the
changes formatted in the ChanegLog style, as described in CONTRIBUTE.
I wrote them for this commit, please see the commit for the details of
the formatting we use.

Well, the commit= f2144eef=C2=A0does not contain any ChangeLog entries... maybe you forgot t= o stage these changes? But yes, I understand what you mean.

<= /div>
Regards,
Philippe
--94eb2c06164623a872053e0b94f7-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:46:55 2016 Received: (at 24555-done) by debbugs.gnu.org; 4 Oct 2016 15:46:55 +0000 Received: from localhost ([127.0.0.1]:44705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRvj-0001vw-1Q for submit@debbugs.gnu.org; Tue, 04 Oct 2016 11:46:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRvi-0001vj-17 for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 11:46:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brRvY-0003sF-Cy for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 11:46:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brRvY-0003re-AK; Tue, 04 Oct 2016 11:46:44 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1brRvW-0001vV-Bq; Tue, 04 Oct 2016 11:46:42 -0400 Date: Tue, 04 Oct 2016 18:46:41 +0300 Message-Id: <83k2dom80u.fsf@gnu.org> From: Eli Zaretskii To: Philippe Vaucher In-reply-to: (message from Philippe Vaucher on Tue, 4 Oct 2016 17:18:23 +0200) Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> <83r37wmayh.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: 24555-done Cc: monnier@iro.umontreal.ca, 24555-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.7 (-------) > From: Philippe Vaucher > Date: Tue, 4 Oct 2016 17:18:23 +0200 > Cc: Stefan Monnier , 24555-done@debbugs.gnu.org > > Finally, in the future please provide commit log messages for the > changes formatted in the ChanegLog style, as described in CONTRIBUTE. > I wrote them for this commit, please see the commit for the details of > the formatting we use. > > Well, the commit f2144eef does not contain any ChangeLog entries... maybe you forgot to stage these > changes? But yes, I understand what you mean. Not ChangeLog entries, but commit log message formatted as ChangeLog. IOW, this: Restore 'command-debug-status' functionality * src/callint.c (Fcall_interactively): Bind command-debug-status to nil. This restores functionality inadvertently removed in Emacs 25.1. (Bug#24555) * lisp/subr.el (command-debug-status): Declare obsolete. * doc/lispref/debugging.texi (Internals of Debugger): Document that 'command-debug-status' is obsolete. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 04 11:55:07 2016 Received: (at 24555-done) by debbugs.gnu.org; 4 Oct 2016 15:55:07 +0000 Received: from localhost ([127.0.0.1]:44720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brS3f-00028a-2u for submit@debbugs.gnu.org; Tue, 04 Oct 2016 11:55:07 -0400 Received: from mail-ua0-f175.google.com ([209.85.217.175]:35949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brS3e-000283-0T for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 11:55:06 -0400 Received: by mail-ua0-f175.google.com with SMTP id r64so20260215uar.3 for <24555-done@debbugs.gnu.org>; Tue, 04 Oct 2016 08:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=L/XhNHVS05dJYs6sSXqeOUiHKYha25/d+3PumzGeueA=; b=ldUD8mNu2rzTyaXAqL9u11iaew+wOnmmvZcPjH+M34H22TIDhz0K+ygMFj4JkcrKUb eEJKIZ4EaDInx59HumqSUVZkLDSxM2JSBsS1oyX56zlr29Hh6XvwS3JpVu7PU2NXifN2 hjxmQvBiRrfatE4B3VBkBCDiFFSe58jsoCy2CloSK+Wpp+seTSjGKcbPtGmRWHZT3gbt krJSOhxcjCrNvE/aqvyQPZcrB/elzM0rY4eF1t3hNDhzaZp+ZEhbYXSp1GHLtQd6gM6C 6TH1FBhuAX1ihDT30XIfkelPlDyuJoprBXzFQxN2IJDfgR0uKKCVvV/n9WJYB9eaKAKO Bwvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=L/XhNHVS05dJYs6sSXqeOUiHKYha25/d+3PumzGeueA=; b=fz+WqOdCEDa46aQMAxSjm0nHgmU8/m6rz7Ns9AUh+gG3L5NmWy/Y00HY896yxdA74L wKVXZrxWYa9RHjfUmmd+/bAZShmYCDaaQmjPZVmAHG1yX4ExPE0xBki4xzHEHGMnsSPT xzRDMEl3xBBQI6bZGGJpQu4OmnA+A1b8rRtMXMfTszNgzYQRN/xl+DazHaQ/Szj60tgx qnVTxIrPYbODaODudk9AcTzfg3+SMHc8uCc2iQkqF6IUcjSzK1FmzVKO29eFytP8an57 wOpGsU35cO2ujt95E8/xMmKfOH05aDb9PNruCCaeiohZZUXF6BuU/QmRHLgYpYbwb0nL ciwA== X-Gm-Message-State: AA6/9RkVckqzWxmAze9aMLJCkP1OqtWvPhdKi051h7ntfA274SjtRt0FG7teGc8K/EIGMGjv4ufoLRWgDtPgiQ== X-Received: by 10.176.1.77 with SMTP id 71mr2705976uak.58.1475596500416; Tue, 04 Oct 2016 08:55:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.0.197 with HTTP; Tue, 4 Oct 2016 08:54:29 -0700 (PDT) In-Reply-To: <83k2dom80u.fsf@gnu.org> References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> <83r37wmayh.fsf@gnu.org> <83k2dom80u.fsf@gnu.org> From: Philippe Vaucher Date: Tue, 4 Oct 2016 17:54:29 +0200 Message-ID: Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status' To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a11409d3c3d3dde053e0c15a6 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24555-done Cc: Stefan Monnier , 24555-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a11409d3c3d3dde053e0c15a6 Content-Type: text/plain; charset=UTF-8 > > > Well, the commit f2144eef does not contain any ChangeLog entries... > maybe you forgot to stage these > > changes? But yes, I understand what you mean. > > Not ChangeLog entries, but commit log message formatted as ChangeLog. > Ah, right. That is indeed a very complete change description! Thanks, Philippe --001a11409d3c3d3dde053e0c15a6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> W= ell, the commit f2144eef does not contain any ChangeLog entries... maybe yo= u forgot to stage these
> changes? But yes, I understand what you mean.

Not ChangeLog entries, but commit log message formatted as ChangeLog= .

Ah, right. That is indeed a very comp= lete change description!

Thanks,
Phi= lippe
--001a11409d3c3d3dde053e0c15a6-- From unknown Sun Jun 15 08:37:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 02 Nov 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator