Subject: bug#24555: closed (Re: bug#24555: [PATCH] Remove unused variable `command-debug-status')

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 04 Oct 2016 14:44:02 +0000

Your bug report

#24555: [PATCH] Remove unused variable `command-debug-status'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
24555: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24555
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#24555: [PATCH] Remove unused variable `command-debug-status'
From: Eli Zaretskii <[email-masked]>
To: Philippe Vaucher <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Tue, 04 Oct 2016 17:43:18 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Philippe Vaucher <[email-masked]>
> Date: Mon, 3 Oct 2016 09:42:14 +0200
> Cc: Stefan Monnier <[email-masked]>, [email-masked]
> 
> And again new patches without a typo :-)

Thanks, I pushed this to the emacs-25 branch, and I'm marking this
bug done.

Please note that your patch had a fatal flaw: specbind needs a
(quoted) symbol, not its value.  Using Vcommand_debug_status there
produced a broken binary that would display an error message and
become unresponsive.  See what I actually committed for the details.

Also, the obsolescence warning needed some minor tweaks (it turns out
that my advice to prepend a semi-colon was a bad idea, as a semi-colon
and a newline are produced by Emacs automatically).

Please always test the build after you patch it, to make sure the
behavior is correct and no bugs creep in.

Finally, in the future please provide commit log messages for the
changes formatted in the ChanegLog style, as described in CONTRIBUTE.
I wrote them for this commit, please see the commit for the details of
the formatting we use.

Thanks a lot for working on this.

Subject: [PATCH] Remove unused variable `command-debug-status'
From: Philippe Vaucher <[email-masked]>
To: [email-masked]
Date: Wed, 28 Sep 2016 14:39:02 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

For information, I did the procedure for copyright assignment to Emacs and
it is complete.

This patch removes the variable `command-debug-status', which really seems
to be unused since a long time to me (that's what "git -G
Vcommand-debug-status" says).

Philippe
From eae6374e5a3f052c55e4e9e8b821539b6f1900aa Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <[email-masked]>
Date: Wed, 28 Sep 2016 12:14:28 +0200
Subject: [PATCH] Remove unused variable `command-debug-status'

---
 doc/lispref/debugging.texi | 12 ------------
 src/callint.c              |  6 ------
 2 files changed, 18 deletions(-)

diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi
index 2f83b40..f4e63ae 100644
--- a/doc/lispref/debugging.texi
+++ b/doc/lispref/debugging.texi
@@ -644,18 +644,6 @@ the debugger.
 This function is used only by the debugger.
 @end defun
 
-@defvar command-debug-status
-This variable records the debugging status of the current interactive
-command.  Each time a command is called interactively, this variable is
-bound to @code{nil}.  The debugger can set this variable to leave
-information for future debugger invocations during the same command
-invocation.
-
-The advantage of using this variable rather than an ordinary global
-variable is that the data will never carry over to a subsequent command
-invocation.
-@end defvar
-
 @defun backtrace-frame frame-number
 The function @code{backtrace-frame} is intended for use in Lisp
 debuggers.  It returns information about what computation is happening
diff --git a/src/callint.c b/src/callint.c
index 053ee6c..ccb5c6a 100644
--- a/src/callint.c
+++ b/src/callint.c
@@ -928,12 +928,6 @@ Maximum length of the history list is determined by the value
 of `history-length', which see.  */);
   Vcommand_history = Qnil;
 
-  DEFVAR_LISP ("command-debug-status", Vcommand_debug_status,
-	       doc: /* Debugging status of current interactive command.
-Bound each time `call-interactively' is called;
-may be set by the debugger as a reminder for itself.  */);
-  Vcommand_debug_status = Qnil;
-
   DEFVAR_LISP ("mark-even-if-inactive", Vmark_even_if_inactive,
 	       doc: /* Non-nil means you can use the mark even when inactive.
 This option makes a difference in Transient Mark mode.
-- 
2.10.0