From unknown Sun Jun 22 04:27:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2016 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24543@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14748293971342 (code B ref -1); Sun, 25 Sep 2016 18:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Sep 2016 18:49:57 +0000 Received: from localhost ([127.0.0.1]:35782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boEUu-0000LZ-V9 for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boEUt-0000LD-7v for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boEUn-0001sf-4E for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boEUn-0001sP-0z for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boEUk-0008S2-QH for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2016 14:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boEUf-0001r2-T9 for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2016 14:49:46 -0400 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]:35269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boEUf-0001qy-OL for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2016 14:49:41 -0400 Received: by mail-it0-x22f.google.com with SMTP id r192so56414443ita.0 for ; Sun, 25 Sep 2016 11:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version; bh=ZuooDu4H+zqUvsVOi7G18ubuHjp61QmuCmemugaq0/k=; b=FoxJjukJ4JJeeH5/j9NV2KJ2hH5tRq/rH8kssJJfhlKLxF3Ver/SkkjguoxgA7QUo1 uqT4AK5TkcQ8pDATSsvY70HvvVwhRkacjP3acP5AvjStCWEM71lF1gLVM0qdwwqgvjEB QImHVlFISZQd7d/Kyf1GP+jXteKuswSv831sMhHoMmNviLppcis/zsNDTwkDKt4Q39EU onoiTOwHvcw028soYIKKptnw4Q4Zw4g1mIqJnMInVIsaYVWWFuJqb8jQUQuV/TQvYYFN Ax7CN9OnovoT0e/RtMX8kvLviJSTbsAe5S1czoNhp6BkolMoicyyRs9D1wxX5q01Qyoy fZHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=ZuooDu4H+zqUvsVOi7G18ubuHjp61QmuCmemugaq0/k=; b=WYdqiQAIdJKplY6IgrYiqAH9mBBXohpXeo9k0Qcm9j6hgsGwxYknWKuFmk/ph96NEa crJwmbBrbucVrQLz5YrwYYaxMSMMLL4GkDjAPqx9W4SYofa8p9ICLbgE9a5vKN7wCArq yHeKO86WB1siMo7EE9yr/OdXTyQIj9eeCApXtkTwfr3s2/rRLETXacc8OQzSCEIUKvSG d64RQahzfE8uKnB+flC5c460kHC1qJxcgdRmBIod8zXJZ0CM9LfyXpjGtNm8S51sPXZH upneNslqcSjUW4b9QjB99P/swx3xHQSre1pmXv5Suxj7nfwsZepHscSiR15cwruo0LUD pL9w== X-Gm-Message-State: AA6/9Rn7bnYiPIAzJYXQ1AURvTq1/VIh7Vc2Nkc62iBAixqDLjHKF9NCHOZ9vssS1L8lbg== X-Received: by 10.36.65.2 with SMTP id x2mr13285517ita.78.1474829380843; Sun, 25 Sep 2016 11:49:40 -0700 (PDT) Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id a192sm2434384itc.8.2016.09.25.11.49.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Sep 2016 11:49:40 -0700 (PDT) From: Alex Date: Sun, 25 Sep 2016 12:49:11 -0600 Message-ID: <87d1jrzufs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Recipe: emacs -Q C-h o font-lock-comment-face RET Only the variable of this name is shown, not the face (which can be viewed with describe-face, of course). It appears that when the face only shares a name with a function, then both the function and face are shown. Only a variable shadows the face in describe-symbol. From unknown Sun Jun 22 04:27:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2017 21:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24543@debbugs.gnu.org Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.149765009826275 (code B ref 24543); Fri, 16 Jun 2017 21:55:01 +0000 Received: (at 24543) by debbugs.gnu.org; 16 Jun 2017 21:54:58 +0000 Received: from localhost ([127.0.0.1]:51779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLzCj-0006pj-RM for submit@debbugs.gnu.org; Fri, 16 Jun 2017 17:54:58 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:35866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLzCj-0006pW-23 for 24543@debbugs.gnu.org; Fri, 16 Jun 2017 17:54:57 -0400 Received: by mail-it0-f44.google.com with SMTP id m47so41647957iti.1 for <24543@debbugs.gnu.org>; Fri, 16 Jun 2017 14:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=keiYYQvRK/72EzgcwG9z7aCA044biB3myANn3Oa2GmM=; b=TzlVnYZDJFkpgfJ1rE3+QrIB5uoJlzPPpe/Z61S+0GM4w6O2+g/ONCbSbJ5RyF6KET FkMMhZBusaJACpFQh18QaTHzEkoXMAXk0zSHgTDKO+lLGDy+JzzDl2+SjJcvzQgwcU6e h50jVdOPdktDI7s+iIAJ6OkJ3Q7r3Qkz1GG22ogPexPsQkDHlUUzNG1/CBnoIAPEKBjk qJUQf41BHFRAZ9Gouj5sWcZKv+kX/EPqc5uKh5LngRQcCb/QNeR2JKHMtRY63+L84eQq gVYWcfZbFM9pD+5UaJPO5ZPA1uTu8DJeUZOIlJrtkYT3PjZfvx3jV2MpNJR/1l2/3QAz fEBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=keiYYQvRK/72EzgcwG9z7aCA044biB3myANn3Oa2GmM=; b=trJYcP44p0wlo7w3p3X6OxIUOhH5crqbw0P/WfAefe72ozwl/wWjRPIYrj+wyGxCcq F4P8QE2SR5/WR2SX3CsX64hVgjeeXLXUtXZxzZVB35T2IbcVoxPpiL8qwJar3QdnH0Sz sSuu9aKNmrvHw7UR/qI/i+bvp9oeK3zGXYli5D8Y7BukOS/8BEmlM4//rC9cGkG6Lfua Xi2DqDanB2Fl2TVqmuhHAPfUFWFkAB+IvOquE/2W68tWMY1kDY1dfEEL9nJYGMGeb6gT SZ86Is2qp0CtcAIw4KOpmkjGdVs2Q6WmB0q2UmtppUxr2e0D/nkbaq0b8/Z/pMDqV4EB HfbA== X-Gm-Message-State: AKS2vOzH7w+P3aJ4ZiWr4hHbfOv8KfL4czEk1KqNmDoqj3ym8wUkMlF0 ySTlh9lrTL7fO9dG X-Received: by 10.36.160.75 with SMTP id o72mr4701771ite.119.1497650091100; Fri, 16 Jun 2017 14:54:51 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id p80sm2525096itp.6.2017.06.16.14.54.49 for <24543@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Jun 2017 14:54:49 -0700 (PDT) From: Alex References: <87d1jrzufs.fsf@gmail.com> Date: Fri, 16 Jun 2017 15:54:45 -0600 In-Reply-To: <87d1jrzufs.fsf@gmail.com> (Alex's message of "Sun, 25 Sep 2016 12:49:11 -0600") Message-ID: <87shizwqca.fsf@lylat> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Alex writes: > Recipe: > > emacs -Q > C-h o font-lock-comment-face RET > > Only the variable of this name is shown, not the face (which can be > viewed with describe-face, of course). > > It appears that when the face only shares a name with a function, then > both the function and face are shown. Only a variable shadows the face > in describe-symbol. This is because describe-symbol isn't returning (buffer-string) like describe-{function, variable} are. I've attached a patch fixing this problem. Additionally, I have attached another patch that re-orders the placement of variables/faces in describe-symbol, to put more emphasis on the variable entry rather than the face. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Properly-show-faces-in-describe-symbol-Bug-24543.patch Content-Description: fix >From 9a3196624d3a24beb3a0625e8a2a74751368c112 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Fri, 16 Jun 2017 15:37:47 -0600 Subject: [PATCH 1/2] Properly show faces in describe-symbol (Bug#24543) * lisp/faces.el (describe-face): Return (buffer-string). --- lisp/faces.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/faces.el b/lisp/faces.el index 9a8a1344ca..dabb7c3e7e 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1447,7 +1447,7 @@ describe-face (setq face (list face))) (with-help-window (help-buffer) (with-current-buffer standard-output - (dolist (f face) + (dolist (f face (buffer-string)) (if (stringp f) (setq f (intern f))) ;; We may get called for anonymous faces (i.e., faces ;; expressed using prop-value plists). Those can't be -- 2.11.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-lisp-help-mode.el-describe-symbol-backends-Reorder-e.patch Content-Description: reorder >From 9ec7945fd45af4999a315f2ceba9bbc61cbf0710 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Fri, 16 Jun 2017 15:49:13 -0600 Subject: [PATCH 2/2] * lisp/help-mode.el (describe-symbol-backends): Reorder entries --- lisp/help-mode.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 3fb793e7aa..24dfb9120b 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -393,12 +393,12 @@ help-buffer (defvar describe-symbol-backends `((nil ,#'fboundp ,(lambda (s _b _f) (describe-function s))) - ("face" ,#'facep ,(lambda (s _b _f) (describe-face s))) (nil ,(lambda (symbol) (or (and (boundp symbol) (not (keywordp symbol))) (get symbol 'variable-documentation))) - ,#'describe-variable))) + ,#'describe-variable) + ("face" ,#'facep ,(lambda (s _b _f) (describe-face s))))) ;;;###autoload (defun help-make-xrefs (&optional buffer) -- 2.11.0 --=-=-=-- From unknown Sun Jun 22 04:27:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jul 2017 04:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24543@debbugs.gnu.org Cc: Eli Zaretskii Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.150104329629326 (code B ref 24543); Wed, 26 Jul 2017 04:29:01 +0000 Received: (at 24543) by debbugs.gnu.org; 26 Jul 2017 04:28:16 +0000 Received: from localhost ([127.0.0.1]:56616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daDvj-0007cw-Re for submit@debbugs.gnu.org; Wed, 26 Jul 2017 00:28:15 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:38521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daDvi-0007ci-7L for 24543@debbugs.gnu.org; Wed, 26 Jul 2017 00:28:14 -0400 Received: by mail-io0-f194.google.com with SMTP id l7so10531148iof.5 for <24543@debbugs.gnu.org>; Tue, 25 Jul 2017 21:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=81WFdjIV+rlF985UyiW0c3qdu+7OoC1fGuq7CLwbNfk=; b=gxRVCdLqur/lrX6qEbI8A72Zg9FjavAXR/879yaWLq12UmLTIjxKPwyGJI7dgd3VUJ 5m13yc5emhZHokeZY+0Ua+ilG4vPSTBJR1nZZiKkrlTWkOaNXUbhUuQqIfkBpUDO0R6x aPo3E58w3TpBSg9eheGpA8PnW95DSE3IPXeVwMBkwmeCy1U1HZQtuVwfMqMe6AlVobwS ImBqf3ZSBM4lMi/kCOFeP9x1NYXGN9n/U0TnAjE6Ap803SKoC93E+FoqeTUyLF8q4cMH wO/tPL50yPJcxVRTdNbND/5Z1/25uJRtwPibXAxS0ABz4sglV4wiDq4c+3cPfHW8SfgV rIOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=81WFdjIV+rlF985UyiW0c3qdu+7OoC1fGuq7CLwbNfk=; b=uB2CYzxDRo7ZHSoZvpjX7Kc6jm4uzyCl9g1k4oA89kCQbXDT8wiqK5IdNtMv5IQEZa oyA/WewBeq33lnTULCAqE2gW0ZAtBFxBq39etv0fNcG2qR/7BZvpwa3aqZEXwUlRsqlV cHmLKGSjQn8ohE8NpIlWcFhTKOTgzVHb2jxyjwm9i/bUgJkcSGzpj7pWqSQR8o+aAvHu 8NmKd5Zg1Or3bRlYBGtfkNygP++FCfSVl/Hm9QXlrqtS2pCf3kcBXTkZyFuVc6ZizLW/ tAuauscer1IIrQZsr6/ZB5wFfED7hkvhr21bx76SZYf5Jz6BGyt/9xQWXN/gDZBbC22X /QmA== X-Gm-Message-State: AIVw112ohu4+0/H8+CP34+uHXD53UAMCTtfHgBy0HL9oeLFCSXd7QZV0 bbOVoekEvlsf0eLP X-Received: by 10.107.162.6 with SMTP id l6mr22911536ioe.84.1501043288236; Tue, 25 Jul 2017 21:28:08 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id l184sm7556947iol.43.2017.07.25.21.28.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Jul 2017 21:28:07 -0700 (PDT) From: Alex References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> Date: Tue, 25 Jul 2017 22:28:05 -0600 In-Reply-To: <87shizwqca.fsf@lylat> (Alex's message of "Fri, 16 Jun 2017 15:54:45 -0600") Message-ID: <87r2x3g6ui.fsf@lylat> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Alex writes: > Alex writes: > >> Recipe: >> >> emacs -Q >> C-h o font-lock-comment-face RET >> >> Only the variable of this name is shown, not the face (which can be >> viewed with describe-face, of course). >> >> It appears that when the face only shares a name with a function, then >> both the function and face are shown. Only a variable shadows the face >> in describe-symbol. > > This is because describe-symbol isn't returning (buffer-string) like > describe-{function, variable} are. > > I've attached a patch fixing this problem. > > Additionally, I have attached another patch that re-orders the placement > of variables/faces in describe-symbol, to put more emphasis on the > variable entry rather than the face. Ping. Eli? From unknown Sun Jun 22 04:27:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jul 2017 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Cc: 24543@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.15010803721735 (code B ref 24543); Wed, 26 Jul 2017 14:47:02 +0000 Received: (at 24543) by debbugs.gnu.org; 26 Jul 2017 14:46:12 +0000 Received: from localhost ([127.0.0.1]:57518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daNZj-0000Rv-UH for submit@debbugs.gnu.org; Wed, 26 Jul 2017 10:46:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daNZj-0000Ri-1F for 24543@debbugs.gnu.org; Wed, 26 Jul 2017 10:46:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daNZa-0000Av-NH for 24543@debbugs.gnu.org; Wed, 26 Jul 2017 10:46:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daNZa-0000Ar-Js; Wed, 26 Jul 2017 10:46:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1448 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1daNZa-0004Bv-0V; Wed, 26 Jul 2017 10:46:02 -0400 Date: Wed, 26 Jul 2017 17:45:48 +0300 Message-Id: <83lgnb5k9v.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87r2x3g6ui.fsf@lylat> (message from Alex on Tue, 25 Jul 2017 22:28:05 -0600) References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> <87r2x3g6ui.fsf@lylat> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alex > Cc: Eli Zaretskii > Date: Tue, 25 Jul 2017 22:28:05 -0600 > > Ping. Eli? Sorry, I hoped someone more knowledgeable about this stiff will beat me to it. I will review this in a couple of days. From unknown Sun Jun 22 04:27:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2017 07:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alex Cc: 24543@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.150122733113683 (code B ref 24543); Fri, 28 Jul 2017 07:36:02 +0000 Received: (at 24543) by debbugs.gnu.org; 28 Jul 2017 07:35:31 +0000 Received: from localhost ([127.0.0.1]:59135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dazo3-0003Yc-Dl for submit@debbugs.gnu.org; Fri, 28 Jul 2017 03:35:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dazo1-0003YQ-G9 for 24543@debbugs.gnu.org; Fri, 28 Jul 2017 03:35:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daznr-0000EB-EQ for 24543@debbugs.gnu.org; Fri, 28 Jul 2017 03:35:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daznr-0000Dz-BK; Fri, 28 Jul 2017 03:35:19 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3036 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1daznp-00021i-Q2; Fri, 28 Jul 2017 03:35:19 -0400 Date: Fri, 28 Jul 2017 10:35:02 +0300 Message-Id: <83k22t3tg9.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87shizwqca.fsf@lylat> (message from Alex on Fri, 16 Jun 2017 15:54:45 -0600) References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alex > Date: Fri, 16 Jun 2017 15:54:45 -0600 > > > emacs -Q > > C-h o font-lock-comment-face RET > > > > Only the variable of this name is shown, not the face (which can be > > viewed with describe-face, of course). > > > > It appears that when the face only shares a name with a function, then > > both the function and face are shown. Only a variable shadows the face > > in describe-symbol. > > This is because describe-symbol isn't returning (buffer-string) like > describe-{function, variable} are. > > I've attached a patch fixing this problem. Thanks. This LGTM, but doesn't the fact that describe-face's return value will change after this constitute an incompatible change? And if so, could it break some of the users of this function out there? From unknown Sun Jun 22 04:27:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2017 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 24543@debbugs.gnu.org Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.15012747362763 (code B ref 24543); Fri, 28 Jul 2017 20:46:01 +0000 Received: (at 24543) by debbugs.gnu.org; 28 Jul 2017 20:45:36 +0000 Received: from localhost ([127.0.0.1]:60383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbC8e-0000iV-MM for submit@debbugs.gnu.org; Fri, 28 Jul 2017 16:45:36 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:32882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbC8c-0000iH-Ud for 24543@debbugs.gnu.org; Fri, 28 Jul 2017 16:45:35 -0400 Received: by mail-it0-f49.google.com with SMTP id v127so7665316itd.0 for <24543@debbugs.gnu.org>; Fri, 28 Jul 2017 13:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=IM7ABpslEFlWLpep0n63rY3XR7eQ1wiJyNLkkOKQ3ZE=; b=uspBtYHTSD4nhRvayNZUekyTUyUJiOiGHqX272tqDXm3tPHeMzBNAFNp0PrSE3EV0B UcivcGFSGMzS1HWmkacZBVXpn0z5JIvOvkKzs7kaycvp8hqq440kfhbyaHWBwWPKafCY 0rPv62Ti7IaYy1ZHe4s9AmGS/sBzzndfnNuUadBteG7iBTG83ANIeE1DPcuEiIR0XwGg OLUQCtP0WmkNF8lAskuarBUSgjaRPg4eM6zJskNl8n1qWXy02VBq56FBJf4jI0NGOEf3 jEavxjrqRrS1lV6CQWFnH7Y7KdhS3Nmm1i0SjYJCP6kvMD095yeTp/gdYnzJ/WSf2wUb rjmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=IM7ABpslEFlWLpep0n63rY3XR7eQ1wiJyNLkkOKQ3ZE=; b=ozajyXie5lkmSYCRs0HR8DOi/xKKORZEc33gUUp31Gafl8LpTZ1nY2ShtZhUiFGd4P KJg7NGmPsk1GzlAYE5Gzy/HA30oq7WY2jI7lBdv4kU09QVWwLwMZiKvbpqfEI4WAcKIz OVqt4Urj010G8OjA8HeOH6JX0ol0MWI+BdkfLg44Qs8s4eKSNdWcg3xXhSCajXEHmcxj eTtJ8au8pfy1Ea1j6mN10jXHVeuYbloLtDug2WT6XdunlE/CcRrD4T2r8j6LSfV4ZbAv +grFM2der9dQftxbL/juH/d/aYuOt+BdrwtvBc26464aSWQflNmwc5sdR2jtdeg7L4vk u1iw== X-Gm-Message-State: AIVw111m5hYs7f8X32LKzAf4SiQsxTXiao9XIEBCDzX5+4iXX8pB4OWZ gUP8fTG11LRRhkMT X-Received: by 10.36.233.194 with SMTP id f185mr11161298ith.166.1501274729029; Fri, 28 Jul 2017 13:45:29 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id y75sm2602822itb.31.2017.07.28.13.45.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Jul 2017 13:45:28 -0700 (PDT) From: Alex In-Reply-To: <83k22t3tg9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Jul 2017 10:35:02 +0300") References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> <83k22t3tg9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Date: Fri, 28 Jul 2017 14:45:24 -0600 Message-ID: <87o9s42suz.fsf@lylat> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: >> From: Alex >> Date: Fri, 16 Jun 2017 15:54:45 -0600 >> >> > emacs -Q >> > C-h o font-lock-comment-face RET >> > >> > Only the variable of this name is shown, not the face (which can be >> > viewed with describe-face, of course). >> > >> > It appears that when the face only shares a name with a function, then >> > both the function and face are shown. Only a variable shadows the face >> > in describe-symbol. >> >> This is because describe-symbol isn't returning (buffer-string) like >> describe-{function, variable} are. >> >> I've attached a patch fixing this problem. > > Thanks. This LGTM, but doesn't the fact that describe-face's return > value will change after this constitute an incompatible change? And I suppose so; would it be expected to be documented in NEWS? > if so, could it break some of the users of this function out there? Potentially, but I don't see that being an issue in this case. The return value isn't documented, so users shouldn't be (and likely aren't) relying on describe-face always returning nil. It makes more sense to treat describe-face like describe-{function, variable}. Though I'm not sure why those two procedures return (buffer-string) in the first place. In any case, I figure it's better to leave those and describe-symbol alone and just make describe-face behave similarly. From unknown Sun Jun 22 04:27:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Subject: bug#24543: closed (Re: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable) Message-ID: References: <83a83ewg43.fsf@gnu.org> <87d1jrzufs.fsf@gmail.com> X-Gnu-PR-Message: they-closed 24543 X-Gnu-PR-Package: emacs Reply-To: 24543@debbugs.gnu.org Date: Sat, 05 Aug 2017 08:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1501923242-18728-1" This is a multi-part message in MIME format... ------------=_1501923242-18728-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24543: 25.1; describe-symbol doesn't show face with same name as a variable which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24543@debbugs.gnu.org. --=20 24543: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24543 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1501923242-18728-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24543-done) by debbugs.gnu.org; 5 Aug 2017 08:53:20 +0000 Received: from localhost ([127.0.0.1]:42457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddupj-0004rB-MY for submit@debbugs.gnu.org; Sat, 05 Aug 2017 04:53:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddupi-0004qx-60 for 24543-done@debbugs.gnu.org; Sat, 05 Aug 2017 04:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddupa-0000c1-8E for 24543-done@debbugs.gnu.org; Sat, 05 Aug 2017 04:53:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddupa-0000bw-4T; Sat, 05 Aug 2017 04:53:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1388 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ddupY-0006Et-VQ; Sat, 05 Aug 2017 04:53:09 -0400 Date: Sat, 05 Aug 2017 11:53:00 +0300 Message-Id: <83a83ewg43.fsf@gnu.org> From: Eli Zaretskii To: Alex In-reply-to: <87o9s42suz.fsf@lylat> (message from Alex on Fri, 28 Jul 2017 14:45:24 -0600) Subject: Re: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> <83k22t3tg9.fsf@gnu.org> <87o9s42suz.fsf@lylat> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 24543-done Cc: 24543-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alex > Cc: 24543@debbugs.gnu.org > Date: Fri, 28 Jul 2017 14:45:24 -0600 > > > if so, could it break some of the users of this function out there? > > Potentially, but I don't see that being an issue in this case. The > return value isn't documented, so users shouldn't be (and likely aren't) > relying on describe-face always returning nil. It makes more sense to > treat describe-face like describe-{function, variable}. OK, I pushed the changes. Thanks. ------------=_1501923242-18728-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Sep 2016 18:49:57 +0000 Received: from localhost ([127.0.0.1]:35782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boEUu-0000LZ-V9 for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boEUt-0000LD-7v for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boEUn-0001sf-4E for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boEUn-0001sP-0z for submit@debbugs.gnu.org; Sun, 25 Sep 2016 14:49:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boEUk-0008S2-QH for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2016 14:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boEUf-0001r2-T9 for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2016 14:49:46 -0400 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]:35269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boEUf-0001qy-OL for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2016 14:49:41 -0400 Received: by mail-it0-x22f.google.com with SMTP id r192so56414443ita.0 for ; Sun, 25 Sep 2016 11:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version; bh=ZuooDu4H+zqUvsVOi7G18ubuHjp61QmuCmemugaq0/k=; b=FoxJjukJ4JJeeH5/j9NV2KJ2hH5tRq/rH8kssJJfhlKLxF3Ver/SkkjguoxgA7QUo1 uqT4AK5TkcQ8pDATSsvY70HvvVwhRkacjP3acP5AvjStCWEM71lF1gLVM0qdwwqgvjEB QImHVlFISZQd7d/Kyf1GP+jXteKuswSv831sMhHoMmNviLppcis/zsNDTwkDKt4Q39EU onoiTOwHvcw028soYIKKptnw4Q4Zw4g1mIqJnMInVIsaYVWWFuJqb8jQUQuV/TQvYYFN Ax7CN9OnovoT0e/RtMX8kvLviJSTbsAe5S1czoNhp6BkolMoicyyRs9D1wxX5q01Qyoy fZHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=ZuooDu4H+zqUvsVOi7G18ubuHjp61QmuCmemugaq0/k=; b=WYdqiQAIdJKplY6IgrYiqAH9mBBXohpXeo9k0Qcm9j6hgsGwxYknWKuFmk/ph96NEa crJwmbBrbucVrQLz5YrwYYaxMSMMLL4GkDjAPqx9W4SYofa8p9ICLbgE9a5vKN7wCArq yHeKO86WB1siMo7EE9yr/OdXTyQIj9eeCApXtkTwfr3s2/rRLETXacc8OQzSCEIUKvSG d64RQahzfE8uKnB+flC5c460kHC1qJxcgdRmBIod8zXJZ0CM9LfyXpjGtNm8S51sPXZH upneNslqcSjUW4b9QjB99P/swx3xHQSre1pmXv5Suxj7nfwsZepHscSiR15cwruo0LUD pL9w== X-Gm-Message-State: AA6/9Rn7bnYiPIAzJYXQ1AURvTq1/VIh7Vc2Nkc62iBAixqDLjHKF9NCHOZ9vssS1L8lbg== X-Received: by 10.36.65.2 with SMTP id x2mr13285517ita.78.1474829380843; Sun, 25 Sep 2016 11:49:40 -0700 (PDT) Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id a192sm2434384itc.8.2016.09.25.11.49.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Sep 2016 11:49:40 -0700 (PDT) From: Alex To: bug-gnu-emacs@gnu.org Subject: 25.1; describe-symbol doesn't show face with same name as a variable Date: Sun, 25 Sep 2016 12:49:11 -0600 Message-ID: <87d1jrzufs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Recipe: emacs -Q C-h o font-lock-comment-face RET Only the variable of this name is shown, not the face (which can be viewed with describe-face, of course). It appears that when the face only shares a name with a function, then both the function and face are shown. Only a variable shadows the face in describe-symbol. ------------=_1501923242-18728-1--