GNU bug report logs - #24535
[PATCH] sed: fix incorrect match for title case

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 24535 <at> debbugs.gnu.org
Subject: bug#24535: [PATCH] sed: fix incorrect match for title case
Date: Sun, 25 Sep 2016 17:38:44 -0700

[Message part 1 (text/plain, inline)]

On Sat, Sep 24, 2016 at 10:49 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
> On Sat, 24 Sep 2016 20:43:01 -0700
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> Thank you for that patch.
>> Quick feedback:
>>
>> Did you intend to use the new function, require_el_iso88597_locale_?
>>
>> Please replace this line from your new test (I prefer to avoid double
>> quoting strings intended to contain backslashes, because each must be
>> doubled, and that impairs readability/maintainability):
>>
>>   printf "/\\(\\)\\\\1$chr/Ip" >prog || fail=1
>>
>> with this:
>>
>>   printf '/\(\)\\1'"$chr"/Ip >prog || fail=1
>>
>> Is that a stray "-f -n" in the test script? This cannot work as intended:
>>
>>   $ sed -f -n -f prog in >out
>>   sed: couldn't open file -n: No such file or directory
>
> Thanks for quick feedback.  Sorry, I seem that I extracted the patch
> from old repository.  I fixed it, and ru-run all tests and they are
> passed.

Thank you. That looks great.
I have renamed the new test file to remove the "mb-" prefix, since
it's not multibyte-related, and adjusted the commit log:

[sed-title-case-fix.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.