GNU bug report logs - #24535
[PATCH] sed: fix incorrect match for title case

Previous Next

Full log

Message #11 received at 24535 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 24535 <at> debbugs.gnu.org
Subject: Re: bug#24535: [PATCH] sed: fix incorrect match for title case
Date: Sun, 25 Sep 2016 14:49:11 +0900

[Message part 1 (text/plain, inline)]

On Sat, 24 Sep 2016 20:43:01 -0700
Jim Meyering <jim <at> meyering.net> wrote:

> Thank you for that patch.
> Quick feedback:
> 
> Did you intend to use the new function, require_el_iso88597_locale_?
> 
> Please replace this line from your new test (I prefer to avoid double
> quoting strings intended to contain backslashes, because each must be
> doubled, and that impairs readability/maintainability):
> 
>   printf "/\\(\\)\\\\1$chr/Ip" >prog || fail=1
> 
> with this:
> 
>   printf '/\(\)\\1'"$chr"/Ip >prog || fail=1
> 
> Is that a stray "-f -n" in the test script? This cannot work as intended:
> 
>   $ sed -f -n -f prog in >out
>   sed: couldn't open file -n: No such file or directory

Thanks for quick feedback.  Sorry, I seem that I extracted the patch
from old repository.  I fixed it, and ru-run all tests and they are
passed.

[0001-sed-fix-incorrect-match-for-title-case.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.