GNU bug report logs -
#24530
tests: revamp multibyte-white-space test to be more permissive
Previous Next
Reported by: Jim Meyering <jim <at> meyering.net>
Date: Sat, 24 Sep 2016 23:04:02 UTC
Severity: normal
Done: Jim Meyering <jim <at> meyering.net>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your message dated Sat, 24 Sep 2016 17:25:23 -0700
with message-id <CA+8g5KErebC+CkYt7ZTKww8RaMyU1TiWOBZv1mf3fLS9u9PN2g <at> mail.gmail.com>
and subject line Re: bug#24530: tests: revamp multibyte-white-space test to be more permissive
has caused the debbugs.gnu.org bug report #24530,
regarding tests: revamp multibyte-white-space test to be more permissive
to be marked as done.
(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)
--
24530: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24530
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
[Message part 3 (text/plain, inline)]
grep's multibyte-white-space would too often fail.
Its failure was mainly a reflection on the system's poor locale
support, so this test did not give good signal on whether one would be
well-advised to install the resulting grep binary.
I've done this:
tests: revamp multibyte-white-space test to be more permissive
This test elicits too many failures. Whether a system has accurate
unicode "whitespace" attributes should not influence whether grep's
test suite passes. In many cases, now you will see a warning that
some multibyte characters do not pass whitespace-related tests, but
this test no longer fails. However, if you run this test on a modern
enough system, it does require that \s and \S do work properly with
most of the listed characters.
* tests/multibyte-white-space: Confirm that Fedora 24's locale
tables still declare those four Unicode code points *not* whitespace.
Honor a new column telling how to handle failure. Provide more
information in each diagnostic.
With the attached patch, even on Fedora 24, we see new warnings like
this (before those characters were not even checked), and the test
passes as it did before:
warning: \s failed to match \xe2\x80\x87 in the en_US.UTF-8 locale
warning: \S mistakenly matched \xe2\x80\x87 in the en_US.UTF-8 locale
warning: \s failed to match \xe2\x80\x8b in the en_US.UTF-8 locale
warning: \S mistakenly matched \xe2\x80\x8b in the en_US.UTF-8 locale
warning: \s failed to match \xe2\x80\xaf in the en_US.UTF-8 locale
warning: \S mistakenly matched \xe2\x80\xaf in the en_US.UTF-8 locale
More importantly, on less modern systems, while this test would fail
before, now it will merely emit warnings like the above.
[tests--revamp-multibyte-white-space.diff (application/octet-stream, attachment)]
[Message part 5 (message/rfc822, inline)]
On Sat, Sep 24, 2016 at 4:02 PM, Jim Meyering <jim <at> meyering.net> wrote:
> grep's multibyte-white-space would too often fail.
> Its failure was mainly a reflection on the system's poor locale
> support, so this test did not give good signal on whether one would be
> well-advised to install the resulting grep binary.
>
> I've done this:
>
> tests: revamp multibyte-white-space test to be more permissive
> This test elicits too many failures. Whether a system has accurate
> unicode "whitespace" attributes should not influence whether grep's
> test suite passes. In many cases, now you will see a warning that
> some multibyte characters do not pass whitespace-related tests, but
> this test no longer fails. However, if you run this test on a modern
> enough system, it does require that \s and \S do work properly with
> most of the listed characters.
> * tests/multibyte-white-space: Confirm that Fedora 24's locale
> tables still declare those four Unicode code points *not* whitespace.
> Honor a new column telling how to handle failure. Provide more
> information in each diagnostic.
>
> With the attached patch, even on Fedora 24, we see new warnings like
> this (before those characters were not even checked), and the test
> passes as it did before:
>
> warning: \s failed to match \xe2\x80\x87 in the en_US.UTF-8 locale
> warning: \S mistakenly matched \xe2\x80\x87 in the en_US.UTF-8 locale
> warning: \s failed to match \xe2\x80\x8b in the en_US.UTF-8 locale
> warning: \S mistakenly matched \xe2\x80\x8b in the en_US.UTF-8 locale
> warning: \s failed to match \xe2\x80\xaf in the en_US.UTF-8 locale
> warning: \S mistakenly matched \xe2\x80\xaf in the en_US.UTF-8 locale
>
> More importantly, on less modern systems, while this test would fail
> before, now it will merely emit warnings like the above.
Pushed: http://git.sv.gnu.org/cgit/grep.git/commit/?id=7c4c69400c6ab
This bug report was last modified 8 years and 237 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.