From unknown Fri Jun 20 07:29:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24514 <24514@debbugs.gnu.org> To: bug#24514 <24514@debbugs.gnu.org> Subject: Status: 24.5; [WIP][PATCH] Lispy backtraces Reply-To: bug#24514 <24514@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:29:19 +0000 retitle 24514 24.5; [WIP][PATCH] Lispy backtraces reassign 24514 emacs submitter 24514 Vasilij Schneidermann severity 24514 wishlist tag 24514 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 22 19:16:21 2016 Received: (at submit) by debbugs.gnu.org; 22 Sep 2016 23:16:21 +0000 Received: from localhost ([127.0.0.1]:32808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnDE5-0001TW-Jq for submit@debbugs.gnu.org; Thu, 22 Sep 2016 19:16:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnDE3-0001TI-RU for submit@debbugs.gnu.org; Thu, 22 Sep 2016 19:16:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnDDx-0000Ya-FB for submit@debbugs.gnu.org; Thu, 22 Sep 2016 19:16:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnDDx-0000Y5-Bx for submit@debbugs.gnu.org; Thu, 22 Sep 2016 19:16:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnDDv-00086E-1f for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 19:16:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnDDr-0000Vx-Gl for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 19:16:10 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnDDr-0000Ux-8Z for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 19:16:07 -0400 Received: by mail-wm0-f52.google.com with SMTP id w84so280605819wmg.1 for ; Thu, 22 Sep 2016 16:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=YRCZzD0kFwR7aJX1qaAmxB/1+6tJq/YoZGMHz+goUbI=; b=Q2dS8G0h/jHKZl6tMCv7qjLpLJoQk8i354jOyjHghIMvirND/C1lMLjI7TvAClXQX+ vVo++IAr1WIQuBoc9eQLBqhnY/pRXjjlQS5m23IQ044hqSQkyC+bKk0EmoBL0kYsZVQH lWQnt0YWW3zM8EUxeeBOHnWTexDqj1DkpGzDM2f7y8eRRMnfAtXt+0enJz2AR4isj0vg 9JN5l2Rk8TZ77RgDEyrUphT1xvZNV6u2TPGB+Hom/TEunjsysitaRb0K45MWl7CqtUjE SGSB54c785Yh4YM+r9pv7OEPpVxnAMFfv+AAV24TdHbbL7neXpcKDF1KlYci9etl+O12 Iuyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=YRCZzD0kFwR7aJX1qaAmxB/1+6tJq/YoZGMHz+goUbI=; b=OyW0rkZcOwDi5fdKh6VbyG5f5Tmyr/epIrRasGP7aaNUFkqzkJz5fcfDYqR3PW3oE/ lPKudJva9g6K9QyK68VwMMpD7jWLMV1x1ZJrdUL20qIpSwTKim09zcdUtEf47hFTFOnw c9TMkb+TVmWFR8AkriZihq6OjR3zK1n4n0yy3lB0dBAr5VIWNnbQR8+v/xvu5Vaa5W+j w3j3FERRvjLIR2Gfus7mM4v3G9b9Ls84wsZngtYP/cOssSSJ9Oy1hha1Kb0ElrENwwQf Dua97LOkww+dCT6sq8QTmO9ARXBZ1FBlmNyu0bhE7ApKT5WUlEWxUCwTUUGKHlaLTcjL 949w== X-Gm-Message-State: AE9vXwNAYLFdVjysItaTErKtYvZLCXK4c2x9SqhBMErFpcB2/2dtFwnl2UQLtFHlO8r31Q== X-Received: by 10.194.190.37 with SMTP id gn5mr4154629wjc.168.1474586105182; Thu, 22 Sep 2016 16:15:05 -0700 (PDT) Received: from localhost (dslb-092-073-102-189.092.073.pools.vodafone-ip.de. [92.73.102.189]) by smtp.gmail.com with ESMTPSA id jn7sm4287961wjb.5.2016.09.22.16.15.04 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Sep 2016 16:15:04 -0700 (PDT) Date: Fri, 23 Sep 2016 01:14:47 +0200 From: Vasilij Schneidermann To: bug-gnu-emacs@gnu.org Subject: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20160922231447.GA3833@odonien.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline User-Agent: Mutt/1.7.0 (2016-08-17) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) --opJtzjQTFsWo+cga Content-Type: text/plain; charset=utf-8 Content-Disposition: inline I wrote a minimal patch that increases the overall consistency in a backtrace buffer by printing the call stack frames as S-Expressions. Before: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) +(1 t) eval((+ 1 t) nil) eval-expression((+ 1 t) nil) call-interactively(eval-expression nil nil) command-execute(eval-expression) After: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) (debug error (wrong-type-argument number-or-marker-p t)) (+ 1 t) (eval (+ 1 t) nil) (eval-expression (+ 1 t) nil) (funcall-interactively eval-expression (+ 1 t) nil) (call-interactively eval-expression nil nil) (command-execute eval-expression) Now, this patch isn't perfect. For some reason there's an extra debug line in the second version, I've yet to investigate into the reason for this. The other problem is that while I can't imagine any reason to go back to the original view of the backtrace, I cannot rule out that this change might break other tools relying on it. I'd appreciate any feedback on this. --opJtzjQTFsWo+cga Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Make-backtraces-great-again.patch" >From 232cb613a83f128d8ee90d7a52fcbde06fd29766 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Thu, 22 Sep 2016 23:01:21 +0200 Subject: [PATCH] Make backtraces great again --- lisp/emacs-lisp/debug.el | 2 +- src/eval.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 22a3f39..4020620 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -279,7 +279,7 @@ That buffer should be current already." (goto-char (point-min)) (delete-region (point) (progn - (search-forward "\n debug(") + (search-forward "\n (debug") (forward-line (if (eq (car args) 'debug) ;; Remove debug--implement-debug-on-entry ;; and the advice's `apply' frame. diff --git a/src/eval.c b/src/eval.c index 72facd5..e32e7a1 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3409,8 +3409,9 @@ Output stream used is value of `standard-output'. */) else { tem = backtrace_function (pdl); - Fprin1 (tem, Qnil); /* This can QUIT. */ write_string ("("); + Fprin1 (tem, Qnil); /* This can QUIT. */ + write_string (" "); { ptrdiff_t i; for (i = 0; i < backtrace_nargs (pdl); i++) -- 2.9.3 --opJtzjQTFsWo+cga-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 03:51:45 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 07:51:45 +0000 Received: from localhost ([127.0.0.1]:33027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLGr-0005lz-8p for submit@debbugs.gnu.org; Fri, 23 Sep 2016 03:51:45 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLGo-0005lm-S0 for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 03:51:43 -0400 Received: by mail-wm0-f45.google.com with SMTP id 197so3275325wmk.1 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 00:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RwFB4rL9waNoAvG9f5Ad/NDMzW5TozJPPPxHDpuwXBU=; b=wuY20WuMixlIVt78zvPci1x60yFII5lK8WXJTBCJjIAOIP5qCRobxgQXx0hWTTvV+k tEABgKLDmHZ7HT4I3oSglKoVYOQldLYzI9rohwGdQmvCCtpCLjQvVLd+PxVirWDRwv2j NhVnAlxH19e3AO3JnpC6F/qdUr5kWW9ukvuWNXV1Tk/7e1g43iDA9GSo99W6XMzcI6p5 PmNRgkyBFPbw0UZbTW/FYf0HQT+K8uzWr/uuXkq4zqcXOixgwhiaLvsTzjjQCI962LTS +fvLfmE90JYHE8wBGMEGN9Nh5VyJt3co9KVT1wf29sBcW1v+AvxOaIHRLuq1alxdMr4g s5jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RwFB4rL9waNoAvG9f5Ad/NDMzW5TozJPPPxHDpuwXBU=; b=J9errUda+1z29AY1pLxRiomkZD4R4kI0tnm6Fu8ExB0tWlpgat6C+9VhDuz54bVcWq J8d9OhJ3b9l4Gy8jyn2JfJKyoAunvA2cHWApxtEqAqvE4IeOUMHwqp6A6Tvm0CU+9N1n YUQIaX+yggcaeVvzoe3ADDQl4fDn0Wa6psjKKkm0l7gPjchq7pmBRnKPgrn/KIcGvQg9 n4GAx+4/WZkFnHclNcjFYTlNDvxliVtSUAawDmVkswUsHSF/CCsDuw7QX7gBFcdA2I6i 3F+evIT28pbjO/KMiND+g72sA2WCldi9z9yVBgvCqGzxnbMI9O+Cdstfz0sTCu1Pvc0B f7Jw== X-Gm-Message-State: AA6/9RmOLOqZiR1QftTGJrcO+XzTXVTGld6hEsAI9zpjqFLi68R/2jaxMn32kWqZrvhgGQ== X-Received: by 10.28.136.197 with SMTP id k188mr1509542wmd.54.1474617097087; Fri, 23 Sep 2016 00:51:37 -0700 (PDT) Received: from localhost ([89.204.137.24]) by smtp.gmail.com with ESMTPSA id 188sm1781462wmo.1.2016.09.23.00.51.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 00:51:36 -0700 (PDT) Date: Fri, 23 Sep 2016 09:51:16 +0200 From: Vasilij Schneidermann To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel , 24514@debbugs.gnu.org Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20160923075116.GA612@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > This looks great! I love it. And the patch looks very clean, too. Thanks! I've updated the patch after a bit more testing. The extra debug line happened because the search in debug.el did actually search for a `debug' call, so `(search-forward "\ (debug")` would match a call to `debug-foo` as well. Assuming there will always be extra args, this can be solved by appending a space to the search string. In case this is not true, I'll have to go for `re-search-forward` to handle a `(debug)` as well. The other problem was that there were extraneous spaces at times, this can be handled by making the line that prepends an argument with a space unconditional. > But it scares me a bit. Some tools do depend on e.g. trimming a > backtrace after printing it. Does edebug work with your patch, for > example? Yes, it does. However, you're raising a good point here. I would expect such a change to neither break Emacs core nor any of the bundled Emacs Lisp code. Guarantees about popular external code are hard to make, but communicating the change with the respective authors and maintainers should do the trick. What I've initially asked for is whether there might be any good reason for *not* doing things this way. I've grepped the 24.5 sources and most usage of `backtrace' appears to be of diagnostic nature. The only thing other than `debug.el` manipulating them is `edebug-backtrace' which I've never heard of before. I'll take a better look at its sources for my next revision of the patch. > I'm not sure what the right way to transition is. Maybe Emacs should > let Lisp programs access the backtraces in a structured way, and then > backtrace printing would only be a user-facing facility (programs > wouldn't use the textual representation). There is actually a way to do this, simply use `backtrace-frame' with an increasing integer argument until it returns nil: (let ((frame t) ; dummy value to kick-start the loop (i 0)) (while frame (setq frame (backtrace-frame i)) (message "%S" frame) (setq i (1+ i)))) This feature is used in `ert.el` to save a backtrace and reconstruct it. Perhaps all current users of `backtrace' that rely on its current representation should be using `backtrace-frame' instead? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 03:53:02 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 07:53:02 +0000 Received: from localhost ([127.0.0.1]:33031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLI6-0005oO-Ic for submit@debbugs.gnu.org; Fri, 23 Sep 2016 03:53:02 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLI5-0005nt-9e for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 03:53:01 -0400 Received: by mail-wm0-f46.google.com with SMTP id l132so15259395wmf.0 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 00:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=resent-from:resent-date:resent-message-id:resent-to:delivered-to :subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=+J/I/cshNjN4Cnbv/HPnUP88sIOe6a5ieO2K7ae/0ho=; b=mhroGECcEPoI1kKt54blLoB+l0EG+Y35UOydyzXUx48arH6K1L9nZ2jEZkM5xXHTo0 l3oCMGqjxAum7LCOEj1azcSxA8ZEpxcRjVNYq6rqNgsn9ayxE23Lv2/R199UhBIAlRnd kgTt9W/bxm4DWv10dkDsZrqlXNFZxwLok0M+IgEdDAFX4zy8j82wB14+q4LUtklWmiRl aNFGwK1HN8LKpLr32SLt/zBm88ggaaRVoc39DnCblKRUtuRikCX09dxpbF8Qf318KfSa s5Lu0xkLsQeJavhGPqLBxmNs6SofCIJI4qMN52BaECJtRCaDPGPVDPBtYIdIghDmfkHF LhNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:delivered-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=+J/I/cshNjN4Cnbv/HPnUP88sIOe6a5ieO2K7ae/0ho=; b=cL/qpkgAHppArIIVEQfTLVWm82QHdSO52UVG7hcyVSzgpE041LN5+54NJ4+ifxBCgL lgMPxeKKqDLWy0u1t63gQTLcIeZvY1A/67sREwRiCMnhBIgwow6YfF4aLyhrYMc5ApSI li/xYtdY5gfc/s5lrlgoVNEscYon/+hHSPHaNdERalJAl9pwukp+5wm55OJ0NrX1ucMw PCHZ0h788FiNCZMHP2P6u4LFhHRasdbSWO6G84eJPLoUtwvhlRL5ZSwpPjHuFIqo3Xvg OzDUkN+iw65S58T9p8CmneyygGfM1z0PhadOoWFN6mIIOw/ykSDIHT6IQ5CSoeYhJKOk GdTA== X-Gm-Message-State: AA6/9Rl/LLFIFT+Rqw6SfGgTz6OwncokV6ZB0kbVpmenwg9MpjF/X3jlrJ/1K5ArDdhjcw== X-Received: by 10.28.126.81 with SMTP id z78mr1512761wmc.13.1474617175404; Fri, 23 Sep 2016 00:52:55 -0700 (PDT) Received: from localhost ([89.204.137.24]) by smtp.gmail.com with ESMTPSA id w71sm1755354wmw.17.2016.09.23.00.52.54 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 00:52:55 -0700 (PDT) Resent-From: Vasilij Schneidermann Resent-Date: Fri, 23 Sep 2016 09:52:37 +0200 Resent-Message-ID: <20160923075237.GB612@odonien.localdomain> Resent-To: 24514@debbugs.gnu.org Delivered-To: v.schneidermann@gmail.com Received: by 10.103.103.199 with SMTP id b190csp314682vsc; Thu, 22 Sep 2016 19:22:20 -0700 (PDT) X-Received: by 10.194.191.162 with SMTP id gz2mr4500049wjc.182.1474597340201; Thu, 22 Sep 2016 19:22:20 -0700 (PDT) Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.10]) by mx.google.com with ESMTPS id kc2si5274334wjc.61.2016.09.22.19.22.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 19:22:20 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning clement.pit@gmail.com does not designate 212.227.17.10 as permitted sender) client-ip=212.227.17.10; Received: from [18.189.53.55] ([18.189.53.55]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0LtG3f-1aqf8S1r4d-012oua for ; Fri, 23 Sep 2016 04:22:19 +0200 Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces To: Vasilij Schneidermann References: <20160922231447.GA3833@odonien.localdomain> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> Date: Thu, 22 Sep 2016 22:22:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160922231447.GA3833@odonien.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX" X-Provags-ID: V03:K0:wl5/Io5oRtTvMBkXz8TNzYaDDjeZWf3DC+Tkis/YxSRcP30PI9o fn0Q6U9LpMfHOBcfIaNUYmiujAtXUgPzEe5oWC0xsQ+l7ZoDKfC50Ch42ZVugRg+TNPR1Wh ZqNBvTNFisaZ7jWi6rOFLL84Ppy2M1fk4K3BZjhr1KbuLYjiTY0qaQ9M20ffQTDaCzAVvLK Xqyo+Yy+F7SIyUy8S2Ptw== X-UI-Out-Filterresults: notjunk:1;V01:K0:C+7wQGNQZaA=:A60LU48N5wUNf6gFeiq/B/ Zt6/yqhNApIUh3JCg7k2Yu0ZlATWhzlLK+Ztlm/i+Jg2xEYVS4wz/HCvjEnXomeyDF1LJ54gd yycuUCGNuF7qxI8GmqT4nrk/Li+Lsr8Mnb503MJFIzXpLSRdkd1cJFOvwWbpxnk5tqpiwnfk0 orCmhKJ5fC8h1AWVfY+hDtDeuP3cqr/n/CcTPwgfACnnRHr0nsAfe/f7noeIqdz2K/BdG/2cg 03ESuLnH+AaRrp5ZilwnJ93cJlUEpwI/noscO40Vve9LJALFULqXVHmNI5j0h7x93mfoy/LMn JtumSflfmPH0owLRhwp3+WE8POwcLyM+PfS3y6S/PDbFcGq334nBJMy5+AZlnE7PR9Yy0K2Ts 70hlErn67NIg/LCK5l2RDGxj7ui1D6WrUFSTQKrNQM5YDWPqjSiMfiI3sLLz6IQFIqIvh2o73 RCbkkNDQqpLbB22ZAtaauSGWKO7O+1awa1bBwhLtGDq8Vd2nneosrntCrd44C2wDMFCgrI8j0 IabbiOeM449xIO1ssQW0aABO6RO0taH76GBlzlzNOavdGRT9z5ZUP8Pm18BZxhtI3P8gBSvKy lCF7AqYrWstqA1JyeJBqv+EPxlWCfaZ4+EvFubuPc9AL6gGLYlf/KiLyiKn6ocubr2hyKmXBT 24LDcwIF4Ya8jGwkHnjYPgTlsjjnsi/4qT8mccwjL3+SflDmOglOXgSCtMzFsVCHcXK0= X-TUID: h12R7O2Hf7Z1 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX Content-Type: multipart/mixed; boundary="jjpc0sEhx6ogM41N7HK88GTpu7F005DQ8"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Vasilij Schneidermann Message-ID: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> In-Reply-To: <20160922231447.GA3833@odonien.localdomain> --jjpc0sEhx6ogM41N7HK88GTpu7F005DQ8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This looks great! I love it. And the patch looks very clean, too. But it scares me a bit. Some tools do depend on e.g. trimming a backtrac= e after printing it. Does edebug work with your patch, for example? I'm not sure what the right way to transition is. Maybe Emacs should let= Lisp programs access the backtraces in a structured way, and then backtr= ace printing would only be a user-facing facility (programs wouldn't use = the textual representation). Cheers, Cl=C3=A9ment. On 2016-09-22 19:14, Vasilij Schneidermann wrote: > I wrote a minimal patch that increases the overall consistency in a > backtrace buffer by printing the call stack frames as S-Expressions. >=20 > Before: >=20 > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t= ) > +(1 t) > eval((+ 1 t) nil) > eval-expression((+ 1 t) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) >=20 > After: >=20 > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t= ) > (debug error (wrong-type-argument number-or-marker-p t)) > (+ 1 t) > (eval (+ 1 t) nil) > (eval-expression (+ 1 t) nil) > (funcall-interactively eval-expression (+ 1 t) nil) > (call-interactively eval-expression nil nil) > (command-execute eval-expression) >=20 > Now, this patch isn't perfect. For some reason there's an extra debug > line in the second version, I've yet to investigate into the reason for= > this. The other problem is that while I can't imagine any reason to go= > back to the original view of the backtrace, I cannot rule out that this= > change might break other tools relying on it. I'd appreciate any > feedback on this. >=20 --jjpc0sEhx6ogM41N7HK88GTpu7F005DQ8-- --52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5JHaAAoJEPqg+cTm90wjRXcP/1dK4WyvnAzCuN41Dn5HHFjq fXqE3UMXUjOd1faZfTALJIZ8sBx4svMaTLIjl5HetUJ8+RVwBuXhs1rkevdVHvSi +t1I6y5ubp+12vpOdeVbn8PX8baDBNf4c1CTzHc2agksqJXSwPN2UaJSjgHpxLTf 2r7pv2jSX6d4z+SgVAxD1r8rAhgawpVcFP1xzxZ2ibBRGI1Stt3c51y7RmBeIpSL QAAwAbPMDKUcmeA2TT4OrBoggqcc1YI2pQFklfkTcN3d2cDK/R7599/Sw+p9z8Rf ZiijVbFHOz8dB2bdfLWmiy2RwMUBMlxdDloezGDyEfyxaK1X2OckE/ZSfF1FqgOW sao692T362ln24tsDhahxa98dDNCTYYOgsmJtk1Gl6qLMgCweQ5RXKYZZ/93MbXV 4BoE/b0k/KLN+8A6GyJ6cWQIYupWe/KN78rbpP3zmr/zt1TX2z/zZmrlojz4hCVu xWeqpkgIBk/2PghEDRgvrC8o4AkcYnsKf2qsA18V+hbspZJK854spYTamUTlp3Ly eohZrp2zPPfqVIi4sg3NhUR5JFglqWgFD8AbuHgDoUYxdT0jdtzz1Jtp38MzDxUR C0+83YiiNEDm2u6ROzok7rXZK/YYB4AJ32vYfX53w0v6IWUNqbjhZGZVzeKCIMWu qClFgVVi9Px5I9tF14zq =SRcr -----END PGP SIGNATURE----- --52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 04:13:05 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 08:13:05 +0000 Received: from localhost ([127.0.0.1]:33047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLbU-0006Ig-Qg for submit@debbugs.gnu.org; Fri, 23 Sep 2016 04:13:04 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLbT-0006IC-FD for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 04:13:03 -0400 Received: by mail-wm0-f42.google.com with SMTP id l132so16235260wmf.0 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 01:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B9rW3ibZw/roH1eLGkbLqPKizZr7Yoo05HpgET4YzyE=; b=np+72XMWzEJD4oZx/4lRZQpyo172bKbB1h1FiFFsz2AS2VN/8IHxvrQICADubqIMJA wSkvVf4PRKcbVAGIwNdWUB1OCfBw7teYDtT131xrdCrlI+iNIAQYpSW4HvgY5BxB78mM oNFhvzvvsa8llOxfRfpWMTbn8IXPCD2b73mmx1QS/FEA/B7TKOe3gE/GtXlQ5K2XWnCP xtSA6OI0yPe731dpGGQt1qhSSBWagvk7f5BA3SCsRB6sSxWA70fgGkxfoT//kWuLHiJQ ouJxpUiLlMtEGhUR0buDxI30L+sjRH51puz/MsHEphlcpbqi6QtriQzIF7aKkEc88GDG +Liw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B9rW3ibZw/roH1eLGkbLqPKizZr7Yoo05HpgET4YzyE=; b=Rbom8N3K8yzqzcKnP7VzhOAMKxsPmsXqEYkTAFoecDoTevdovq/pVpeRJJvJih6n27 YF27+NsUamlhh1YjSh5Qx3yc63u2WR7ujisYU7KvRe6Iqypxcruc8DrOsvficAtnFf8G T/XEt4Y0ZeaotobYhkr0paTGNlqqDc1iCmwGuuj67MbZ7IjztBkvO3gpUcsd/BY898O3 0kEiU1eEetMNPZkdkYDw9dRqoIgSg9wlngaNQekWuzTuVbbI8xsTBLateZkRCdBgkItd hOV0uAAwA739o+PPkup6uPRRDMaLt7lr6+pvc4+rFmTNtNK0zHLSpLxoZ0bKu1sfWhyV +FOg== X-Gm-Message-State: AE9vXwPSnMUpPK1byHMaUrRIbYlSU2n0xG41cQyj5xrBj1MyBNdwkQtsJLkk44glsGT0Uw== X-Received: by 10.194.93.8 with SMTP id cq8mr5574106wjb.10.1474618377812; Fri, 23 Sep 2016 01:12:57 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id xb6sm5959155wjb.30.2016.09.23.01.12.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 01:12:57 -0700 (PDT) Date: Fri, 23 Sep 2016 10:12:35 +0200 From: Vasilij Schneidermann To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel , 24514@debbugs.gnu.org Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20160923081235.GA644@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline In-Reply-To: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Ouch, forgot the attachment. --y0ulUmNC+osPPQO6 Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Make-backtraces-great-again.patch" >From f85845921c5e06475c925508ba41b06340f4c95a Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Thu, 22 Sep 2016 23:01:21 +0200 Subject: [PATCH] Make backtraces great again --- lisp/emacs-lisp/debug.el | 2 +- src/eval.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 22a3f39..a1ca336 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -279,7 +279,7 @@ That buffer should be current already." (goto-char (point-min)) (delete-region (point) (progn - (search-forward "\n debug(") + (search-forward "\n (debug ") (forward-line (if (eq (car args) 'debug) ;; Remove debug--implement-debug-on-entry ;; and the advice's `apply' frame. diff --git a/src/eval.c b/src/eval.c index 72facd5..698e0a1 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3409,13 +3409,13 @@ Output stream used is value of `standard-output'. */) else { tem = backtrace_function (pdl); - Fprin1 (tem, Qnil); /* This can QUIT. */ write_string ("("); + Fprin1 (tem, Qnil); /* This can QUIT. */ { ptrdiff_t i; for (i = 0; i < backtrace_nargs (pdl); i++) { - if (i) write_string (" "); + write_string (" "); Fprin1 (backtrace_args (pdl)[i], Qnil); } } -- 2.9.3 --y0ulUmNC+osPPQO6-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 05:50:36 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 09:50:36 +0000 Received: from localhost ([127.0.0.1]:33067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnN7r-0000Al-R8 for submit@debbugs.gnu.org; Fri, 23 Sep 2016 05:50:35 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnN7q-0000AV-5p for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 05:50:34 -0400 Received: by mail-wm0-f48.google.com with SMTP id w84so20947758wmg.1 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 02:50:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:delivered-to:date:message-id:from:to:cc:in-reply-to :subject:reply-to:references:mime-version:content-transfer-encoding; bh=N7Rkn1CtytjJNdGqmUbmaFlhjR4EM86MBxjgUVLAzXY=; b=cWj5ZSvyA9WumOKWuCg7Nsy9ZgW73H6tGCYBwKL2EzafC8Cfz9Tm+ZuWdPSl1a1gV8 g33W1ROsOwMDkps7YDs310plzSXFbpkrq5sb00dzt8paicOBqhJJdsjpCRIgY0Plds+L +mUDXuK9TxISJnIJ+7YK+ELfPiYDMrAVwGGdtJQexnQroxLStvAkGMaA7NB95HliIriB g2z4zlIjghG6FDTgumX8Afz4O0VH8fEhG6jz+TdVvzA/oq8mHo8cRO1KFOWl9QpP15IR HF/JJCsZ9/BmNndNhkL6I2mF0P7fJQHpvycFfuskgRdnyatKKaUr59N9fD/vF2O6RZEH OKjA== X-Gm-Message-State: AA6/9RnutdcxPszEilygFjkTg13Wg2UnrQkkJSBKWzVTwZ9dQzppCInidLXE9QJQrmyAvQ== X-Received: by 10.28.4.72 with SMTP id 69mr1831354wme.91.1474624228260; Fri, 23 Sep 2016 02:50:28 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id o5sm2235859wmg.16.2016.09.23.02.50.27 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 02:50:28 -0700 (PDT) Resent-From: Vasilij Schneidermann Resent-Date: Fri, 23 Sep 2016 11:50:11 +0200 Resent-Message-ID: <20160923095011.GB644@odonien.localdomain> Resent-To: 24514@debbugs.gnu.org Delivered-To: v.schneidermann@gmail.com Received: by 10.103.103.199 with SMTP id b190csp451570vsc; Fri, 23 Sep 2016 02:44:14 -0700 (PDT) X-Received: by 10.200.56.72 with SMTP id r8mr6802977qtb.120.1474623854404; Fri, 23 Sep 2016 02:44:14 -0700 (PDT) Received: from eggs.gnu.org (eggs.gnu.org. [2001:4830:134:3::10]) by mx.google.com with ESMTPS id b137si4565186qkc.44.2016.09.23.02.44.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Sep 2016 02:44:14 -0700 (PDT) Received-SPF: pass (google.com: domain of eliz@gnu.org designates 2001:4830:134:3::10 as permitted sender) client-ip=2001:4830:134:3::10; Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnN1e-0005T6-Tz for v.schneidermann@gmail.com; Fri, 23 Sep 2016 05:44:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnN1e-0005Sk-RD; Fri, 23 Sep 2016 05:44:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3371 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bnN1e-0004El-2U; Fri, 23 Sep 2016 05:44:10 -0400 Date: Fri, 23 Sep 2016 12:44:37 +0300 Message-Id: <83shsrc5mi.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel In-reply-to: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> (message from =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel on Thu, 22 Sep 2016 22:22:13 -0400) Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-TUID: PdQmMgAiP1r6 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 Cc: v.schneidermann@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > From: Clément Pit--Claudel > Date: Thu, 22 Sep 2016 22:22:13 -0400 > > I'm not sure what the right way to transition is. Maybe Emacs should let Lisp programs access the backtraces in a structured way, and then backtrace printing would only be a user-facing facility (programs wouldn't use the textual representation). How about if we install this with a user option, off by default, that switches to the new format when turned on? Then we could collect user experience for some time, and make this the default if everyone likes it. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 06:06:56 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 10:06:56 +0000 Received: from localhost ([127.0.0.1]:33079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnNNg-0000aL-Kf for submit@debbugs.gnu.org; Fri, 23 Sep 2016 06:06:56 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnNNf-0000a7-Pr for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 06:06:56 -0400 Received: by mail-wm0-f50.google.com with SMTP id w84so21752342wmg.1 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 03:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=resent-from:resent-date:resent-message-id:resent-to:date:from:to:cc :subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=dYNB/KC2cZQQg6Cm3h9P0ySXxHddkDoiyY8tgIfK7ec=; b=tbe/d6G1n20TtDcair+mSW0u0A9Du+Twg+z1BdK8a2UXcqijNMXCQofYKiEptcsfbK iDqSCgVijJTq5HOJZT5xCYSulVbSRxqmWgVGbzpLBDKAeJpfBSJre/q27zIvb+hyuyaG NZO8gZLizydClpPxWcUX20CPWTU3z3IOrEPthkbDujS/08vTu61vGvZ8mMMTcOSBcbCB n5+NeaITb0XNqlaYOS6FRSZXy+lcgTwmGT27krRZXBOSMHKlF7HPzu9/cXDmA3efYf7D z6SXb3wdgM6wZ7x3MVcY6XLxnkPbl1c/twQUD5xci2FJi976JzCWqSGKzfdyr63YPnB6 VYMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dYNB/KC2cZQQg6Cm3h9P0ySXxHddkDoiyY8tgIfK7ec=; b=bOVVOcRVe078dMF4D34NAcnBt9vjsR16csDPqJVGVH4B2cEy6LVeiSctIk/0YcFHAy gPNJ6ZfhdhiQPdj7JdyMFHCFYbwjcg7wWrH6JYpjFNCY5OE6zNei58ujOAoMEx4oaPSq Ykw3FxP6sCKZ86GVi0FT6D9HCnsgggzClB+C4F+Fvb5dQHnQ9CWn6hq7i5wCoMhlGmcc qLnFniNs7yLSkY6gJarXC0rliseZk9IJxhWWu/ZLE8IFpfAQpLXbBzQ4aYcDrr9/xotM OQS+0NkwZWfQoF9goozAgBKOzkLujvhub0dF6NI3CODeFSrA0mtyXmes4UyfQ7hwjJ2j wvmg== X-Gm-Message-State: AA6/9RkVds50euHCLXU5l9NsIg+WmBBnEX0t9VQMS0+JvmUxpz12bLp/LIHoja411naPhQ== X-Received: by 10.28.56.196 with SMTP id f187mr1900004wma.120.1474625209958; Fri, 23 Sep 2016 03:06:49 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id q10sm2318546wme.6.2016.09.23.03.06.49 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 03:06:49 -0700 (PDT) Resent-From: Vasilij Schneidermann Resent-Date: Fri, 23 Sep 2016 12:06:33 +0200 Resent-Message-ID: <20160923100633.GE644@odonien.localdomain> Resent-To: 24514@debbugs.gnu.org Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id bk7sm6374534wjc.36.2016.09.23.02.55.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 02:55:57 -0700 (PDT) Date: Fri, 23 Sep 2016 11:55:41 +0200 From: Vasilij Schneidermann To: Eli Zaretskii , 24515@debbugs.gnu.org Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20160923095541.GC644@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> <83shsrc5mi.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <83shsrc5mi.fsf@gnu.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-TUID: G2p8rKSYiMql X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 Cc: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > How about if we install this with a user option, off by default, that > switches to the new format when turned on? This sounds sensible, but I'm not sure whether it's worth complicating the patch by adding checks for this new user option in `eval.c`, `debug.el` and `edebug.el`. > Then we could collect user experience for some time, and make this the > default if everyone likes it. How do you plan on informing and surveying users? Would a discussion on emacs-devel be the way to do this or do you have something different in mind? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 06:13:00 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 10:13:00 +0000 Received: from localhost ([127.0.0.1]:33084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnNTY-0000jT-Az for submit@debbugs.gnu.org; Fri, 23 Sep 2016 06:13:00 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnNTW-0000jH-P2 for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 06:12:59 -0400 Received: by mail-wm0-f50.google.com with SMTP id w84so22050203wmg.1 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 03:12:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:delivered-to:date:message-id:from:to:cc:in-reply-to :subject:reply-to:references:mime-version:content-transfer-encoding; bh=wETUKcDz9zi68oT1ja+BIUCt4dIC+8zH4O3k3J9CQEY=; b=VVTMU98fu7L3cXi+oATmkEjNrTkjRtcI4s0WXSBsBqgewwSvrgtOzth6ZO8iNgUrb0 01uDh72+7or2aghgk18Y1LOA4TwKBzU+m1y4X/YaabI3TqxaTyEVSwYqGPLc7sspoiEG +aNIWglatTw1qF+Lgj597Y4XOhQr6dMZEczl7EMTJv6W0n90EQBMS47qtenrwGxVmHQo AZCaZklOliqH1mHPYbB2vTVZQf88AweJt5DBbTC9amw7vz4pj4ixtN2enDvwqbkxfpNZ 55P3q+VfshIif9JqNPCnfn5Fc35+imv8ExYo/FZesjHk8hAPHsMZrBFuiNE6SudCc/KR WtSg== X-Gm-Message-State: AE9vXwPqjbYsexklFDz4VlOYrTnzo5Xo5sYOBAgUa0DprwgsIjmwOMCQmpFN0XVP39TODw== X-Received: by 10.194.0.116 with SMTP id 20mr6265121wjd.123.1474625572984; Fri, 23 Sep 2016 03:12:52 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id n131sm2358063wmd.3.2016.09.23.03.12.52 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 03:12:52 -0700 (PDT) Resent-From: Vasilij Schneidermann Resent-Date: Fri, 23 Sep 2016 12:12:36 +0200 Resent-Message-ID: <20160923101236.GF644@odonien.localdomain> Resent-To: 24514@debbugs.gnu.org Delivered-To: v.schneidermann@gmail.com Received: by 10.103.103.199 with SMTP id b190csp459977vsc; Fri, 23 Sep 2016 03:06:47 -0700 (PDT) X-Received: by 10.55.25.73 with SMTP id k70mr6989191qkh.133.1474625207666; Fri, 23 Sep 2016 03:06:47 -0700 (PDT) Received: from eggs.gnu.org (eggs.gnu.org. [208.118.235.92]) by mx.google.com with ESMTPS id w22si4602630qkb.106.2016.09.23.03.06.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Sep 2016 03:06:47 -0700 (PDT) Received-SPF: pass (google.com: domain of eliz@gnu.org designates 208.118.235.92 as permitted sender) client-ip=208.118.235.92; Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnNNS-0007pt-Ej for v.schneidermann@gmail.com; Fri, 23 Sep 2016 06:06:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnNNF-0007lx-Es; Fri, 23 Sep 2016 06:06:29 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3392 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bnNNE-0003ZZ-Jj; Fri, 23 Sep 2016 06:06:29 -0400 Date: Fri, 23 Sep 2016 13:06:56 +0300 Message-Id: <83r38bc4lb.fsf@gnu.org> From: Eli Zaretskii To: Vasilij Schneidermann In-reply-to: <20160923095541.GC644@odonien.localdomain> (message from Vasilij Schneidermann on Fri, 23 Sep 2016 11:55:41 +0200) Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> <83shsrc5mi.fsf@gnu.org> <20160923095541.GC644@odonien.localdomain> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-TUID: LPMDXU32OV3o X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 Cc: 24515@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > Date: Fri, 23 Sep 2016 11:55:41 +0200 > From: Vasilij Schneidermann > Cc: Clément Pit--Claudel > > > How about if we install this with a user option, off by default, that > > switches to the new format when turned on? > > This sounds sensible, but I'm not sure whether it's worth complicating > the patch by adding checks for this new user option in `eval.c`, > `debug.el` and `edebug.el`. It's a complication, sure. But it doesn't sound too complicated, and given the fears of breaking someone's code, I think it's justified. > > Then we could collect user experience for some time, and make this the > > default if everyone likes it. > > How do you plan on informing and surveying users? Would a discussion on > emacs-devel be the way to do this or do you have something different in > mind? I thought just watching the discussions and the bug tracker would be enough. Then, a couple of releases from now, we could ask whether making it the default would be okay, and see how people react. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 09:22:31 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 13:22:31 +0000 Received: from localhost ([127.0.0.1]:33158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnQQx-00077K-JG for submit@debbugs.gnu.org; Fri, 23 Sep 2016 09:22:31 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnQQv-000770-Cl for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 09:22:29 -0400 Received: from [18.189.53.55] ([18.189.53.55]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0LZvrB-1b6LNz10Zx-00loZA; Fri, 23 Sep 2016 15:22:22 +0200 Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces To: Vasilij Schneidermann , 24514@debbugs.gnu.org References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> <20160923075116.GA612@odonien.localdomain> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <9682182c-2575-4827-2a22-ead1071c26d7@gmail.com> Date: Fri, 23 Sep 2016 09:22:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160923075116.GA612@odonien.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EGCJRPpQ8KfhVm2FbeEadNAujonfwCBAm" X-Provags-ID: V03:K0:G30V81IgcU3uMrXRWl58u0QwPKMW95EEeRs8XHr8nY0xw8z4d/j gvgimJq6+0uqxMKtCyhWV7qyeTPM+Ly8fKFWJKCAZsBBbRuL0IakAtFrIchoZqRE7g/K4aM nMHKZuQTyKrGvhBrvMMVU26JR9tQjjmzLi5IlsOuWFOjbgcS1I9sfcEAgb1B9sBjcuX8yYq LU5cnU8KisXapRauh9skQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mamnLwDG3i0=:dtDsbFbz4X+Yk5p8iD31FQ LS4JpxkAl5bBMV0hlDiugGSt0M9oov0Mw8kK61/jzOA+kzd6s5DXKK8j72EvWn/KGwqUjUg3N n4/U5mOOOTJwU6+PPf/jafESLztJrRGT2e5Ire/bLLRLh7tT8EwIxyMAwCgHsK95F5pgWlc9U UXKDt2uJI/FiLVSBY9Ys7T24XvV/CdbZgN45LDc5x6SjiFCHUyTsLut8VBKlDPYmOX1zxIb8w PK6sHzL5LbrQZ1OOaGOH2gN9E0xuJ0jmBARzcWrFcUQ8qx1RtIHf1kM0ucsRxbnEsUwmsZOyV iswkg9Zc3BjRSXU0y4qd1TelCUlly9/cDGcW6fkEmH8ip4cxhb+5aB1wv1GH7MIKwKS6qD1DL LP2Hu5cUo70wbLQIMnTlr6iJ1PZjv+KX5b6wAkjPKA3Gwx3RnTz3K2YUHPBK2ur+f+lcl2Pkv l2bhfKaXPgnhPVwzTznnH2V/iEV5m3VDxjL8ceRY86jW1tOd70VJ1xJUTAc+5xmlQdIAtXJQs e5CSojK8PiYaYV2foKPms/dvOnNUXSyVgffqhs8LjAanVOytz//ximYE0zVr9N367rhTTnKVt n/0eu1plQcO6vgDSAiiRjgKMYt0hcyDX7Oog7jJVlhpFtoy23Zmk92hgWSQk1ubOk334Edg3t 9gjT3N/QreZy+EfUyy3lpBNQb X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2016-09-23 03:51, Vasilij Schneidermann wrote: >> This looks great! I love it. And the patch looks very clean, too. > > Thanks! I've updated the patch after a bit more testing. The extra > debug line happened because the search in debug.el did actually > search for a `debug' call, so `(search-forward "\ (debug")` would > match a call to `debug-foo` as well. Assuming there will always be > extra args, this can be solved by appending a space to the search > string. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.24 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (clement.pit[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [212.227.17.24 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.24 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 24514 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2016-09-23 03:51, Vasilij Schneidermann wrote: >> This looks great! I love it. And the patch looks very clean, too. > > Thanks! I've updated the patch after a bit more testing. The extra > debug line happened because the search in debug.el did actually > search for a `debug' call, so `(search-forward "\ (debug")` would > match a call to `debug-foo` as well. Assuming there will always be > extra args, this can be solved by appending a space to the search > string. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [212.227.17.24 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.24 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.24 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (clement.pit[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EGCJRPpQ8KfhVm2FbeEadNAujonfwCBAm Content-Type: multipart/mixed; boundary="8IaLama4qBwWv0NtwIRBqdgXDl7rEXT9c"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Vasilij Schneidermann , 24514@debbugs.gnu.org Message-ID: <9682182c-2575-4827-2a22-ead1071c26d7@gmail.com> Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> <20160923075116.GA612@odonien.localdomain> In-Reply-To: <20160923075116.GA612@odonien.localdomain> --8IaLama4qBwWv0NtwIRBqdgXDl7rEXT9c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-09-23 03:51, Vasilij Schneidermann wrote: >> This looks great! I love it. And the patch looks very clean, too. >=20 > Thanks! I've updated the patch after a bit more testing. The extra=20 > debug line happened because the search in debug.el did actually > search for a `debug' call, so `(search-forward "\ (debug")` would > match a call to `debug-foo` as well. Assuming there will always be > extra args, this can be solved by appending a space to the search > string. Could it just search for the first occurence only? >> But it scares me a bit. Some tools do depend on e.g. trimming a=20 >> backtrace after printing it. Does edebug work with your patch, >> for example? >=20 > Yes, it does. =E2=80=A6 The only thing other than `debug.el`=20 > manipulating them is `edebug-backtrace' which I've never heard of=20 > before.=20 This is the one I was scared about. You can get a backtrace while edebugg= ing by pressing t IIRC. I have a faint memory of this code doing nasty t= hings to remove edebug instrumentation from the backtrace before displayi= ng it. >> I'm not sure what the right way to transition is. Maybe Emacs >> should let Lisp programs access the backtraces in a structured way, >> and then backtrace printing would only be a user-facing facility >> (programs wouldn't use the textual representation). >=20 > There is actually a way to do this, simply use `backtrace-frame' with > an increasing integer argument until it returns nil: >=20 > (let ((frame t) ; dummy value to kick-start the loop (i 0)) (while > frame (setq frame (backtrace-frame i)) (message "%S" frame) (setq i > (1+ i)))) Neat! Didn't know about this. I think it would be great to add a pointer= to this in the documentation of `backtrace'. Great work :) Cl=C3=A9ment. --8IaLama4qBwWv0NtwIRBqdgXDl7rEXT9c-- --EGCJRPpQ8KfhVm2FbeEadNAujonfwCBAm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5SyIAAoJEPqg+cTm90wjPJcP/jRsYN69Liw0PmjYaOdPE1nM N6tt1Z2rdKe/k8cn3Krsr5UyqFJC9aVs9kFhFgGI12oxXlOq5nUSri8uz5EfFoHI CcaxrSE0Xc0J6xfxmBgld5kqe6wzAtOSWb1fvyjQvvFEbhRW50lgYJD9FefovE1n HnsoMlkje7d4MZmlapIE8Z20IZVItsNyEi+7FRhUI3wiboniSbxmndcfoScLZuIA Jsq2uHwN0c1W6rAEFcznVkeiD/lk6pRcBM9fgPE/fWQu6A8M/dmdMQLu4YnnRWSo Np/TPgBEpkMxin98XlLpUOscH27XlJKus9NgyENbApxqx6T09mrtQP2qqR2IBl5Q G+rdNsf7L4C5cUTNy61g8ByY8qxOTqoUjIJ3xvarPwrNIV/CZmNvpg0CKUaGQEYS PO3u4brH2dalW8s2pmz0nfZcy+iomgDpgeUWNl7sQWOQjxDf8RZ9teX/t5Dicp4N W3wHbySIiOV9xDWIaj8KXfY+02+hUFPjmwP53f/AT94suoaKPkm4K1yi0WVrrocI wCzsFj/YlxzPGJSFLn6hUrgQE4iEbTPsD+kmuE3SiU5hWBBh64S3+fRuCQ0as1i3 3pDpB5q4PthNF9eQZsgvd6PTV47DPUNP88jw6cJKCxQ8Ubtv2UEl6MSfjadHdMOJ l1orD06u1BTU3AePXtaO =Xzvf -----END PGP SIGNATURE----- --EGCJRPpQ8KfhVm2FbeEadNAujonfwCBAm-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 09:27:42 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 13:27:42 +0000 Received: from localhost ([127.0.0.1]:33170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnQVy-0007FW-Et for submit@debbugs.gnu.org; Fri, 23 Sep 2016 09:27:42 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnQVw-0007FH-8j for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 09:27:40 -0400 Received: by mail-wm0-f46.google.com with SMTP id w84so31870476wmg.1 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 06:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=resent-from:resent-date:resent-message-id:resent-to:delivered-to :subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=OYUTvjYtF0qS4yFclRB+QlIROVNVp/lx0XXQWqsbEUI=; b=OyqZ2itEcgF6GK7dU49kHov15+1P5ipRmsEfLECkHCwmUU64PjUjP2tl93XvHVmJpC llo+UkGgzOyMHOKK7OezU239YfIS/i2WvFavo1EutLRSaS4eDNgFwJmIN6awELTY+OvY WyzxwLP0gIuYnzRX9ogiZCLFB1T0dffiuFjwhE40gzrSzcyLGLMyoBxw1Q6HuyEOckID kfyiTOjLNQUjCkrGeKdyOhR99YIAXj000HboJ/r0tLY7RmkZ95zxtcJlA+FJbm1VIO4q JuKannATxqWzJvsJy8TYDsboUyEVxnL3OZoo4uKdKVzpZmxlWA28ntt5YgSTPhLWrauG OaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:delivered-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=OYUTvjYtF0qS4yFclRB+QlIROVNVp/lx0XXQWqsbEUI=; b=CLX1KDuwspX3ecIZ80FbfFVzRJxKsbXaX2cX3hqlWRnpXvkfGD+ZIjFqO9kiX2GNVZ UlkqcQZCYfw+ZoQdmKnsnmKaaNfUgPC7haJIf2q64/sxmoWDKIk1MbmBMhpu5Fyanxss M0N8zMlOi9EMMPAllFWlUotuTOa65P2CUZWx2Zoc4JorTwisJOTs6ewOE2fKdCW+7noh 3hMEvQZhKnQtRcTf7Ar6ykhm6Ks55Ow1i9i4ic+Cw0PgCmhl3G4nBUTis2ZDXR79HX/2 AXNkr6iAXVeX2hlMe6Xbe5Z8pvXlCHPFKP8lGJ9ikUytDstsV1xVevNNLcBdRomVB+kN hE1Q== X-Gm-Message-State: AA6/9RkiKbyUV5GfB15igIdsIOqnRHJ+JxHkTsVgoEu5BtEhfpr1SkKMzNEOKKHRu3hRJw== X-Received: by 10.28.98.68 with SMTP id w65mr3067131wmb.4.1474637254257; Fri, 23 Sep 2016 06:27:34 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id z12sm3145319wmz.11.2016.09.23.06.27.33 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 06:27:33 -0700 (PDT) Resent-From: Vasilij Schneidermann Resent-Date: Fri, 23 Sep 2016 15:27:17 +0200 Resent-Message-ID: <20160923132717.GG644@odonien.localdomain> Resent-To: 24514@debbugs.gnu.org Delivered-To: v.schneidermann@gmail.com Received: by 10.103.103.199 with SMTP id b190csp549022vsc; Fri, 23 Sep 2016 06:25:10 -0700 (PDT) X-Received: by 10.194.114.100 with SMTP id jf4mr6947930wjb.87.1474637110547; Fri, 23 Sep 2016 06:25:10 -0700 (PDT) Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.13]) by mx.google.com with ESMTPS id l130si3354556wmb.28.2016.09.23.06.25.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Sep 2016 06:25:10 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning clement.pit@gmail.com does not designate 212.227.17.13 as permitted sender) client-ip=212.227.17.13; Received: from [18.189.53.55] ([18.189.53.55]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0McyCA-1bWRr43xcw-00IFDk; Fri, 23 Sep 2016 15:25:09 +0200 Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces To: Vasilij Schneidermann , Eli Zaretskii , 24515@debbugs.gnu.org References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> <83shsrc5mi.fsf@gnu.org> <20160923095541.GC644@odonien.localdomain> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <214366cf-7c30-c7bd-573f-340cd208b842@gmail.com> Date: Fri, 23 Sep 2016 09:25:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160923095541.GC644@odonien.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s0idgPKrwMaxbH4oH8rUEN1iihsw3Q3P0" X-Provags-ID: V03:K0:XOBSzNI/MVM3+WofyDUtOO08wAATHi3tcygy7UiX6JlVVUlq7tq V1SrEA7IXs8GLn8LjIEzzo4RfoLEhJ1OFl8QHB8wnQdSV8pLSQqfZzpnCfP5kAwsRmIncyr wHek86fnpc6wGmt+49IQtFXuGyaXn2tUXp4bcgU4SHjlLAQaJdDb0SNxMLKUJlfnmfNsf5L OkBvqmX1GWgwVB7+cauow== X-UI-Out-Filterresults: notjunk:1;V01:K0:TnLr4flbWCA=:Xg/mQlToaIaLAHWSpUoFav 8PUHY0GgMbJ+Jfo/jALwqsP9vvbsKIjJ3k15yZeVlW2qeTvEGaENtE34IxhJxH3nWKItrDFEL zs8vHYujKZA4Hj0K1DzDwdiMwTl7g8t+b1NRDAm45XNSVU1nnDRg3YW0KL948nsk2hD8K6OI4 w3ZqR8iOtzdkyM2Oyfom+Hfyctkp4DzDMiyf+rTcJa+oOERtTAUrnmAdPF+6E6oBXsl5Re8wf KS5wmQMYupKx5cL4XDZGD3Dh/iSrzTTd+pUPaKQOW5x7KC4/mA1aYGgyQdc4dm/3NnQChcuBA Tt/2I0dcrSKDig1Z0Y26y75h0T4mPIRoCI6sq6Ft85uSaTiUlt81+1gDG/n3KhOmyiv+3ExVy y3Jg2Y461GyDBimDgu1CJL4Bbxz20oghXFYC5OHLsDr0/zp/fKol1SsNMpSPXFEnZiVYxPxrp Vkfz/bjZencKHIPkkGxy6pOnAo1pUl0StfN3w/X8O5icRgg/WCeJMqhhSB5ax6luOMC3DJgDe fF4lNLAxAlccbhNckyordkATEufRPtf2kEHtM2DJ0WeS7Fbtw6gJFDADjeDUcz7nXKQqAZmPs fpClwMyiP+CiXpNqq6IPG6tw5knXkbE8A15ZlIaZVsZR9lafQ0hltJqsJp6OSlqbD7M63Y2Lr 37qvx/JadWSzYbdc+WwkS8P9G X-TUID: GBrBPPDX/sX7 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s0idgPKrwMaxbH4oH8rUEN1iihsw3Q3P0 Content-Type: multipart/mixed; boundary="vGwPPWUASWXdvsF8Tj1GDt7ITmbtjNI21"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Vasilij Schneidermann , Eli Zaretskii , 24515@debbugs.gnu.org Message-ID: <214366cf-7c30-c7bd-573f-340cd208b842@gmail.com> Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> <83shsrc5mi.fsf@gnu.org> <20160923095541.GC644@odonien.localdomain> In-Reply-To: <20160923095541.GC644@odonien.localdomain> --vGwPPWUASWXdvsF8Tj1GDt7ITmbtjNI21 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-09-23 05:55, Eli Zaretskii wrote: > How about if we install this with a user option, off by default, that > switches to the new format when turned on? I like this idea :) In that case, we should probably mention the options = in NEWS, adding a note that code should be updated. --vGwPPWUASWXdvsF8Tj1GDt7ITmbtjNI21-- --s0idgPKrwMaxbH4oH8rUEN1iihsw3Q3P0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5S0zAAoJEPqg+cTm90wjYpsQAK/4kdmkBQRZH1s5uwyeniML aXY4QbTclB+ZmJyASMsJjxsZXrgvE5lPVoelmtp5C3bQldndGoUb7MN//57K+CMG mvNOos3GTWZPqvhb34UUJp/7LP4zdeqvVSN7oAFN7sjeMv1H69YsuCBXRYq0Eja7 Uw+O0N917idLuJRKHpN3ZTpMtfAhyqNB89w4GsnycJgq7hkLPKaV4KnxpWeZ1C1k C8m+ymeCgXCXQyMSSTzl6cYml85mk+9DZ/TGJ8D+qxLhHlrivQvGF7qQx+EOXUgV YJ4qNZaWsDxucG+owtd5Inq3chRBCJitZbzTEcOXMrQpKsNi0qWTn7wfHpYOiKK2 K36EGuITaMNtXXQQ0F7zETSuGGJpSabHr8Dz78icvlpIFiIv5Etqq25TxL8IGd0h H0gR9aim7Ptx0H+OLdV5AAfVcfFB7Jauhs6Yrcunlw0yXsQiet6Xw0j8rgJ1rrGf yJSV/bw2x6ymmbUdgG/xqD0NGJRcRRKiUL5KmhT+9ddeoj5KTr7Ah6BXK24KVTcZ l03EtRSxFQfTntkK2Yow9LgFm519XdgA7Bj/9rU4xe/2ZKlUN1Lmn5jTto56NFXq GaTGcXPlrT4AX19zqS/zwjbT3LKtHahTjcRj7Ys0wxDxqmKAvsWlY6wwFnN2epyf /KeBC+6ckckELFQHmcJO =RZu3 -----END PGP SIGNATURE----- --s0idgPKrwMaxbH4oH8rUEN1iihsw3Q3P0-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 14:48:02 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 18:48:02 +0000 Received: from localhost ([127.0.0.1]:33693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnVVy-0006jx-A8 for submit@debbugs.gnu.org; Fri, 23 Sep 2016 14:48:02 -0400 Received: from mail.muc.de ([193.149.48.3]:33488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnVVw-0006jX-Gr for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 14:48:01 -0400 Received: (qmail 30986 invoked by uid 3782); 23 Sep 2016 18:47:59 -0000 Date: 23 Sep 2016 18:47:59 -0000 Message-ID: <20160923184759.30985.qmail@mail.muc.de> From: Alan Mackenzie To: Vasilij Schneidermann Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.3.1-20141224 ("Tallant") (UNIX) (FreeBSD/10.3-RELEASE-p7 (amd64)) X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 24514 Cc: 24514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) In article you wrote: > [-- text/plain, encoding 7bit, charset: utf-8, 30 lines --] > I wrote a minimal patch that increases the overall consistency in a > backtrace buffer by printing the call stack frames as S-Expressions. > Before: > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) > +(1 t) > eval((+ 1 t) nil) > eval-expression((+ 1 t) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) > After: > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) > (debug error (wrong-type-argument number-or-marker-p t)) > (+ 1 t) > (eval (+ 1 t) nil) > (eval-expression (+ 1 t) nil) > (funcall-interactively eval-expression (+ 1 t) nil) > (call-interactively eval-expression nil nil) > (command-execute eval-expression) I'm not sure I'm in favour of this change. There is some tool in some circumstances which prints the lines in the "before:" fashion interspersed with internal forms from function which start off with "(" in column 0. Having the distinction between lines starting with "(" and lines starting with the function name is handy for telling them apart. Sorry I can't be more specific about the circumstances this happens in, but it happens relatively frequently. > Now, this patch isn't perfect. For some reason there's an extra debug > line in the second version, I've yet to investigate into the reason for > this. The other problem is that while I can't imagine any reason to go > back to the original view of the backtrace, I cannot rule out that this > change might break other tools relying on it. I'd appreciate any > feedback on this. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 16:43:29 2016 Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 20:43:29 +0000 Received: from localhost ([127.0.0.1]:33731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnXJg-0002m1-QD for submit@debbugs.gnu.org; Fri, 23 Sep 2016 16:43:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnXJf-0002lp-J1 for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 16:43:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnXJZ-0007AI-GJ for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 16:43:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnXJY-00076V-0b; Fri, 23 Sep 2016 16:43:20 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bnXJW-0006m1-R0; Fri, 23 Sep 2016 16:43:18 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Vasilij Schneidermann In-reply-to: <20160922231447.GA3833@odonien.localdomain> (message from Vasilij Schneidermann on Fri, 23 Sep 2016 01:14:47 +0200) Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> Message-Id: Date: Fri, 23 Sep 2016 16:43:18 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-Debbugs-Envelope-To: 24514 Cc: 24514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] An item in a backtrace consists of a function and ACTUAL parameters (argument values). If you do (list 'a 'b), the function will be list and the argument values will be (a b). (list a b) is a misleading way to represent that. It looks like a and b are expressions to be evaluated. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 15:16:26 2016 Received: (at 24514) by debbugs.gnu.org; 27 Sep 2016 19:16:26 +0000 Received: from localhost ([127.0.0.1]:37384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boxre-0003CD-HR for submit@debbugs.gnu.org; Tue, 27 Sep 2016 15:16:26 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boxrc-0003Bt-SJ for 24514@debbugs.gnu.org; Tue, 27 Sep 2016 15:16:25 -0400 Received: by mail-wm0-f49.google.com with SMTP id l132so30469696wmf.1 for <24514@debbugs.gnu.org>; Tue, 27 Sep 2016 12:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rgku3my9D0iOcMhi6cbUf8WRJvpynlEoQmxmoc9oAus=; b=uE3Xvi/4svLeoKpQHJ1Mk+6/ctQH30L/nlnRm8ctmwbBvuRCZDt9jDMp4rAoxmPL8X ck/PEPqPlTQYgZ8L0ibldlImGQyp92vb3EDo2OrSwppXGLu4DPbDM7cH3cpJNHCNGr/h RWAe2lbvO1+sGyLBLYWBCTPLWyGnDCXBsVW4MDLhlgF6rMk1+dW0baubWy3qauOIQJLy qulC1s7u2PzQx6SAbnYZjZqFxCbGWTuHJePjny1Bcde+lPS5riasITL45taCuVVEhoFx hYLqKc+VpPWDMzNFRIW2nzgbZdnnKmyn4hBmdk3BSm1k26HinuCMdqVv7KJHcWPd36rd 06Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rgku3my9D0iOcMhi6cbUf8WRJvpynlEoQmxmoc9oAus=; b=hNFJAPbN80zUy4Wu70hP4AG3p4gxMurtZ45iO+dWw+7iWyl9dM3YfLacK0QIWa4E1w Oel2WAhA//Nnrjl2QXVRq2IRx/3KOR7RQy6T0Rgx9E7vn5v7GzBVcXm6q/t9H1rCO+pu kUxobO7kLAvsJIj+e+US5y++O5cy3F1ex07U2tVRre3lrY+zdVnXZ9/SPWdT7lVpjGiI xeGml9DgNJjv23vk54r81Te/8vC5wBKFoCCwvad/nHT38f+PYAu81i/Beida0GK4oz6B urvdAOKtKJybd/3F75LclUS3ido4QZ4wgPvFnQLPOAhErL/m61lwamnLchwV7HAXNRgm 5RbQ== X-Gm-Message-State: AA6/9RlZEGuCXuH6j9hVnHYe9hRHzEfoQdyDWvPSZGdJXkIzDQZmiyYfU8HbVK/0ns/tyw== X-Received: by 10.28.154.142 with SMTP id c136mr4616189wme.102.1475003778741; Tue, 27 Sep 2016 12:16:18 -0700 (PDT) Received: from localhost (dslb-088-077-124-050.088.077.pools.vodafone-ip.de. [88.77.124.50]) by smtp.gmail.com with ESMTPSA id b193sm11455205wmg.18.2016.09.27.12.16.17 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Sep 2016 12:16:18 -0700 (PDT) Date: Tue, 27 Sep 2016 21:16:03 +0200 From: Vasilij Schneidermann To: 24514@debbugs.gnu.org Subject: Re: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20160927191603.GA610@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20160922231447.GA3833@odonien.localdomain> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --KsGdsel6WgEHnImy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hello again, I've updated the patch as suggested to make the behavior configurable. I'm pretty sure though that the customization option's name is terrible. Any suggestions for a better one? --KsGdsel6WgEHnImy Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Make-backtraces-great-again.patch" >From 7b953b3ec64b26edd812d0ad3e4e01bad4f94193 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Thu, 22 Sep 2016 23:01:21 +0200 Subject: [PATCH] Make backtraces great again --- lisp/emacs-lisp/debug.el | 4 +++- lisp/emacs-lisp/edebug.el | 4 +++- src/eval.c | 12 ++++++++++-- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 22a3f39..c481ee2 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -279,7 +279,9 @@ That buffer should be current already." (goto-char (point-min)) (delete-region (point) (progn - (search-forward "\n debug(") + (search-forward (if debugger-lispy-backtrace + "\n (debug " + "\n debug(")) (forward-line (if (eq (car args) 'debug) ;; Remove debug--implement-debug-on-entry ;; and the advice's `apply' frame. diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index c283c16..a2e9c00 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -3797,7 +3797,9 @@ Otherwise call `debug' normally." (forward-line 1) (delete-region last-ok-point (point))) - ((looking-at "^ edebug") + ((looking-at (if debugger-lispy-backtrace + "^ (edebug" + "^ edebug")) (forward-line 1) (delete-region last-ok-point (point)) ))) diff --git a/src/eval.c b/src/eval.c index 72facd5..fc6e5a6 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3409,13 +3409,17 @@ Output stream used is value of `standard-output'. */) else { tem = backtrace_function (pdl); + if (debugger_lispy_backtrace) + write_string ("("); Fprin1 (tem, Qnil); /* This can QUIT. */ - write_string ("("); + if (!debugger_lispy_backtrace) + write_string ("("); { ptrdiff_t i; for (i = 0; i < backtrace_nargs (pdl); i++) { - if (i) write_string (" "); + if (i || debugger_lispy_backtrace) + write_string(" "); Fprin1 (backtrace_args (pdl)[i], Qnil); } } @@ -3838,6 +3842,10 @@ This is nil when the debugger is called under circumstances where it might not be safe to continue. */); debugger_may_continue = 1; + DEFVAR_BOOL ("debugger-lispy-backtrace", debugger_lispy_backtrace, + doc: /* Non-nil means display call stack frames as lists. */); + debugger_lispy_backtrace = 0; + DEFVAR_LISP ("debugger", Vdebugger, doc: /* Function to call to invoke debugger. If due to frame exit, args are `exit' and the value being returned; -- 2.9.3 --KsGdsel6WgEHnImy-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 11:28:12 2016 Received: (at 24514) by debbugs.gnu.org; 28 Sep 2016 15:28:12 +0000 Received: from localhost ([127.0.0.1]:38049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGmJ-0008Gv-W0 for submit@debbugs.gnu.org; Wed, 28 Sep 2016 11:28:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGmI-0008Gi-Pz for 24514@debbugs.gnu.org; Wed, 28 Sep 2016 11:28:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpGm9-0008Tu-G3 for 24514@debbugs.gnu.org; Wed, 28 Sep 2016 11:28:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGm9-0008TL-DD; Wed, 28 Sep 2016 11:28:01 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1225 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpGm7-0002Yi-JD; Wed, 28 Sep 2016 11:28:00 -0400 Date: Wed, 28 Sep 2016 18:28:00 +0300 Message-Id: <8337kkoxhb.fsf@gnu.org> From: Eli Zaretskii To: Vasilij Schneidermann In-reply-to: <20160927191603.GA610@odonien.localdomain> (message from Vasilij Schneidermann on Tue, 27 Sep 2016 21:16:03 +0200) Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> <20160927191603.GA610@odonien.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24514 Cc: 24514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > Date: Tue, 27 Sep 2016 21:16:03 +0200 > From: Vasilij Schneidermann > > I've updated the patch as suggested to make the behavior configurable. Thanks! > I'm pretty sure though that the customization option's name is terrible. > Any suggestions for a better one? How about debugger-stack-frame-as-list? Two minor nits to make this patch perfect: . Add the variable to cus-start.el, so that it will be a defcustom . Add a NEWS entry and mention the variable in the ELisp manual Thanks a lot for working on this. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 06:30:21 2016 Received: (at 24514) by debbugs.gnu.org; 30 Sep 2016 10:30:21 +0000 Received: from localhost ([127.0.0.1]:39301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpv5A-0002Ig-Rm for submit@debbugs.gnu.org; Fri, 30 Sep 2016 06:30:21 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpv58-0002IT-CP for 24514@debbugs.gnu.org; Fri, 30 Sep 2016 06:30:18 -0400 Received: by mail-wm0-f66.google.com with SMTP id p197so1317490wmg.1 for <24514@debbugs.gnu.org>; Fri, 30 Sep 2016 03:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j4wAH0aFRxeMDQgObUjFBCYZNxt1On249kXXdgV++YQ=; b=P4rdu/mDNe7BsFV8k0EXCnFxczD+pSDCSm/QSm31BodcA4Xbpfnm/ImOCOzEJvjxBg 2guO+jSHJlLpJQ60z9EmSvV9BKVyZJ2GItY+kjuML1rSYKApox9kdyfEEqkWYytItqW6 6h6toCo/gO4Yuw3Qk0aYwXFC1vWd16qI8ZMWLDeIgMlIDYXQAa1xKlBpg4XXhJ5/V+FJ RSMlEejji/J2y0/RYwgmGZW8T/HY2Rx+eph1X3/Z0Ru/nv73HCvarwdfkQNW/7KlXW1x d73avbIwTuvHB3UFJy63pSyBCguml3mxQefw7tMpghQFMLPAc3TbG40XYBQza7sNjV7P H0xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j4wAH0aFRxeMDQgObUjFBCYZNxt1On249kXXdgV++YQ=; b=QxsbRRo0zTCChUcujAjHMMS/oBu/ymfYl8mPJ1vSOCZIUwrxoJXvJUyxl3/MGh2CP8 lHaee2T9YRTRTgb+swb58BFu4+zhZJVG1uRzqp8RxgP5S2ny89HbIICj1nb7kLvTlPf5 tlZXck6YKLBod5NhjPxQSYfAU01pnEOFTDJyBIzS7/zJvBwuAHra9Vcbki5J+pHgLRf9 KSiEbjyWY91TUx8z6hrqabyYwNoVWOJlO2W0EPd5QH2lHx0DZ7hgdSsym2ZW8FvYowJC RbvSyi96ybRCdbyG7yw+rHtUamhSIsKInYajeDRrOt4XVRSO6jI2avS2/L9LLo/MzrK2 YZHA== X-Gm-Message-State: AA6/9RnpmwtukcjQBnC781pq9hGcYdNPQ6f/o8wYEP2EeBzwLSVRZX8JejVAzHedeyESqw== X-Received: by 10.28.196.200 with SMTP id u191mr2951172wmf.67.1475231412630; Fri, 30 Sep 2016 03:30:12 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id 193sm3421361wmo.14.2016.09.30.03.30.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Sep 2016 03:30:11 -0700 (PDT) Date: Fri, 30 Sep 2016 12:29:56 +0200 From: Vasilij Schneidermann To: Eli Zaretskii Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20160930102956.GA666@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> <20160927191603.GA610@odonien.localdomain> <8337kkoxhb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <8337kkoxhb.fsf@gnu.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24514 Cc: 24514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline > How about debugger-stack-frame-as-list? Thanks, sounds good to me. > Two minor nits to make this patch perfect: > > . Add the variable to cus-start.el, so that it will be a defcustom > . Add a NEWS entry and mention the variable in the ELisp manual I've done these and changed the commit message to comply better with the changelog style. Let me know if there's still something off. --IS0zKkzwUGydFO0o Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Add-new-debugger-stack-frame-as-list-option.patch" >From 62d47f75adc8d319b6fc35bb79bcf316d16bec00 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Thu, 22 Sep 2016 23:01:21 +0200 Subject: [PATCH] Add new 'debugger-stack-frame-as-list' option Allow displaying all lines in `backtrace' as lists. * doc/lispref/debugging.texi: Document the new variable * src/eval.c: New variable * lisp/emacs-lisp/debug.el: Adjust backtrace processing for new variable * lisp/emacs-lisp/edebug.el: Adjust backtrace processing for new variable --- doc/lispref/debugging.texi | 29 +++++++++++++++++++++++++++++ etc/NEWS | 5 +++++ lisp/cus-start.el | 1 + lisp/emacs-lisp/debug.el | 4 +++- lisp/emacs-lisp/edebug.el | 4 +++- src/eval.c | 12 ++++++++++-- 6 files changed, 51 insertions(+), 4 deletions(-) diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi index 98c4705..15eea8a 100644 --- a/doc/lispref/debugging.texi +++ b/doc/lispref/debugging.texi @@ -623,6 +623,35 @@ forms are elided. @end smallexample @end deffn +@defvar debugger-stack-frame-as-list +If this variable is non-@code{nil}, every line of the backtrace is +displayed as a list. This aims to improve backtrace readability at +the cost of special forms no longer being visually different from +regular function calls. + +The above example would look as follows: +@smallexample +@group +----------- Buffer: backtrace-output ------------ + (backtrace) + (list ...computing arguments...) +@end group + (progn ...) + (eval (progn (1+ var) (list (quote testing) (backtrace)))) + (setq ...) + (save-excursion ...) + (let ...) + (with-output-to-temp-buffer ...) + (eval (with-output-to-temp-buffer ...)) + (eval-last-sexp-1 nil) +@group + (eval-last-sexp nil) + (call-interactively eval-last-sexp) +----------- Buffer: backtrace-output ------------ +@end group +@end smallexample +@end defvar + @defvar debug-on-next-call @cindex @code{eval}, and debugging @cindex @code{apply}, and debugging diff --git a/etc/NEWS b/etc/NEWS index a72be53..a88d9ec 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -179,6 +179,11 @@ questions, with a handy way to display help texts. +++ ** 'switch-to-buffer-preserve-window-point' now defaults to t. ++++ +** The new variable 'debugger-stack-frame-as-list' allows displaying +all call stack frames in 'backtrace' as lists. Both debug.el and +edebug.el have been updated accordingly. + * Editing Changes in Emacs 25.2 diff --git a/lisp/cus-start.el b/lisp/cus-start.el index c830ed8..c6d0ae4 100644 --- a/lisp/cus-start.el +++ b/lisp/cus-start.el @@ -246,6 +246,7 @@ Leaving \"Default\" unchecked is equivalent with specifying a default of (debug-ignored-errors debug (repeat (choice symbol regexp))) (debug-on-quit debug boolean) (debug-on-signal debug boolean) + (debugger-stack-frame-as-list debugger boolean) ;; fileio.c (delete-by-moving-to-trash auto-save boolean "23.1") (auto-save-visited-file-name auto-save boolean) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 22a3f39..7d27380 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -279,7 +279,9 @@ That buffer should be current already." (goto-char (point-min)) (delete-region (point) (progn - (search-forward "\n debug(") + (search-forward (if debugger-stack-frame-as-list + "\n (debug " + "\n debug(")) (forward-line (if (eq (car args) 'debug) ;; Remove debug--implement-debug-on-entry ;; and the advice's `apply' frame. diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index c283c16..0c2a8ad 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -3797,7 +3797,9 @@ Otherwise call `debug' normally." (forward-line 1) (delete-region last-ok-point (point))) - ((looking-at "^ edebug") + ((looking-at (if debugger-stack-frame-as-list + "^ (edebug" + "^ edebug")) (forward-line 1) (delete-region last-ok-point (point)) ))) diff --git a/src/eval.c b/src/eval.c index 72facd5..f07cc83 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3409,13 +3409,17 @@ Output stream used is value of `standard-output'. */) else { tem = backtrace_function (pdl); + if (debugger_stack_frame_as_list) + write_string ("("); Fprin1 (tem, Qnil); /* This can QUIT. */ - write_string ("("); + if (!debugger_stack_frame_as_list) + write_string ("("); { ptrdiff_t i; for (i = 0; i < backtrace_nargs (pdl); i++) { - if (i) write_string (" "); + if (i || debugger_stack_frame_as_list) + write_string(" "); Fprin1 (backtrace_args (pdl)[i], Qnil); } } @@ -3838,6 +3842,10 @@ This is nil when the debugger is called under circumstances where it might not be safe to continue. */); debugger_may_continue = 1; + DEFVAR_BOOL ("debugger-stack-frame-as-list", debugger_stack_frame_as_list, + doc: /* Non-nil means display call stack frames as lists. */); + debugger_stack_frame_as_list = 0; + DEFVAR_LISP ("debugger", Vdebugger, doc: /* Function to call to invoke debugger. If due to frame exit, args are `exit' and the value being returned; -- 2.10.0 --IS0zKkzwUGydFO0o-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 09:26:20 2016 Received: (at 24514) by debbugs.gnu.org; 30 Sep 2016 13:26:20 +0000 Received: from localhost ([127.0.0.1]:39336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpxpT-0001Rb-Lx for submit@debbugs.gnu.org; Fri, 30 Sep 2016 09:26:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpxpR-0001RO-No for 24514@debbugs.gnu.org; Fri, 30 Sep 2016 09:26:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpxpI-0006wG-AD for 24514@debbugs.gnu.org; Fri, 30 Sep 2016 09:26:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpxpI-0006vY-6z; Fri, 30 Sep 2016 09:26:08 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4449 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpxpF-0002vT-6Y; Fri, 30 Sep 2016 09:26:06 -0400 Date: Fri, 30 Sep 2016 16:26:03 +0300 Message-Id: <83lgy9msd0.fsf@gnu.org> From: Eli Zaretskii To: Vasilij Schneidermann In-reply-to: <20160930102956.GA666@odonien.localdomain> (message from Vasilij Schneidermann on Fri, 30 Sep 2016 12:29:56 +0200) Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> <20160927191603.GA610@odonien.localdomain> <8337kkoxhb.fsf@gnu.org> <20160930102956.GA666@odonien.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 24514 Cc: 24514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > Date: Fri, 30 Sep 2016 12:29:56 +0200 > From: Vasilij Schneidermann > Cc: 24514@debbugs.gnu.org > > > Two minor nits to make this patch perfect: > > > > . Add the variable to cus-start.el, so that it will be a defcustom > > . Add a NEWS entry and mention the variable in the ELisp manual > > I've done these and changed the commit message to comply better with the > changelog style. Let me know if there's still something off. Thanks, pushed to master. The log entry need some tweaking to bring it to our standards; see my commit for what was needed. If this bug can be closed now, please do. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 12 11:35:08 2016 Received: (at 24514-done) by debbugs.gnu.org; 12 Oct 2016 15:35:08 +0000 Received: from localhost ([127.0.0.1]:53197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buLYi-00008S-1v for submit@debbugs.gnu.org; Wed, 12 Oct 2016 11:35:08 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buLYg-00007l-58 for 24514-done@debbugs.gnu.org; Wed, 12 Oct 2016 11:35:06 -0400 Received: by mail-lf0-f50.google.com with SMTP id x79so83742662lff.0 for <24514-done@debbugs.gnu.org>; Wed, 12 Oct 2016 08:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fOFtMSE5yV1syX1zEFHfaSxsNDEQ1Dji/3fXDxeFsvU=; b=pBwen7lFi1ZUz/Esuwu1VQ0SbVDX2TwKX5/fdwtqGE1fwXsi33EWtxA13jI0k9+5NZ Ewnq67dWD5805uj+qToVGndNZdiJnRvc9DINu6zMWV1p6W3JTqQ/9UsK7U9l/WL41wZi 9OexIhaqDzrD9om7A+6jq+t44fL65U1W2L1kFf3KqiNJalqfoxzZCCPzUeZ/uYl5tyK3 eXE7EdHaDeAvqs5qNBgI+LJ1LFnoOc4xRGEFq+UsrKIvYjNosm3AcsBeNdzhwFOfa5v2 iQCRYYAb7gjbecKoIYkQ+rSwfIrJHq4y+RtpukGWkZ9zZPUdBb1fO6OYtcsCrSTc3NqZ AkKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fOFtMSE5yV1syX1zEFHfaSxsNDEQ1Dji/3fXDxeFsvU=; b=U+wZMsQ7uOvgcCzKVyoZIALwWfmoDiuctQIQyuQ0BpJg3L5B5DxdfEnBORIBSRUiBa XTubj0Eb74LiXf61fe3f2SeEVUudt0pOSk49iBf7Y+LJxgNVBeyIHqKAG2Q72S4Pi5W+ Co1JBNr3Oq0c7mkmWVyX/HQRDcW692yV769Flf+UF59zqfgcraLp8QlmcYzXFNoGQQNx 1N6aL6FbF6njm0TMOQoMSwrkdttEaijgFy8Hg/vjIEYEfdMWBk3sAQlkKpkddPWO2V3p nckTWHpToiEezBP15Cp28lbfBGM2yoKDsyM4RZM54PcB6kUMHv97rMOmvZbGyQe0QCP4 MzuA== X-Gm-Message-State: AA6/9RkpsVRCn0nnarjsxNEFn+A58FtMaHK1koKk57Brxhd28tgnpwTum6KwWtwHjDvN2g== X-Received: by 10.194.147.48 with SMTP id th16mr2446889wjb.68.1476286499933; Wed, 12 Oct 2016 08:34:59 -0700 (PDT) Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id e2sm13782834wjw.14.2016.10.12.08.34.59 for <24514-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Oct 2016 08:34:59 -0700 (PDT) Date: Wed, 12 Oct 2016 17:34:42 +0200 From: Vasilij Schneidermann To: 24514-done@debbugs.gnu.org Subject: Re: 24.5; [WIP][PATCH] Lispy backtraces Message-ID: <20161012153442.GA664@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> <20160927191603.GA610@odonien.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160927191603.GA610@odonien.localdomain> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24514-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Feature was fully implemented and committed to the respective branch. From unknown Fri Jun 20 07:29:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Nov 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator