From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 22 11:53:16 2016 Received: (at submit) by debbugs.gnu.org; 22 Sep 2016 15:53:16 +0000 Received: from localhost ([127.0.0.1]:60811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bn6JI-0002ik-0m for submit@debbugs.gnu.org; Thu, 22 Sep 2016 11:53:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bn6JF-0002iX-RD for submit@debbugs.gnu.org; Thu, 22 Sep 2016 11:53:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn6J9-00060J-Cp for submit@debbugs.gnu.org; Thu, 22 Sep 2016 11:53:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6J9-0005zj-9c for submit@debbugs.gnu.org; Thu, 22 Sep 2016 11:53:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6J6-0006mY-EP for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 11:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn6J0-0005ua-ET for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 11:53:03 -0400 Received: from aibo.runbox.com ([91.220.196.211]:53816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6J0-0005pr-40 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 11:52:58 -0400 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1bn6It-000525-DV for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 17:52:51 +0200 Received: from ip70-171-222-16.tc.ph.cox.net ([70.171.222.16] helo=[192.168.0.106]) by mailfront10.runbox.com with esmtpsa (uid:179284 ) (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1bn6IZ-0007Ur-VQ for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2016 17:52:32 +0200 From: Gemini Lasswell Content-Type: multipart/mixed; boundary="Apple-Mail=_39045FD3-01BA-4497-82A1-83E72A880CC7" Subject: 25.1.50; backquotes cause testcover to report 1value errors Message-Id: <3058CAD3-D2CD-4A26-8F53-FC7B38BE7176@runbox.com> Date: Thu, 22 Sep 2016 08:52:28 -0700 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --Apple-Mail=_39045FD3-01BA-4497-82A1-83E72A880CC7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Backquote syntax can cause testcover to report "Value of form marked = with =E2=80=981value=E2=80=99 does vary=E2=80=9D errors. Here is some = code with two different variations of the problem: (defmacro my-lambda (&rest body) `(lambda () ,@body)) (defun my-example () (let ((lambda-1 (my-lambda (message "lambda-1"))) (lambda-2 (my-lambda (message "lambda-2")))) (funcall lambda-1) (funcall lambda-2))) (defmacro my-print-symbol (name) `(message "the symbol is %s" ',name)) (defun my-example-2 () (my-print-symbol foo) (my-print-symbol bar)) To reproduce the bug: 1. save the above code into a file 2. emacs -Q 3. M-x eval-expression RET (require =E2=80=98testcover) RET 4. M-x testcover-start RET filename RET To make the attached stack trace: 5. M-x toggle-debug-on-error RET 6. M-x eval-expression RET (my-example-2) RET In my opinion testcover should not be claiming that it is an error if = its 1value determination is incorrect. There is no error in the code = being tested, there is just a shortcoming in the heuristics that = testcover is using to figure out what color splotch to put on the line. = But if a form has returned a second value, that code has had adequate = coverage and no splotch is necessary. --Apple-Mail=_39045FD3-01BA-4497-82A1-83E72A880CC7 Content-Disposition: attachment; filename=testcover-backtrace.txt Content-Type: text/plain; name="testcover-backtrace.txt" Content-Transfer-Encoding: quoted-printable Debugger entered--Lisp error: (error "Value of form marked with = =E2=80=981value=E2=80=99 does vary: (message the symbol is %s (quote = bar))") signal(error ("Value of form marked with =E2=80=981value=E2=80=99 does = vary: (message the symbol is %s (quote bar))")) error("Value of form marked with `1value' does vary: %s" (message "the = symbol is %s" (quote bar))) testcover-1value(2 (message "the symbol is %s" (quote bar))) (lambda nil (testcover-1value 2 (list (quote message) "the symbol is = %s" (list (quote quote) (testcover-after 1 name)))))() testcover-enter(my-print-symbol (lambda nil (testcover-1value 2 (list = (quote message) "the symbol is %s" (list (quote quote) (testcover-after = 1 name)))))) (lambda (name) (testcover-enter (quote my-print-symbol) (function = (lambda nil (testcover-1value 2 (list (quote message) "the symbol is %s" = (list (quote quote) (testcover-after 1 name))))))))(bar) (my-print-symbol bar) (testcover-after 3 (my-print-symbol bar)) (lambda nil (testcover-after 1 (my-print-symbol foo)) (testcover-after = 3 (my-print-symbol bar)))() testcover-enter(my-example-2 (lambda nil (testcover-after 1 = (my-print-symbol foo)) (testcover-after 3 (my-print-symbol bar)))) my-example-2() eval((my-example-2) nil) eval-expression((my-example-2) nil) funcall-interactively(eval-expression (my-example-2) nil) call-interactively(eval-expression record nil) command-execute(eval-expression record) execute-extended-command(nil "eval-expression" "eval-expression") funcall-interactively(execute-extended-command nil "eval-expression" = "eval-expression") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) --Apple-Mail=_39045FD3-01BA-4497-82A1-83E72A880CC7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 In GNU Emacs 25.1.50.4 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 = Version 10.11.6 (Build 15G1004)) of 2016-09-19 built on malolo.local Windowing system distributor 'Apple', version 10.3.1404 Recent messages: You can run the command =E2=80=98eval-expression=E2=80=99 with M-: testcover Edebug: my-lambda Edebug: my-example Eager macro-expansion failure: (error "Value of form marked with = =E2=80=981value=E2=80=99 does vary: (lambda nil (message lambda-2))") Edebug: my-print-symbol Edebug: my-example-2 Eager macro-expansion failure: (error "Value of form marked with = =E2=80=981value=E2=80=99 does vary: (message the symbol is %s (quote = bar))") You can run the command =E2=80=98testcover-start=E2=80=99 with M-x tes-s = RET Eager macro-expansion failure: (error "Value of form marked with = =E2=80=981value=E2=80=99 does vary: (message the symbol is %s (quote = bar))") Configured using: 'configure --with-ns' Configured features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils testcover edebug easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 208822 9083) (symbols 48 20772 0) (miscs 40 54 207) (strings 32 19256 5265) (string-bytes 1 616985) (vectors 16 35113) (vector-slots 8 671287 4994) (floats 8 179 99) (intervals 56 227 22) (buffers 976 12)) --Apple-Mail=_39045FD3-01BA-4497-82A1-83E72A880CC7-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 19:48:23 2017 Received: (at 24509-done) by debbugs.gnu.org; 8 Oct 2017 23:48:23 +0000 Received: from localhost ([127.0.0.1]:56864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1LJ0-00024M-Qj for submit@debbugs.gnu.org; Sun, 08 Oct 2017 19:48:22 -0400 Received: from aibo.runbox.com ([91.220.196.211]:51348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1LIz-00024F-Nc for 24509-done@debbugs.gnu.org; Sun, 08 Oct 2017 19:48:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=8d+RVZnyvaAMEEva2rJZMA1F3VGVZyLXjuDCWJzEDZg=; b=Lg4WPtYcGJxsZ4uHvL6YNJ2XrN ySMj9GALncY0P6F+7Gis6tSF7npIpL9rijTToWKgHlqN75TAO7AT8LLSvQpYNnguLso4nYzz3IXQz HyZwP5xSNA7TjQuDXgsU8pdt6Q5LxfLsC5GwOrFGfGxbXGrjplaa1d493BHsIJHdApzdxeO1e77s8 SXN/v0Xi5nFBSsQqzerolYXtBYfoi5hg2v5r8VWByVomw/8WymqzOFuUW0DDIe3+kaK09nkZCXS9t 6F3YyhkeRG8yTRndL9Lfh6S7y3K1gXEif1tqxnLzT3potbK8YOIrQp73D1mXtgOQiAcYhkxvsyTlc V+fKJeSQ==; Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1e1LIy-0005fq-VE for 24509-done@debbugs.gnu.org; Mon, 09 Oct 2017 01:48:21 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront12.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1e1LIl-0001su-AU for 24509-done@debbugs.gnu.org; Mon, 09 Oct 2017 01:48:07 +0200 From: Gemini Lasswell To: 24509-done@debbugs.gnu.org Subject: Re: bug#24509: 25.1.50; backquotes cause testcover to report 1value errors References: <3058CAD3-D2CD-4A26-8F53-FC7B38BE7176@runbox.com> Date: Sun, 08 Oct 2017 16:48:05 -0700 In-Reply-To: <3058CAD3-D2CD-4A26-8F53-FC7B38BE7176@runbox.com> (Gemini Lasswell's message of "Thu, 22 Sep 2016 08:52:28 -0700") Message-ID: <87vajpyzey.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24509-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in master, by the patch applied for bug#25316. From unknown Sun Jun 22 00:17:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Nov 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator