GNU bug report logs - #24494
24.4; Trailing comma in emacs-module.h

Previous Next

Package: emacs;

Reported by: Christopher Wellons <wellons <at> nullprogram.com>

Date: Wed, 21 Sep 2016 15:24:02 UTC

Severity: wishlist

Tags: fixed, patch

Found in version 24.4

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Christopher Wellons <wellons <at> nullprogram.com>
To: 24494 <at> debbugs.gnu.org
Subject: bug#24494: 24.4; Trailing comma in emacs-module.h
Date: Wed, 21 Sep 2016 11:22:57 -0400

Building Emacs itself now requires a C99 compiler, but this requirement
needn't extend to dynamic modules. Removing a trailing comma (see patch)
makes emacs-module.h C89/C90 compatible, allowing modules to be built
using older C compilers. Trailing commas weren't permitted until C99.

diff --git a/src/emacs-module.h b/src/emacs-module.h
--- a/src/emacs-module.h
+++ b/src/emacs-module.h
@@ -67,7 +67,7 @@ enum emacs_funcall_exit
   emacs_funcall_exit_signal = 1,

   /* Function has exit using `throw'.  */
-  emacs_funcall_exit_throw = 2,
+  emacs_funcall_exit_throw = 2
 };

 struct emacs_env_25
This bug report was last modified 7 years and 322 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.