Subject: Re: bug#24494: 24.4; Trailing comma in emacs-module.h

From: [email-masked]
Date: Sat, 01 Jul 2017 16:50:55 -0400

tags 24494 fixed
close 24494 26.1
quit

Glenn Morris <[email-masked]> writes:

> Christopher Wellons wrote:
>
>> Building Emacs itself now requires a C99 compiler, but this requirement
>> needn't extend to dynamic modules. Removing a trailing comma (see patch)
>> makes emacs-module.h C89/C90 compatible, allowing modules to be built
>> using older C compilers. Trailing commas weren't permitted until C99.
>
> Thanks for the report. I don't have an opinion, but some comments:
>
> 1) I think it's going to be hard for developers to remember to use
> different conventions for emacs-module.h, so C99-isms are likely to
> creep back in.
>
> 2) Are people really likely to be building Emacs modules with set-ups
> that can't build Emacs itself?
>
> 3) It seems this feature was supported by gcc since 0.9? Ie, forever?
> https://www.gnu.org/software/gcc/c99status.html
>
> Hopefully someone who does have an opinion will quickly either fix or
> wontfix this issue. :)

This has now been done in [1: 0489f2ca5a].

[1: 0489f2ca5a]: 2017-07-01 20:02:24 +0200
  Improve C++98 compatibility
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0489f2ca5a01445d3abb39aea18d54257fedd5f1