From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 01:56:06 2016 Received: (at submit) by debbugs.gnu.org; 20 Sep 2016 05:56:06 +0000 Received: from localhost ([127.0.0.1]:57798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmE2I-0004oL-Jm for submit@debbugs.gnu.org; Tue, 20 Sep 2016 01:56:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmE2G-0004ns-7U for submit@debbugs.gnu.org; Tue, 20 Sep 2016 01:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmE2A-0003W2-3v for submit@debbugs.gnu.org; Tue, 20 Sep 2016 01:55:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmE28-0003Vi-RM for submit@debbugs.gnu.org; Tue, 20 Sep 2016 01:55:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmE26-0001LM-LQ for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2016 01:55:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmE21-0003Uh-Eh for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2016 01:55:54 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmE1z-0003SK-0W for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2016 01:55:49 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 57A99204F9 for ; Tue, 20 Sep 2016 01:55:36 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 20 Sep 2016 01:55:36 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:message-id:mime-version:subject:to :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qDv95j9P6ZCkuFkUNQ5FwSYyM2c =; b=Ead2ncTwTC0j0lNfLHsc/qE4PCDxHOFPIHW0AyGhElWE+Rq+q8eIYeBauDq J+ALT71HHddtpvdANzah9czfeqZf3rBGFQ4GC0fa213goXOZP3XfxtI3qGIPZqoH czvjLZb85NBZWN1Gm1YTjyuRDgu2mCD0q+AJIc7VQsXZtAio= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=qD v95j9P6ZCkuFkUNQ5FwSYyM2c=; b=VmZKlXlrktylpBG6hUZX4SBBrVWUZiXaKv DMc0u+crCMMWh8XznAWZ1gLN1Q3dt4TRPhGmV4WD+2f/Mz75ctGbYbHawrjEjcnx l1Etl20MFc4yd365zajT3DnESz4J9df+QREAt4PDU/R6xPiGPGu/fm3UnjP5IMDG lCgugXexI= X-Sasl-enc: c2DRL7glqHouMaiO9R9aKQQggJLIZXAABiw6mUbi0KnT 1474350935 Received: from scrawny (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id F01F0F2988 for ; Tue, 20 Sep 2016 01:55:35 -0400 (EDT) Received: from dima by scrawny with local (Exim 4.87) (envelope-from ) id 1bmE1m-00064i-Pv for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2016 22:55:34 -0700 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: 25.1; make-mode: should '$' have punctuation syntax? Date: Mon, 19 Sep 2016 22:55:34 -0700 Message-ID: <87mvj3nmi1.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain This is a report from this emacs-devel post: https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00414.html Making a bug report to keep track of this question. The original message: I've been working with Makefiles recently, and discovered that $ has word syntax. This results in odd behaviors. For instance, if you have asdf-$(xyz) in your buffer with the point on 'a', then commands like M-s . or C-M-SPC select "asdf-$", which makes no sense. Shouldn't $ have punctuation syntax (attached patch)? Am I missing something obvious here? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=make-mode-punctuation-syntax-for-$.patch diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el index fb71420..2b4ed85 100644 --- a/lisp/progmodes/make-mode.el +++ b/lisp/progmodes/make-mode.el @@ -712,6 +712,7 @@ makefile-mode-syntax-table (modify-syntax-entry ?# "< " st) (modify-syntax-entry ?\n "> " st) (modify-syntax-entry ?= "." st) + (modify-syntax-entry ?$ "." st) st) "Syntax table used in `makefile-mode'.") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 10:30:54 2016 Received: (at 24477) by debbugs.gnu.org; 20 Sep 2016 14:30:54 +0000 Received: from localhost ([127.0.0.1]:58327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmM4S-0002JV-QY for submit@debbugs.gnu.org; Tue, 20 Sep 2016 10:30:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmM4N-0002JF-VC for 24477@debbugs.gnu.org; Tue, 20 Sep 2016 10:30:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmM4D-0001sR-80 for 24477@debbugs.gnu.org; Tue, 20 Sep 2016 10:30:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmM4D-0001ra-47; Tue, 20 Sep 2016 10:30:37 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2317 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bmM4B-0005GN-Cj; Tue, 20 Sep 2016 10:30:35 -0400 Date: Tue, 20 Sep 2016 17:30:57 +0300 Message-Id: <83bmzihcda.fsf@gnu.org> From: Eli Zaretskii To: Dima Kogan In-reply-to: <87mvj3nmi1.fsf@secretsauce.net> (message from Dima Kogan on Mon, 19 Sep 2016 22:55:34 -0700) Subject: Re: bug#24477: 25.1; make-mode: should '$' have punctuation syntax? References: <87mvj3nmi1.fsf@secretsauce.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-Debbugs-Envelope-To: 24477 Cc: 24477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) > From: Dima Kogan > Date: Mon, 19 Sep 2016 22:55:34 -0700 > > I've been working with Makefiles recently, and discovered that $ has > word syntax. This results in odd behaviors. For instance, if you have > > asdf-$(xyz) > > in your buffer with the point on 'a', then commands like M-s . or > C-M-SPC select "asdf-$", which makes no sense. Shouldn't $ have > punctuation syntax (attached patch)? Am I missing something obvious > here? Does your change still allow to type "C-x 4 a" in a line like this: asdf-$(xyz) = FOO and get a ChangeLog entry that references "asdf-$(xyz)"? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 13:00:51 2016 Received: (at 24477) by debbugs.gnu.org; 20 Sep 2016 17:00:51 +0000 Received: from localhost ([127.0.0.1]:58411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmOPb-0005vB-9R for submit@debbugs.gnu.org; Tue, 20 Sep 2016 13:00:51 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmOPZ-0005v1-3Q for 24477@debbugs.gnu.org; Tue, 20 Sep 2016 13:00:49 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A365220800; Tue, 20 Sep 2016 13:00:48 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 20 Sep 2016 13:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=0VZ9/ 7Bg91cOskefalZzSx91ZS8=; b=sa1Jgib/N3DcIInbxYX9K0X8utw7s46jeYO7e vjzFBfYViPPPhwoE92l8uRSSmftkYYsa/7iglX7qQ/RQWEsnLiem+3quJjFY+8TD uH1Gf+OCneJKh9pt5vsBNzDkgbSy05DGCYytc3nFJV6S4dErKw4+aukMoEtnaM5u 2+Skb8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=0VZ9/7Bg91cOskefalZzSx91ZS8=; b=T6Ayd hDv+mTaM9JhcKqlvaDo8NWKSxAE9I5t/hfj8XwmE0N7w6Scb9B41eQzLA3HBv3jS DHWcdk5ZpQIz1XaMzU07NdxB6VJN0Ip81+Vlajv3D5hYBxVm46LXvS0O0abU2tvf p0XubjobL+DS+k62ls5GCGqFgN63f/xBNxI/RA= X-Sasl-enc: chI3tWB9BBUU5OHe7qH0mQaRvLZxSn5X1pY+v3hGam6k 1474390848 Received: from shorty.local (unknown [128.149.110.210]) by mail.messagingengine.com (Postfix) with ESMTPA id 52F6EF2988; Tue, 20 Sep 2016 13:00:48 -0400 (EDT) Received: from dima by shorty.local with local (Exim 4.87) (envelope-from ) id 1bmOPX-0001K4-2J; Tue, 20 Sep 2016 10:00:47 -0700 References: <87mvj3nmi1.fsf@secretsauce.net> <83bmzihcda.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 25.1.1 From: Dima Kogan To: Eli Zaretskii Subject: Re: bug#24477: 25.1; make-mode: should '$' have punctuation syntax? In-reply-to: <83bmzihcda.fsf@gnu.org> Date: Tue, 20 Sep 2016 10:00:47 -0700 Message-ID: <87a8f27bgg.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24477 Cc: 24477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Does your change still allow to type "C-x 4 a" in a line like this: > > asdf-$(xyz) = FOO > > and get a ChangeLog entry that references "asdf-$(xyz)"? It appears to, yes. From debbugs-submit-bounces@debbugs.gnu.org Tue May 15 20:18:03 2018 Received: (at 24477) by debbugs.gnu.org; 16 May 2018 00:18:03 +0000 Received: from localhost ([127.0.0.1]:36138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIk8o-0008T9-Ro for submit@debbugs.gnu.org; Tue, 15 May 2018 20:18:03 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:54032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIk8m-0008SZ-Lk; Tue, 15 May 2018 20:18:01 -0400 Received: by mail-it0-f68.google.com with SMTP id n64-v6so6159610itb.3; Tue, 15 May 2018 17:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=h+5lnEduEJj9ivyQkcWR0nBqSx0EFzkanew9Sc2zxzA=; b=eKOLtAyqwbAOAfnKvqCtWILo0UaN5Bjyx/AW3HpEr4jTqaf2lE1d+0X1fUvdbG6tOg sZn9gedJSVqo2SV2FFceBbrlXliK1B/t+AN0J7omVTQDwJqgmiFYfpEAdGNQhBKAuOaX f0i6qWkYW22GaKuLHp0zv+EqUjfXIlgWsMLSmXpdyGE+CeKfMuU4fODEgM1I1G3XxH7T 5uXD5s147TP8AdcLCif3wOyBmgGDB+VVtCKNuhuHHpewk2Bz8h6ehXzaNEpEmsNn1Si3 m6Rfv8/Cxfrd26V9WNamJammOW4pc2/XPdGUYLh5ctl1b7MH7oxLHnZeuGECN+NNtllV VdWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=h+5lnEduEJj9ivyQkcWR0nBqSx0EFzkanew9Sc2zxzA=; b=X9owMvhWLXKy+XJH4NVEFbR0bQG1db9GAFv/NkcMDvIPPwP2xETjNGMycbMhVR7fhe +pz/6ziMrWPRQvL/Y0/0XD7lZoj7oRKRbVZ9tKqnph4ofxJAulzz9E4O6zyYHFAzXlsW Pebqi6ODJE45RMedXQf2KDOkXDH9MV/iB4gjPa73amvMifR2jk+00FsA3RiL5uy7fH25 Q1QV6sVoYbXmdz2vrFLihHTog8/8OAbf6OlXQAo0oD0UQ1AiRZ9kBf7wUaGXnYxQhNyK 9wYyZHM/oS6JoDwIToSmn5hRHlxp+UkfRSyBa1Kp7IUsT0Yoskd/wfS8WEqEvaLXDezT L5Tg== X-Gm-Message-State: ALKqPwdj0OGxk268H9y4g4dUf+rIB2RNq7vMhuJZkNXoEzsKRM0QZWWz IFEXjgynypnOBqM+0cG5/4GzXA== X-Google-Smtp-Source: AB8JxZrYhIwDibT12RSc0rgxRjUWrmnmkY4cTTadAirsQNolj4+wPLAQuxgj1Ke2L8OGzGq+NPw7OQ== X-Received: by 2002:a24:4151:: with SMTP id x78-v6mr206538ita.0.1526429875214; Tue, 15 May 2018 17:17:55 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z203-v6sm718714ioe.77.2018.05.15.17.17.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 17:17:54 -0700 (PDT) From: Noam Postavsky To: Dima Kogan Subject: Re: bug#24477: 25.1; make-mode: should '$' have punctuation syntax? References: <87mvj3nmi1.fsf@secretsauce.net> <83bmzihcda.fsf@gnu.org> <87a8f27bgg.fsf@secretsauce.net> Date: Tue, 15 May 2018 20:17:53 -0400 In-Reply-To: <87a8f27bgg.fsf@secretsauce.net> (Dima Kogan's message of "Tue, 20 Sep 2016 10:00:47 -0700") Message-ID: <877eo4jvwu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24477 Cc: Eli Zaretskii , 24477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 24477 fixed close 24477 27.1 quit Dima Kogan writes: > Eli Zaretskii writes: > >> Does your change still allow to type "C-x 4 a" in a line like this: >> >> asdf-$(xyz) = FOO >> >> and get a ChangeLog entry that references "asdf-$(xyz)"? > > It appears to, yes. `makefile-add-log-defun' doesn't consult the syntax table, it uses only regexps (which don't use the \sSYNTAX construct, as far as I can tell). Anyway, there seems to be no reason not to make this change, so I've pushed it in master. [1: 4c3cd27df9]: 2018-05-15 19:33:34 -0400 Give '$' punctuation syntax in make-mode (Bug#24477) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4c3cd27df9c0735d907813a8c16a87acc54b9edc From unknown Sat Sep 06 14:23:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Jun 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator