GNU bug report logs - #24477
25.1; make-mode: should '$' have punctuation syntax?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24477 in the body.
You can then email your comments to 24477 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; make-mode: should '$' have punctuation syntax?
Date: Mon, 19 Sep 2016 22:55:34 -0700

[Message part 1 (text/plain, inline)]

This is a report from this emacs-devel post:

    https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00414.html

Making a bug report to keep track of this question. The original
message:

I've been working with Makefiles recently, and discovered that $ has
word syntax. This results in odd behaviors. For instance, if you have

    asdf-$(xyz)

in your buffer with the point on 'a', then commands like M-s . or
C-M-SPC select "asdf-$", which makes no sense. Shouldn't $ have
punctuation syntax (attached patch)? Am I missing something obvious
here?

[make-mode-punctuation-syntax-for-$.patch (text/x-diff, inline)]

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index fb71420..2b4ed85 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -712,6 +712,7 @@ makefile-mode-syntax-table
     (modify-syntax-entry ?#  "<     " st)
     (modify-syntax-entry ?\n ">     " st)
     (modify-syntax-entry ?= "." st)
+    (modify-syntax-entry ?$ "." st)
     st)
   "Syntax table used in `makefile-mode'.")
 

Message #8 received at 24477 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 24477 <at> debbugs.gnu.org
Subject: Re: bug#24477: 25.1; make-mode: should '$' have punctuation syntax?
Date: Tue, 20 Sep 2016 17:30:57 +0300

> From: Dima Kogan <dima <at> secretsauce.net>
> Date: Mon, 19 Sep 2016 22:55:34 -0700
> 
> I've been working with Makefiles recently, and discovered that $ has
> word syntax. This results in odd behaviors. For instance, if you have
> 
>     asdf-$(xyz)
> 
> in your buffer with the point on 'a', then commands like M-s . or
> C-M-SPC select "asdf-$", which makes no sense. Shouldn't $ have
> punctuation syntax (attached patch)? Am I missing something obvious
> here?

Does your change still allow to type "C-x 4 a" in a line like this:

asdf-$(xyz) = FOO

and get a ChangeLog entry that references "asdf-$(xyz)"?

Message #11 received at 24477 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24477 <at> debbugs.gnu.org
Subject: Re: bug#24477: 25.1; make-mode: should '$' have punctuation syntax?
Date: Tue, 20 Sep 2016 10:00:47 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> Does your change still allow to type "C-x 4 a" in a line like this:
>
> asdf-$(xyz) = FOO
>
> and get a ChangeLog entry that references "asdf-$(xyz)"?

It appears to, yes.

Message #14 received at 24477 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24477 <at> debbugs.gnu.org
Subject: Re: bug#24477: 25.1; make-mode: should '$' have punctuation syntax?
Date: Tue, 15 May 2018 20:17:53 -0400

tags 24477 fixed
close 24477 27.1
quit

Dima Kogan <dima <at> secretsauce.net> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> Does your change still allow to type "C-x 4 a" in a line like this:
>>
>> asdf-$(xyz) = FOO
>>
>> and get a ChangeLog entry that references "asdf-$(xyz)"?
>
> It appears to, yes.

`makefile-add-log-defun' doesn't consult the syntax table, it uses only
regexps (which don't use the \sSYNTAX construct, as far as I can tell).

Anyway, there seems to be no reason not to make this change, so I've
pushed it in master.

[1: 4c3cd27df9]: 2018-05-15 19:33:34 -0400
  Give '$' punctuation syntax in make-mode (Bug#24477)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4c3cd27df9c0735d907813a8c16a87acc54b9edc

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.