GNU bug report logs - #24457
[PATCH] sed: use dfa matcher for regex with anchor

Previous Next

To reply to this bug, email your comments to 24457 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: <bug-sed <at> gnu.org>
Subject: [PATCH] sed: use dfa matcher for regex with anchor
Date: Sun, 18 Sep 2016 18:00:38 +0900

[Message part 1 (text/plain, inline)]

Recently, dfa module started to support that newline_anchor option is
set to false.

sed could not use dfa fully up to now, as sed sets newline_anchor to
false in many cases.

This change is that sed uses dfa even if newline_anchor option is false.

[0001-sed-use-dfa-matcher-for-regex-with-anchor.patch (text/plain, attachment)]

Message #8 received at 24457 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 24457 <at> debbugs.gnu.org
Subject: Re: bug#24457: [PATCH] sed: use dfa matcher for regex with anchor
Date: Sun, 06 Nov 2016 23:26:23 +0900

[Message part 1 (text/plain, inline)]

On Sun, 18 Sep 2016 18:00:38 +0900
Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

> Recently, dfa module started to support that newline_anchor option is
> set to false.
> 
> sed could not use dfa fully up to now, as sed sets newline_anchor to
> false in many cases.
> 
> This change is that sed uses dfa even if newline_anchor option is false.

Hi,

I rebased the patch.

Norihiro

[0001-sed-use-dfa-matcher-for-regex-with-anchor.patch (text/plain, attachment)]

Message #11 received at 24457 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 24457 <at> debbugs.gnu.org
Subject: Re: bug#24457: [PATCH] sed: use dfa matcher for regex with anchor
Date: Wed, 9 Nov 2016 10:34:22 -0500

Hello,

> On Nov 6, 2016, at 09:26, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> 
> I rebased the patch.
> 
> Norihiro
> <0001-sed-use-dfa-matcher-for-regex-with-anchor.patch>

Thanks for the continued improvements!

Could it be that the test files are missing from this patch (testsuite/anchor.{sed,good,inp}) ?

-assaf

Message #14 received at 24457 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 24457 <at> debbugs.gnu.org
Subject: Re: bug#24457: [PATCH] sed: use dfa matcher for regex with anchor
Date: Thu, 10 Nov 2016 22:30:12 +0900

[Message part 1 (text/plain, inline)]

On Wed, 9 Nov 2016 10:34:22 -0500
Assaf Gordon <assafgordon <at> gmail.com> wrote:

> Hello,
> 
> > On Nov 6, 2016, at 09:26, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> > 
> > I rebased the patch.
> > 
> > Norihiro
> > <0001-sed-use-dfa-matcher-for-regex-with-anchor.patch>
> 
> Thanks for the continued improvements!
> 
> Could it be that the test files are missing from this patch (testsuite/anchor.{sed,good,inp}) ?
> 
> -assaf
> 

Hi Assaf,

Thanks for reviewing.  I leaved them, and now added them.

Norihiro

[0001-sed-use-dfa-matcher-for-regex-with-anchor.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.