GNU bug report logs - #24439
ispell.el; cutom setting `ispell-library-directory'; patch

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24439: closed (ispell.el; cutom setting `ispell-library-directory';
 patch)
Date: Sat, 08 Oct 2016 12:19:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 08 Oct 2016 15:18:36 +0300
with message-id <83zimfghk3.fsf <at> gnu.org>
and subject line Re: bug#24439: ispell.el; cutom setting `ispell-library-directory'; patch
has caused the debbugs.gnu.org bug report #24439,
regarding ispell.el; cutom setting `ispell-library-directory'; patch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24439: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24439
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Laimonas Vėbra <laimonas.vebra <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: ispell.el; cutom setting `ispell-library-directory'; patch
Date: Wed, 14 Sep 2016 23:02:03 +0300

[Message part 3 (text/plain, inline)]

Hello,

On Windows if one uses cygwin ispell, then one should fix ispell LIBDIR 
(which is not correct absolute path) relative to cygwin root by setting 
`ispell-library-directory'. Or one also might wish to use custom 
location of dictionaries.
Currently ispell.el breaks this possibiliity, because it resets
`ispell-library-directory' to possibly incorrect or unwanted ispell 
LIBDIR on every ispell call. Suggested patch attached.

I'm not sure if it doesn't break something (that's why i'm asking in 
patch comments), but AFAICS it shouldn't.
Could someone familiar with ispell.el overview and comment on this tiny 
patch?

[ispell.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Agustin Martin <agustin6martin <at> gmail.com>
Cc: 24439-done <at> debbugs.gnu.org, laimonas.vebra <at> yahoo.com
Subject: Re: bug#24439: ispell.el; cutom setting `ispell-library-directory';
 patch
Date: Sat, 08 Oct 2016 15:18:36 +0300

> From: Agustin Martin <agustin6martin <at> gmail.com>
> Date: Sat, 8 Oct 2016 13:30:50 +0200
> Cc: Laimonas Vėbra <laimonas.vebra <at> yahoo.com>
> 
> Hi, Eli
> 
> I had a look at your patch and it looks really fine, thanks for caring about this.

(It's not my patch, it was written by Laimonas.)

> I have also run some tests with it, and seems to work very well regarding dictionary selection. Did not check
> actual spellchecking (Checked with an old 24.4.1 where at least a function is not available, but could at least
> check that lists of available dictionaries)

Thanks for the review.  I pushed this to the master branch (in
Laimonas's name), and I'm marking this bug done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.