From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 16:03:36 2016 Received: (at submit) by debbugs.gnu.org; 12 Sep 2016 20:03:36 +0000 Received: from localhost ([127.0.0.1]:57967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjXS4-0004Z5-3q for submit@debbugs.gnu.org; Mon, 12 Sep 2016 16:03:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjXS3-0004Yt-HA for submit@debbugs.gnu.org; Mon, 12 Sep 2016 16:03:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjXRx-0002x2-IU for submit@debbugs.gnu.org; Mon, 12 Sep 2016 16:03:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjXRx-0002wA-GS for submit@debbugs.gnu.org; Mon, 12 Sep 2016 16:03:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjXRv-0006zq-DP for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 16:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjXRr-0002uT-FE for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 16:03:27 -0400 Received: from vaj.namazu.org ([202.221.179.42]:53782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjXRr-0002ti-75 for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 16:03:23 -0400 Received: from vaj.namazu.org (vaj.namazu.org [202.221.179.42]) by vaj.namazu.org (Postfix) with ESMTP id E249F263F9A; Tue, 13 Sep 2016 05:03:19 +0900 (JST) From: TSUCHIYA Masatoshi To: bug-gnu-emacs@gnu.org Subject: Proposal to set buffer not-modified when downloading a sieve script X-Cite-Me: =?iso-2022-jp?B?GyRCRVobKEI=?= Date: Mon, 12 Sep 2016 16:03:18 -0400 Message-ID: <87fup4sx6h.fsf@tsuchiya.vaj.namazu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Because sieve-edit-script() does not set buffer not-modified when downloading a sieve script, so, a user including muself cannot distinguish whether the viewing script is modified or not modified from the downloaded script on the managesieve server. If sieve-edit-script() set buffer not-modified when downloading a sieve script, a user can distinguish its modified status easily. Therefore, I propose the following patch. =2D-=20 TSUCHIYA Masatoshi --=-=-= Content-Type: text/x-diff Content-Disposition: inline --- a/lisp/sieve.el +++ b/lisp/sieve.el @@ -207,7 +207,8 @@ require \"fileinto\"; err) (setq err (sieve-manage-getscript name newbuf sieve-manage-buffer)) (switch-to-buffer newbuf) - (unless (sieve-manage-ok-p err) + (if (sieve-manage-ok-p err) + (set-buffer-modified-p nil) (error "Sieve download failed: %s" err))) (switch-to-buffer (get-buffer-create "template.siv")) (insert sieve-template)) --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlfXCgYACgkQ+Iw/tfZVWLI0OQCgpSiYaqn65Z6EYfgq5XyijOMZ imoAoLzzNkm/G21cmIxzYthg14bjo9mW =5oM6 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 19:08:51 2016 Received: (at 24423-done) by debbugs.gnu.org; 12 Sep 2016 23:08:51 +0000 Received: from localhost ([127.0.0.1]:58025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjaLK-00025W-VT for submit@debbugs.gnu.org; Mon, 12 Sep 2016 19:08:51 -0400 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:36777 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjaLJ-00025J-OF for 24423-done@debbugs.gnu.org; Mon, 12 Sep 2016 19:08:49 -0400 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60001 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1bjaLC-000mah-ES; Mon, 12 Sep 2016 18:08:43 -0500 Date: Tue, 13 Sep 2016 08:08:45 +0900 Message-ID: From: Katsumi Yamaoka To: tsuchiya@namazu.org Subject: Re: bug#24423: Proposal to set buffer not-modified when downloading a sieve script References: <87fup4sx6h.fsf@tsuchiya.vaj.namazu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) Cancel-Lock: sha1:OFmB+0BbVocr9uIkM5eDcG8kJ70= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24423-done Cc: 24423-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, 12 Sep 2016 16:03:18 -0400, TSUCHIYA Masatoshi wrote: > Because sieve-edit-script() does not set buffer not-modified when > downloading a sieve script, so, a user including muself cannot > distinguish whether the viewing script is modified or not modified from > the downloaded script on the managesieve server. > If sieve-edit-script() set buffer not-modified when downloading a sieve > script, a user can distinguish its modified status easily. > Therefore, I propose the following patch. The patch looks fine and useful. I've committed it in the Emacs master with this log entry: sieve.el: Make the buffer to edit unmodified initially (bug#24423) * lisp/net/sieve.el (sieve-edit-script): Make the buffer to edit be not modified-p initially (bug#24423). Thanks. From unknown Sat Jun 21 05:14:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 11 Oct 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator