From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 00:34:45 2016 Received: (at submit) by debbugs.gnu.org; 11 Sep 2016 04:34:45 +0000 Received: from localhost ([127.0.0.1]:55886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biwTc-0007Of-NJ for submit@debbugs.gnu.org; Sun, 11 Sep 2016 00:34:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biwTb-0007OT-Ab for submit@debbugs.gnu.org; Sun, 11 Sep 2016 00:34:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biwTV-0002HW-14 for submit@debbugs.gnu.org; Sun, 11 Sep 2016 00:34:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biwTU-0002HG-Tg for submit@debbugs.gnu.org; Sun, 11 Sep 2016 00:34:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biwTS-0003tn-74 for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 00:34:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biwTO-0002GK-6a for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 00:34:34 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biwTN-0002DW-VK for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 00:34:30 -0400 Received: by mail-pa0-f65.google.com with SMTP id ez1so5949837pab.3 for ; Sat, 10 Sep 2016 21:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version; bh=jSfUgTT7a71+LlTy8BKRuP333TuoK6/OD9a/gmzSTws=; b=v32LoQ7GSvGqil6MKtRUpuyulycMyAjvMIhi+Gu+GAPoZTu6PTELpX0ZPnWjr8WAj4 CmpPFOedaKGpyvZmEa8fgdfohQ/Du5IPd5+L4bWVmfd+F5LVLJ3Z6hfwFiiKmz3KG1CC 4/ClydXutTcNGBnuA/mH8LrYkdWSMFM329yheSp8v8ozOyh/KleikFVppKzMwn84EyI3 OX0ZMWucoy1byZriwPt5lBLzOhxarFl0yHKutsEcDiwUBhEzCcMPojkrSiaHHnvsG8fe cU+N1XSmWMfiDLXX6rPk0eLB67D8jfGo2Uwula21WBZuwtPq1QOZLEI+6FQIPhF8H+tv kRLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:user-agent :mime-version; bh=jSfUgTT7a71+LlTy8BKRuP333TuoK6/OD9a/gmzSTws=; b=Xd97dbE4noEzsbj9v/67R1NW6UFuLwDca9jywX9/xOADHB9mC43u/sQnzF3xKcA6FV ZQCnqz+u8cBDQxM0+j7v8KMc5mcGpG6fHjcKErbsrH944O1F86GTI1Lu1qMsVpW75Lop ADFL3dTvilRLUg0cTuskQ1YnHhupGL/9VkuFjLUwKFYt0UODHBzfXn2S4bZvYnjwZFlf bTyaR0dGLkqlQHxDsPG8/SDxBKOlV+Rl07Zw+orks59S0pr/CFsZL3ypRQ6Y5kMwJuPT vhT7S4ixpBUo5EmIjOjtmdArtxkLadEdIXEeyD7E+ab7DVMpRvH7ZKNK6j+3syuewZlu 17sQ== X-Gm-Message-State: AE9vXwMKnGoFnXm8C4MYOx8QGKkSchUpn2Bt2d5Qhj16YCQWStN5UgNUHUyxutxAmtDiMg== X-Received: by 10.66.5.137 with SMTP id s9mr12877598pas.151.1473568387712; Sat, 10 Sep 2016 21:33:07 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id s63sm15158621pfb.52.2016.09.10.21.33.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Sep 2016 21:33:07 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 11 Sep 2016 13:33:04 +0900 (JST) X-X-Sender: calancha@calancha-pc To: bug-gnu-emacs@gnu.org Subject: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q -eval "(require 'dired-x)" ;; Assumed you have Emacs source code in `source-directory'. ;; Following should visit `lisp' on Dired and set point on `simple.el'. M-: (find-file (expand-file-name (concat "lisp/dired-x.el") source-directory)) RET C-u C-x C-j simple.el RET *) The first patch just fix this bug. *) The second patch makes to work following non-interactive call: (dired-jump nil (abbreviate-file-name (expand-file-name (concat "lisp/dired-x.el") source-directory))) ;; i.e., accepts an UNIX file-name as: "~/foo/bar ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From e7a5a0534ac3f2bb624acb855ddbdbb8cd04c7a3 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sun, 11 Sep 2016 13:14:28 +0900 Subject: [PATCH] dired-jump: Expand file-name after read-file-name call Fix Bug#24409. * lisp/dired-x.el (dired-jump): --- lisp/dired-x.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index 088ca81..7c65a2c 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -413,11 +413,12 @@ dired-jump In case the proper Dired file line cannot be found, refresh the dired buffer and try again. When OTHER-WINDOW is non-nil, jump to Dired buffer in other window. -Interactively with prefix argument, read FILE-NAME and -move to its line in dired." +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. +Interactively with prefix argument, read FILE-NAME." (interactive (list nil (and current-prefix-arg - (read-file-name "Jump to Dired file: ")))) + (expand-file-name + (read-file-name "Jump to Dired file: "))))) (if (bound-and-true-p tar-subfile-mode) (switch-to-buffer tar-superior-buffer) (let* ((file (or file-name buffer-file-name)) -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 713d23fd2a0c798df265e29a21d1bd04f483f1b0 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sun, 11 Sep 2016 13:15:26 +0900 Subject: [PATCH] dired-jump: Make sure file-name is expanded * lisp/dired-x.el (dired-jump): Use expand-file-name on FILE-NAME before call dired-goto-file (Bug#24409). --- lisp/dired-x.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index 088ca81..4470a2c 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -413,14 +413,16 @@ dired-jump In case the proper Dired file line cannot be found, refresh the dired buffer and try again. When OTHER-WINDOW is non-nil, jump to Dired buffer in other window. -Interactively with prefix argument, read FILE-NAME and -move to its line in dired." +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. +Interactively with prefix argument, read FILE-NAME." (interactive (list nil (and current-prefix-arg - (read-file-name "Jump to Dired file: ")))) + (expand-file-name + (read-file-name "Jump to Dired file: "))))) (if (bound-and-true-p tar-subfile-mode) (switch-to-buffer tar-superior-buffer) - (let* ((file (or file-name buffer-file-name)) + (let* ((file (or (and file-name (expand-file-name file-name)) + buffer-file-name)) (dir (if file (file-name-directory file) default-directory))) (if (and (eq major-mode 'dired-mode) (null file-name)) (progn -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.21.5) of 2016-09-10 Repository revision: 0bbdeed10f37d4ce203e1f5feb0cd7c4b5eeec72 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 00:42:50 2016 Received: (at 24409) by debbugs.gnu.org; 11 Sep 2016 04:42:50 +0000 Received: from localhost ([127.0.0.1]:55891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biwbS-0007gh-KA for submit@debbugs.gnu.org; Sun, 11 Sep 2016 00:42:50 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:35029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biwbQ-0007gU-Po for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 00:42:49 -0400 Received: by mail-oi0-f54.google.com with SMTP id d191so19948235oih.2 for <24409@debbugs.gnu.org>; Sat, 10 Sep 2016 21:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6FPMzd+cAvrPBkmeRYfIU9fWGlIexUtJW0NIpxLzbdM=; b=avDYwE3HhnqUsO75JkJ41IbOyErHsFDf6RHGu7WQZvdzVCCR3tlhhCk9py2aiMQKlV c5gTGZV5s/ukgxSQZAxd6ohvo2h2rE+NaWJl5Pjl1dwiPEo1MAuEcvdDEtPk84iF8S26 LXJjwlHYBqb2cS9xry2SVaBTv2Yow77pQalN7eq7mrT6PmLUmixBCfyTM+DmztKQ7h87 AeeriS2Vyu7UUtoWivMcfD+aGFGJ1+/q8McBYp0d2QjLoo0+aRZsMkWd4uEVM0h2X3vz KlUPgOkQCoRlgwcRykDXbFQFYwO6s1H1XQ4WsGSW4kuRlL6A+qsszQwfYxnPrBqhN4Gu tk0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6FPMzd+cAvrPBkmeRYfIU9fWGlIexUtJW0NIpxLzbdM=; b=U8JpzqDJ7EUgSk8UU3RwRX6MRgotLKUs+U1DHFpxjIPG5DjMqr6OjjTUAQ551uefxP AlJnwjTPL3J1MbMhA8Qjy/FXR6gZJv8rFMJxeu5VL2acQgWI6T26ozWJuKx96dfhpoSf 5HpB9IbxI3aC0wFHHuhmNTv32ZmXetRYMk0IWVnuuv9OonAV+TNWyvMQ5lsJ+G3v/tGF 7LWPDzguIHBDVH6HEu5dvML0vpto47R3ZHoHVoyRTyVQdxkFGHs2YkcgpjcqoGF3xqAO +cEixUldcmcIi8Xom89WvNX0KSXtGgEUYJIp9Rk3jI3jBZTwMPK8Dtw0xR5sC4rEWI/f ys4w== X-Gm-Message-State: AE9vXwMfzBkmUwPEB31hLRWXEwpdXaMdbKeqiSBTbRkteOtpU1/uSIX7HiRJ8WeI1UTHejRfsVufHoOSSTmvlQ== X-Received: by 10.202.242.214 with SMTP id q205mr16072217oih.60.1473568963271; Sat, 10 Sep 2016 21:42:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.41.144 with HTTP; Sat, 10 Sep 2016 21:42:42 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Sun, 11 Sep 2016 00:42:42 -0400 X-Google-Sender-Auth: _QKKqEPJaJOhpAXEepnyY3FQmDw Message-ID: Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line To: Tino Calancha Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, Sep 11, 2016 at 12:33 AM, Tino Calancha wrote: > (interactive > (list nil (and current-prefix-arg > - (read-file-name "Jump to Dired file: ")))) > + (expand-file-name > + (read-file-name "Jump to Dired file: "))))) > (if (bound-and-true-p tar-subfile-mode) > (switch-to-buffer tar-superior-buffer) > - (let* ((file (or file-name buffer-file-name)) > + (let* ((file (or (and file-name (expand-file-name file-name)) > + buffer-file-name)) [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.54 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.218.54 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.54 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, Sep 11, 2016 at 12:33 AM, Tino Calancha wrote: > (interactive > (list nil (and current-prefix-arg > - (read-file-name "Jump to Dired file: ")))) > + (expand-file-name > + (read-file-name "Jump to Dired file: "))))) > (if (bound-and-true-p tar-subfile-mode) > (switch-to-buffer tar-superior-buffer) > - (let* ((file (or file-name buffer-file-name)) > + (let* ((file (or (and file-name (expand-file-name file-name)) > + buffer-file-name)) [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.218.54 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.54 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.54 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid On Sun, Sep 11, 2016 at 12:33 AM, Tino Calancha wrote: > (interactive > (list nil (and current-prefix-arg > - (read-file-name "Jump to Dired file: ")))) > + (expand-file-name > + (read-file-name "Jump to Dired file: "))))) > (if (bound-and-true-p tar-subfile-mode) > (switch-to-buffer tar-superior-buffer) > - (let* ((file (or file-name buffer-file-name)) > + (let* ((file (or (and file-name (expand-file-name file-name)) > + buffer-file-name)) Doesn't the second `expand-file-name` call make the first one redundant? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 00:50:16 2016 Received: (at 24409) by debbugs.gnu.org; 11 Sep 2016 04:50:16 +0000 Received: from localhost ([127.0.0.1]:55895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biwie-0007rQ-CI for submit@debbugs.gnu.org; Sun, 11 Sep 2016 00:50:16 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:34006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biwic-0007rE-Q9 for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 00:50:15 -0400 Received: by mail-pf0-f173.google.com with SMTP id p64so42109071pfb.1 for <24409@debbugs.gnu.org>; Sat, 10 Sep 2016 21:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/yykvPWmlAZwxjRY/7QTDEP+OBPOCHaD+iejEDRRjvI=; b=ZJcmLxedB4Bbdq9nqTptHxy8itlkHdjsfOutIGQrNJQAulN6Wmzl1O+swQ0ok1Pep0 tEHeuD3CwpkErtwBaowAcZYHR9y0zGiTteitTLat4im9Ed4flj3pBnwzbFDSqn0wMfe+ ubizGqE2d4GDA7US5cgyYsp+eOm7/A5uCa1saZC1vyRkeOCUJzzTCLWliSDqZ5SUywKs 7qOkr+PB4nYSV0qX5tH2qawAhHFpoUbFHnJWGnEASPAag00tryuj9mv45DY+wr5Y9Vc5 MWGquJjsSYrjITiQsDNJ/LMGXJjH16Nd9THaswiCmeCJVUV9fDShd1euhYv+O4dC4HMo LU2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/yykvPWmlAZwxjRY/7QTDEP+OBPOCHaD+iejEDRRjvI=; b=OaDLBgK0eqGtWH5EYg9DBjrGP1DbcdnGr3lyCly6y5aVZB7ZbtCoBa14XxXZez4KMT 1n2fWZDpg1svpOzdA2KGkf87hPnqcSlTLWZqkw5OsH8+h9Hzp2UMKBZvSJlybRwj6+58 6hYm978aGnpNCbr14bMwosqCweB6ylzGV0rUxIYPA0/yds9HGpdwtTDMb+kzQIW2x6P1 +F/j3Qt5/XGPhX/QW6/6sGPmCtm2Ogm1WSQuAW8tS7JFINXOlB5V5zF/jEXe8P67Sv6C 7ewnymaPrnCsPmwCy+iXsVl6V7W2yBKca7yo5W8dZzdo7mEs7iFVoVfYrUzwxOLfqNpf /hgQ== X-Gm-Message-State: AE9vXwO+P7hO2mRyPCVjnE5f9td4TT5Au1nu3LbJe2V9oeuWOTTlZ+rCX9Wyipgk8SD+ug== X-Received: by 10.98.19.196 with SMTP id 65mr21234029pft.121.1473569408888; Sat, 10 Sep 2016 21:50:08 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id xn11sm15245712pac.38.2016.09.10.21.50.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Sep 2016 21:50:08 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 11 Sep 2016 13:50:04 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Noam Postavsky Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 11 Sep 2016, Noam Postavsky wrote: > On Sun, Sep 11, 2016 at 12:33 AM, Tino Calancha wrote: >> (interactive >> (list nil (and current-prefix-arg >> - (read-file-name "Jump to Dired file: ")))) >> + (expand-file-name >> + (read-file-name "Jump to Dired file: "))))) >> (if (bound-and-true-p tar-subfile-mode) >> (switch-to-buffer tar-superior-buffer) >> - (let* ((file (or file-name buffer-file-name)) >> + (let* ((file (or (and file-name (expand-file-name file-name)) >> + buffer-file-name)) > > Doesn't the second `expand-file-name` call make the first one redundant? Absolutely. Thank you! Following is the corrected second patch: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From f4b0e30a79e4d2c959931d9baec7ce72cd67c935 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sun, 11 Sep 2016 13:47:50 +0900 Subject: [PATCH] dired-jump: Make sure file-name is expanded * lisp/dired-x.el (dired-jump): Use expand-file-name on FILE-NAME before call dired-goto-file (Bug#24409). --- lisp/dired-x.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index 088ca81..2ab9562 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -413,14 +413,15 @@ dired-jump In case the proper Dired file line cannot be found, refresh the dired buffer and try again. When OTHER-WINDOW is non-nil, jump to Dired buffer in other window. -Interactively with prefix argument, read FILE-NAME and -move to its line in dired." +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. +Interactively with prefix argument, read FILE-NAME." (interactive (list nil (and current-prefix-arg (read-file-name "Jump to Dired file: ")))) (if (bound-and-true-p tar-subfile-mode) (switch-to-buffer tar-superior-buffer) - (let* ((file (or file-name buffer-file-name)) + (let* ((file (or (and file-name (expand-file-name file-name)) + buffer-file-name)) (dir (if file (file-name-directory file) default-directory))) (if (and (eq major-mode 'dired-mode) (null file-name)) (progn -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.21.5) of 2016-09-10 Repository revision: 0bbdeed10f37d4ce203e1f5feb0cd7c4b5eeec72 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 11:37:01 2016 Received: (at 24409) by debbugs.gnu.org; 11 Sep 2016 15:37:02 +0000 Received: from localhost ([127.0.0.1]:56573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj6oX-0001O1-OI for submit@debbugs.gnu.org; Sun, 11 Sep 2016 11:37:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj6oW-0001Np-Fl for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 11:37:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bj6oO-0005qc-AN for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 11:36:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj6oO-0005qJ-6j; Sun, 11 Sep 2016 11:36:52 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1138 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bj6oM-000759-D4; Sun, 11 Sep 2016 11:36:50 -0400 Date: Sun, 11 Sep 2016 18:36:51 +0300 Message-Id: <83a8febg8c.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Sun, 11 Sep 2016 13:33:04 +0900 (JST)) Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.2 (-------) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.2 (-------) > From: Tino Calancha > Date: Sun, 11 Sep 2016 13:33:04 +0900 (JST) > > > emacs -Q -eval "(require 'dired-x)" > > ;; Assumed you have Emacs source code in `source-directory'. > ;; Following should visit `lisp' on Dired and set point on `simple.el'. > M-: (find-file (expand-file-name (concat "lisp/dired-x.el") > source-directory)) RET > C-u C-x C-j simple.el RET > > *) The first patch just fix this bug. Thanks. A few nits: Please be sure to explain the need for the expand-file-name call either in a comment or in the log message. Also, you fixed the do string (thanks!), but didn't mention that in the log message. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 13:03:24 2016 Received: (at 24409) by debbugs.gnu.org; 11 Sep 2016 17:03:24 +0000 Received: from localhost ([127.0.0.1]:56666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8A8-0003Wr-9W for submit@debbugs.gnu.org; Sun, 11 Sep 2016 13:03:24 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8A6-0003Wb-T1 for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 13:03:23 -0400 Received: by mail-pa0-f53.google.com with SMTP id id6so43468865pad.3 for <24409@debbugs.gnu.org>; Sun, 11 Sep 2016 10:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=YqXwn9jkoRf5OJFH/hwcMj0FUKgB2wFmi9FbPcNVC5k=; b=SfkFxJfIdAQFcStnTf0O7fjbayj9hBpf0gzOLgbMwAJPlbirwYDJODPpbMoj4YoFov N3RfYyLEzSv5nA5WqyiHs30Ej2Ywx7PO4yXSSmZDDr1XXNw9dOAFfvrP8OHHrHbPWyoP 15mwKsUM3+1lDxvs+0VspAb+6eWQPKtkapN+u7g8rao1iy3t/d78vGQibdvCmvaG1Z4E 7ntmn1h/r2NDwJk+lm6cbPp4/TBO/2QsqF+gDonWL7U9oNZ6RNqxqWOiPv1PmBmq0k4j e3TigBwcMg6wGAO+1tlkqTNryqUvF5n6JduN/MSXZio04RFhGXfRk42g99A72GYOqCcD 4Zxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=YqXwn9jkoRf5OJFH/hwcMj0FUKgB2wFmi9FbPcNVC5k=; b=mYkEmXrKm2OEN6HGqB+im5opKM6vCJgfHYt9JbOo5SXfrKtnBorHwGPA7VJP/jfO6j ADaurGldA0G9hDgdwkNr37JvS3YNRbzUzXgTjEbznOZxOQQiekIOyUCMnz+2kkJ2HfCN AbLTUfO/ZW9cnuehhZGzeEWhIn/p1928EKckTzmqpgmXefc+XcIA8iS3eh5U+jONTr3H xFiggWCDHSV5hX4b/DjRhV6oJQzc4+rE/b+dWHlji7wTP6uoT6WKDlTmr6YCWrGgAq/0 2D5z0/wne3HHk5gyP4oJxoT7Ux3Xd4NCHbaKETDcFSJYI6QAEI1M1MqkUG/jO7BuRB/2 0LUQ== X-Gm-Message-State: AE9vXwNU1ChqR4AO8/X08pqzi/Bu91oKqEcEJZFq3T2evNiKz5lHhkM1oUX2xjpBAUV3ng== X-Received: by 10.66.220.106 with SMTP id pv10mr25574633pac.81.1473613397083; Sun, 11 Sep 2016 10:03:17 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id 7sm18691907pfk.6.2016.09.11.10.03.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Sep 2016 10:03:16 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Mon, 12 Sep 2016 02:03:14 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line In-Reply-To: <83a8febg8c.fsf@gnu.org> Message-ID: References: <83a8febg8c.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 11 Sep 2016, Eli Zaretskii wrote: > Thanks. A few nits: > > Please be sure to explain the need for the expand-file-name call > either in a comment or in the log message. > Also, you fixed the do string (thanks!), but didn't mention that in > the log message. *) Please, take a look in the new patch below with more verbose log message/comments. *) Where should go the fix: emacs-25 branch or master? ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From fcb693f38657c2e47e6bb3116a781bebaea1d3ea Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Mon, 12 Sep 2016 01:53:44 +0900 Subject: [PATCH] dired-jump: Expand file-name before dired-goto-file call * lisp/dired-x.el (dired-jump): Use expand-file-name on FILE-NAME before dired-goto-file call: this is mandatory in interactive calls (Bug#24409); in non-interactive calls is also desirable in order to accept an abbreviated FILE-NAME as ~/dir/file. Clarify in doc string the meaning of arg FILE-NAME. --- lisp/dired-x.el | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index 088ca81..2a9bd72 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -413,14 +413,20 @@ dired-jump In case the proper Dired file line cannot be found, refresh the dired buffer and try again. When OTHER-WINDOW is non-nil, jump to Dired buffer in other window. -Interactively with prefix argument, read FILE-NAME and -move to its line in dired." +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. +Interactively with prefix argument, read FILE-NAME." (interactive (list nil (and current-prefix-arg (read-file-name "Jump to Dired file: ")))) (if (bound-and-true-p tar-subfile-mode) (switch-to-buffer tar-superior-buffer) - (let* ((file (or file-name buffer-file-name)) + ;; Expand file-name before calling `dired-goto-file': + ;; This is required in interactive calls because the return value + ;; of `read-file-name' is not expanded; it also helps in + ;; non-interactive calls, where file-name could be an abbreviated + ;; file name as ~/dir/file (Bug#24409). + (let* ((file (or (and file-name (expand-file-name file-name)) + buffer-file-name)) (dir (if file (file-name-directory file) default-directory))) (if (and (eq major-mode 'dired-mode) (null file-name)) (progn -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.21.5) of 2016-09-12 Repository revision: 0bbdeed10f37d4ce203e1f5feb0cd7c4b5eeec72 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 13:17:11 2016 Received: (at 24409) by debbugs.gnu.org; 11 Sep 2016 17:17:11 +0000 Received: from localhost ([127.0.0.1]:56670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8NT-0003rH-HC for submit@debbugs.gnu.org; Sun, 11 Sep 2016 13:17:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj8NR-0003r0-Tn for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 13:17:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bj8NI-0000vW-Lp for 24409@debbugs.gnu.org; Sun, 11 Sep 2016 13:17:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj8NI-0000v5-Ia; Sun, 11 Sep 2016 13:17:00 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bj8NB-0000b1-Cg; Sun, 11 Sep 2016 13:16:54 -0400 Date: Sun, 11 Sep 2016 20:16:51 +0300 Message-Id: <83zine9x18.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Mon, 12 Sep 2016 02:03:14 +0900 (JST)) Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line References: <83a8febg8c.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.2 (-------) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.2 (-------) > From: Tino Calancha > Date: Mon, 12 Sep 2016 02:03:14 +0900 (JST) > cc: Tino Calancha , 24409@debbugs.gnu.org > > *) Please, take a look in the new patch below with more verbose log > message/comments. Thanks, see a follow-up comment below. > *) Where should go the fix: emacs-25 branch or master? Master, of course. > - (let* ((file (or file-name buffer-file-name)) > + ;; Expand file-name before calling `dired-goto-file': > + ;; This is required in interactive calls because the return value > + ;; of `read-file-name' is not expanded; it also helps in > + ;; non-interactive calls, where file-name could be an abbreviated > + ;; file name as ~/dir/file (Bug#24409). > + (let* ((file (or (and file-name (expand-file-name file-name)) > + buffer-file-name)) I think a better comment would be to say that dired-goto-file requires its argument to be an absolute file name, and the result of read-file-name could be an abbreviated file name. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 00:37:26 2016 Received: (at 24409) by debbugs.gnu.org; 12 Sep 2016 04:37:26 +0000 Received: from localhost ([127.0.0.1]:56920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjIzl-0004U6-WA for submit@debbugs.gnu.org; Mon, 12 Sep 2016 00:37:26 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjIzk-0004Tr-3i for 24409@debbugs.gnu.org; Mon, 12 Sep 2016 00:37:24 -0400 Received: by mail-pa0-f50.google.com with SMTP id cm16so47016401pac.0 for <24409@debbugs.gnu.org>; Sun, 11 Sep 2016 21:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=Cd/6wkft0+sMW9HmEKcKnOkxs18aAR5abOBU6qQRyMI=; b=xisGr8sDbfq+RmAP9vcGiMCRVL+B8iKXq4AD/8wHQZuXQndba7NmtIEXfLphkGi9NY g28nys6tqy/57P0S9TDw4Wkg157RIewP9Rc4cFQc4nHwpOlx6+y7L1fS5fTSrI55+TPi vOTBtPRkOx8I8Oe+iL4WHLgTZQmM/0Xpf82sssmx8qQlejk0SVpLLONSDeVTRE1rhgQI OQVkNrXCt4OlZvIdQcbbMr8yh0PkbgWSm+RV15WHygzaWi0mc0O1l1RVYjQyKHm0MJci YoWShFyDZwmMza3f9wt+lF/eY4mEAEfJGPyrYrEE8YuMRfF/ZVaSwK1Pls9gTZbrTgYP 99UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=Cd/6wkft0+sMW9HmEKcKnOkxs18aAR5abOBU6qQRyMI=; b=iY6XYH48Te/An4HotSCJoeju705US3FJNPdzwZlr6zmodQojKocriyFMFa6mlAoj76 5iUHZhuPIKMrWIXGqVMxnLGyoiItN2Gbe4jWzd1+v5/sr5PRiJ6YJ96kR9IAO9YPQJaX TC7df79Il88nakZuZ8xFKDJAVudJvMY58xUETkqN32xD3uRkqo/hJXTuVNfBs0dPLTyE YcUaW+tP9uwozhuZXGoLVvoMmnvCcyXBp4TInfnDKdHFJfiVv7nVwYFvd4+l7ZQ8cZqz 2clhMyPdYudKL7fTcjpOR7tYS8pQBOtYIPFJ3nx6gU3XG716AwIHcYMn9f5QeFXNwy70 NovQ== X-Gm-Message-State: AE9vXwNE3mJog8X0gSz8wtoYc4rykTOpgzMijw0r/J0AveiN2TEYuuygzAmxPcr771uWCw== X-Received: by 10.66.217.132 with SMTP id oy4mr29896245pac.46.1473655038326; Sun, 11 Sep 2016 21:37:18 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id f16sm16434533pfd.84.2016.09.11.21.37.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Sep 2016 21:37:17 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Mon, 12 Sep 2016 13:37:14 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line In-Reply-To: <83zine9x18.fsf@gnu.org> Message-ID: References: <83a8febg8c.fsf@gnu.org> <83zine9x18.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 11 Sep 2016, Eli Zaretskii wrote: > I think a better comment would be to say that dired-goto-file requires > its argument to be an absolute file name, and the result of > read-file-name could be an abbreviated file name. Thank you. I rewrote the comment/log message with your suggestion. I included the word canonical: an abbreviated file name could be an absolute file name, for instance ~/foo, but dired-goto-file, in addition to absolute file name, requires the substitution of '~/'. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 3e58d4987590dbdb54d08fd6be201bd0cad4b804 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Mon, 12 Sep 2016 13:16:32 +0900 Subject: [PATCH] dired-jump: Expand file-name before dired-goto-file call Command dired-goto-file requires its argument to be an absolute canonical file name. Interactively FILE-NAME is read with read-file-name, which could return an abbreviated file name, i.e., non-canonical (Bug#24409). * lisp/dired-x.el (dired-jump): Use expand-file-name on FILE-NAME. Clarify in doc string the meaning of arg FILE-NAME. --- lisp/dired-x.el | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index be762e6..90420ad 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -413,14 +413,19 @@ dired-jump In case the proper Dired file line cannot be found, refresh the dired buffer and try again. When OTHER-WINDOW is non-nil, jump to Dired buffer in other window. -Interactively with prefix argument, read FILE-NAME and -move to its line in dired." +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. +Interactively with prefix argument, read FILE-NAME." (interactive (list nil (and current-prefix-arg (read-file-name "Jump to Dired file: ")))) (if (bound-and-true-p tar-subfile-mode) (switch-to-buffer tar-superior-buffer) - (let* ((file (or file-name buffer-file-name)) + ;; Expand file-name before `dired-goto-file' call: + ;; `dired-goto-file' requires its argument to be an absolute + ;; canonical file name; the result of `read-file-name' could + ;; be an abbreviated file name, i.e., non-canonical (Bug#24409). + (let* ((file (or (and file-name (expand-file-name file-name)) + buffer-file-name)) (dir (if file (file-name-directory file) default-directory))) (if (and (eq major-mode 'dired-mode) (null file-name)) (progn -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.21.5) of 2016-09-12 built on calancha-pc Repository revision: 367f8568bc9e759ebdfb423648891efa0346456b From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 12:53:29 2016 Received: (at 24409) by debbugs.gnu.org; 12 Sep 2016 16:53:29 +0000 Received: from localhost ([127.0.0.1]:57864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjUU4-0006oc-Rh for submit@debbugs.gnu.org; Mon, 12 Sep 2016 12:53:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjUU3-0006oP-BP for 24409@debbugs.gnu.org; Mon, 12 Sep 2016 12:53:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjUTt-0004cX-DC for 24409@debbugs.gnu.org; Mon, 12 Sep 2016 12:53:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjUTt-0004cF-A8; Mon, 12 Sep 2016 12:53:17 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1872 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bjUTr-0007xv-EP; Mon, 12 Sep 2016 12:53:15 -0400 Date: Mon, 12 Sep 2016 19:53:19 +0300 Message-Id: <83fup59i0w.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Mon, 12 Sep 2016 13:37:14 +0900 (JST)) Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line References: <83a8febg8c.fsf@gnu.org> <83zine9x18.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.3 (-------) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.3 (-------) > From: Tino Calancha > Date: Mon, 12 Sep 2016 13:37:14 +0900 (JST) > cc: Tino Calancha , 24409@debbugs.gnu.org > > > I think a better comment would be to say that dired-goto-file requires > > its argument to be an absolute file name, and the result of > > read-file-name could be an abbreviated file name. > Thank you. I rewrote the comment/log message with your suggestion. > I included the word canonical: an abbreviated file name could be > an absolute file name, for instance ~/foo, but dired-goto-file, > in addition to absolute file name, requires the substitution of '~/'. We don't have a notion of a "canonical" file name in Emacs, so I'm not sure this helps. OTOH, "absolute file name" is quite clear, and I don't think people will be confused by the fact that ~/foo returns non-nil from file-name-absolute-p. > +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. "When FILE-NAME is non-nil, jump to its line in Dired." (Try to avoid saying the same thing twice too close to one another.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 03:04:16 2016 Received: (at 24409) by debbugs.gnu.org; 13 Sep 2016 07:04:16 +0000 Received: from localhost ([127.0.0.1]:58149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjhlQ-0005Jq-4d for submit@debbugs.gnu.org; Tue, 13 Sep 2016 03:04:16 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjhlO-0005Jd-Mp for 24409@debbugs.gnu.org; Tue, 13 Sep 2016 03:04:15 -0400 Received: by mail-pa0-f42.google.com with SMTP id id6so58885218pad.3 for <24409@debbugs.gnu.org>; Tue, 13 Sep 2016 00:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZfJZcFvuOk+8kfNC6HZojzUPUfB6M6yUGWT7nu77fFg=; b=qVowIQXTIurxzUNfxFRJxETZHUa/iLO4iddkPJBv4dojP/P02CRQKUAUtHHL+2UGl7 KQbHEK+ELq8QqTep6HXBhjrtvdAlP/MpXwsC/2JDp4XhjqBxR4cm3jxU7vVmtdThh4MK O0L3ngyjHhCqp/sQf/mC4MG7SqXpFNZ6Lv6/VuyCEl7NN8hmfUAZu0xTfr6oO59MSOp7 5S3pvOvTVrNj+aYs6AfNS1VcRAEHzKjGEFgrCthdHlMeWkk3OUkeUUL81TLr+S16PFtc 9n03G129r+f7zUHlIgZvAIoxggeJ7/qk5zkE1U9yfGhyGqyySV1Cg3THDP2DbrH9/nVj JnyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZfJZcFvuOk+8kfNC6HZojzUPUfB6M6yUGWT7nu77fFg=; b=ZW26jjbWVsPspWD2pBCAGfxxPmcbKxfNCwqUFm8zbcqSgM0TYcJ05KV91Lcis6hnIT ftgwxrCKZgexMKH9LrepDM9Sn52jVnLFWVJ73o6Tkf5F0IlH0Bnr1pXNBO5TlsAzP7I5 hc3gDXUcOQjsHZNBsB7bI2zmJPSxRjc+zjI/kocvWnN3929XKan/gcCu7ysErGBTAeva CbckaWYJfWXr0Z5MR55aJFOIzXhA0wNI5aOQJuz5HyzSlO7MvHCx6Map85zPqucNMshB NdowPngMsg7S+xWda99M+4Jt1gH3Wr6Cb9puo9VWc7L2YoIq2LDtFfWI/P+vqCTP2RjJ urXg== X-Gm-Message-State: AE9vXwOudo9EAEvfTbdlaHUAs7YSeilXKKb4CIqNM1Ay+++3y5hXfkDvqlGbfHUZve7sJg== X-Received: by 10.66.25.228 with SMTP id f4mr41399762pag.157.1473750248921; Tue, 13 Sep 2016 00:04:08 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id 3sm28800932pai.48.2016.09.13.00.04.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 00:04:08 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 13 Sep 2016 16:04:05 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line In-Reply-To: <83fup59i0w.fsf@gnu.org> Message-ID: References: <83a8febg8c.fsf@gnu.org> <83zine9x18.fsf@gnu.org> <83fup59i0w.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, 12 Sep 2016, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Mon, 12 Sep 2016 13:37:14 +0900 (JST) >> cc: Tino Calancha , 24409@debbugs.gnu.org >> >>> I think a better comment would be to say that dired-goto-file requires >>> its argument to be an absolute file name, and the result of >>> read-file-name could be an abbreviated file name. >> Thank you. I rewrote the comment/log message with your suggestion. >> I included the word canonical: an abbreviated file name could be >> an absolute file name, for instance ~/foo, but dired-goto-file, >> in addition to absolute file name, requires the substitution of '~/'. > > We don't have a notion of a "canonical" file name in Emacs, so I'm not > sure this helps. OTOH, "absolute file name" is quite clear, and I > don't think people will be confused by the fact that ~/foo returns > non-nil from file-name-absolute-p. Ok, i will not use the word canonical. >> +When FILE-NAME is non-nil, move to FILE-NAME line in Dired. > > "When FILE-NAME is non-nil, jump to its line in Dired." > (Try to avoid saying the same thing twice too close to one another.) Added. Thank you very much. Once you give me the LGTM i will apply the following corrected patch: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From e1541dd78cb5bf81247bd4025a603cef81f3a3cb Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Tue, 13 Sep 2016 15:59:45 +0900 Subject: [PATCH] dired-jump: Expand file-name before dired-goto-file call Command dired-goto-file requires its argument to be an absolute file name. Interactively FILE-NAME is read with read-file-name, which could return an abbreviated file name (Bug#24409). * lisp/dired-x.el (dired-jump): Use expand-file-name on FILE-NAME. Clarify in doc string the meaning of arg FILE-NAME. --- lisp/dired-x.el | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index be762e6..41c2256 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -413,14 +413,19 @@ dired-jump In case the proper Dired file line cannot be found, refresh the dired buffer and try again. When OTHER-WINDOW is non-nil, jump to Dired buffer in other window. -Interactively with prefix argument, read FILE-NAME and -move to its line in dired." +When FILE-NAME is non-nil, jump to its line in Dired. +Interactively with prefix argument, read FILE-NAME." (interactive (list nil (and current-prefix-arg (read-file-name "Jump to Dired file: ")))) (if (bound-and-true-p tar-subfile-mode) (switch-to-buffer tar-superior-buffer) - (let* ((file (or file-name buffer-file-name)) + ;; Expand file-name before `dired-goto-file' call: + ;; `dired-goto-file' requires its argument to be an absolute + ;; file name; the result of `read-file-name' could be + ;; an abbreviated file name (Bug#24409). + (let* ((file (or (and file-name (expand-file-name file-name)) + buffer-file-name)) (dir (if file (file-name-directory file) default-directory))) (if (and (eq major-mode 'dired-mode) (null file-name)) (progn -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.21.5) of 2016-09-13 Repository revision: 367f8568bc9e759ebdfb423648891efa0346456b From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 10:37:34 2016 Received: (at 24409) by debbugs.gnu.org; 13 Sep 2016 14:37:35 +0000 Received: from localhost ([127.0.0.1]:58804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjoq2-000314-KK for submit@debbugs.gnu.org; Tue, 13 Sep 2016 10:37:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjopx-00030m-UR for 24409@debbugs.gnu.org; Tue, 13 Sep 2016 10:37:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjopo-0004bf-M7 for 24409@debbugs.gnu.org; Tue, 13 Sep 2016 10:37:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjopo-0004bU-IJ; Tue, 13 Sep 2016 10:37:16 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2555 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bjopl-0000mn-RG; Tue, 13 Sep 2016 10:37:16 -0400 Date: Tue, 13 Sep 2016 17:37:13 +0300 Message-Id: <83lgyv9886.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Tue, 13 Sep 2016 16:04:05 +0900 (JST)) Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line References: <83a8febg8c.fsf@gnu.org> <83zine9x18.fsf@gnu.org> <83fup59i0w.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.3 (-------) X-Debbugs-Envelope-To: 24409 Cc: 24409@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.3 (-------) > From: Tino Calancha > Date: Tue, 13 Sep 2016 16:04:05 +0900 (JST) > cc: Tino Calancha , 24409@debbugs.gnu.org > > Once you give me the LGTM i will apply the following corrected patch: LGTM, thank you. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 11:10:01 2016 Received: (at 24409-done) by debbugs.gnu.org; 13 Sep 2016 15:10:01 +0000 Received: from localhost ([127.0.0.1]:58826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjpLQ-0003m5-Jb for submit@debbugs.gnu.org; Tue, 13 Sep 2016 11:10:00 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjpLK-0003lm-MB for 24409-done@debbugs.gnu.org; Tue, 13 Sep 2016 11:09:55 -0400 Received: by mail-pf0-f178.google.com with SMTP id p64so64699377pfb.1 for <24409-done@debbugs.gnu.org>; Tue, 13 Sep 2016 08:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:in-reply-to:message-id:references:user-agent :mime-version; bh=w4TB2Rq0Cibv0EMsErcM/Eidy1UW7JKD/yyWcmtgpiQ=; b=a7S9yl961FJH8u3hCs5NYy8aBLFz3e/CDStlubPJif+/3uTQ32+9oj6u3mcqqZN5gs /siL4+ybAf8Vb3dNlhIMD0dHTaLRP/lYWn0q6aAeMwlecLwFXi2YlVliSFTaHBj5rlaj 5CAdtSEYr+x38BSkFwX7nrDIq0lYljDQEmbN6skYkV8xRmWY+idnj404GpJwehyQ2b7a 54/4J/+BuS7kgqjWelK8iHmzTzrQ4Wd95H+Oi53KDLuT9NHqwUpwTXFtHXbeW3GjhEpd /Sn+M3JQGG8e1yfzc4v9NApuklekBCoqPbeZqVwS11HV49YmlypQeb8I1OiLQi8wk6da 6j6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=w4TB2Rq0Cibv0EMsErcM/Eidy1UW7JKD/yyWcmtgpiQ=; b=XctWlcl5snj+Th8fF3BHIA9WXPlHVNVVXE7fnQf8LHfl2mQmYLk0Mo+s7ASrM5Vydb Tgny1GoudKAns5x9PFk9qMq+d/lE6nPGDMC9Sck5zDLk0zGqdgU0DSSmAYC/L+DI7pMO c1Sp3fps/8C4CN2UMtQDSZ75ArnhYJVmuO9SYqQJcL1i43o6RrLHrc6ctXAlOQ5Fc9G7 XDfzlAxtXW4K0rSpP0UwhW4wT7VWpkY8+5W5VN1+O+8Q0ngp6HX/YejlMZHXGcC1BnZH s2Y+4e4xGhaGY/xVwGn4dHAaUkoWEWzFhJL/csyLTjr9whNcXKnsUMqSNgBR+Hob9a27 a6kg== X-Gm-Message-State: AE9vXwM7qxe7bBMzoEmyIGCypk5qRysjKKMn6OzHHfv/lPkYMx1cDACDqrSScmYJR4hUzA== X-Received: by 10.98.14.20 with SMTP id w20mr2223751pfi.9.1473779384851; Tue, 13 Sep 2016 08:09:44 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id uj8sm10410282pab.5.2016.09.13.08.09.43 for <24409-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 08:09:44 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 14 Sep 2016 00:09:41 +0900 (JST) X-X-Sender: calancha@calancha-pc To: 24409-done@debbugs.gnu.org Subject: Re: bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line In-Reply-To: <83lgyv9886.fsf@gnu.org> Message-ID: References: <83a8febg8c.fsf@gnu.org> <83zine9x18.fsf@gnu.org> <83fup59i0w.fsf@gnu.org> <83lgyv9886.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24409-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 13 Sep 2016, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Tue, 13 Sep 2016 16:04:05 +0900 (JST) >> cc: Tino Calancha , 24409@debbugs.gnu.org >> >> Once you give me the LGTM i will apply the following corrected patch: > > LGTM, thank you. Thank you. Pushed fix to master branch as commit 3988ceaa From unknown Mon Jun 23 04:11:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Oct 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator