GNU bug report logs - #2439
23.0.60; [patch] `Mark set' clobbers useful message in ibuffer

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 2439 <at> debbugs.gnu.org, Geoff Gole <geoffgole <at> gmail.com>
Subject: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in
Date: Wed, 25 Feb 2009 14:53:56 -0500

>> Thanks for your patch, but please try to avoid hardcoding "1" as above.
>> Just use (point-min) instead.
> What is the point, when having a narrowed buffer would be an error?

Because 1 is sometimes an error, whereas (point-min) isn't.

> because `goto-line' uses `(save-restriction (widen) ...)'. So, if
> anything, is not that the patch should use `point-min', but that it
> should use

>   (save-restriction
>     (widen)
>     (goto-char 1)
>     (forward-line orig))

No, it should be

   (save-restriction
     (widen)
     (goto-char (point-min))
     (forward-line orig))

> though I don't think narrowing the ibuffer buffer and then sorting is
> a common enough operation to worry about it.  Same for bs-down, where
> I implemented the same fix.

Agreed.  But still using (point-min) rather than 1.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.