GNU bug report logs - #2439
23.0.60; [patch] `Mark set' clobbers useful message in ibuffer

Previous Next

Package: emacs;

Reported by: Geoff Gole <geoffgole <at> gmail.com>

Date: Mon, 23 Feb 2009 02:35:04 UTC

Severity: normal

Tags: patch

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 2439 <at> debbugs.gnu.org
Cc: Geoff Gole <geoffgole <at> gmail.com>
Subject: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in  ibuffer
Date: Wed, 25 Feb 2009 17:51:22 +0100

On Wed, Feb 25, 2009 at 17:30, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> Thanks for your patch, but please try to avoid hardcoding "1" as above.
> Just use (point-min) instead.

What is the point, when having a narrowed buffer would be an error?

In this case,

  (goto-char 1)
  (forward-line orig)

is not the same as

  (goto-line (1+ orig))

because `goto-line' uses `(save-restriction (widen) ...)'. So, if
anything, is not that the patch should use `point-min', but that it
should use

  (save-restriction
    (widen)
    (goto-char 1)
    (forward-line orig))

though I don't think narrowing the ibuffer buffer and then sorting is
a common enough operation to worry about it. Same for bs-down, where I
implemented the same fix.

    Juanma
This bug report was last modified 16 years and 149 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.